GitLab

* ShareableFileReference is not thread-safe, we should make sure we only handle it on IO thread
* FileUtil implementation no longer needs to directly handle ShareableFileReference

BUG=140508


Review URL: https://chromiumcodereview.appspot.com/10834167

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149992 0039d316-1c4b-4281-b951-d872f2087c98

- These changes make the output timestamps & durations more accurate.
- Isolates output timestamps from rounding effects in the input timestamps.
- Fixes output timestamp error caused by the 1 frame coding delay.
- Trims off starting samples when Vorbis signals negative timestamps.


BUG=126183
TEST=None. Existing tests still pass.

Review URL: https://chromiumcodereview.appspot.com/10831020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149991 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10843031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149990 0039d316-1c4b-4281-b951-d872f2087c98

Add memory leak suppressing for StatisticsRecorderTest.

Review URL: https://chromiumcodereview.appspot.com/10827132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149989 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none.
TEST=none

TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10831166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149988 0039d316-1c4b-4281-b951-d872f2087c98

1. Refactor out app_list_bubble_border so that it can be used for launcher
tooltip border.
2. UI polish: increase padding, make tooltip single line, reduce maximum
tooltip width.

BUG=133292
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10834140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149987 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100514
TBR=mmenke

Review URL: https://chromiumcodereview.appspot.com/10852013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149986 0039d316-1c4b-4281-b951-d872f2087c98

GpuVideoDecoder owns GpuVideoDecodeAcceleratorHost; it was a bug that
~CommandBufferProxyImpl() called GpuVideoDecodeAcceleratorHost::Destroy() (since
the latter deletes |this|).

This bug was uncovered due to an unrelated GPU-process crashing bug, which
triggered context loss and the subsequent stack in the linked bug.  With this
change, killing the GPU process mid-playback fires a JS error on the <video> tag
(correctly), but the renderer keeps on just fine.

BUG=140138


Review URL: https://chromiumcodereview.appspot.com/10852009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149985 0039d316-1c4b-4281-b951-d872f2087c98

When the GPU process dies/gets killed, the Send() can fail (e.g. EPIPE),
triggering lost context recreation, before OnChannelError gets called (happening
when we return to the message loop) which ends up deleting the GpuProcessHost.
So, in the mean time, make sure we don't try to reuse that GpuProcessHost to
recreate a channel.

BUG=129067


Review URL: https://chromiumcodereview.appspot.com/10834165

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149984 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139401

Review URL: https://chromiumcodereview.appspot.com/10853006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149983 0039d316-1c4b-4281-b951-d872f2087c98

On errors and destruction, use the service_runtime object in the subprocess
to kill the translator processes immediately rather than just signaling the
translation thread, which may be blocked on an RPC.
Any pending or new RPC calls will fail immediately, and the translation thread
can simply bail.
This makes destruction/surfaway much faster and more responsive and simplifies
error handling and object cleanup. The only caveat is that now the translation
thread and NaClSubprocess must be careful not to race service runtime operations
(which are protected by subprocess_mu_) with RPCs (which are called
without a mutex because they block). This is currently already ensured because
srpc_client is a separate object from service_runtime in NaClSubprocess.

R=sehr@chromium.org,jvoung@chromium.org,robertm@chromium.org
BUG= http://code.google.com/p/nativeclient/issues/detail?id=2195
TEST=nacl_integration (especially pnacl_bad_browser_test)


Review URL: https://chromiumcodereview.appspot.com/10830149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149982 0039d316-1c4b-4281-b951-d872f2087c98

(Views only) Disable drop-down buttons for managed permissions and display the source of the managed setting (e.g. policy, extension).


BUG=113688
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10831128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149981 0039d316-1c4b-4281-b951-d872f2087c98

This adds a singleton class that holds ContactStore objects
and exposes Contact objects to the rest of the browser.

BUG=128805
TEST=none
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10831162

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149980 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140073
TEST=manual using inserted logging

Review URL: https://chromiumcodereview.appspot.com/10828106

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149979 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140116


Review URL: https://chromiumcodereview.appspot.com/10837105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149978 0039d316-1c4b-4281-b951-d872f2087c98

The previous issue (http://codereview.chromium.org/10837089/) was reverted because
of win_aura compile error. It turns out that I use "small" as variable name but
"small" was defined as char when compiled on win_aura. Renamed the variable.

BUG=140336
TBR=saintlou, sky, jhawkins, lambroslambrou

Review URL: https://chromiumcodereview.appspot.com/10837110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149977 0039d316-1c4b-4281-b951-d872f2087c98

The problem this fixes is, depending on the exact timing, a context would
receive a lost context callback (task 1), and would then post a task to recreate
the context (task 2). In parallel a task would be posted to signal the
GpuChannelHost that the channel is lost (task 3).

Because task 3 is posted from the IO thread, whereas task 2 is posted from
another thread (but they both are posted to the "main" thread), the race in
posting results in a race in execution, and task 2 may try to recreate a context
using a channel that doesn't know yet that it's non-functional, resulting in
failing to send the message and failing to create the context.

This patch changes the post order - task 3 is posted before task 1 - ensuring
task 2 is posted after task 3 (since task 2 is posted after task 1 executes).

BUG=129067


Review URL: https://chromiumcodereview.appspot.com/10837104

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149976 0039d316-1c4b-4281-b951-d872f2087c98

With this change, Chromoting will use chromoting-oauth.talkgadget.google.com
to talk to the talkgadget during the auth phase and will use
chromoting-client.talkgadget.google.com when the client is interacting with
the talkgadget.

Host interactions with the talkgadget will be controlled by policy and will be
handled in a separate cl.

BUG=132345
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10837106

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149975 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149974 0039d316-1c4b-4281-b951-d872f2087c98

Ensure proper locking around all uses of curr_input_buffer_ and input_buffers_.

TEST=by hand
BUG=none

Change-Id: I4cc92a1b0be47ce95bc0def580a88ac3a9f7deec


Review URL: https://chromiumcodereview.appspot.com/10853005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149973 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=


Review URL: https://chromiumcodereview.appspot.com/10830169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149972 0039d316-1c4b-4281-b951-d872f2087c98

touch.

BUG=128741
TEST=see bug
R=sadrul@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10823165

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149971 0039d316-1c4b-4281-b951-d872f2087c98

CID=104234,104664
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10824031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149970 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139401

Review URL: https://chromiumcodereview.appspot.com/10850036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149969 0039d316-1c4b-4281-b951-d872f2087c98

Also:
- The uninstall survey will use the metro Chrome local state if there is no desktop Chrome local state (although in the future we maybe want to aggregate them).
- Chrome inactivity for toast purposes is now based on the most-recently used of both desktop and metro Chrome.

BUG=125793
TEST=install chrome, make it the default, launch into metro at least once, quit, then uninstall and check the "also clear..." box.  Metro data dir should be gone.

Review URL: https://chromiumcodereview.appspot.com/10826144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149968 0039d316-1c4b-4281-b951-d872f2087c98

Ensure that the leading headline text is shown on layout.
Selecting a [0,0] range moves the cursor to the leading text edge.
Textfield implementations then pan to show the cursor position.

Verified on local builds CrOS and Windows (with win/views textfields).

BUG=140273
TEST=Page info bubbles show the leading section text on Win and CrOS.

Review URL: https://chromiumcodereview.appspot.com/10826126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149967 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128816
TEST=


Review URL: https://chromiumcodereview.appspot.com/10792020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149965 0039d316-1c4b-4281-b951-d872f2087c98

Fixes chrome_page_zoom::Zoom(). First, correctly retrieves the default zoom level from the user Profile instead of from RendererPreferences. Second, correctly sets the default zoom level when content::PAGE_ZOOM_RESET is passed as the zoom parameter (previously, it just set the zoom to 100% no matter what the default zoom level was).

BUG=
TBR=jhawkins

Review URL: https://chromiumcodereview.appspot.com/10826136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149964 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10830172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149963 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133109
R=robertshield
Review URL: https://chromiumcodereview.appspot.com/10823170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149962 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139887


Review URL: https://chromiumcodereview.appspot.com/10836091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149959 0039d316-1c4b-4281-b951-d872f2087c98

~GestureRecognizerImpl() was leaking memory.  Now it doesn't.  An unfortunate side effect of this leak was that GestureSequence objects hold a pointer to the GR's parent window (helper_) that is no longer valid after the dtor is called.  They also hold a callback timer, which fires for a long press...

This CL fixes the crash in issue 139420, but it doesn't fix the full bug.  Specifically, the popup menu is still not responding to touch.

BUG=139420

Review URL: https://chromiumcodereview.appspot.com/10826117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149957 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=functional/browser.py
R=nirnimesh@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10852011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149956 0039d316-1c4b-4281-b951-d872f2087c98

Turned out the original design was not good, and the code won't be used.

BUG=140314
TEST=compile
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10828163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149955 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/125937
TEST=existing
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149888
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149916
Review URL: https://chromiumcodereview.appspot.com/10831137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149954 0039d316-1c4b-4281-b951-d872f2087c98

[UMA] Add " (Metro)" to the OS name for UMA uploads from Chrome running under Windows 8's Metro mode.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10834077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149953 0039d316-1c4b-4281-b951-d872f2087c98

See related spec here: http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html#algorithms-enrypted-block

If the AesDecryptor cannot find the decryption for the encrypted buffer, it returns a kNoKey.

In ProxyDecryptor, if the input cannot be decrypted due to kNoKey, the ProxyDecryptor will cache the encrypted buffers and callbacks and fire a needkey event. When some key is added (AddKey called) later, it will try to decrypt these buffers again. The callbacks will be fired on the same thread where Decrypt() was called originally.

BUG=125401, 125753
TEST=media_unittest, media layout_tests

Review URL: https://chromiumcodereview.appspot.com/10822026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149952 0039d316-1c4b-4281-b951-d872f2087c98

The biggest improvement here is that early termination of the callback series is accomplished by deleting the object.

BUG=138583

Review URL: https://chromiumcodereview.appspot.com/10830146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149951 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140571
TEST=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10826155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149950 0039d316-1c4b-4281-b951-d872f2087c98

This API is to clear all the local cache of Drive.

BUG=135197
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10837091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149949 0039d316-1c4b-4281-b951-d872f2087c98