- 25 Aug, 2020 40 commits
-
-
David Jean authored
Fixed crash on exit with connectedScenes empty while the last scene tries to get interfaceProvider from it. Fixed crash with disconnected states remaining as dangling pointer observers in AppState Bug: 1114586 Change-Id: I4865d261082e81c2684065f97a8a6d94ffd2164d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374785Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#801332}
-
Jonathan Mengedoht authored
Bug: 927473 Change-Id: Ib87706aeb8c6e100ba542a31e7374b2fe8c12210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372325 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#801331}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d37b0ec2bb0c..cccd55094dbe 2020-08-25 nisse@webrtc.org Delete unneeded dependencies on deprecated build target webrtc_common 2020-08-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0c4572c2..ba69b98d (801101:801212) 2020-08-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6cc8efac..0c4572c2 (800536:801101) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia13aa4ec9c7eb685c987c45fe3c34a2278f22005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374805Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801330}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cd8de1d295b4..d6482730a5b0 2020-08-25 treehugger-gerrit@google.com Merge "Fix typo in sqlite BUILD define" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I177d7209896bf478f3b3847b07e6333812b9efdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374232Reviewed-by:
-
Peter Kasting authored
* Remove string arg to constructor, since SetText() already existed. * Strip trailing whitespace in SetText() as was previously done in the constructor, and comment about why it matters. I doubt this ever triggered outside of unittests. * Default the listener arg to null, which a lot of callers want. * While touching the callers anyway, use std::make_unique<>(), T* AddChildView(), etc. more. Bug: 648382,1108460 Change-Id: I7b3893ce922264581a7696d8fbcbdc70aecefaf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360498 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#801328}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5a8fc1fe06a2..cdedf581e53e 2020-08-25 wolfi@chromium.org Revert "Update Mocha and rollup-plugin-terser" 2020-08-25 sigurds@chromium.org Add filter in network panel for resource type 2020-08-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-25 chrche@microsoft.com [Elements]: Fixing issue when searchConfig is unexpectedly undefined 2020-08-24 jegarc@microsoft.com Hide color picker on scroll 2020-08-24 patrick.brosset@microsoft.com Allow horizontal scrolling in the Elements tree 2020-08-24 michael.liao@microsoft.com [Accessibility - XHR Breakpoints]: Set accessible name for text input 2020-08-24 michael.liao@microsoft.com [AriaUtils]: Removing NVDA workaround for alert function 2020-08-24 petermarshall@chromium.org components: Use the new PieChart2 everywhere 2020-08-24 petermarshall@chromium.org css: Remove our implementation of data-keyboard-focus 2020-08-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-24 tvanderlippe@chromium.org Fix contextmenu for console view messages 2020-08-24 tvanderlippe@chromium.org Update Mocha and rollup-plugin-terser 2020-08-24 hablich@chromium.org [Docs] Fix link to workflow.md 2020-08-24 nsatragno@chromium.org Flip webauthnPane experiment flag 2020-08-24 alexrudenko@chromium.org Partially revert: [Perfmon] Improve contrast of labels in dark theme If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1116327,chromium:1120103,chromium:1120844,chromium:1121086,chromium:1121141,chromium:880265 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib1d2e1953a818f81decffa8dda47e9f19115a6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374229Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/25e9f126d8c3..a5c279111d94 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fergal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: fergal@google.com Change-Id: I021bf56752d15d9655a08119718856d56b8183f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373238Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801326}
-
Aaron Leventhal authored
This patch removes the now unused method BrowserAccessibilityComWin::IsListBoxOptionOrMenuListOption() AX-RelNotes: n/a Bug: None Change-Id: I21e076c5a5ec8de83b0a7919ebb63de5350e7c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368460Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#801325}
-
Hirokazu Honda authored
The bitrate is not specified in MultipleOutstandingEncodes case. So the default bitrate is used. It causes a failure in higher resolutions because of the bad stream quality. This fixed the issue. This also removes the default argument value to the bitrate argument in order to refrain this bug. Bug: 1045825 Test: video_encode_accelerator_tests on atlas Change-Id: I9c638db22175a7bc0573868fadc2057ec34bbdb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371903 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#801324}
-
Alexander Hendrich authored
This CL: * uses ExtensionId as type instead of std::string * adds empty default implementations to ExternalCacheDelegate since most delegates don't care about all On*() methods. Bug: none Change-Id: I37cce73d60708305b8746e20803216da21eefa9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366744 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801323}
-
Dominick Ng authored
The tests fail at tear down when the TestingProfile is pre-emptively destroyed. Remove the pre-emptive destruction to fix the flakes. Additionally, instantiate an in-process data decoder in the test to ensure that data decoding doesn't need another process. BUG=1115763,1115762 Change-Id: I0b12669144093090d7f280057ee5069e314d6bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371767 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#801322}
-
Findit authored
This reverts commit 2a107111. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 801312 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzJhMTA3MTExMWQzYTY4ZWY3NjQwNjM0YmIxYzk5ODljOGI4MWVlODIM Sample Failed Build: https://ci.chromium.org/b/8871005296611674816 Sample Failed Step: compile Original change's description: > Video Tutorials : Modularized JNI bridge > > This CL moves the VideoTutorialServiceFactory and the JNI bridge into > the internal target. A corresponding public factory class is generated > from the internal factory using android_library_factory function. The > JNI function lives in video_tutorial_service_bridge_factory.cc which is > included in chrome/browser target while still living in > chrome/browser/video_tutorials/internal. > > Bug: 1120097 > Change-Id: I4cbc7e2763012e3780a28f58bf14e3374464e20e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368474 > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801312} Change-Id: I9f4a941756cfce48418d07a5477712f992ecfdd2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1120097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374233 Cr-Commit-Position: refs/heads/master@{#801321}
-
Yuki Shiino authored
Disable an unittest that tests OOM allocation behaviors when USE_PARTITION_ALLOC_AS_MALLOC because operator new (nothrow) do not return nullptr and crash instead. Bug: 998048 Change-Id: I14a2b25152568c912273215a24b9b528ddfa304e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366446 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#801320}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4dd122392f3a..12df3cafeee0 2020-08-24 greg@lunarg.com Fix SSA-rewrite to remove DebugDeclare for variables without loads (#3719) 2020-08-24 stevenperron@google.com Add undef for inlined void function (#3720) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: Ic6dbacc23b0f153ea678d8e34c74bc21d7a53daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374228Reviewed-by:
-
arthursonzogni authored
Add a basic WPT test where the reported: body.type is: "access-to-coop-page-from-other" Bug: 1090273 Change-Id: I6961a1a939c707264f215542a2bd99cdc45fb34d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367098 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#801318}
-
arthursonzogni authored
This checks the following scenario: 1) Start from cross origin isolated document. 2) It opens a new window with the same policy, but with CSP:sandbox. Currently, this ends with two documents in the same cross-origin isolated process, but from a different origin. Goal of this test is to trigger DCHECK/CHECK we might have, or will have will: https://chromium-review.googlesource.com/c/chromium/src/+/2230632 Bug: 1115426 Change-Id: Id457f8bc30bf737405aed8d1e98f4243aef7135b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351920 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /base This CL was uploaded by git cl split. R=thestig@chromium.org Bug: 1110266 Change-Id: I164e315751f8e43de5e37f639d836bd09129d706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371210Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#801316}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9ad0c9e91a7d..578215be44d0 2020-08-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 4f7edbe1f6f0 to 7bce5194d1d6 (7 revisions) 2020-08-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 65295ec3 to 752313f1 (354 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Test: Test: Test: angle_unittests.exe --gtest_filter=FastInteger* Change-Id: I6f236a6b6128479fc13bb2106484e278c37410ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374227Reviewed-by:
-
Noel Gordon authored
third_party/closure_compiler/externs/file_manager_private.js says that the third argument to getContentMetadata is a boolean includeImages. Fix all parts of this API to agree with that definition, including the test coverage (MediaMetadata apitests). Closure compilation pointed out the type error when using the API from file app frontend JS. Bug: 1114622 Change-Id: Ie5102e14b796cc92931a20abb65c3ddec50adb78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368575 Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#801314}
-
Hans Wennborg authored
which includes 'printenv' now used by some lit test. The zip was constructed like this: $ gsutil.py cp gs://chromium-browser-clang/tools/gnuwin-13.zip . $ unzip gnuwin-13.zip $ curl -L -O https://downloads.sourceforge.net/project/gnuwin32/coreutils/5.3.0/coreutils-5.3.0-bin.zip $ unzip coreutils-5.3.0-bin.zip bin/printenv.exe $ mv bin/printenv.exe gnuwin/ $ zip -r9 gnuwin-14.zip gnuwin/ $ gsutil.py cp -n -a public-read gnuwin-14.zip gs://chromium-browser-clang/tools/gnuwin-14.zip TBR=thakis Bug: 1121387 Change-Id: I93f49303e104431be50389bbf7202621f6881d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374146Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#801313}
-
Shakti Sahu authored
This CL moves the VideoTutorialServiceFactory and the JNI bridge into the internal target. A corresponding public factory class is generated from the internal factory using android_library_factory function. The JNI function lives in video_tutorial_service_bridge_factory.cc which is included in chrome/browser target while still living in chrome/browser/video_tutorials/internal. Bug: 1120097 Change-Id: I4cbc7e2763012e3780a28f58bf14e3374464e20e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368474Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801312}
-
Hidehiko Abe authored
Lacros used to use mojo_base::mojo::Binder to establish the Mojo connection between Lacros and Ash chromes, preferring the plataform independent way. However, it is too late for passing initializing parameters, which needs to be passed before starting the main message loop. This CL directly binds the LacrosChromeService, so that parameters can be available at earlier timing. Bug: 1115092 Test: Ran Lacros locally. Change-Id: I5345fa4bfe57b9a922e2d6c389c579266893d03b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353976 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
evliu authored
This CL introduces a check to verify that the SODA binary and language pack components are downloaded before launching the speech recognition service. In the event where the files are not yet downloaded, a generic error message will be shown to the user indicating that speech recognition is not available. Bug: 1121384 Change-Id: Iff628202884869a04ce54761137aca4d40497fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373388Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#801310}
-
Karel Král authored
This is a reland of 19a1e60d Original change's description: > Add tracing support for mojo handle kinds > > Support tracing of mojo handle and remote/receiver kinds. Thus provide > more precise debugging information for developers. Also avoid > generating fallback literals for base::trace_event::ValueToString. > > Bug: 1103623 > Change-Id: Ib01e79f7ae0aba64cabda3aea87cc1d1aed3b921 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356005 > Commit-Queue: Karel Král <karelkral@google.com> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798588} Fix crbug.com/1117192 by not tracing interface kinds as these have incompatible API (either have is_bound or is_valid). Bug: 1103623 Change-Id: Id126e143e478054e1aacc9f3fa48df3f9dbf113f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368556Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Karel Král <karelkral@google.com> Cr-Commit-Position: refs/heads/master@{#801309}
-
Fergal Daly authored
Test was recently added, flaky on various windows builders. TBR=justinmiron@chromium.org Bug: 1121444 Change-Id: I962811e829051da2a9ff00c015613357b3d0664e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371729Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#801308}
-
Harald Alvestrand authored
The test RTCRtpTransceiver.https.html was written wrong. Bug: chromium:1115087 Change-Id: If6961ac8ec33605ecf97da10d97e4c35281cc6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374446Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#801307}
-
Tom Anderson authored
This makes it easier to track the remaining usages of Xlib. I plan on removing headers from x11.h a couple at a time. Once we're down to just Xlib.h, I'll remove the Xlib.h include and replace it with manual declarations for all the types and functions we need (XOpenDisplay(), etc). Then I'll continue incrementally removing types and functions from there. BUG=1066670 R=msisov,sky,penghuang Change-Id: Ia80e911eb540f99c2a4aa3edf396f1e1cc982e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373227Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#801306}
-
arthursonzogni authored
Previous patch: https://chromium-review.googlesource.com/c/chromium/src/+/2364492 Added a WebFeature. Unfortunately, this isn't observable from the content/ layer. This is because the ContentBrowserClient::LogWebFeatureForCurrentPage() is currently left blank. Every content/ embedders copy-pasted almost all the same implementation, using the page_load_metrics::MetricsWebContentsObserver::RecordFeatureUsage() function. Instead of adding the tests into content/browser, this adds them to chrome/browser/ Bug: 1116413 Change-Id: I635eb004653c737403544b324c47ca7ef6b884d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366936Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
Greg Thompson authored
This reverts commit 44f5ba08. Reason for revert: This strategy doesn't work, so let's go back to the previous strategy. It doesn't work today, but will in an upcoming Google Update release. Original change's description: > [mini_installer] Move the fallback reporting to InstallerError. > > https://crrev.com/798844 attempted to send up a signal regarding whether > or not the fallback temp directory was used. Unfortunately, Omaha does > not include the ExtraCode1 value for successful installs. It does, > however, send up success HRESULTS in the InstallerError value. This CL, > therefore, switches to that. The two values to look out for are > 0x00044001 and 0x00044002 (two success HRESULTS in FACILITY_ITF that > otherwise appear to be unused). > > BUG=516207,1100280 > > Change-Id: I319c5dbe7162543a71465238c5320719225fa1f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368353 > Auto-Submit: Greg Thompson <grt@chromium.org> > Commit-Queue: S. Ganesh <ganesh@chromium.org> > Reviewed-by: S. Ganesh <ganesh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800584} TBR=ganesh@chromium.org,grt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 516207 Bug: 1100280 Change-Id: I38f6d27904d8f822c949fb07285ae63830ce533a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374206Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#801304}
-
Fredrik Söderqvist authored
SVGImageForContainer::PaintImageForCurrentFrame() doesn't pass on zoom, and will thus produce a result an image that differs from how the same image would look if it was painted using a more direct code-path - such as Draw(). Add a |zoom| argument to SVGImage::PopulatePaintRecordForCurrentFrameForContainer and adjust callers to pass a relevant zoom-factor. Re-order the order of the arguments to match other methods that accept zoom. Bug: 1121177 Change-Id: If2e1abe8ee3f9f29e176044b1ea3261bc300a87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368593Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#801303}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iab3c70ec38b82e32a40af23e645ffae506d60052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374225Reviewed-by:
-
Jecelyn Yeen authored
Change-Id: Ie572954f1ad75a50b12a1f0c268bd2d2919b0e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371947 Commit-Queue: Jecelyn Yeen <jec@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Sundoo Kim authored
Explicitly remove the copy constructor and assignment operator with the delete keyword. Bug: 1010217 Change-Id: Ic3450e3f9b42d3ee530460f34f42e0def6b42ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368572Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#801300}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e8bde89026d6..42aaf8bd7f23 2020-08-25 thestig@chromium.org Simplify CFX_Font's CharsetFontMap code. 2020-08-24 nigi@chromium.org Enable FPDFEditEmbedderTest.PathOnTopOfText for Skia/SkiaPaths. 2020-08-24 thestig@chromium.org Abstract some raw data tables in CFX_Font. 2020-08-24 thestig@chromium.org Simply _CheckIncludeOrder() presubmit check. 2020-08-24 tsepez@chromium.org Introduce class EmbedderTestEnvironment 2020-08-24 thestig@chromium.org Add ReverseCopy3Bytes() utility function. 2020-08-24 thestig@chromium.org Switch to memcpy()/std::fill()/std::swap() in image processing code. 2020-08-24 thestig@chromium.org Switch to memcpy()/memset() in image conversion code. 2020-08-24 thestig@chromium.org Remove dead code in CJpegContext. 2020-08-24 tsepez@chromium.org Introduce CFX_GEModule::PlatformIface::CreateDefaultSystemFontInfo(). 2020-08-24 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Code Coverage from af90718d311e to 2d8a12dca47a (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: If9a1dc83ce19f2cc580d5041bc1f3ed74b5d2988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374346Reviewed-by:
-
Zhuoyu Qian authored
This CL rename Web IDL |OverrideBuiltins| to |LegacyOverrideBuiltins| to make its usage more clear. Bug: 1072773 Change-Id: I0068fe21136dc3ccf68c5a34e293fffab99a3ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359880Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#801298}
-
Michele Mancina authored
Bug: b/161674018 Change-Id: If93e5eaab7391fad3af8b29d4030a6cc43d47737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360070 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Maksim Sisov authored
disable tests for non-X11 (ozone and non-ozone) backends. Otherwise, they can be ran for wayland backend, which is incorrect. Bug: 789065 Change-Id: Ia2956a1e9137e77968a193182c7db675470ca307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372463 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
-
James Hollyer authored
On Windows we grab the raw mouse movements and stop actually moving the mouse when in unadjusted movement so moving to the center does not make sense. However, on ChromeOS and Linux we temporarily turn off mouse Acceleration in the settings and keep the mouse moving like normal so The move to center calculation should not change. Bug: 1119468 Change-Id: Ib318627340df98f55205f4489084d88c89a7fd37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373447Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#801295}
-
Fergal Daly authored
It was reenabled in https://crrev.com/c/2008079 but it is still flaky when run with leak detection. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak?limit=100 TBR=cassew@google.com,rakina@chromium.org Bug: 833655 Change-Id: I4268307e0549d38c6e653217776a5f31309badbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371948 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
-
Sundoo Kim authored
Explicitly remove the copy constructor and assignment operator with the delete keyword. Bug: 1010217 Change-Id: I209ebbcb89a616c91284c170ef251bbb4fd3091e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371382Reviewed-by:
-
