- 19 Aug, 2020 40 commits
-
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. Bug: 1110266 Change-Id: Ibf45218c1ba6a609714ba80ee2d7bae28e929f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352689Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#799767}
-
Andrew Comminos authored
This was disabled in the past due to build failures, which are no longer reproducible on the latest checkout. Bug: 600399 Change-Id: I10bbc35d49edf2458d4262fb9201a0997a5e745e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362974Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#799766}
-
Alice Wang authored
This CL adjusts the UI for the sign-in general error screen in the web sign-in flow and add strings needed for the screen. The order of the view elements in account_picker_bottom_sheet_view.xml are rearranged to make sure that the height of sign-in general error screen is the same as the sign-in in progress screen. Screenshot: https://crbug.com/1114589#c5 Bug: 1114589 Change-Id: I281c59eb7a64f7121cf1a8dcd989a32c37f6a1a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362588Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#799765}
-
Henrique Nakashima authored
This is a step to modularize ChromeTabCreator. Bug: 1112920 Change-Id: I45d896c1427446d4484947121ae147f6e59c3c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357349Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#799764}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e0a44a28c5be..08a42d0acc75 2020-08-19 mmortensen@google.com query_build_logs: Enable date range searches with --before, --after. 2020-08-19 vapier@chromium.org toolchain: fix capturing of output 2020-08-18 iby@google.com Fix unclear message when deploying SELinux changes 2020-08-18 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-18 bpastene@chromium.org Replace various uses of deploy_chrome's '--to' with '--device'. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I7c7db72ea9449ae3aa672c6aa7e4684e5b0d4b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364279Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799763}
-
Corentin Wallez authored
Following the PSA for API deprecations, the following are removed: - GPUDevice.createBufferMapped - GPUBuffer.mapReadAsync - GPUBuffer.mapWriteAsync Also a small check in ValidateRange is fixed. Bug: dawn:22 Change-Id: I390b9992683e660fece3a17e0671149a40efcd1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351971 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#799762}
-
zhaoyangli authored
Roll all iOS builder and tester machines in infra/config to use Xcode 12 beta 4.Exceptions: - Branched builders. - Goma, WebRTC, cronet builders. - ios-webkit-tot (builder uses a customized Xcode) Changed iOS 13 simulator runtime from 13.4 -> 13.6 for tests in the rolled builders. infra/config change won't be effective for CQ jobs. Thus, iOS builders won't pass CQ due to incompatibility of builder and tester Xcode version. Adding NOTRY label to this change. No-try: true Bug: 1116656 Change-Id: I276e2c6f74d353ad4b07c194c8925331acedb1dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357424 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#799761}
-
Primiano Tucci authored
This is a manual roll to catch up with the changes in http://r.android.com/1393348 https://android.googlesource.com/platform/external/perfetto.git/+log/72e31331da03..ef0fb4c2707e 2020-08-19 lalitm@google.com Merge "tp: use sched blocked reason in thread state table" 2020-08-19 fmayer@google.com Fix non-explicit single-argument ctors. 2020-08-19 lalitm@google.com Merge "tp: parse sched blocked reason from proto and systrace" 2020-08-19 primiano@google.com Merge "Protozero: fall back on the heap when nesting too deep" 2020-08-19 taylori@google.com Update trace_processor Bug: 960303 Change-Id: I62ba6535aa56c1b90cbe9b3a3e6597e9a59e949f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362805 Commit-Queue: Primiano Tucci <primiano@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#799760}
-
Adam Langley authored
|FidoTunnelDevice| performs a caBLEv2 handshake, and passes CTAP2 messages, across a WebSocket. BUG=1002262 Change-Id: I0d6e89019aca292a1795b380a9b87b59971733b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340388 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#799759}
-
Brandon Wylie authored
Bug: 1117079 Change-Id: Ibf4fea0162df9eb890b39dc4265473bb98874d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360481Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#799758}
-
yilkal authored
This cl updates EDUCoexistence message strings because the EDU account will be added to ARC++. Bug: 1115310, 1115313 Change-Id: I2a1828a9603d97b562856bcec18e25d51225b7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353089Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Carlos Pizano <cpu@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#799757}
-
Fredrik Söderqvist authored
Introduce a SVGListPropertyBase class that SVG*List types can inherit from to get generic list handling. This deduplicates code that will be essentially identical already. The type-specific SVG*List class now only provides type-specific access to the underlying list. This also allows more straight-forward sharing of for example the ValueAsString() implementation,(now depending on the virtual method on the listed object wrapped in generic list-string building. The interface exposed to the DOM environment is moved to the corresponding tear-off classes, and the interface of the list base class is simplified to a slightly smaller set of operations. Split SVGListPropertyTearOffHelper::CreateItemTearOff into variants for "attached to list" and "detached from list" since we know this at the callsites. Bug: 1106762 Change-Id: I8263bb957ed4824ad70341fd4dd161d1214e697e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302614 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#799756}
-
Dominique Fauteux-Chapleau authored
Bug: 1119390 Change-Id: Id9224cd80ead2d37dc918d8dafd381fa289489e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363836Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#799755}
-
Mike Dougherty authored
Changes being made in crrev.com/c/2353092 are breaking these tests when using web::HttpServer. So this CL converts them to the now recommended EmbeddedTestServer. Bug: 891834 Change-Id: I3a64b9ce3288fe137dc9b6dd01d7352cd72e395b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362972Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#799754}
-
Chris Harrelson authored
Also, clean up an obsolete comment. Change-Id: I489387a7ed13edc777fd11c30deadac962affe6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364217Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#799753}
-
Yao Xiao authored
The server is expecting this field, otherwise the event will be dropped. Bug: 1119394 Change-Id: I7606ca2b8df2eff9c0ea3913e93694241e937ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364516Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#799752}
-
Fletcher Woodruff authored
Extend the expiry of these metrics to 2020-12-01, since there are some new analyses we would like to run on the collected data. Bug: 1117221 Change-Id: I35db56cf48800282f88cf19a0d09fbc84d8dff8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360320Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Fletcher Woodruff <fletcherw@chromium.org> Cr-Commit-Position: refs/heads/master@{#799751}
-
Becca Hughes authored
This adds the new CSS file and makes more resources available to the NTP. Change-Id: Iee5435ddb3f26e153628ccdcff0032efe29bed50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363566Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#799750}
-
Mohamed Amir Yosef authored
Bug: 1108422 Change-Id: I6a9996b0bd8245e3289acf4d8c3a6469ddb85827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362923 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#799749}
-
Ilia Samsonov authored
Some baselines have changed, baselines are from https://test-results.appspot.com/data/layout_results/linux-blink-optional-highdpi-rel/67/high_dpi_blink_web_tests%20%28with%20patch,%20experimental%29/layout-test-results/results.html Bug: 1068400 Change-Id: Ic5aa345759dcca696e8fef9b324423d536dfe6a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349408 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#799748}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/a1cee8dc919d..53747dfe65ea $ git log a1cee8dc9..53747dfe6 --date=short --no-merges --format='%ad %ae %s' 2020-08-18 marpan vp9-svc: Fix to resetting RC for temporal layers 2020-08-17 marpan rtc-vp9: Fix to rcstats in vp9_spatial_svc_encoder 2020-08-10 angiebird Avoid re-allocating fp_motion_vector_info 2020-08-10 angiebird Cosmetic changes in simple_encode.h 2020-08-10 angiebird Correct the first pass motion vector scale 2020-08-10 angiebird Cosmetic change for simple_encode_test.cc 2020-08-07 angiebird Make target_frame_bits error margin configurable. 2020-08-07 angiebird Avoid division by zero for rate q_step model 2020-08-03 angiebird Add rq_history to encode_frame_result 2020-08-07 angiebird Fix ObserveFirstPassMotionVectors() (...) 2020-07-15 angiebird Build libsimple_encode.a separately 2020-06-15 angiebird Add SetEncodeSpeed() to SimpleEncode 2020-07-07 jianj Cap target bitrate to raw rate internally 2020-07-07 jianj Cap target bitrate to raw rate internally 2020-07-09 jzern test/*: rename *TestCase to TestSuite 2020-07-09 jzern test/*: rename *TestCase to TestSuite 2020-07-01 jinbo-hf vp8,vpx_dsp:[loongson] fix bugs reported by clang 2020-06-29 jzern add CONTRIBUTING.md 2020-06-17 jzern update googletest to v1.10.0 2020-06-18 jzern vp9_skip_loopfilter_test: make Init() return a bool Created with: roll-dep src/third_party/libvpx/source/libvpx R=jzern@google.com Change-Id: Iaeeae89035f45fea2a7d83a9c54ef1ce8b0f9434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364030Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#799747}
-
David Benjamin authored
This is no longer used and has been getting increasingly buggy as Chrome and macOS evolve (see bugs 762915, 983451, 1020622, 1078158, 1098786). The two uses have since been removed, so remove the support code. Bug: 1111423 Change-Id: I07b5268dd07c2659ed1bd710bfaae704804e5daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347000 Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#799746}
-
Brandon Wylie authored
Bug: 1116927 Change-Id: Ie0603c81108b236f7f4356559cef7759219ea00f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359566Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#799745}
-
Viviane Yang authored
Change-Id: Ib4f3e3224d88c970b96f21e898f60fc3099ab4bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362904Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#799744}
-
Matthias Körber authored
With structured names, profiles must be finalized after an import. For the tests to work correctly, the two necessary lines are added. Bug: 1099202 Change-Id: I7b835fa144871cd4549415270685996f9bfabe51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362825 Commit-Queue: Christoph Schwering <schwering@google.com> Auto-Submit: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#799743}
-
Alexander Cooper authored
This reverts commit 4f0531b4. Reason for revert:Another change was speculatively reverted at the same time, when the webgl_conformance_tests began passing again. This change does not change behavior except on Windows, so shouldn't be the cause of the webgl_conformance_tests failure/passing on chromeos. Original change's description: > Revert "Revert back to the default GPU when no renderers are using WebXR" > > This reverts commit 0fb7ef15. > > Reason for revert: Speculative revert > May have broken webgl_conformance_tests on chromeos-amd64-generic-rel: > https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-rel/45665 > > Original change's description: > > Revert back to the default GPU when no renderers are using WebXR > > > > The GPU process may have been restarted and initialized on a different > > GPU than the default if the VR headset is not plugged into the default > > GPU. Staying on this XR compatible GPU can drain battery a lot quicker. > > When there are no longer any renderers using WebXR, this change reverts > > reverts the GPU process back to the default GPU. > > > > Bug: 1090951 > > Change-Id: Ibc5e7f709d2c82d5a6e8cbda08766d1d654951a3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321771 > > Commit-Queue: Patrick To <patrto@microsoft.com> > > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#798950} > > TBR=patrto@microsoft.com,alcooper@chromium.org > > Change-Id: I14e44c4fe60cdde138ea281b8766ac113887aa99 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1090951 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359663 > Reviewed-by: Fergus Dall <sidereal@google.com> > Commit-Queue: Fergus Dall <sidereal@google.com> > Cr-Commit-Position: refs/heads/master@{#798984} TBR=patrto@microsoft.com,sidereal@google.com,alcooper@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1090951 Change-Id: Id5cf2e4c949b2d5b727047bdadb7fe021a535e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363288Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Patrick To <patrto@microsoft.com> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#799742}
-
Kevin McNee authored
This reverts commit 4e425ce4. Reason for revert: The introduced test, InfoBarUiTest.InvokeUi_mac_system, CHECKs on Mac10.13 Tests (dbg). https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/19756 [60632:775:0819/091938.267274:FATAL:mac_system_infobar_delegate.cc(55)] Check failed: ShouldShow(). Original change's description: > mac: introduce system infobar > > This infobar will be used (via field trials) to display updated info > about current OS support and provide users with a link to more info. > The infobar receives both activation info (which configs to show for) > and the actual strings to display via field trials, so it can be updated > for deployed Chrome instances without an update cycle. > > This change adds: > * The infobar itself > * A feature MacSystemInfobar that controls whether the feature is > enabled and if so which configs (Arm or Rosetta) it's enabled in > * A switch --force-mac-system-infobar which causes the infobar to act as > though it was running on a specified system, for both manual and > automatic tests > * A variety of IDS_MAC_SYSTEM_INFOBAR_* constants to customize the > infobar's message, link, and link text > * Unit tests for the logic to interpret the feature and the > enable/disable configs > > Bug: 1116578 > Change-Id: Ie7fd6e772a0112a17e794d1b8fcb009c57ebed4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360479 > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799615} TBR=ellyjones@chromium.org,pkasting@chromium.org,asvitkine@chromium.org Change-Id: Ia7e7877d75b500b8eb05bb93bab63606c94fcfdf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364892Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#799741}
-
David Bokan authored
This CL moves the window.location.fragmentDirective object, used for feature detecting support for text fragments, to document.fragmentDirective. This is a web-facing change. Intent-to-ship thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ygBV2vWIX-o/kbYwrJgDAgAJ Bug: 1057795 Change-Id: I1a7df51a1cde4c39a3595d7d83b118403db5cd5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343634 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#799740}
-
Ben Mason authored
Bug: 1119325 Change-Id: I04727f349d0012a4a89ab93032530ccecf53e767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364210Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#799739}
-
Mohamed Amir Yosef authored
This is a mechanical change that passes a raw pointer to PasswordStoreConsumer::OnGetPasswordStoreResultsFrom() instead of a scoped_refptr to avoid a potential refcount churn. Bug: 1108422 Change-Id: I7f435fef2a22a0b9647914ab05367fd0511e536d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362903 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#799738}
-
Haiyang Pan authored
This test suite is fairly stable in fyi MM, and the capacity of 4-core bots looks suffcient. Also increase the shard number to 20 given it runs a bit slower on 4-core bots Bug: 997376, 1098111, 1116620 Change-Id: Ie2a6ab4a9be334d720837b3ebbb64537c8076cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363648Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#799737}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/69cb5514ee4c..53effa99e255 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mcnee@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mcnee@google.com Change-Id: I26a248ee96dae61ceb02da848089aa51d62cb774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362982Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799736}
-
Dylan Cutler authored
Bug: 973801 Change-Id: I37abe1065f80f4c2d7aca88f09dfd0ebb85cfa8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352512Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#799735}
-
Eugene But authored
Do not call reportBackUserAction on SettingsTableViewController as root settings view controller does not have "back" button and does not have to record "back" metric. DCHECK was hapenning after dragging SettingsTableViewController bottom and returning it back, which called presentation callback for root settings controller. Bug: 1117512 Change-Id: I45f3a2285007e8098b9155501a9c526fecf1df8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363003 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#799734}
-
Mohamed Amir Yosef authored
This is analogous to PasswordForm::in_store and reflects in which store those credentials are stored. Bug: 1108422 Change-Id: I1b60e2cc2725959342abf1a0d1dad9df09d10edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364508Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#799733}
-
Maks Orlovich authored
Bug: 982374 Change-Id: I9d83f7938967f44be95c410610d4a38f8c59b6d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364058Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#799732}
-
Kevin McNee authored
This reverts commit 5de0588a. Reason for revert: A few time related unit tests started flaking on win-asan, starting from the build containing this CL (13964). Suspecting this CL to be the culprit. https://ci.chromium.org/p/chromium/builders/ci/win-asan https://ci.chromium.org/p/chromium/builders/ci/win-asan/13964 e.g. [ RUN ] ElapsedThreadTimerTest.Simple ../../base/timer/elapsed_timer_unittest.cc(72): error: Expected: (timer.Elapsed()) >= (kLoopingTime), actual: 0.000988 s vs 0.001 s Stack trace: Backtrace: base::ElapsedThreadTimerTest_Simple_Test::TestBody [0x00007FF7C6A735B1+1351] (C:\b\s\w\ir\cache\builder\src\base\timer\elapsed_timer_unittest.cc:72) [ FAILED ] ElapsedThreadTimerTest.Simple (289 ms) Original change's description: > //base/time cleanups: > > * Make more things constexpr and/or make it possible to do so later > * Inline SaturatedAdd/Sub(), FromDouble(), FromProduct() > * Order the FromUnits{,D}() pairs together > * Init members in declaration > * Briefer implementations of various functions > * IWYU > * Fix declared-but-not-defined issue for FromTimeSpec() w/OS_FUSCHIA > * Use more specific DCHECKs > * No else after return > * Omit needless qualifiers > * EXPECT -> static_assert where possible > * <atomic> is legal now > * Don't handle DCHECK failure > > The inlines don't hurt size: this saves 4 KB off chrome.dll in my local > release build. > > Bug: none > TBR: stevenjb@chromium.org > Change-Id: I269d6426ac1587569e7a4c785250a4dd5e95d5bf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358997 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799459} TBR=stevenjb@chromium.org,pkasting@chromium.org,miu@chromium.org,tsepez@chromium.org,khegde@chromium.org Change-Id: Ic855d54ae010859b82c55848fb14d8af2cb778d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364062Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#799731}
-
adamta authored
Improves header animation for when feed changes from visible to hidden. Sets border radius and colour in advance, and animates border width when the state changes. Bug: 1085419 Change-Id: I86778e7a50594dde1f8fb159f787a8c20ff8bc29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342319 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#799730}
-
Sky Malice authored
Bug: 1111970 Change-Id: I473c0eed6a0975062055691f663ee9601cd70de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339760Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#799729}
-
Xi Han authored
Record Startup.Android.FirstDrawCompletedTime.{Instant,NoInstant}. Bug: 1092931 Change-Id: I2d589ddc7f880cd7ccfc3c3fe45c46409896a035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355590Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#799728}
-