- 04 Dec, 2019 40 commits
-
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/modules/mediastream as much as possible, and makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below factory functions, - MediaStreamEvent::Create - ApplyConstraintsRequest::Create - InputDeviceInfo::Create - MediaStreamTrackEvent::Create Bug: 939691 Change-Id: If665d5a2d90cf01c209c9fbb97f69efc73421823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947617Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#721441}
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/modules/websockets as much as possible, and makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below factory functions, - CloseEvent::Create - MockWebSocketChannel::Create - WebPepperSocketChannelClientProxy::Create Bug: 939691 Change-Id: I60ffa9b9b94b51723fe606d60a9b1215c0c72cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947615Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30972d73df3e..bb1785937ac6 Created with: gclient setdep -r src-internal@bb1785937ac6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I6d90c3c2b73b925ceaebff0fe65dff6577cb5da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950246Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721439}
-
Denis Kuznetsov authored
As the user image selection screen is removed from signin flow, this test is not needed anymore. Bug: 888784 Change-Id: Ic07da1021cea63dcc88060daa731b887a6fe3e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948941Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#721438}
-
Tim van der Lippe authored
This should have been removed in https://chromium-review.googlesource.com/c/chromium/src/+/1946372 Change-Id: Ic5d7a032fbc5c5a988260f3c202f5ea561a5a8b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949476 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#721437}
-
Andreas Haas authored
This CL replaces uses of version of deprecatedByteLengthAsUnsigned in the ImageData implementation with byteLengthAsSizeT. In ValidateConstructorArguments we check for potential overflows and throw an exception if necessary. Some uses can already deal with size_t anyways. In one case I cast the value with a checked_cast. R=jbroman@chromium.org Bug: chromium:1008840 Change-Id: I5d3117a27e1b385428603a08f33d624b42cc4592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948928 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#721436}
-
Sergey Poromov authored
../../chrome/browser/ui/app_list/arc/arc_app_utils.cc:385:13: warning: format specifies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Wformat] (base::TimeTicks::Now() - base::TimeTicks()).InMilliseconds())}); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../chrome/browser/ui/app_list/arc/arc_app_utils.cc:214:39: note: format string is defined here "S.org.chromium.arc.request.start=%ld"; Change-Id: Idd0f1dd9923a5d4dd66783f5af5037efaeb7109f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947662Reviewed-by:Yury Khmel <khmel@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Auto-Submit: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#721435}
-
Alexander Hendrich authored
Bug: none Change-Id: Ic68454edd22d927a9e01df04d2cbdd932567cec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949475 Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Zakhar Voit <voit@google.com> Reviewed-by:
Zakhar Voit <voit@google.com> Cr-Commit-Position: refs/heads/master@{#721434}
-
Jonathan Ross authored
This reverts commit 5d834c94. Reason for revert: Compilation error in test support for rtc: FAILED: obj/third_party/blink/renderer/modules/peerconnection/test_support/mock_web_rtc_peer_connection_handler Failing Build: https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/8289 Original change's description: > Remove web_rtc_api_name.h from Blink API surface > > It isn't used outside Blink due to the Onion Soupping of WebRTC. It was moved to > renderer/platform/mediastream and renamed so that "web" is not prefixed to the > file name and the types defined inside. > > Bug: 919392 > Change-Id: I8ccf33bdd75f0b04ffd6bc515be1b737a3ea3945 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944864 > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Commit-Queue: Sergio Villar <svillar@igalia.com> > Cr-Commit-Position: refs/heads/master@{#721424} TBR=jbroman@chromium.org,svillar@igalia.com,altimin@chromium.org Change-Id: I4af774231f943625518ba93684c78fa486dbecfa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948922Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#721433}
-
arthursonzogni authored
The Content-Security-Policy-Report-Only header with script-src was not checked for "eval". This patch fixed the issue. --- This is mostly caused by the function: ~~~ void ScriptController::UpdateDocument() { window_proxy_manager_->MainWorldProxyMaybeUninitialized()->UpdateDocument(); EnableEval(); } ~~~ Line 1 makes V8 to bypass checking CSP "eval" if there are no CSP or TrustedType checks to make. So far so good! Line 2 made V8 to bypass checking CSP "eval" unconditionally. Wrong! --- The second problem was that V8 AllowCodeGenerationFromStrings was not set to false in case of 'report-only' CSP. This patch fixed this and went further. Blink now requires V8 to always call it back before any 'eval' call, no matter if there are policies or not. This is simpler. --- Bug: 980127 Change-Id: Ia5b4887cc981d85a077649df8a54cfebace245ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947741 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#721432}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/bbd0694f9ab2..9c795fda9a8c git log bbd0694f9ab2..9c795fda9a8c --date=short --first-parent --format='%ad %ae %s' 2019-12-04 bclayton@google.com VulkanUnitTests: Fix bad comment on assembly. Created with: gclient setdep -r src/third_party/swiftshader@9c795fda9a8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I2c8b063a7887b73ed872136751a7487be301daee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950196Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721431}
-
Nikita Podguzov authored
As far as we want to reuse StickySettings in Printing API for extracting information about recent printer activity we should place it in more appropriate component. Also create GetInstance() function to support the assumption that only one instance of the class is instantiated. Background: crrev.com/c/1893206 Bug: 996785 Change-Id: I6c5205ef181e56836954f83990a007ee04f351ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947738 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#721430}
-
Michael van Ouwerkerk authored
Bug: 1018129 Change-Id: Ie0424315ab4c7b02e5899c30d0efa7062588d66f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948831Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#721429}
-
Yngve N. Pettersen authored
This allows downstream embedders to specify their own branding files and locations without having to patch chromium source files. Change-Id: I8b5c1d71a11998ef68b586f11326d82aced35529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932781Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yngve Pettersen <yngve@vivaldi.com> Cr-Commit-Position: refs/heads/master@{#721428}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f3aa582f01c2..1ef4b91dcb8a git log f3aa582f01c2..1ef4b91dcb8a --date=short --first-parent --format='%ad %ae %s' 2019-12-04 yangguo@chromium.org Reimport a11y-axe-core tests from Chromium 2019-12-04 mathias@chromium.org Update various Network Conditions User-Agent strings 2019-12-04 mathias@chromium.org Update Network Conditions User-Agent strings for Safari Created with: gclient setdep -r src/third_party/devtools-frontend/src@1ef4b91dcb8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029031 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic3c3cc8173cfdbc6b40d4ebf49fc42ba1a1a6ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950243Reviewed-by:
-
Sergey Poromov authored
Support Chrome OS (only managed by the Google cloud). We also try to take advantage of the browser's existing management infrastructure rather than creating new cloud policy clients if we can find one already. Unifies the way how DMToken is retrieved. TBR=avi@chromium.org out_chromeos/Default/unit_tests Bug: chromium:1012048 Test: out/Default/unit_tests && Change-Id: Id94468200e6a79a2a5b3ad4dcbf12c5972a629e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846475 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#721426}
-
Chris Blume authored
It seems that some years ago clang@Windows didn't have the proper intrinsic required, which prompted the use of inline ASM. It has a side effect in that it will allow compilation of the optimized function within the same compilation unit while using regular compiler flags (i.e. 'crc32' instruction on x86 requires some special compiler flags). Main issue is that inline ASM is blocked on dependencies (e.g. 'base') that will be linked to NaCl. The main idea here is to allow the whole Chromium code base to use the highly optimized checksums in zlib (e.g. crc32 and Adler-32), exported through an interface (i.e. base::Crc32()). This patch fixes this issue by removing the use of inline ASM. The workaround is to use clang/gcc 'target attributes' to instruct the backend to use different code generation options for the optimized function, see: https://clang.llvm.org/docs/AttributeReference.html#target NOTE: While testing on my personal Windows PC, VS2019 including smmintrin.h was insufficient. I needed to explicitly include either immintrin.h or nmmintrin.h. I expected I would need that, but it seems to be working with just smmintrin.h. Bug: 902789 Change-Id: Id692fb839e20b26f9ba8b45538e652d5b140cd36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941688 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#721425}
-
Sergio Villar Senin authored
It isn't used outside Blink due to the Onion Soupping of WebRTC. It was moved to renderer/platform/mediastream and renamed so that "web" is not prefixed to the file name and the types defined inside. Bug: 919392 Change-Id: I8ccf33bdd75f0b04ffd6bc515be1b737a3ea3945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944864Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_party/blink/renderer/modules/mediarecorder as much as possible, and makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below factory functions, - BlobEvent::Create(const AtomicString& type, Blob* blob, double timecode) - MediaRecorderHandler::Create Bug: 939691 Change-Id: I82450514fab5bf2c5667fbdb5b7930d4cc02a6aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949839Reviewed-by:
-
Yutaka Hirano authored
WebView and Headless (may) use their custom network stack instead of the network service, but they want security features implemented in the network service such as CORS. This CL introduces URLLoaderFactoryParams.factory_override. It, if set, is used to replace the network::URLLoaderFactory used in network::CorsURLLoaderFactory. Also, it also has a member to get a network::URLLoaderFactory that could have been used by the network::CorsURLLoaderFactory, in order to allow embedders to use the network service without CORS. AwContentBrowserClient sets |factory_override| via WillCreateURLLoaderFactory. When AwProxyingURLLoaderFactory intercepts a request, 1. If |factory_override| is not found, this is a navigation request, or non-network request. Do what it does currently. 2. Otherwise, pass the request to the URLLoaderFactory captured at WillCreateURLLoaderFactory. The CORS modules in the network service will use the URLLoaderFactory passed as |factory_override.overriding_factory|. 3. When the URLLoaderFactory passed as |factory_override.overriding_factory| is called, it consult with the WebView application. When it returns a response (intercepting case), return that response to the CorsURLLoader. Otherwise, use the URLLoaderFactory passed as |factory_override.overridden_factory_receiver| at WillCreateURLLoaderFactory to ignore CORS. Bug: 1027011 Change-Id: I258b7507ee0a7991df2c1ae1c9f5f0cc71ad67ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928100Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#721422}
-
Jan Wilken Dörrie authored
This change modifies the native strings used in base::FilePath, base::CommandLine and base::Environment to be std::wstring on Windows. Furthermore it updates callers within //base to be compatible with the upcoming switch of base::string16 from std::wstring to std::u16string. Bug: 911896 Change-Id: I3843e87c15ad0faeaa0e5e0ca3059c39e8108dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817603 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#721421}
-
Elly Fong-Jones authored
This test doesn't work on Mac because the restore behavior is different. The fact that it doesn't work was obscured by issue 899286. :( Bug: 1028239 Change-Id: I9dab005ace535eddeec3b431818166f3e3372047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947929Reviewed-by:
-
Juan Antonio Navarro Perez authored
Bug: 1029008 Change-Id: I38d1642451bd0aeb85c25cc1de87737008c38ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940150 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#721419}
-
Eric Seckler authored
Since benchmarks are still flakily failing on linux-perf due to overrunning the buffer. We may be able to reduce this further again once we remove LegacyEvent completely. Bug: 1029510 Change-Id: Ie91d85842fae1f82632c1e72c87e5dc1508ff714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948743 Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#721418}
-
Andreas Haas authored
With this CL I remove a use of DOMArrayBufferView::deprecatedByteLengthAsUnsigned and replace it by using DOMArrayBufferView::byteLengthAsSizeT. To avoid potential problems with overflows I do an overflow check in NavigatorBeacon::sendBeacon and throw a RangeError if necessary. Additionally I added checks to the BeaconDOMArrayBufferView implementation where the byteLengthAsSizeT is actually used. R=yhirano@chromium.org Bug: chromium:1008840 Change-Id: Ifa94e08e47384232e9d112244ffc29e0e870b2b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948884Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#721417}
-
Andreas Haas authored
I removed the declaration of two functions where I deleted the definition recently. Drive-by: I also changed the implementation of ByteLengthAsUnsigned to use a checked_cast now. I was not aware of checked_cast back when I did the change originally. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I8863115c06b44d1c04e8bb71df93709a25012e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947740Reviewed-by:
-
Andreas Haas authored
The implementation can already deal with size_t anyways. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: Id0c0b9997cd2a27dd40d240e234cb89d314a651e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948888Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4b6a26740234..f3aa582f01c2 git log 4b6a26740234..f3aa582f01c2 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 yangguo@chromium.org Remove invalid isolate entries in BUILD.gn 2019-12-04 anubmat@microsoft.com DevTools: Add profileType context in the aria-description of Memory tool sidebar tree elements 2019-12-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. 2019-12-03 zoeclifford@chromium.org Update Googlebot User-Agent 2019-12-03 mjackson@microsoft.com Allow user to tab to the inspect link on the remote devices panel. 2019-12-03 yangguo@chromium.org Move test and localization scripts 2019-12-03 janscheffler@chromium.org Show Network request with SameSite issues Created with: gclient setdep -r src/third_party/devtools-frontend/src@f3aa582f01c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1030258,chromium:963183,chromium:984733 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iab0c9089c5bc957ea3de62b99766e5429ff87dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950041Reviewed-by:
-
Hugo Holgersson authored
See Issue 803086 for motivation and context of this effort. Bug: 803086, 1000578 Change-Id: Ib36de3f671204ce0d9b4d05e68966e735ba5544e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949784Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Hugo Holgersson <hholgersson@fb.com> Cr-Commit-Position: refs/heads/master@{#721413}
-
Mark Cogan authored
Update the RecentTabsCooordinator to use the preferred initializer. Most of the change volume comes from adopting the preferred dispatcher/ handler style and usage. This is especially painful in the unittest, since the dispatcher in the test browser needs to conform to several protocols to pass the runtime checks used by HandlerForProtocol(). This probably means that the large command protocols, especially those that conform to several other protocols, need to be made more specific. Bug: 1029346 Change-Id: I69baf57ce162799b5af4ec6fdfe19e7bdc787d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944468Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#721412}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/249cb200173f..b939b4a7247d git log 249cb200173f..b939b4a7247d --date=short --first-parent --format='%ad %ae %s' 2019-12-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src a4af7676feb0..e58c080d4f02 (1 commits) Created with: gclient setdep -r src/third_party/angle@b939b4a7247d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I43b14eb77064c953a4b4a1aed5060120447e3dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949541Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3ed4586044f2..e82a428605f6 git log 3ed4586044f2..e82a428605f6 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 dneto@google.com WebGPU: Array size at most max signed int + 1 (#3077) 2019-12-03 9856269+sarahM0@users.noreply.github.com Permit the debug instructions in WebGPU SPIR-V - remove from the optimizer (#3083) 2019-12-03 dneto@google.com graphics robust access: use signed clamp (#3073) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@e82a428605f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I8354cc6437209c19cc8b1e8a7d956d656cbca0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950029Reviewed-by:
-
Richard Knoll authored
Instead of using the WebContents from the tab that initiated showing a SharingDialog, always use the one from the currently shown tab. This makes sure that we show the origin if the initiating one does not match the one in the active tab. Bug: 1029414 Change-Id: Idf79aeff17db3c5cf3137af19727bdaf79989bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948838 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#721409}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/162322e97930..30972d73df3e Created with: gclient setdep -r src-internal@30972d73df3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iffcd017fac9212c9dc8ce223927aab8e0f812ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950034Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a097c941d4f8..b64ff931eb98 git log a097c941d4f8..b64ff931eb98 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 skyostil@google.com TrackEvent: Add tip about constexpr event names Created with: gclient setdep -r src/third_party/perfetto@b64ff931eb98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:132678367 Tbr: perfetto-bugs@google.com Change-Id: I28eecd9921eac4afdc88be08b7fc6911aabcdad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950035Reviewed-by:
-
Maksim Sisov authored
Posthandling events does not work properly in this case as we are not able to track if the event that has been sent to sink is handled or not. That is, SendEventToSink results in copying the entire event which means that the original event is not going to have its handling status changed. That means that we are not able to track if the event is handled or not unless a dispatcher or a target are destroyed (remember that SendEventToSink returns EventDispatchDetails, but does not say anything about handling results). That resulted in the WindowEventFilterLinux always post-processing events and opening context menus twice (the first one was closed immediately after it was shown and the second one was shown instead). TEST: manually tested. Bug: 1028046 Change-Id: I2bedda57c7ca8a05171428da26b889eac04cf36f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947733Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#721406}
-
Mario Sanchez Prada authored
This CL migrates the mojo client in the renderer side of the contextual_search component to the new BrowserInterfaceBroker, and adapts the code in the browser process to register the binder from PopulateChromeFrameBinders(), instead of doing it inside of ContextualSearchObserver. Last, this CL also extracts the ContextualSearchObserver class out of contextual_search_manager.cc, so that the receiver can be bound now via the BinderMap owned by the BrowserInterfaceBroker. Bug: 936482,1006361 Change-Id: I95c8046650883c872750dd7408a38e7433ed9df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906667Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Mike West authored
We shipped this restriction in M77 ([1]). We can safely remove the underlying feature flags and histogram. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1646784 Bug: 1030135 Change-Id: I52ce3c152862c0ae74742444faacef741db60abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947734 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#721404}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I32f3daabe58344ff6e6ed22b7876b839a93a1839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950030Reviewed-by:
-
Andy Paicu authored
Bug: 986737 Change-Id: I80eabeb588d807453241df3dacdd1a764c66d7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942087Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#721402}
-
