GitLab

Revert of Generalize V4L2 HW video codec device names (patchset #1 id:1 of https://codereview.chromium.org/730693005/)

Reason for revert:
This change breaks video_ChromeHWDecodeUsed, please see crbug.com/439175 for details.

Original issue's description:
> Generalize V4L2 HW video codec device names
>
> Switch to more generalized V4L2 video accelerator device names and update
> sandbox rules to reflect that.
>
> This is another attempt at crrev.com/763743002, reverted in
> crrev.com/767383002 with a fixup for sandbox permissions.
>
> BUG=405861,437598
> TEST=compile
>
> Committed: https://crrev.com/30a3721c82953428d445a93ebe2bf0014e27bc10
> Cr-Commit-Position: refs/heads/master@{#306642}

TBR=jorgelo@chromium.org,scherkus@chromium.org,posciak@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=405861,437598

Review URL: https://codereview.chromium.org/784553004

Cr-Commit-Position: refs/heads/master@{#307077}

The MediaImportHandler is the overall framework class for coordinating the
import of media from attached media devices to Drive.  This initial
implementation sketches out the process, using FileOperationManager to provide
the actual copy functionality.
- UI and checks for opt-in to Drive->Photos sync and Photos->Drive sync are just
  stubbed out as TODOs.
- The use of FileOperationManager means that the import process is surfaced as a
  normal copy operaion, which is not the final goal.  Follow-up work is needed
  to implement a separate import queue and associated task management and UI.

BUG=420680

Review URL: https://codereview.chromium.org/762593006

Cr-Commit-Position: refs/heads/master@{#307076}

When gpu context is lost, CopyTextureCHROMIUMResourceManager can be deleted
without releasing resources like GLES2DecoderImpl.

BUG=438950

Review URL: https://codereview.chromium.org/780293002

Cr-Commit-Position: refs/heads/master@{#307075}

Better error messages on archive failures, and stop running with partial page sets in user_story_runner.

BUG=435063

Review URL: https://codereview.chromium.org/748013003

Cr-Commit-Position: refs/heads/master@{#307074}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/22c9ae1..69469b5

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=halcanary@google.com

Review URL: https://codereview.chromium.org/772363003

Cr-Commit-Position: refs/heads/master@{#307073}

Waterfall is running on chartjson now, but we've got hacks in the recipes to swap the command lines from buildbot->chartjson.

ie. instead of:

{
  "steps": {
    "blink_perf.animation": {
      "cmd": "/path/to/run_benchmark -v --output-format=buildbot the_test",
      "device_affinity": -1,
      "perf_dashboard_id": "foo"
    },
}

->

{
  "steps": {
    "blink_perf.animation": {
      "cmd": "/path/to/run_benchmark -v --output-format=chartjson --upload-results the_test",
      "device_affinity": -1,
      "perf_dashboard_id": "foo"
    },
}

BUG=422173, 422174

Review URL: https://codereview.chromium.org/779223004

Cr-Commit-Position: refs/heads/master@{#307072}

The loop that adds prefixes from 1 billion to 3 billion has been broken
since it was modified in Feb 27, 2014, change 2b59b0a6. It didn't survive
the change from signed to unsigned integers meaning that this test
function has effectively been disabled.

This bug was found by VC++'s /analyze which said:
src\chrome\browser\safe_browsing\prefix_set_unittest.cc(280) :
warning C6294: Ill-defined for-loop:
initial condition does not satisfy test.  Loop body not executed.

BUG=427616

Review URL: https://codereview.chromium.org/779163002

Cr-Commit-Position: refs/heads/master@{#307071}

BUG=

Review URL: https://codereview.chromium.org/780223005

Cr-Commit-Position: refs/heads/master@{#307070}

This adds more spam in release builds, but will be valuable in
diagnosing bugs.

BUG=435786

Review URL: https://codereview.chromium.org/783713002

Cr-Commit-Position: refs/heads/master@{#307069}

schemas.  They're unnecessary (controlled by the presence, or lack thereof, of
an HTML file documenting the API) and I keep on seeing code reviews of
cargo-culted APIs that add it.

R=rockot@chromium.org

Review URL: https://codereview.chromium.org/754693004

Cr-Commit-Position: refs/heads/master@{#307068}

Use the unversioned symlink to ensure we always load instrumented udev.

BUG=437464, 438427
R=thestig@chromium.org, reillyg@chromium.org

Review URL: https://codereview.chromium.org/755873003

Cr-Commit-Position: refs/heads/master@{#307067}

For DirectWrite font metrics calculate the height by rounding up the summation of the ascent and descent values retrieved from skia.

This ensures that the font size matches closely with GDI. Examples include the omnibox text size which is hardcoded to
16. However with DW we get the size as 15 which causes the text to appear smaller.

BUG=434860

Review URL: https://codereview.chromium.org/777363002

Cr-Commit-Position: refs/heads/master@{#307066}

The deadline for low-latency mode should be one frame interval off. It
was accidentally set to be an immediate deadline.

BUG=421923

Review URL: https://codereview.chromium.org/777353003

Cr-Commit-Position: refs/heads/master@{#307065}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e542608..01aebe5

TBR=schenney@chromium.org,dominicc@chromium.org

Review URL: https://codereview.chromium.org/779323002

Cr-Commit-Position: refs/heads/master@{#307064}

The IndexedDBDispatcherHost maintains a map of BLOB UUID's to BLOBs, but if two
(or more) cursors are both active and referencing the same BLOB then two (or
more) BLOBs would exist with the same UUID, and their keys would collide in this
map. This change reference counts these BLOBs to avoid duplication.

Also, access to the existing map was not synchronized and was accessed on two
different threads.

BUG=435880,436137

Review URL: https://codereview.chromium.org/774593004

Cr-Commit-Position: refs/heads/master@{#307063}

Add dedicated PipelineStatus UMAs for encrypted content to differentiate DecryptingVideoDecoder (DVD) & DecryptingDemuxerStream (DDS) codepath.

Tested the DVD path using netflix/Linux. DDS needs a chromeOS build.

BUG=435374

Review URL: https://codereview.chromium.org/770423004

Cr-Commit-Position: refs/heads/master@{#307062}

996e952  libvpx: set clang_warning_flags for all platforms
4a32064  libvpx: add -Wno-conversion for Clang builds, gn edition

BUG=431803

Review URL: https://codereview.chromium.org/784543002

Cr-Commit-Position: refs/heads/master@{#307061}

BUG=439159
TBR=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/781113002

Cr-Commit-Position: refs/heads/master@{#307060}

This reverts commit 5a9a39b7.

The commit is causing ARC apps to deadlock.

BUG=435414

Review URL: https://codereview.chromium.org/774763005

Cr-Commit-Position: refs/heads/master@{#307059}

BUG=419191
TEST=manual + new test

Review URL: https://codereview.chromium.org/738593002

Cr-Commit-Position: refs/heads/master@{#307058}

Add a synced property, elastic_overscroll, similar to page_scale_factor.

Use this property to translate the overscroll elasticity layer.

With this in place, the overscroll effect works most of the time,
when using impl-thread events.

Originally committed at r306991, reverted at r306995 due to ASAN break
due to LTI::overscroll_elasticity_layer_ not being initialized.

BUG=133097
TBR=aelias

Review URL: https://codereview.chromium.org/749393005

Cr-Commit-Position: refs/heads/master@{#307057}

When running VC++'s /analyze it says:
src\chrome\installer\mini_installer\mini_installer.cc(217) : warning
C6001: Using uninitialized memory 'ret'.

This may be a false positive but if reg is guaranteed to be initialized
before it is read then this guarantee is very subtle. The safe thing to
do is to initialize it.

This potential bug was introduce in December 2010 in:
http://codereview.chromium.org/5875003

BUG=427616

Review URL: https://codereview.chromium.org/780983002

Cr-Commit-Position: refs/heads/master@{#307056}

BUG=439346

Review URL: https://codereview.chromium.org/761863007

Cr-Commit-Position: refs/heads/master@{#307055}

VC++'s /analyze complained about peculiar use of sizeof, and the code is
peculiar.

The original code was:

memset(ref, 'X', sizeof(char) * arraysize(buf));

Validating the correctness of this requires knowing that buf and ref
have the same number of elements, and requires knowing that ref is an
array of 'char'. It is simpler and safer to do this:

memset(ref, 'X', sizeof(ref));

The warning was:

src\base\strings\safe_sprintf_unittest.cc(64) : warning C6260:
sizeof * sizeof is usually wrong.  Did you intend to use a character count
or a byte count?

This change will not change the behavior of the code, just its
readability.

This code was introduced in:
https://chromiumcodereview.appspot.com/18656004

BUG=427616

Review URL: https://codereview.chromium.org/774933011

Cr-Commit-Position: refs/heads/master@{#307054}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/95f9b5f..22c9ae1

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=halcanary@google.com

Review URL: https://codereview.chromium.org/777423002

Cr-Commit-Position: refs/heads/master@{#307053}

BUG=none
TEST=none
R=jam@chromium.org

Review URL: https://codereview.chromium.org/758463003

Cr-Commit-Position: refs/heads/master@{#307052}

This is done by turning scoped_ptr<PrefixSet> into scoped_ptr<const PrefixSet>.

While this doesn't fully address the issue of making sure there are no
updates on other threads it does help any readers trying to prove this
for themselves.

BUG=None

Review URL: https://codereview.chromium.org/781613002

Cr-Commit-Position: refs/heads/master@{#307051}

BUG=chromedriver:416
TBR=stgao@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/776233004

Cr-Commit-Position: refs/heads/master@{#307050}

device/bluetooth will soon be accessed by content/browser. This
change converts it from a static library to a shared component.

BUG=438305

Review URL: https://codereview.chromium.org/778443002

Cr-Commit-Position: refs/heads/master@{#307049}

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/781623002

Cr-Commit-Position: refs/heads/master@{#307048}

BUG=chromedriver:992
TBR=stgao@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/764373003

Cr-Commit-Position: refs/heads/master@{#307047}

BUG=437085

Review URL: https://codereview.chromium.org/778923003

Cr-Commit-Position: refs/heads/master@{#307046}

- Expand the PromiseErrorFilter to allow multiple types of errors to be filtered out.

- Add a new type of allowed error, namely errors from the compiler failing to
  unwrap the result of a returned Promise chain.  Example:

  /** @return {!Promise<string>} */
  var getStringAsync = function() {
    /** @return {!Promise<string>} */
    var generateString = function() {return Promise.resolve('foo');};
    return Promise.resolve().then(generateString);
  };

  The compiler will emit an error that looks like

  ERROR - inconsistent return type
  found   : Promise<Promise<string>>
  required: Promise<string>

BUG=406995

Review URL: https://codereview.chromium.org/776273003

Cr-Commit-Position: refs/heads/master@{#307045}

This removes some uses of Bit('target_ARCH'), the definitions of which
have been removed from the NaCl side.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=2703
TEST=nacl_integration

Review URL: https://codereview.chromium.org/778173002

Cr-Commit-Position: refs/heads/master@{#307044}

This was checked with the following command line:

$ out/Debug/gn check out_gn/Debug //ui/*

And cleaned until it reported "Header dependency check OK".

BUG=367595,376000
TEST=see above
R=sky@chromium.org

Review URL: https://codereview.chromium.org/769943003

Cr-Commit-Position: refs/heads/master@{#307043}

Replace direct access to kGoogleServicesUsername with calls to SigninManager.  There is no functional change in this CL.

Some places outside SigninManager still use the pref, like one_click_signinin and ProfileIOData, but that is deprecated code that will go away.  I will remove that code in separate CLs.

BUG=107160

Review URL: https://codereview.chromium.org/763673002

Cr-Commit-Position: refs/heads/master@{#307042}

Google to other.

This also resets the pref to off if they go away from Google.

BUG=437889

Review URL: https://codereview.chromium.org/780703004

Cr-Commit-Position: refs/heads/master@{#307041}

app_shell is pure-aura, so cannot rely on the usual views::WebView and
views::Widget initial-focus behavior. It must manually set focus on the
WebContents during creation.

BUG=438751
TEST=added to app_shell_browsertests ShellApiTest

Review URL: https://codereview.chromium.org/754313003

Cr-Commit-Position: refs/heads/master@{#307040}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a9bf1aa..95f9b5f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=halcanary@google.com

Review URL: https://codereview.chromium.org/756423007

Cr-Commit-Position: refs/heads/master@{#307039}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fde5bea..e542608

TBR=schenney@chromium.org,dominicc@chromium.org

Review URL: https://codereview.chromium.org/757943003

Cr-Commit-Position: refs/heads/master@{#307038}