- 20 Mar, 2018 40 commits
-
-
Christian Dullweber authored
In order to delete navigations, recents tabs and session entries, a service needs to listen to history deletions and remove this data when required. Because history deletions can not only be triggered by UI but also by extensions, the listener should be created at startup. Because ChromeBrowsingDataDelegate is not that small and has a few other dependencies, a separate service in browsing_data/ is created. Bug: 407074 Change-Id: If068023967d502ba663473d13ec7844d70e7ca14 Reviewed-on: https://chromium-review.googlesource.com/962762 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#544363}
-
Francois Doray authored
SurfaceTreeHost::UpdateHostWindowBounds() used to call ui::Layer::SetFillsBoundsOpaquely() directly. With this CL, the method is called through aura::Window::SetTransparent(). This is equivalent, except that the |transparent_| bit of the aura::Window, on which aura::WindowOcclusionTracker depends, is also updated. This CL also adds a ScopedPauseOcclusionTracking instance to ensure that occlusion isn't recomputed multiple times during a call to SurfaceTreeHost::UpdateHostWindowBounds(). Bug: 668690 Change-Id: I4f6181d4e247f2a54d96569b3379964c9253246a Reviewed-on: https://chromium-review.googlesource.com/970746Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#544362}
-
Peter Collingbourne authored
Shrinks the apk size by another 12kb. Bug: 742525 Change-Id: I97e889cca1adb52da69490c57094565121d0b52a Reviewed-on: https://chromium-review.googlesource.com/970083 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#544361}
-
Becca Hughes authored
This moves the high MEI bit from Document to Page. BUG=821372 Change-Id: I51ba39c7251a9c511cab29db028e6f6bf7167124 Reviewed-on: https://chromium-review.googlesource.com/964526 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#544360}
-
Robert Flack authored
Bug: 813520 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3f5b734202c69346c4681c11a40ebb58922f7e64 Reviewed-on: https://chromium-review.googlesource.com/969587Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#544359}
-
Elly Fong-Jones authored
These tests assume window closure via views::Widget::Close() is synchronous, which is not guaranteed to be the case. Spinning the runloop allows async window closure to happen properly in these tests, which fixes them for MacViews. Bug: 817408 Change-Id: Ic2d0443283a46573631a628cf57d077514674326 Reviewed-on: https://chromium-review.googlesource.com/970725Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#544358}
-
Sylvain Defresne authored
It is not necessary to disable web usage when clearing off-the-record browsing data (as the WebKit bug is not exercised in that case). Bug: 821753 Change-Id: I62b011ac182f8e8b7107109a23ac8102da44e574 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/970466 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#544357}
-
tzik authored
This adds std::move() around base::Callback instances where it looks relevant, by applying `base_bind_rewriters -rewriter=add_std_move`. https://crrev.com/c/970143, plus manual fixes. Example: // Before: void set_callback(base::Closure cb) { g_cb = cb; } void RunCallback(base::Callback<void(int)> cb) { cb.Run(42); } void Post() { base::Closure task = base::Bind(&Foo); PostTask(FROM_HERE, task); } // After: void set_callback(base::Closure cb) { g_cb = std::move(cb); } void RunCallback(base::Callback<void(int)> cb) { std::move(cb).Run(42); } void Post() { base::Closure task = base::Bind(&Foo); PostTask(FROM_HERE, std::move(task)); } Specifically, it inserts std::move() if: - it's a pass-by-value parameter or non-const local variable. - the occurrence is the latest in its control flow. - no pointer is taken for the variable. - no capturing lambda exists for the variable. Change-Id: I53853f9b9c8604994e2065af66ed4607af9c12ed Reviewed-on: https://chromium-review.googlesource.com/970056Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#544356}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8ac76771..e57b381c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If9be0dc42c638ecf4a79c6b5450c3cd59cad72d6 Reviewed-on: https://chromium-review.googlesource.com/970724Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#544355}
-
Elly Fong-Jones authored
These tests are testing behavior of LocationBarView, which is only used when there is a BrowserView, so testing them with a BrowserWindowCocoa doesn't work. Bug: 817408 Change-Id: Ic0d4f2cd072d4561c0f7df2c881e9df3b65a7354 Reviewed-on: https://chromium-review.googlesource.com/970743Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#544354}
-
Benoit Lize authored
Adds a test for detached requests with cross-origin server-side redirects. Checks that both the initial and the following origin can set cookies. Bug: 816837 Change-Id: I98fd6ac0b617de20dfe2e074ddcbd80bb94e4bb4 Reviewed-on: https://chromium-review.googlesource.com/970643 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
-
Ehsan Chiniforooshan authored
This was accidentally deleted in crrev.com/c/575716. Bug: 797809 Change-Id: I360915247c8fc093beed2426b760ec680cd50ccb Reviewed-on: https://chromium-review.googlesource.com/949977Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#544352}
-
Peter E Conn authored
Digital Asset Link verification consists of two parts, verifying the link from the app to the website and verifying the link from the website to the app. The first part is done client side and a developer can easily satisfy this by putting a line in their app's manifest. The second part is done server side and thus a developer cannot create a link between their app and a locally running web server for development. This CL adds a command line Chrome flag that disables the server-side check allowing developers to use trusted web activity on locally hosted websites. Change-Id: I47a00ec45e5016ef398e876c1b35be680b2284f8 Reviewed-on: https://chromium-review.googlesource.com/883467 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
-
Boris Sazonov authored
This CL extracts ConsentTextTracker from AccountSigninView and implements consent recording in SigninFragmentBase by using ConsentTextTracker. Bug: 814728 Change-Id: I7c699e63bea7a2c61244e72956d4774d46d79556 Reviewed-on: https://chromium-review.googlesource.com/964841Reviewed-by:
-
Elad Alon authored
This is a purely cosmetic change, bring the order of the private methods in line with the public ones. (The order of the public methods was changed by a previous CL that made some of the methods virtual.) Bug: 775415 Change-Id: I978cc34bc1ac6ffa579608030de3ac1343f7eb92 Reviewed-on: https://chromium-review.googlesource.com/966905Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#544349}
-
Vaclav Brozek authored
chrome/android/java/src/PRESUBMIT.py currently contains one test: checking for bad use of Notification.Builder. This CL improves that test in two ways: * It makes it ignore the forbidden pattern in comments. * It adds a test for the presubmit check. Bug: 821981 Change-Id: I5e2e362ed2168e479b446eccdca11e76a95e9e85 Reviewed-on: https://chromium-review.googlesource.com/966626 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/d2c8332e2b03..9047dac7576d $ git log d2c8332e2..9047dac75 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None,chromium:None,chromium:822799,chromium:680172,chromium:None,chromium:755660,chromium:None,chromium:None,chromium:None,chromium:755660 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia063873eca78ba81cec927cf4374423586bb338f Reviewed-on: https://chromium-review.googlesource.com/970723 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544347}
-
Oleh Prypin authored
Add remoting/webapp to prevent possible compile failures that were not detected previously (see https://chromium-review.googlesource.com/969604) And re-add 'all' on Linux and Windows dbg -- the slowdown is OK because these can run in parallel with testers which use release builds Bug: chromium:820041 Change-Id: Ic1c7d5e47748c216bbe43c54c2fa526a16b5dc39 Reviewed-on: https://chromium-review.googlesource.com/970545Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544346}
-
Avi Drissman authored
BUG=730593 Change-Id: I99aba6a46ed01fe3ec3579ee1f6180670f2e6778 Reviewed-on: https://chromium-review.googlesource.com/969109Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#544345}
-
David Bokan authored
This crash was occurring because a local frame is made the effective rootScroller. Then, it is navigated to a cross origin domain and it swaps in a remote frame. The code to handle this for rootScroller would mark the document as needing layout - after which we'll notice the rootScroller is no longer valid and replace it. However, before that happens we might get a resize IPC which executes code in RootScrollerController that assumes an iframe rootScroller is local. The fix here is to just immediately recompute the effective rootScroller when the iframe's FrameView is changed. We also need to notify the RootScrollerController of updates to an iframe's FrameView in more cases. Previously, we would early-out if the iframe wasn't the effective root scroller. This would fail in some situations. e.g. The iframe loses its FrameView which causes us to recalculate and remove it as the effective root scroller. The iframe then gets a new FrameView so we should recalculate again. This CL makes it so we early out only if the iframe isn't the rootScroller or implicit rootScroller. Bug: 805298 Change-Id: Ibf5c46c9fea6016bfa376116dc1f18723fe2c2d1 Reviewed-on: https://chromium-review.googlesource.com/957791Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#544344}
-
David Roger authored
Bug: 714018 TBR: avi Change-Id: I7bdf746f928f0feb6cf08d63a12b506063256430 Reviewed-on: https://chromium-review.googlesource.com/931129Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#544343}
-
Justin Cohen authored
Updates the spacing within each content suggestion cell and the style of the collection view container. Bug: 805638 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3ef8ae27f5f275c48cb9c6ed6c2b9c6ea65e0505 Reviewed-on: https://chromium-review.googlesource.com/962979 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#544342}
-
Gauthier Ambard authored
This CL adds a coordinator for the popup menu. This coordinator is in charge of handling all "showPopupX" events. This coordinator is aimed to replace all the other coordinator currently handling those event, like the toolsMenuCoordinator or the TabHistoryCoordinator and their associated protocols. Bug: 804770, 804771 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib206abed3c22bf64b023b9cd55a7fe11a7372ccd Reviewed-on: https://chromium-review.googlesource.com/962454 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#544341}
-
Gabriel Charette authored
Re-uses existing helpers to make these truly empty impls in non-dcheck builds. Most importantly, this allows instrumenting these calls with extra tracing information when debugging without having to rebuild the world (thread_restrictions.h is implicitly included virtually everywhere). (and yes they should be outright removed in favor of the new ones but that's orthogonal to this CL) R=fdoray@chromium.org Bug: gab doesn't like to rebuild the world when debugging Change-Id: I6f7f39a26164c4375fd9b48233236a528b0fa2b5 Reviewed-on: https://chromium-review.googlesource.com/969446 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#544340}
-
Ashley Enstad authored
Bug: 757933 Change-Id: Iaa6e4d2e254dccef2f6e4a81909b3eefa7f7fd46 Reviewed-on: https://chromium-review.googlesource.com/969954 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#544339}
-
Gauthier Ambard authored
This CL creates the first files used to present the popup menu. The presenter is used to display a view inside a popup, with a scrim on the rest of the screen, preventing interactions. It also creates a flag to enable it, as we don't want to use the general phase 1 flag while the tools menu is not working. For now this presenter is not used anywhere. Bug: 804770 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3015e8aeb063dd948f8bf1cdb8d15667093345ae Reviewed-on: https://chromium-review.googlesource.com/962444Reviewed-by:
-
Mostyn Bramley-Moore authored
Followup to https://chromium-review.googlesource.com/c/chromium/src/+/970242 Bug: 814305 Change-Id: I3e034eb8c1bc093cc6117641c625059f0e208f70 Reviewed-on: https://chromium-review.googlesource.com/970471Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#544337}
-
Finnur Thorarinsson authored
Convert ... const CallBack& callback ... to ... CallBack callback Bug: 734095 Change-Id: I96125e214b5337c78763ba304e8a7135cd42b635 Reviewed-on: https://chromium-review.googlesource.com/964327 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#544336}
-
Adam Rice authored
Prior to this change, response body methods such as response.body.arrayBuffer() would reject with a TypeError if the fetch was aborted. This change makes them correctly reject with an AbortError instead. This implements stage #3 of the "Body Cancellation" section of the design doc: https://docs.google.com/document/d/1OuoCG2uiijbAwbCw9jaS7tHEO0LBO_4gMNio1ox0qlY/edit#heading=h.fvc7d7q07oio Bug: 817687 Change-Id: Ifde322d9c22485a8ba9d14fd4ffca65c4fb4745a Reviewed-on: https://chromium-review.googlesource.com/954765 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#544335}
-
Rayan Kanso authored
The flag ensures that the broadcast receiver for notification taps gets foreground priority upon receiving the broadcast intent. Bug: 868654 Change-Id: Ie45d039a3f0fb74fd40d467828ba2d7bf3e993ee Reviewed-on: https://chromium-review.googlesource.com/968872Reviewed-by:
Anita Woodruff <awdf@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#544334}
-
Alexander Potapenko authored
This reverts commit 380375bf. Reason for revert: MSan reports on buildbots and Clusterfuzz, see https://bugs.chromium.org/p/chromium/issues/detail?id=823654 Original change's description: > Adding a |root_background_color| to RenderFrameMetadata > > Added |root_background_color| to RenderFrameMetadata. Since > |root_background_color| does not change with every frame,it's added > to low frequency fields. > > One use case is added together with this change: > RenderWidgetHostViewAura::SubmitCompositorFrame is used to sniff the > |root_background_color| from the CompositorFrame, after this change, > RWHVA listens to RenderFrameMetadataProvider and updates the background > color when the RenderFrameMetadata changes. > > Bug: 716911 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: I6857d0096fe3662b53410e2a7dc8a1682c0544c5 > Reviewed-on: https://chromium-review.googlesource.com/952303 > Commit-Queue: Yi Xu <yiyix@chromium.org> > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544172} TBR=fsamuel@chromium.org,tsepez@chromium.org,yiyix@chromium.org Change-Id: I5d079dbd1ddc84e4c938a253aa105e68c5b279d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 716911 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/970405Reviewed-by:
Alexander Potapenko <glider@chromium.org> Commit-Queue: Alexander Potapenko <glider@chromium.org> Cr-Commit-Position: refs/heads/master@{#544333}
-
David Roger authored
Tracks the changes in token states for all accounts. Tokens can have three states: Regular (retrieved from Gaia), Invalid (created by Chrome and known to be invalid) or None (no token). Recorded when a token is loaded or changed. Bug: 821863 Change-Id: I4e73978a746315ff81d9bc395b3186f178fe2cca Reviewed-on: https://chromium-review.googlesource.com/964525Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#544332}
-
Olivier Robin authored
Some web sites (like apple.com or llbean.com) build forms after the page loading. This prevent using the server side type resolution. Add a tracker to update the autofill forms regularly. Bug: 798675 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ieaaf502a7bff38756d90bd96e94c058977dcab7b Reviewed-on: https://chromium-review.googlesource.com/943321 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#544331}
-
Koji Ishii authored
This patch rebaselines text-only failures that have matched images, from the following bot result on ToT. https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_layout_tests_layout_ng/4285 Additional rebaselines were found by adjusting the normalization logic: * Text dumps can contain arbitrary strings before the dump. Before this patch, the text must start with "layer at". * Ignore trailing spaces of text runs. * Ignore position of LayoutBR TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I58d22a7af545e15d88b89cf770104feb6ab93d8c Reviewed-on: https://chromium-review.googlesource.com/970621 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#544330}
-
Magnus Jedvert authored
TBR=tommi Bug: None Change-Id: I58f12bcc2deb794f921ad3dd94d527fabe8e7681 Reviewed-on: https://chromium-review.googlesource.com/970462Reviewed-by:
Magnus Jedvert <magjed@chromium.org> Reviewed-by:
-
Mounir Lamouri authored
Fixes a crash when onPlay and onPause were called without a MediaNotificationInfo object available. This should not happen but clients seems to regularly crash because of it. Possibly Android runs the callbacks at moments we are not expecting. Bug: 817051 Change-Id: Ieb06f93a06025386300ee3c7513f530b63c3215d Reviewed-on: https://chromium-review.googlesource.com/955694 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#544328}
-
Ulan Degenbaev authored
The _markDetachedDOMTreeNodes in the worker sets the detachedDOMTreeNode flag if the node is native and its name starts with "Detached " prefix. This patch also ensures that '.highlight' and '.detached-dom-tree-node' CSS styles are not set both at the same time. Bug: 811925 Change-Id: Iee4ee0647abb19a36c1be2f078b4c2915d67cba5 Reviewed-on: https://chromium-review.googlesource.com/964761 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#544327}
-
Hans Wennborg authored
This reverts commit 33f64ee2. After the latest Clang roll, lld will not warn about missing symbols from the order file, so enable the use of order files again. Originally reviewed at https://chromium-review.googlesource.com/955726 TBR=thakis@chromium.org,rnk@chromium.org Bug: 792131, 728324 Change-Id: I6662f40b9b36063eec172728027b82d96a2cd487 Reviewed-on: https://chromium-review.googlesource.com/970421Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#544326}
-
Zhuoyu Qian authored
Since ApplyBlockElementCommand::DoApply() has checked |visible_start| is not null before, and |new_selection|'s base is |visible_start|, so |new_selection| can not be an empty selection and the null check of |new_selection| is redundant, we can remove it. Bug: 689392 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Ic278963f06b05b65a2d1a08532b9a2a78ef530d3 Reviewed-on: https://chromium-review.googlesource.com/967631Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544325}
-
Jochen Eisinger authored
Now that downloads initially look like navigations, we have to allow some navigations from extension views such as popups BUG=821219,823639 R=clamy@chromium.org,rdevlin.cronin@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I2276a5649120a17974bf576791f74e3eac3d4e3a Reviewed-on: https://chromium-review.googlesource.com/960003 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544324}
-
