- 03 Dec, 2018 40 commits
-
-
Camillo Bruni authored
This CL adds the following trace events in the blink category: - PendingScript::ExecuteScriptBlock - ScriptRunner::ExecuteInOrderTask - ScriptRunner::ExecuteAsyncTask - ClassicPendingScript::GetSource Bug: 865098 Change-Id: I4b8af61283bd97b0ab1d9e0b74fc0f08ce7a2293 Reviewed-on: https://chromium-review.googlesource.com/c/1356545 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#613047}
-
Hiroki Nakagawa authored
Public mojom files for dedicated workers and shared workers should be placed in public/mojom/worker. Bug: 906991 Change-Id: I570f91823247349609afb3ce0ba62880ba14cf27 Reviewed-on: https://chromium-review.googlesource.com/c/1358291 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#613046}
-
Gauthier Ambard authored
This CL changes how the broadcasted value of toolbar height is done. The value is now broadcasted when the view will become visible instead of when it did become visible. Using this, the toolbar insets are updated when the view will become visible, allowing a smoother animation when the screen has been rotated in background. Bug: 908796 Change-Id: I49e42fa9246ff76fc702243a3f6571cb81ab912c Reviewed-on: https://chromium-review.googlesource.com/c/1356588Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#613045}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8b07e43dadf8..9ca9435087e0 git log 8b07e43dadf8..9ca9435087e0 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 cwallez@chromium.org Rename BindGroupBinding -> BindGroupLayoutBinding Created with: gclient setdep -r src/third_party/dawn@9ca9435087e0 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Id6ebb7e953dfdcd3f811c33ac338abf62ae6bcd2 Reviewed-on: https://chromium-review.googlesource.com/c/1358207Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613044}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0b287c5bcafd..96fdf7cbe6ed git log 0b287c5bcafd..96fdf7cbe6ed --date=short --no-merges --format='%ad %ae %s' 2018-12-03 tikuta@chromium.org [ninja] collect build configs Created with: gclient setdep -r src/third_party/depot_tools@96fdf7cbe6ed The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:900161 TBR=agable@chromium.org Change-Id: I535fbd510142cb5dc9c1811614b248986b533c7f Reviewed-on: https://chromium-review.googlesource.com/c/1358204Reviewed-by:
-
Tanja Gornak authored
This patch introduces the new API, which allows to enable/disable the invalidations for noisy session sync related datatypes. The session sync generates a lot of changes, which results into many invalidations, which should be processed. This can negatively affect the battery life on Android. For that reason, on Android, the invalidations for the Sessions should be received only when user is interested in session sync data, e.g. the history sync page is opened. Bug: 909682 Change-Id: I3e875543a8aa17c7b374fb8d963a3dd19e8deccc Reviewed-on: https://chromium-review.googlesource.com/c/1353933 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#613042}
-
Guido Urdaneta authored
This reverts commit be3c24b4. Reason for revert: FindIt has detected it as culprit for at least two tests that started flaking. The FindIt analysis looks correct, but please take a look at the bugs and reland if you think this should reland. See crbug.com/910997 and crbug.com/910921 Original change's description: > Reland "Reland "Start gpu channel and compositor mojo pipe collection eagerly"" > > This is a reland of eacb6ed3 > > The flaky test has been disabled. > > TBR=piman > > Original change's description: > > Reland "Start gpu channel and compositor mojo pipe collection eagerly" > > > > This is a reland of 66794d00 > > > > In this reland we revert changes to RenderThreadImpl and mus to make > > LayerTreeFrameSink creation asynchronous again. > > > > Then in RenderWidget we must remember that a warmup is underway, we do > > so with a bool and a WeakPtrFactory. If it is aborted, we reset the bool > > and invalidate the WeakPtrFactory. > > > > If a request for a frame sink beats the warmup completing, we save > > the callback and run that instead of saving the frame sink on > > RenderWidget when the warmup completes. > > > > This ignores some weird weird corner cases like where warmup is > > aborted then we start another warmup or unfreeze the widget or something > > and will just make redundant requests. Since these are so rare they > > are not worth adding complexity for. > > > > Original change's description: > > > Start gpu channel and compositor mojo pipe collection eagerly > > > > > > When a RenderWidget is frozen, its compositor is stopped. However when > > > the main frame is being navigated, we want to start requesting mojo > > > pipes for the gpu and display compositor immediately so that it can > > > happen in parallel with the navigation loading. > > > > > > Previously, we just always did this when creating a RenderWidget, and > > > left them active when freezing the RenderWidget. After 678f025f > > > however, we don't, and this causes time-to-first-pixels regressions > > > on navigation. > > > > > > So we add a WarmupCompositor() method to RenderWidget, and call this > > > from RenderFrameImpl::CreateFrame() when it makes the provisional > > > frame, and the WebFrameWidget, since we expect to make use of the > > > main frame RenderWidget shortly. > > > > > > Then, if RenderFrameImpl::FrameDetached() occurs, due to the > > > navigation failing, we will AbortWarmupCompositor() to drop the > > > mojo pipes instead of holding onto them indefinitely. > > > > > > This recovers the loading regressions introduced, while also not > > > allocating mojo channels for frozen RenderWidgets indefinitely. > > > > > > In order to do this reasonably, we drop the "callback" from the > > > request to RenderThreadImpl::RequestNewLayerTreeFrameSink so that > > > it always returns something immediately. This way RenderWidget > > > does not need to worry about having a task run to collect the > > > new frame sink, and ordering with tasks from the compositor to > > > collect it. > > > > > > R=piman@chromium.org > > > > > > Change-Id: I6007e26e1622006652ce3619cdd080539d11e7b0 > > > Bug: 905191 > > > Reviewed-on: https://chromium-review.googlesource.com/c/1341073 > > > Commit-Queue: danakj <danakj@chromium.org> > > > Reviewed-by: danakj <danakj@chromium.org> > > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > > Reviewed-by: Antoine Labour <piman@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#610909} > > > > Bug: 905191 > > Change-Id: I6cb65e08a832a969156b96bece0f2e12eccd5b60 > > Reviewed-on: https://chromium-review.googlesource.com/c/1351938 > > Commit-Queue: danakj <danakj@chromium.org> > > Reviewed-by: danakj <danakj@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Antoine Labour <piman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#611838} > > Bug: 905191 > Change-Id: I0320c8604d50d5d83157c058c230b471c0898b26 > Reviewed-on: https://chromium-review.googlesource.com/c/1355321 > Reviewed-by: danakj <danakj@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612253} TBR=danakj@chromium.org,dcheng@chromium.org,sergeyu@chromium.org,piman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 905191 Change-Id: Ibf041a7a02c80df0f0f4a1a02803846fa443c40a Reviewed-on: https://chromium-review.googlesource.com/c/1356810Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#613041}
-
Friedrich Horschig authored
This CL moves the transformation of AccessorySheetTab data to KeyboardAccessoryData.Items from the ManualFillingBridge into the PasswordsAccessorySheetMediator. This enables replacing the Items in a follow-up CL completely and use the AccessorySheetTab to implement the new layout for the passwords. This is a step towards generalization of accessory sheet tabs as new tab will be able to add separate element types with respective views. Bug: 853772 Change-Id: I678d453245568ef006de932274db044b14ffbdfa Reviewed-on: https://chromium-review.googlesource.com/c/1350890Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#613040}
-
Guido Urdaneta authored
This reverts commit ff451c7b. Reason for revert: Suspect of causing consistent failure of xr_browser_tests on Win10 Debug (NVIDIA) bot. See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Debug%20%28NVIDIA%29 First failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Debug%20%28NVIDIA%29/10962 Original change's description: > Enforce active lifetime of XRFrame objects > > Deactivates XRFrame objects once the relevant callback returns, which > causes future calls to the object methods to throw an exception. > > Bug: 906842 > Change-Id: I192453f9f23b1b4d9a404daca352ab80a5393753 > Reviewed-on: https://chromium-review.googlesource.com/c/1343065 > Commit-Queue: Brandon Jones <bajones@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612887} TBR=bajones@chromium.org,klausw@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 906842 Change-Id: I26eb3477ea875362a5f1e6fd0b67bbe4a3c2c4a5 Reviewed-on: https://chromium-review.googlesource.com/c/1356945Reviewed-by:
-
Hiroki Nakagawa authored
This makes worker_main_script_load_params.mojom in the directory reusable for PlzDedicatedWorker. Bug: 906991 Change-Id: I5a5768bab54f7fa76c758afbfcc1f3bd22928385 Reviewed-on: https://chromium-review.googlesource.com/c/1358197Reviewed-by:
-
Adam Rice authored
Set the status of the "TransferableStreams" feature to "experimental". This means that it is enabled by default for layout tests, and behind the "experimental web platform features" in the browser. Remove the virtual test suite for the feature. BUG=894838 Change-Id: I0b1efdbbcaf08448e7578eea2ef859cea1930cbc Reviewed-on: https://chromium-review.googlesource.com/c/1355299 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#613037}
-
Manuel Rego Casasnovas authored
This optimization was introduced in r578233, but with the test included in this patch it was causing a crash. The problem is that the RootInlineBox has more than one children which is not expected. In that case we shouldn't apply the optimization, so a new condition has been added in LayoutText::CanOptimizeSetText() to avoid it. BUG=805785 TEST=fast/css/containment/change-text-node-data-crash.html Change-Id: I924f30f4d0e0ae3e40f2437b54e5323a81a40051 Reviewed-on: https://chromium-review.googlesource.com/c/1356590Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#613036}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I85b84b92eb544b02920139aad88a4fb9a31d830f Reviewed-on: https://chromium-review.googlesource.com/c/1352418Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#613035}
-
Eric Seckler authored
Enables the developer options on <= Dev builds by default and adds a way to activate them on Beta/Stable channels via 7 taps on the chrome version in the preferences, in android-like style. Bug: 898512 Change-Id: Ife44df843e45d660485fb464209964c957a9c887 Reviewed-on: https://chromium-review.googlesource.com/c/1349309 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#613034}
-
Morten Stenshorne authored
Do in LogicalHeightForRow() as in CalcRowLogicalHeight() - i.e. round instead of floor, to convert from LayoutUnit to int. We calculated the pagination strut incorrectly for the line that followed, because it was based on the floored LayoutUnit height of the preceding table row. Then, later on, it got adjusted (rounded from LayoutUnit), and the balancing code got confused, because the line had a pagination strut, but didn't appear to be exactly at the start of a column (there should be no strut in such a case). Bug: 908247 Change-Id: I11fa5430b9ff6e83b20dc25ce1d945e54b80f6ea Reviewed-on: https://chromium-review.googlesource.com/c/1356551 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
With the work for unified ComputedStyle storage on element, found that we are accessing the LayoutObject from the old layout tree when the viewport defining element changes and body is marked for re-attach. TEST=external/wpt/cssom-view/scrollingElement-* Change-Id: I5b8d8f8291d05d058af61779992c24381f3edba0 Reviewed-on: https://chromium-review.googlesource.com/c/1356479 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#613032}
-
Dominick Ng authored
This CL allows ARC to inform ArcAppListPrefs whether a newly installed package is a web app or not. If it is a web app, ArcAppListPrefs requests the web app's data from ARC, and upon receiving the data, triggers an installation of the web app. BUG=893927 Change-Id: Ia88043ef1d01f709e82340326e81de01da6c1c4c Reviewed-on: https://chromium-review.googlesource.com/c/1314068Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#613031}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b673480e9ca4..b501f25a2ef8 Created with: gclient setdep -r src-internal@b501f25a2ef8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia940a0f092b4abc0e0176241c505bdf65a4cf48d Reviewed-on: https://chromium-review.googlesource.com/c/1358203Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613030}
-
Martin Robinson authored
Stop printing a bogus integer version of the id attribute for nodes. We are already printing the string version of this attribute when it is assigned, so removing this code should just make the output less noisy. Bug: 909620 Change-Id: I0b2f08c99ae5e52a14483f27292c5aacd7e5eace Reviewed-on: https://chromium-review.googlesource.com/c/1352362Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#613029}
-
Mikel Astiz authored
This is a reland of a61d2bb4 The flaky test has been excluded from this patch, will be reintroduced in a separate patch. Original change's description: > Reland "Avoid recycling sync tabs if commit pending" > > This is a reland of 62414cfc > > Test improved to avoid flakes. > > Original change's description: > > Avoid recycling sync tabs if commit pending > > > > When a tab is closed, it's possible that the corresponding history > > hasn't been committed yet, and hence there is a risk that synced history > > is lost if the entity is recycled (for another tab that is opened). > > > > In this patch, and behind a feature toggle, this issue is prevented by > > *not* freeing tab nodes while the sync entity is unsynced. Old tabs are > > excluded from this (to avoid problems with expired history) and a max > > cap is also introduced to the number of tabs in this state, in order to > > avoid memory regressions. > > > > Bug: 882489 > > Change-Id: I6dd796642f9553f2713a0814731897a4ffb13f0b > > Reviewed-on: https://chromium-review.googlesource.com/c/1356541 > > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > > Reviewed-by: Marc Treib <treib@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#612971} > > TBR=treib@chromium.org > > Bug: 882489 > Change-Id: Ib3f3ff9e4d620512435d9b22ba7b2c338f92203f > Reviewed-on: https://chromium-review.googlesource.com/c/1357086 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612980} TBR=treib@chromium.org Bug: 882489 Change-Id: Iaa6490f896257baa8a843ca0e7c92f2d7dc11c8c Reviewed-on: https://chromium-review.googlesource.com/c/1356808Reviewed-by:
-
Kent Tamura authored
for "Web Test". The following classes are not renamed in order to avoid to loose blame information though their file names are renamed. - content::LayoutTestBluetoothFakeAdapterSetterImpl - content::LayoutTestBrowserMainParts - content::MojoLayoutTestHelper They are going to be renamed in a following CL. This CL has no behavior changes. Bug: 84341 Change-Id: I86aae05921379bb9d87af65d2203086ee57ee7d6 Reviewed-on: https://chromium-review.googlesource.com/c/1351327Reviewed-by:
-
Yuichiro Hanada authored
Bug: 910240 Test: unit_tests --gtest_filter=*ArcInput* --enable-features=SingleProcessMash Change-Id: I1e836b6743026c901f1f328d96213d2a3eeb3c24 Reviewed-on: https://chromium-review.googlesource.com/c/1358292Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#613026}
-
Mike Dougherty authored
This macro is a no-op and can can be safely removed. Bug: 589840 Change-Id: If00faba34a0f10a3353bc2086329b1ba0c1a0901 Reviewed-on: https://chromium-review.googlesource.com/c/1355768Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#613025}
-
Noel Gordon authored
- remove actions_model_unittest.html - add BUILD rules to auto-generate and compile this unittest - make mock_drive_sync_handler visible to foreground unittests - Add Closure @type defines to unittest variables (OMG). - fix Closure compile errors Bug: 911005 Change-Id: Ia29ca0e11ee984f00daf66271ff65e5fcb52b1c7 Reviewed-on: https://chromium-review.googlesource.com/c/1356732 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#613024}
-
Simon Que authored
We have verified that the RBE-based builder is comparable in compile time versus the class Goma builders. Bug: 855319 Change-Id: Iacb8baea7291d82a09a839db4c72820482096af5 Reviewed-on: https://chromium-review.googlesource.com/c/1358113Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#613023}
-
Matt Falkenhagen authored
Undo a removal from r612849. WindowClient#visibilityState refers to the web-exposed IDL attribute and is still relevant, even though the mojom field name changed. Also, change the order of the mojom fields to match the IDL attribute order in the specification. Change-Id: I445b82c368ac5e22e9bca4e8c22d3c7b1878eedb Reviewed-on: https://chromium-review.googlesource.com/c/1358115Reviewed-by:
-
Kent Tamura authored
This is a preparation to support validation in form-associated custom elements. This CL has no behavior changes. This CL also does: - Rename SetNeedsWillValidateCheck() to UpdateWillValidateCache() to match to the reality - Change a checkValidity() argument from |HeapVector<Member< HTMLFormControlElement>>| to |HeapVector<Member<ListedElement>>|, which is typedefed as |ListedElement::List| Bug: 905922 Bug: https://github.com/w3c/webcomponents/issues/187 Change-Id: I0a97ae7eb85406eb0160c9bffa0568440c554a7e Reviewed-on: https://chromium-review.googlesource.com/c/1358116 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#613021}
-
Pavel Feldman authored
This reverts commit 41f9647f. Reason for revert: applying fix. Original change's description: > Revert "DevTools: allow showing views above and below the Sources sidebar." > > This reverts commit d21d2ed3. > > Reason for revert: Causing devtools_eslint failure > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8928389307771200912/+/steps/devtools_eslint/0/stdout > > Original change's description: > > DevTools: allow showing views above and below the Sources sidebar. > > > > Change-Id: I76a8edbc45bd6e2d775b48c8f93e288d82bed817 > > Reviewed-on: https://chromium-review.googlesource.com/c/1357513 > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > Commit-Queue: Pavel Feldman <pfeldman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#612830} > > TBR=dgozman@chromium.org,pfeldman@chromium.org,kozy@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: I58fd8fab81766fee2aca0747a78f4ac61647f7cf > Reviewed-on: https://chromium-review.googlesource.com/c/1358118 > Reviewed-by: calamity <calamity@chromium.org> > Commit-Queue: calamity <calamity@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613013} TBR=dgozman@chromium.org Change-Id: I0e4cd1fe9585f7ccd365cc449ca0429e0b031141 Reviewed-on: https://chromium-review.googlesource.com/c/1358045 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#613020}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/876ca4326d7d..b673480e9ca4 Created with: gclient setdep -r src-internal@b673480e9ca4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic6686102ace4271ba1a0d938420256d50009dc75 Reviewed-on: https://chromium-review.googlesource.com/c/1358200Reviewed-by:
-
Matt Falkenhagen authored
Previously, ResourceResponse had Url() and OriginalUrlViaServiceWorker(), but it was not an obvious API. Namely, the API drives people to use Url() and unless you read the comment above it you aren't aware of the potential security bug. This CL changes the API to have CurrentRequestUrl() and ResponseUrl(). Both functions have potentially surprising behavior, so the API takes a more neutral surface and people must choose one or the other after reading the comments. The CL itself does not cause behavior changes. It's fairly mechanical. Callsites are updated such that: - Url() becomes CurrentRequestUrl() - OriginalUrlViaServiceWorker() becomes something like WasFetchedViaServiceWorker() ? ResponseUrl() : KURL() Future work is to: - Update WebURLResponse similarly - [https://crbug.com/553535] Make behavior changes by updating callsites to use the repsonse URL when appropriate (yhirano started an audit on the codereview) Change-Id: Ia608a53bcf2674f1943f09da9be1bdb5fc7eba34 Bug: 435446 Reviewed-on: https://chromium-review.googlesource.com/c/1356464Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#613018}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I236fec691de04d3013d02ac4d699757e111304fe Reviewed-on: https://chromium-review.googlesource.com/c/1358201Reviewed-by:
-
Noel Gordon authored
- remove navigation_list_model_unittest.html - add BUILD rules to auto-generate and compile this unittest - fix MockFolderShortcutDataModel BUILD rule - MockFolderShortcutDataModel depends on ui:array_data_model - fix FolderShortcutsDataModel BUILD rule - FolderShortcutsDataModel depends on cr:event_target - add prefix comments to all test cases - test cases should describe their intent - fix Closure compile errors Bug: 910991 Change-Id: I8ba2ad3e917473b83011871d94cf17b80ad64d31 Reviewed-on: https://chromium-review.googlesource.com/c/1356731 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Renee Wright authored
When crostini is disallowed by hardware, Chrome flags, etc, we do not want to show the Linux row in Chrome Settings. If it is not disallowed by these factors but it is enforced off by the enterprise policy then we want to show the Linux row, but disable the "turn on" button and show a policy indicator icon in the row. This change implements that behavior. Change-Id: I8d4367a3e9e732e308ae166855dc91ac1d8ef52b Reviewed-on: https://chromium-review.googlesource.com/c/1322338Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#613015}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id1cf3721127a14a203c57b5c806fa03fd23e886b Reviewed-on: https://chromium-review.googlesource.com/c/1358123Reviewed-by:
-
calamity authored
This reverts commit d21d2ed3. Reason for revert: Causing devtools_eslint failure https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8928389307771200912/+/steps/devtools_eslint/0/stdout Original change's description: > DevTools: allow showing views above and below the Sources sidebar. > > Change-Id: I76a8edbc45bd6e2d775b48c8f93e288d82bed817 > Reviewed-on: https://chromium-review.googlesource.com/c/1357513 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612830} TBR=dgozman@chromium.org,pfeldman@chromium.org,kozy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I58fd8fab81766fee2aca0747a78f4ac61647f7cf Reviewed-on: https://chromium-review.googlesource.com/c/1358118Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#613013}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f83a6296366..876ca4326d7d Created with: gclient setdep -r src-internal@876ca4326d7d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6043e8fa10de79306ad888c5f3144655f73c3b0b Reviewed-on: https://chromium-review.googlesource.com/c/1358082Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 12246 12248 12253 12254 12259 12266 12269 12276 12281 12288 12290 12292 12298 12301 12319 12332 12334 12335 12336 12340 0 lines were removed and 17 lines were deflaked by consecutive results since 12281. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I0efc7329ca04fb946eb78acacd0d26110cdf7a5d Reviewed-on: https://chromium-review.googlesource.com/c/1354728 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Dean Liao authored
IsStorageTypeMappable() was defined and used in video_frame.cc only. Export it as VideoFrame::IsStorageTypeMappable() to use in other places. BUG=None TEST=Pass CQ. Change-Id: Ib3bcf5291e64464c8a75f0e9c5fe2f4c62b179d5 Reviewed-on: https://chromium-review.googlesource.com/c/1356459Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Cr-Commit-Position: refs/heads/master@{#613010}
-
Maggie Cai authored
When dragging a multi-selection of bookmarks in the manager, the order of the selected bookmarks became the order of the selection instead of their original displaying order. This CL updates the order of dragged nodes to the displaying order. BUG=794886 Change-Id: I4ab3ead0454874eee9e7dc49522156aba27f10d4 Reviewed-on: https://chromium-review.googlesource.com/c/1349130Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#613009}
-
Matt Falkenhagen authored
The comments talks of MakeGarbageCollected, but this was meant to refer to `new Response()` in JavaScript. Also quote the relevant specification step. Change-Id: Ib9d545bd610b30d1ce04e6433355053165afd7b9 Reviewed-on: https://chromium-review.googlesource.com/c/1358108Reviewed-by:
-
