- 14 Dec, 2016 40 commits
-
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/7a1cc6766d07..e305cc1f2a44 $ git log 7a1cc6766..e305cc1f2 --date=short --no-merges --format='%ad %ae %s' 2016-12-14 robertphillips Partially defer GrSWMaskHelper 2016-12-14 scroggo Remove SkKTXImageEncoder 2016-12-14 fmalita SK_API-export SkCodec 2016-12-08 scroggo Add SkCodec::FrameInfo::fFullyReceived 2016-12-14 reed remove PLAIN_ENUM flag for SkClipOp 2016-12-14 reed add tests/bench for dynamicwstream Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=msarett@google.com Review-Url: https://codereview.chromium.org/2574323003 Cr-Commit-Position: refs/heads/master@{#438613}
-
zmo authored
BUG=664488 TEST=content_unittests,gpu is enabled in win/NVidia R=kbr@chromium.org,kkinnunen@nvidia.com Review-Url: https://codereview.chromium.org/2569413002 Cr-Commit-Position: refs/heads/master@{#438612}
-
dgozman authored
Attempt #2. Previous one had missing SetRenderFrameHost call. BUG=664683 TBR=pfeldman Review-Url: https://codereview.chromium.org/2572933002 Cr-Commit-Position: refs/heads/master@{#438611}
-
thakis authored
No intended behavior change. BUG= Review-Url: https://codereview.chromium.org/2569013003 Cr-Commit-Position: refs/heads/master@{#438610}
-
paulmeyer authored
This is done by storing the source RenderViewHost and RenderProcessHost for each dragstart. Then, for other drag events (like dragover), if the target frame for that event is in the same RenderViewHost, but different RenderProcessHost, than the source, then the event is not fired. Note that this patch will not affect behavior on Mac, and a subsequent CL will enforce the same thing for Mac. BUG=666858 Review-Url: https://codereview.chromium.org/2568893002 Cr-Commit-Position: refs/heads/master@{#438609}
-
schenney authored
These 3 tests are flaky when run in random order or even alone. As a first step in improving them, modify the tests to get away from setTimeout and to verify that the pauseAnimationAPI is working. This is unlikely to resolve the flakiness, but it will help narrow the cause. R=chrishtr BUG=653722 Review-Url: https://codereview.chromium.org/2569063002 Cr-Commit-Position: refs/heads/master@{#438608}
-
rohitrao authored
BUG=663349 Review-Url: https://codereview.chromium.org/2568003005 Cr-Commit-Position: refs/heads/master@{#438607}
-
chrome://accessibilitydmazzoni authored
Replaces links that toggled a single accessibility mode with a set of checkboxes representing more fine-grained control over accessibility support. Adds some more help text to the UI to explain to users what this is for. There's more to be done but I don't want to completely overhaul the UI in this change, I'd like to just make a good incremental step and most importantly add support for all of the possible accessibility modes. Depends on: https://codereview.chromium.org/2558933002/ BUG=672205 Review-Url: https://codereview.chromium.org/2552203005 Cr-Commit-Position: refs/heads/master@{#438606}
-
jwd authored
BUG=672950 Review-Url: https://codereview.chromium.org/2575823003 Cr-Commit-Position: refs/heads/master@{#438605}
-
chfremer authored
[Mojo Video Capture] Decouple VideoCaptureController from VideoCaptureBufferPool and VideoCaptureDeviceClient Decouple VideoCaptureController from VideoCaptureBufferPool and VideoCaptureDeviceClient. This is needed in order to prepare VideoCaptureController for working with both the (legacy) in-process video capture and the new video_capture Mojo service. List of changes: * Introduce an abstraction FrameBufferHost for the VideoCaptureController to talk to the VideoCaptureBufferPool. * Move VideoFrameReceiverOnIOThread to separate file. * Move factory logic for creating and connecting VideoCaptureBufferPoolImpl and VideoCaptureDeviceClient out of VideoCaptureController and into VideoCaptureManager as well as the tests. * Update OWNERS to include new file and include chfremer as owner. * In VideoCaptureDeviceClient: Rename |frame_format| to |foramt|. This CL is part of the Mojo Video Capture work. For the bigger picture, see [1] CL1.9.8 BUG=584797 TEST= content_unittests, video_capture_unittests, Apprtc loopback on Debug, Desktop Capture Example extension on Release [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing Review-Url: https://codereview.chromium.org/2551193002 Cr-Commit-Position: refs/heads/master@{#438604}
-
pbos authored
BUG=chromium:653531 R=esprehn@chromium.org, mcasas@chromium.org Review-Url: https://codereview.chromium.org/2578623002 Cr-Commit-Position: refs/heads/master@{#438603}
-
zea authored
Reason for revert: crashing on android, spike in datatype errors across platforms. See crbug.com/673618 Reland of [Sync] Put session tracker in charge of maintaining local state. Previously, the session tracker was only updated when local tabs were available in the TabModel. It was not updated with sync data from a previous session (and as a result, we had to pass around the restored_data list at association time in order to handle restoring placeholder tabs). The session tracker now gets updated at startup of previous local state, which is then used when reassociating restored tabs. This is a purely refactoring change that should not introduce user visible changes (although internally the data is managed in a different way). To make this happen, InitFromSyncModel now treats local tabs and remote tabs the same. In addition, the SyncedSessionTracker now has a ReassociateTab method that can be called to update the tab id of a SessionTab. To make this work, the TabNodePool has been moved into the SyncedSessionTracker, and in general data ownership has been simplified (with quite a few new tests added). This is all necessary in order to enable preserving tabs from a previous session when they're not present in the TabModel (which can happen on Android when a custom tab is opened, but the main tabbed activity is not loaded). BUG=639009, 673618 Committed: https://crrev.com/159246f269b561bf931fa56a35b2704fab7dcc96 Cr-Commit-Position: refs/heads/master@{#436786} TBR=skym@chromium.org Review-Url: https://codereview.chromium.org/2575773003 Cr-Commit-Position: refs/heads/master@{#438602}
-
lunalu authored
https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7 create*() methods, fenceSync() method, and getTransformFeedbackVarying() method cause no change in generated files BUG=662005 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2568743009 Cr-Commit-Position: refs/heads/master@{#438601}
-
dfalcantara authored
* Clicking on an in-progress or paused download now sends the user to Download Home instead of doing nothing. This uses the existing Intent broadcasting mechanism, using a lack of download IDs in the Intent as a signal that Download Home should be opened instead. * Unifies the DownloadBroadCastReceiver and DownloadManagerService pathways for opening a download. This also fixes an assert that called a method on the UI thread instead of in the background. * Failing to open a download now sends the user to Download Home instead of silently failing. * Cleans up some code in DownloadNotificationService. * Prevents showing unresumable files in Download Home. This happens if the user tries to download a file that is "interrupted" when a file doesn't exist (e.g.). * Disallow long pressing on an incomplete file in Download Home. BUG=658246,658742 Review-Url: https://codereview.chromium.org/2571623002 Cr-Commit-Position: refs/heads/master@{#438600}
-
zmin authored
BUG=630181 Review-Url: https://codereview.chromium.org/2573533003 Cr-Commit-Position: refs/heads/master@{#438599}
-
khorimoto authored
BUG=672263 Review-Url: https://codereview.chromium.org/2570383002 Cr-Commit-Position: refs/heads/master@{#438598}
-
pilgrim authored
As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. This CL replaces append() with push_back() in Source/core/editing/. There are too many references to change them all at once, so this CL is part 5 of many. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2571953004 Cr-Commit-Position: refs/heads/master@{#438597}
-
dalecurtis authored
We should not be trying to expire frames during the normal rendering process. This corrects a conditional which was incorrectly allowing this behavior and fixes the test which were relying on this behavior. Testing the inverse (i.e. what was broken) is not in this CL, since I ran out of time to add it for now. Notably, I wasn't able to reproduce any issues arising from this mistake. In practice, Render() occurs with such frequency that it's rare for FrameReady() to occur fast enough to out pace it in a meaningful manner relative to the frame duration. BUG=667704 TEST=updated unittests. Review-Url: https://codereview.chromium.org/2570013003 Cr-Commit-Position: refs/heads/master@{#438596}
-
thakis authored
Without this, the test seems to fail after clang roll https://codereview.chromium.org/2577523002 Since there's already a workaround, this is likely triggering the same existing bug that already has a workaround, and not due to a new compiler bug. BUG=673463,674194 TBR=tkent Review-Url: https://codereview.chromium.org/2569763006 Cr-Commit-Position: refs/heads/master@{#438595}
-
isandrk authored
In Public Sessions, extensions (and apps) are force-installed by admin policy so the user does not get a chance to review the permissions for these extensions. This is not acceptable from a security/privacy standpoint, so when an extension uses the TabCapture API for the first time, we show the user a dialog where they can choose whether to allow the extension access to the API. This CL will also whitelist desktopCapture manifest permission feature as it's already safe in its current form (user is prompted) together with tabCapture. BUG=672093 Review-Url: https://codereview.chromium.org/2558843002 Cr-Commit-Position: refs/heads/master@{#438594}
-
davidben authored
BUG=673058 Review-Url: https://codereview.chromium.org/2577683002 Cr-Commit-Position: refs/heads/master@{#438593}
-
xdai authored
Today, even if domain admins set a wallpaper policy, every device shows up with the branding of the OEM until a user logs into the device (and then the user wallpaper policy kicks in). We introduce a new device policy in this CL for domain admins to set a device level policy rather than a user level policy for setting a wallpaper. That way the wallpaper will change after being enrolled to the domain without requiring users to log in. This only impacts the startscreen wallpaper, if the domain admin has set a different wallpaper in the user policy or has allowed the users to select their own wallpaper, that one will be displayed within a session. Note this CL only introduces the policy, the implementation to reflect the policy is addressed in another CL: https://codereview.chromium.org/2572793003/. BUG=475998 Review-Url: https://codereview.chromium.org/2544693002 Cr-Commit-Position: refs/heads/master@{#438592}
-
jrummell authored
Since the close() operation is asynchronous, there is a window where close() can be called a second time before the session is actually closed. Changes allow the second close() to succeed if it is called while the first close() is being processed. BUG=668312 TEST=new test passes Review-Url: https://codereview.chromium.org/2545083004 Cr-Commit-Position: refs/heads/master@{#438591}
-
estark authored
This CL adds an UMA histogram recording the delta between each timestamp received via a secure time service query and the previous one. This should give us an idea of how often users in various experimental groups make secure time queries. BUG=589700 Review-Url: https://codereview.chromium.org/2565173006 Cr-Commit-Position: refs/heads/master@{#438590}
-
eugenebut authored
webViewContainingBlockedImage will be used in various SSL tests and passing image_size to every call is unnecessary and simply clutters the tests. BUG=673520 Review-Url: https://codereview.chromium.org/2569103002 Cr-Commit-Position: refs/heads/master@{#438589}
-
rdevlin.cronin authored
Add the ability to register a custom hook from JS. This is the next step towards being able to use our many, many custom_bindings.js files for existing APIs. Add a test for the same. BUG=653596 Review-Url: https://codereview.chromium.org/2563093002 Cr-Commit-Position: refs/heads/master@{#438588}
-
mthiesse authored
Also fixes some missed nits in https://codereview.chromium.org/2562733002/ BUG=671302 Review-Url: https://codereview.chromium.org/2571713006 Cr-Commit-Position: refs/heads/master@{#438587}
-
jbudorick authored
Revert of Disable flaky test org.chromium.chrome.browser.webapps.WebApkUpdateManagerTest#testCanonicalUrlsDif… (patchset #1 id:1 of https://codereview.chromium.org/2571773002/ ) Reason for revert: reenabling, see bug Original issue's description: > Disable flaky test org.chromium.chrome.browser.webapps.WebApkUpdateManagerTest#testCanonicalUrlsDifferentShouldUpgrade. > > TBR=miguelg@chromium.org > > BUG=673385 > > Committed: https://crrev.com/44ff0871ca857e221a227306f7c256bf5e66659a > Cr-Commit-Position: refs/heads/master@{#438120} TBR=miguelg@chromium.org,grunell@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=673385 Review-Url: https://codereview.chromium.org/2574583004 Cr-Commit-Position: refs/heads/master@{#438586}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1d6a302d..3ca06164 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2575833002 Cr-Commit-Position: refs/heads/master@{#438585}
-
engedy authored
The Safe Browsing Subresource Filter used to reactivate in response to same-page navigations, which resulted in spurious histogram samples being recorded. In some edge cases, a same-page navigation in the main-frame also resulted in no activation in subsequently created child frames. This CL makes sure that the logic on both browser and renderer sides is agnostic of in-page navigations. BUG=637415 Review-Url: https://codereview.chromium.org/2574193002 Cr-Commit-Position: refs/heads/master@{#438584}
-
lukasza authored
Waiting until mousemove DOM event is received is important, because otherwise (because of lag introduced by forwarding events between renderers) button-less mousemove event can arrive at the target frame *after* mousedown event (confusing the renderer whether mouse button is held down or not and therefore preventing dragstart from happening). This CL seems to fix the flakiness that used to be locally reproducible with --site-per-process. Right now we consistently pass 20 repetitions of CrossSiteSubframe/DragAndDropBrowserTest.DragImageBetweenFrames/0. BUG=671445 Review-Url: https://codereview.chromium.org/2577553002 Cr-Commit-Position: refs/heads/master@{#438583}
-
xianglu authored
service. Remove |FaceDetectorOptions| from FaceDetection mojo interface so Blink doesn't need to send it every time detect() is called. BUG=646083 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2564163003 Cr-Commit-Position: refs/heads/master@{#438582}
-
cwallez authored
BUG=chromium:602688 BUG=chromium:665518 BUG=angleproject:1523 BUG=angleproject:1635 BUG=angleproject:1639 TBR=zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2577723002 Cr-Commit-Position: refs/heads/master@{#438581}
-
bnc authored
Make boilerplate.py add newline to the end of generated .cc and .mm files. Review-Url: https://codereview.chromium.org/2570193003 Cr-Commit-Position: refs/heads/master@{#438580}
-
lukasza authored
The rename is needed to avoid a naming collision after changing from Blink to Chromium naming style. Right now we have an |OnError| type and an |onError| virtual method (differing by case of the first character); after a naive rename by the rewrite_to_chrome_style tool we would end up with |OnError| being the name of both the type and the method (with both living in the same namespace). Similar situation happens for onSuccess / OnSuccess names. Changing the type name is a workaround that fits into the guidance on the recommended post-Blink-to-Chromium-rename style suggested by esprehn@ in https://crbug.com/582312#c17: - Getters favor not using "Get", ex. FirstChild() - Unless the type name conflicts, in which case you can either rename the type if it's easy and makes sense, or add "Get", ex. GetContext(). BUG=673480 Review-Url: https://codereview.chromium.org/2570193002 Cr-Commit-Position: refs/heads/master@{#438579}
-
sebsg authored
The Logging uses "." as a separator so the histogram_suffixes in histograms.xml should use the same. BUG=673413 Review-Url: https://codereview.chromium.org/2568243002 Cr-Commit-Position: refs/heads/master@{#438578}
-
davidben authored
We not only need to declare it prior to the 10.12 SDK due to the typedef being missing but, because of -Wpartial-availability, we need to redeclare it even on the 10.12 SDK until the minimum version is 10.12 or later. BUG=none Review-Url: https://codereview.chromium.org/2572113002 Cr-Commit-Position: refs/heads/master@{#438577}
-
megjablon authored
The flag currently doesn't clear savings on Android because of an early return. Since the map of pref lists isn't populated for pref writing writing with zero delay, ClearDataSavingStatistics needs to also clear the prefs using the pref service. BUG=673932 Review-Url: https://codereview.chromium.org/2570203002 Cr-Commit-Position: refs/heads/master@{#438576}
-
eroman authored
* Don't cache ERR_ICANN_NAME_COLLISION under task-based resolver (to match proc-based resolver) * Save an empty address list in cache for ERR_ICANN_NAME_COLLISION entries (rather than the address list originally resolved). BUG=670093 Review-Url: https://codereview.chromium.org/2577503003 Cr-Commit-Position: refs/heads/master@{#438575}
-
tbarzic authored
Adds networking.onc permission, which guards the introduced networking.onc alias - for now, the permission is bound to dev channel and available to the same whitelist as networkingPrivate API. To avoid duplicating whitelist for the two permissions, the whitelist is moved to behavior features and the behavior feature is added as a dependency for both of them. Refactors networking private API tests to enable parameterizing the networking API to be used in the test and adds tests that exercise alias - networking.onc code path. Also groups some sub tests (which were all run in a separate browser test) together in order to reduce total overhead of starting browser for browser tests. This is the first step towards renaming networkingPrivate API to networking.onc (which will be made available to kiosk sessions). BUG=672186 Review-Url: https://codereview.chromium.org/2470193002 Cr-Commit-Position: refs/heads/master@{#438574}
-