- 15 Jan, 2021 40 commits
-
-
arthursonzogni authored
The culprit has been reverted: https://chromium-review.googlesource.com/c/chromium/src/+/2625867 and we verified the crashed were gone. R=danakj@chromium.org Bug: 1153966,1153961 Change-Id: Ic99bbed56808188c92a34b8761e43b5621cf9e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632988Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#844154}
-
Shuran Huang authored
Use the existing origin, site_for_cookies and top_frame_origin values to create an IsolationInfo object to pass into RestrictedCookieManager, which is more aligned with the original behavior (before https://crrev.com/c/2582608) where those three fields were passed into RestrictedCookieManager directly. Bug: 1166328 Change-Id: Id44edf91f15fc8fde93c483d3b4ed2fb25c02548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630370Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Shuran Huang <shuuran@chromium.org> Cr-Commit-Position: refs/heads/master@{#844153}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I259374770df774db4c684a089fa41bcc0bbe4f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633443Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844152}
-
Fabrice de Gans-Riberi authored
http/tests/websocket/multiple-connections-throttled.html is flaky on every platform. See bug for details. Bug: 1167222 Change-Id: Ia3b28cbc716da45b098877c2677a4c319fad9e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633089 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#844151}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610711423-bdaee35d021c9a50df10abe9e0067f035c4386a3.profdata to chrome-win64-master-1610722723-f9a37ccb3c40c7cf55cb95edac87150ac0997011.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9e59897fec8592c79bd5b55098efc94d5ed8c9f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633169Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844150}
-
Cherie Cheung authored
In the existing code, for Drive FS path, ConvertPathToArcUrl() will call guest_os::GuestOsSharePath::SharePath(), which in turns will call Seneschal's SharePath(). As Seneschal's SharePath() is an asynchronous call, it may result in a race condition. To solve this: 1. ConvertPathToArcUrl() will return a flag to indicate if the path needs to be shared. 2. ConvertToContentUrls() will return a list of paths to be shared. 3. A new wrapper function ConvertToContentUrlsAndShare() will handle the path sharing after path conversion is completed. Bug: b:161427985 Test: 1. With FilesApp's OpenWith function (in ARC++/ARCVM), android app can open a Drive FS file. 2. Intent URI can launch an android app. 3. Chrome OS FilesApp as Android file picker works. 4. Drag-and-drop Drive FS file to an android app can open the file. 5. Drive FS thumbnails are showing properly. 6. Chrome camera app can open/save file normally. 7. Note taking android app can annotate images. Change-Id: Idfb0069b7ad2b407cf599748b766b4bf4899b7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601007Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Cherie Cheung <cherieccy@google.com> Cr-Commit-Position: refs/heads/master@{#844149}
-
W. James MacLean authored
This CL ensures that when a local mainframe is converted to a remote one that the VisualViewport for the new mainframe is reset. This is important since non-unit PageScaleFactor should only be stored for local mainframes, otherwise the scale will be innappropriately removed from event coordinates in out-of-process iframes. Bug: 1150977 Change-Id: I4dc8cc4ea0c4521a2f999c97607671ff62d4d159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629491 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#844148}
-
Dan Harrington authored
And send the HEART capability when it's set. Bug: 1158468 Change-Id: Ib7b64ecd4dff4aa23701de0eeceac0b8d1635ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594121 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#844147}
-
Fabrice de Gans-Riberi authored
The test is flaky on Linux, ChromeOS and Android. TBR=dominickn@chromium.org Bug: 1167226 Change-Id: I98fb83da5c47fd0aed1e05045fbd2ecbf2886b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633090 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844146}
-
Robert Sesek authored
Not all devices report this information, so do not test for it. Bug: 1167123, 1164549 Change-Id: Ia2e0262e7a6692cccdc114bbf2decea76c4655ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633668Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#844145}
-
Colin Blundell authored
This CL changes the subresource filter to handle the action of the user initiating a reload of a page with blocked ads entirely within the component, rather than delegating to the embedder. This change concretely means that WebLayer now obtains this behavior for free. To test proper integration in WebLayer, this CL also adds browsertests of the expected behavior in //weblayer. We disable these browsertests on Windows due to https://crbug.com/1152429. Bug: 1116095 Change-Id: I270aff6251d0a498af77b9748bf129036e4d3541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606345 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#844144}
-
Bin Du authored
Lock screen and lock screen app profiles are not regular user profiles. They disable sync and should be skipped when reading sync settings. Bug: b:175067939 Change-Id: I6634ce77efbb39a493df0161a16796650cac73c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628052Reviewed-by:
Gabriel Marin <gmx@chromium.org> Commit-Queue: Bin Du <dubin@google.com> Cr-Commit-Position: refs/heads/master@{#844143}
-
Michael Ershov authored
* Extract creation of policy_request into a standalone function Bug: 1150887 Test: CloudPolicyClientTest* Change-Id: Ie5f67e1272ef9b2692b71ae0c7effade3016999b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550565 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#844142}
-
Richard Townsend authored
A previous security fix prevented text documents from creating preloader_ objects. Calling ScanAndPreload in these cases is incorrect and normally DCHECKed (but it seems like this case is sufficiently rare that it made it into the wild). Bug: 1166786, 901056 Change-Id: Ia1530536d644396601e5d7ab88a878ae378ad832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630742 Auto-Submit: Richard Townsend <richard.townsend@arm.com> Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#844141}
-
David Maunder authored
Currently the load time we have includes the time taken on the sequenced task runner. Since CriticalPersistedTabData and TabState operations are both performed on the sequenced task runner, we block CriticalPersistedTabData read over the TabState read. This unfairly biases the CriticalPersistedTabData load time metric making it larger than it should be. It is better to compare the two independent of the sequenced task runner. Bug: 1166787 Change-Id: Ibc716f66cf9ec745d741f471bbd372048ef9edb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627730Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#844140}
-
Curt Clemens authored
Nearby visibility was being pushed to the second page of the system tray. This made it hard to discover. This cl moves Nearby and screen capture higher in the ordering to increase the likelihood that they end up on the first page. This new ordering was discussed here: https://groups.google.com/a/google.com/g/chromeos-ui-review-listeners/c/pp87GLQT3a0 Screenshot: https://screenshot.googleplex.com/9hzZ4VsRw38Mnb5.png Fixed: 1164456 Change-Id: I5d700757d4893ffea829a816758b1a3ffc372955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622518 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#844139}
-
Jarryd authored
GetAppUserDisplayMode. Change-Id: I42a81b31adb4b3156f722c55385b862d06213503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629464 Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#844138}
-
Aya ElAttar authored
Migrated all the usages of base::Callback & base::Bind in StatusCollector and its derived classes. Bug: 714018 Change-Id: Iba62d767ef2adb9cc136262b6edeeff8e0001f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630027Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#844137}
-
David Dorwin authored
Change-Id: Iaeaa84546ce5e3085ffcb93366714163b556e62a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631209 Auto-Submit: David Dorwin <ddorwin@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#844136}
-
Domenic Denicola authored
All other observable impacts of origin-keying, namely the impact on postMessage and document.domain, are already in place for cross-origin isolated agent clusters. So we only need to update the window.originAgentCluster getter. Fixed: 1163687 Change-Id: Ie10f26def8de2046d2b0ce69b37d56b3c89db57b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630231Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#844135}
-
Dave Tapuska authored
Move processing the OpenChannelToPepperPlugin to mojo and handling on the Pepper specific PepperRendererConnection class. This will allow the removal of the RenderFrameMessageFilter in a following CL. The IPC::ChannelHandle that was passed via legacy IPC is now passed via handle<message_pipe>. There are conversions from the ChannelHandle to a ScopedMessagePipeHandle, this is safe because Legacy IPC param traits took ownership of the ChannelHandle during its serialization. Now it is just more explicit. BUG=1157519 Change-Id: I6d8a979f98fd91848ae12fd5a6a7234e3ce5e217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630226 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#844134}
-
Yusuke Sato authored
They are unused. BUG=None TEST=try Change-Id: I969698f44dadb424b89897ec52ff7488c65d3e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632352Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#844133}
-
Yusuke Sato authored
BUG=None TEST=try Change-Id: Ia714c1dce72a9ac13aacc12900cbca11efeac890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632565Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#844132}
-
Yi Gu authored
Sample build: https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/7525/test-results?expected=false&exonerated=true&flaky=true Bug: 1167210 Change-Id: If80065473d3cac08bce82562cc730944b1cd0c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633349 Auto-Submit: Yi Gu <yigu@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#844131}
-
ckitagawa authored
This test was flaking on P so I've just re-enabled it on everything except P. This should get us a bit more coverage which is nice. Bug: 1110939 Change-Id: I016d2bf0b16e81fe2e39a43f83a67963ce4bed6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626182Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#844130}
-
Maxim Kolosovskiy authored
uploading v2.0 The previous CL (http://crrev.com/c/2527060) broke autofill captured sites tests and was reverted. The issue was fixed in http://crrev.com/c/2552281. So, this CL is just relanding + rebasing (AutofillDownloadManager now created in AutofillHandler, not AutofillManager). See diff in https://chromium-review.googlesource.com/c/chromium/src/+/2629310/1..7 Bug: 1111809 Change-Id: Iab4669843d58661cc6b9af6508f51411932770a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629310Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#844129}
-
Yi Gu authored
See linked bug for details. TBR=alancutter@chromium.org Bug: 1167176 Change-Id: I499e3886178d41c9f0036b381e2ee5f57c1aa16c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633582 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#844128}
-
Yuke Liao authored
This CL creates gn targets for lacros tast tests, and the main motivation is to run lacros tast tests on Chromium CI. Bug: 1158590 Change-Id: I783779c3386a39743b8227367189b0b87832b9dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606188 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#844127}
-
Stepan Khapugin authored
Puts dispatcher to a special mode where it pretends to recognize all selectors and silently fail on shutdown. Bug: 1137686, 1163129 Change-Id: Ib065d7f564f22c5be2285201d5dcd9dea39f60d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472039 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844126}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/e84d83393be4..9aef115356ce $ git log e84d83393..9aef11535 --date=short --no-merges --format='%ad %ae %s' 2021-01-14 quiche-dev Fixes test flakiness by forcing the test client to reconnect after fuzzed requests. 2021-01-14 renjietang In QuicConnection, cancel the previous path validation request before starting a new one. 2021-01-14 mattm Send correct QUIC CRYPTO_ERROR connection error for TLS errors 2021-01-14 renjietang In http/end_to_end_test, use live client address to send STATELESS_RESET. 2021-01-14 wub Minor tweaks to TlsServerHandshaker: - Change TlsServerHandshaker::SelectCertStatus() to TlsServerHandshaker::select_cert_status(). - Set expected_ssl_error to SSL_ERROR_WANT_READ in OnSelectCertificateDone(). - Add a test for async select cert and async signature. 2021-01-14 wub In crypto_test_utils, move connection close frame between two test connections. This allows tests to check connection close errors on both ends. 2021-01-14 wub Add a flag count for --gfe2_restart_flag_quic_tls_prefer_server_cipher_and_curve_list. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I3f634a094103c70bf9db30bae3646a740f6202ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633321 Auto-Submit: Bence Béky <bnc@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844125}
-
Hongchan Choi authored
The Finch setting might not be activated for some cases, and we want to provide developers with thread priority information via chrome://tracing. Bug: 1165842 Change-Id: I50cf618587acb8ce01237c894a21ad4965e22a62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631288Reviewed-by:
Raymond Toy <rtoy@chromium.org> Auto-Submit: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#844124}
-
Junbo Ke authored
Previously no cookie settings were provided when NetworkContext was created, and the default in-memory cookie store was used. Provide a cookie path so that the on-disk cookie store is used. Bug: internal b/177479549 Test: Launch YT on device and verified cookies survived reboot. Change-Id: Icf6ac063ffc0fc13de36bb6dd6b62edc8e4496a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631358Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#844123}
-
Caitlin Fischer authored
The experiment launched. Bug: 1126640 Change-Id: I674ef2336f3f22cf3859775805ec7997a4308281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631929Reviewed-by:
Yann Dago <ydago@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844122}
-
Dave Tapuska authored
Convert FrameHostMsg_DidCreateOutOfProcessPepperInstance and FrameHostMsg_DidDeleteOutOfProcessPepperInstance to mojo messages. These messages can use the PepperBrowserConnection The implementation for RenderFrameMessageFilter can move into the pepper subclasses themselves. BUG=1157519 Change-Id: Ic051729ed0edf99d5bd8165fe5d4d5e21b3cf42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626413 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#844121}
-
Michael Ershov authored
* Delete default constructors in mock callback observers because writing them explicitly doesn’t change anything. * Make `MockDeviceManagementService service_` a strict mock so we don’t need to have EXPECT_CALL().Times(0) in many test. * Change some `EXPECT_CALL(..., Func(_))` into `EXPECT_CALL(..., Func)` where checking arguments is not useful. * Remove some arguments from Expect* functions where they were unused. * Extract creation of policy_response into a standalone function to create it only when necessary and decrease implicit dependencies. * Reformat the file. Bug: 1150887 Test: CloudPolicyClientTest* Change-Id: I3c150a59161a6272d37f19234520a8ac9cb850ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550032 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#844120}
-
Eric Orth authored
Updating everything to match the latest style guide preferences, mostly using references much more liberally and converting output params to returns wherever reasonable. Also switching from copies to moves in a couple places that I happened to notice, and a couple more random cleanups to make Tricium happy. Change-Id: I999f511835e70e61ee8c0e7c5dd7e6b7f2396aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626786Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#844119}
-
chinsenj authored
Currently, the ChromeVox behavior is broken. It doesn't echo typed text, nor does it read out typed text. This CL fixes ChromeVox behavior by calling Textfield::GetAccessibleNodeData() in DeskNameView::GetAccessibleNodeData(). Test: manual Bug: 1166732, 1166693 Change-Id: I54306c8b3ea02000aef7663ace32ffd314d5c235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632045Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#844118}
-
Joshua Pawlicki authored
Inflated distributions are useful for running A/B tests to understand the impact of shipping larger binaries. Bug: 1154844 Change-Id: Ifdfeeb200b58174e5c3e7f346ecf013780111d25 Fixed: 1154844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625888 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#844117}
-
Scott Violet authored
This generally should only happen if the renderer is compromised. BUG=none TEST=none Change-Id: I88d522e1e5f3f557c7f976541b6dc50fb0cfed81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631296Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#844116}
-
Caitlin Fischer authored
The server-side configs show that these studies have launched. Bug: 1126640 Change-Id: I29f802ad203fecc0eab77f68df169e11d02099c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631433Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844115}
-