- 12 Nov, 2020 40 commits
-
-
Angela Yoeurng authored
If a suggestion has a remove suggestion button, this CL adds a voiceover saying 'Press Tab then Enter to remove suggestion.' If a suggestion has a remove suggestion button AND another option, the voiceover will read 'multiple actions are available, press Tab to cycle through them.' The Remove Suggestion button previously was not included in the action count. Bug: 1099798 Change-Id: I84f012d0f9d40a82a8c85214128ce25c6b4323b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533634Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Cr-Commit-Position: refs/heads/master@{#826855}
-
Ben Joyce authored
Bug: 989569 Change-Id: I71607e5272ca98c896d5dd48307f2198b46ef4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520332Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#826854}
-
Chris Lu authored
Bug: 1107489 Change-Id: I8d7f9a4c8567936993a95589bbc9333360df8570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521108 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#826853}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b01e06269f7..2f813eb9ddbb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC zmin@google.com,mamir@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: zmin@google.com,mamir@google.com Change-Id: I829985734e2d419246bf35495341f67b1507dd8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534807Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826852}
-
Alex Rudenko authored
Bug: 1121900 Change-Id: Ia64736ac414b08c4999a9ff077bf82c0e31d03f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534830Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#826851}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8e6646c31e9d..9534205dbf29 2020-11-12 tvanderlippe@chromium.org Typecheck changes/ChangesHighlighter.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I96e42dd4aa3753a0b4ad2f149162b9cad90fa52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535074Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826850}
-
Brandon Wylie authored
Connecting buttons to their actions, writing to prefs and displaying the consent dialog when needed. mocks: https://www.figma.com/file/b1CT6jM3mj0MdBvgQicy4b dd: https://docs.google.com/document/d/1ZnmJUYFBEiIx8TjQPxD18e7NAeJa6yIBamAJyR-ggOk Bug: 1117271 Change-Id: I90dd40c285d9246cfe5b48c62ffdee093c591086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531356 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#826849}
-
Tim Judkins authored
This CL changes over the json schema to use the new returns_async format to define callbacks, enabling promise support on those APIs. Bug: 328932 Change-Id: I13caaf4f9eff77db7cb0afc1516ed485e1908556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515142Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Tim Judkins <tjudkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#826848}
-
Sammie Quon authored
We only have once window observer function OnWindowDestroying, and it only removes the observer unless it is the restore focus window. So there is no point observing the other windows or storing their pointers. Bug: none Test: none Change-Id: Ib66cb0c34c316b1d7ed8c30f3d110e8b32d7b2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533857Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#826847}
-
Tim Judkins authored
This CL changes over the json schema to use the new returns_async format to define callbacks, enabling promise support on those APIs. Bug: 328932 Change-Id: Iab033c7cd7174d82be4740bcf1ee4fca5288665f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514807Reviewed-by:
-
Tim Judkins authored
This CL changes over the json schema to use the new returns_async format to define callbacks, enabling promise support on those APIs. Bug: 328932 Change-Id: I6b93bf1977582ff5a104820728ad891bd2a329e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514965Reviewed-by:
-
Rushan Suleymanov authored
If the last tab is closed, it won't be removed from the "Tabs from other devices" list. This CL fixes it by sending the latest state even if there are no tabs left in window. After current CL the window is considered syncable if it is not about to be closed (regardless of the number of tabs). Bug: 1039234 Change-Id: I15c61b38a6bbd53ea158b216644cd27655f8c4dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485261Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#826844}
-
Tim Judkins authored
This CL changes over the json schema to use the new returns_async format to define callbacks, enabling promise support on those APIs. Bug: 328932 Change-Id: I524d814fd6c9839e9804e6de808bd62ebc2f8fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515441Reviewed-by:
-
Evan Stade authored
Bug: 1147268 Change-Id: I5dd82eb4a2158f68f517d11e3f9c8e06ab89988f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531293Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#826842}
-
Tim Judkins authored
This CL changes over the json schema to use the new returns_async format to define callbacks, enabling promise support on those APIs. Note: action.setIcon does not yet support promises as it uses a custom hook. Promise support for APIs using custom hooks will be added at a later time. Bug: 328932 Change-Id: I3271db95514a5410ae4e361b514c8932dad1d85f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514745Reviewed-by:
-
Tim Judkins authored
This CL changes over the json schema to use the new returns_async format to define callbacks, enabling promise support on those APIs. Bug: 328932 Change-Id: I6b2f545c3b3b92e30a1a355256a17083e12c2e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515141Reviewed-by:
-
Olesia Marukhno authored
Make new permission requests to override current pending requests and then restore pending requests in stack order. Bug: 1019129 Change-Id: Ia7503432cceb27e4db40708c63e3e442e026595e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418445 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#826839}
-
Miyoung Shin authored
This CL changes chrome.dom namespace's channel from dev to stable. Bug: 778816 Change-Id: I4ed039f72330a14baee487e89da325ff1ca707e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532540 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Evan Stade authored
This changes ShortcutHelper to download the splash image for a webapp while the webapp is being installed, rather than after. If the splash image is downloaded before the webapp installation process finishes, the splash image will be stored in a local map until it can be transferred to the WebappDataStorage object. This simplifies the code and fixes a potential UAF. Bug: 1147913 Change-Id: I9405ee9cc304eaf8b9ff2bbaca17c1c63cfd6e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533031 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Sammie Quon authored
Use the sessions AddItem instead of grids AddItem. The former updates the recent items widget and also |num_items_|. This prevents a DCHECK from crashing when exiting overview, since |num_items_| will have the wrong value. Fixed: 1147990 Test: manual Change-Id: I27f76a6da28572da6fa9f8bd045b239e63d7d19f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533994Reviewed-by:
-
Nohemi Fernandez authored
UX and Product have aligned to recommend "Signed in as [full name]" as the title for the sign-in notifications infobars. Bug: 1145592 Change-Id: Idb923fbf284b1a466ae0976d1920e20301319764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534856 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#826835}
-
Scott Violet authored
There were two issues: . Need to register the VariationsIdsProvider with the trial-registry. Without this the header content is never updated. . Need to return true from VariationsClient::IsSignedIn(). This is needed as registerExternalExperimentIDs() supplies SignedIn. I clearly need a test for this. Will add it in a follow up. BUG=11478276 TEST=none Change-Id: I62b6976dd51c3eb3aff4412ee2512b7c5516301b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532516Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#826834}
-
Sigurdur Asgeirsson authored
This addresses nits from https://crrev.com/c/2518028, and generally tides up ScopedObservation and ScopedMultiSourceObservation. Bug: 1145565 Change-Id: I6aa515b25eede775b17a21b34f688e3daf8410a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533899Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826833}
-
Stepan Khapugin authored
Some code (e.g. an app agent in follow-up CL) will require this header; split it into a separate target to prevent circular deps. Bug: none Change-Id: I3c6c57f6e29bbf8c7156d30b71ba08681b2ecc93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521124Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826832}
-
Kuo-Hsin Yang authored
Implement CriticalMemoryPressure and ModerateMemoryPressure signals. Rename kGetMemoryMarginKBMethod to kGetMemoryMarginsKBMethod. Bug: b/149833548 Change-Id: Id7655695e565638fe34a2f7c3bb7cdac79039725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532158Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#826831}
-
Brandon Wylie authored
This reverts commit 92f89de1. Reason for revert: Failing on Lollipop Phone Tester Original change's description: > [Paint Preview] Attempt to fix test in StartupPaintPreviewHelperTest > > This attepts to fix StartupPaintPreviewHelperTest#testDisplayOnStartup > by waiting for activity to be destroyed first. > > Bug: 1145783 > Change-Id: Icd949712cb348dc12829a6eddec17b86045d2c35 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533030 > Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org> > Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826481} TBR=mahmoudi@chromium.org,ckitagawa@chromium.org Change-Id: Ib158454c9c3616a1082a3f25fb14c8ec03799331 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1145783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535211Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#826830}
-
Monica Basta authored
This CL implements the new UI design for 'chrome://settings/manageProfile'. The previous implementation had a input placeholder to allow edit the local profile name and profile avatar selector. The new UI has 4 sections: - Name your profile - Pick a theme color - Pick an avatar - Create desktop shortcut (shown only on Windows devices) All changes are visual changes, no behavioral changes are expected except for the ability to change the profile theme color. Bug: 1147088 Change-Id: Ib4cdea31a97c291b55ccaa2e6e3ec30f54786d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527125 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#826829}
-
Antonio Gomes authored
... window_properties.h. Also kWindowOverviewTitleKey. These are the last properties in the `ash` namespace use in browser_non_client_frame_view_ash.cc|h. BUG=1113900 R=jamescook@chromium.org Change-Id: I463e89cc1b9c1956b59dfb5a46bdab5c6aae38b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534711 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#826828}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=sky@chromium.org Bug: 1145565 Change-Id: Ieb10240f6035314a206ea814709c43c1c739ac7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532954 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#826827}
-
Yann Dago authored
Create BrowsingDataRemoverBrowserTestBase Bug: 1026442 Change-Id: I05b0ebff060e3114a536146e82716a875485c676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524724 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#826826}
-
Sylvain Defresne authored
This directory is pulled via DEPS since https://crrev.com/c/2529104 and causes git status to report that the checkout contains untracked files. Bug: 1140584 Change-Id: Ie837a23d6b4d6f908a70db9f0e03421ce28cf291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534953 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#826825}
-
Sigurdur Asgeirsson authored
As is, it's getting a declaration out of an include in /components someplace. I'm retiring ScopedObserver in /components, which breaks compile here. Bug: 1145565 Change-Id: I69a2dc15aaef4199c91c01177e0ebfcc22e2da24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533140 Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#826824}
-
Michael Thiessen authored
This OWNERS file references the recently deleted chrome/android/java/src/org/chromium/chrome/browser/widget/OWNERS which listed only twellington as an owner, who already owns these directories. No-Presubmit: true Change-Id: Ia911351e1b25cbe870c254b603b6a3f00241ee84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534397 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#826823}
-
Daniel Cheng authored
The HashTraits for scoped_refptr allow lookup by raw pointer value. Bug: 1137931 Change-Id: I226e816e93ec631eb21ecb8ade66d7c0086ff3ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533651Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#826822}
-
Ben Pastene authored
In crbug.com/1129937, we saw build-time regressions during chrome-uprevs that were believed to only show up when symbol_level=2. Now that crbug.com/1129937 is resolved, this adds full symbols to a couple of chrome's Simple Chrome bots which may help catch any similar regressions in the future. Bug: 1129937 Change-Id: I0f37f642f7cb8a6a6a082a3b2cf83a2032620058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488701 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#826821}
-
Owen Min authored
Disable SafeBrowsingTestCase/testBackForwardNavigationWithWarningInIncognito on iOS due to flaky. Bug: 1147360 TBR: ajuma@chromium.org Change-Id: Iec6462085d66d74af61b838955b3c662e9071aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534615Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826820}
-
Colin Blundell authored
This class will be reused in //weblayer browsertests. The componentization requires passing in the RulesetService rather than obtaining it internally from the //chrome-level BrowserProcess global. This in turn causes a slight hiccup in //chrome's subresource filter browsertest harness: the browser process global is not available until SubresourceFilterBrowserTest::SetUpInMainThread(), but many subclasses of SubresourceFilterBrowserTest don't invoke SubresourceFilterBrowserTest::SetUpInMainThread() from their own SetUpInMainThread() methods, and can't be made to in a straightforward way due to dependency issues (some of the code in the subclass' SetUpInMainThread would need to run before SubresourceFilterBrowserTest' and some after). I left that yak to shave for another day and turned TestRulesetPublisher into a local variable in the two SubresourceFilterBrowserTest methods that need it. Bug: 1116095 Change-Id: I453b277e1c3290b169170383aa6531d34db32cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527054Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#826819}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=aee@chromium.org Bug: 1145565 Change-Id: I48d7536ee7228fb3888849c7b2e4c82523bcd230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532956 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#826818}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/850ce5aaee72..c56f1f99c003 2020-11-12 engeg@google.com api: regen protos to latest versions 2020-11-12 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-12 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-12 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-12 hirokisato@google.com Move eve-pi-android-pfq to no-hwtest and add rammus to Android PFQ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Icc39cd329b4b2d364f8ec6dbeadffed1bbf43e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534751Reviewed-by:
-
Regan Hsu authored
The text was previously truncated in English. This CL ensures that the entire string is visible in whatever language, taking as many lines as it needs. Screenshots: https://screenshot.googleplex.com/36o7AGXKQ46TCAV https://screenshot.googleplex.com/Af3XxC4vvt6TFsB Fixed: 1148040 Bug: 1106937 Change-Id: Ibae0db5ab671c2514d17dca1d23ac90b6fca560d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534690Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#826816}
-
