GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4fd7f380..1af9e739

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2171233003
Cr-Commit-Position: refs/heads/master@{#407343}

BUG=630701
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2176773002
Cr-Commit-Position: refs/heads/master@{#407342}

BUG=577686

Review-Url: https://codereview.chromium.org/2165233003
Cr-Commit-Position: refs/heads/master@{#407341}

BUG=624136

Review-Url: https://codereview.chromium.org/2181443002
Cr-Commit-Position: refs/heads/master@{#407340}

Cells's border boxes were not getting resized when their collapsed
border changed because a sibling was removed.

BUG=613728

Review-Url: https://codereview.chromium.org/2173163003
Cr-Commit-Position: refs/heads/master@{#407339}

BUG=628686
R=nicholss@chromium.org,sergeyu@chromium.org

Review-Url: https://codereview.chromium.org/2169273002
Cr-Commit-Position: refs/heads/master@{#407338}

Also implements the UpdateRequest method on the request queue needed to
be able to update the request count, and adds the appropriate tests.

BUG=610521

Review-Url: https://codereview.chromium.org/2176453002
Cr-Commit-Position: refs/heads/master@{#407337}

This was broken in r407045.

TBR=mbarbella@chromium.org
BUG=605732

Review-Url: https://codereview.chromium.org/2180473003
Cr-Commit-Position: refs/heads/master@{#407336}

There is a downstream compiling issue that we could fix next week.

BUG=629768
TBR=jbudorick@chromium.org

Review-Url: https://codereview.chromium.org/2175763003
Cr-Commit-Position: refs/heads/master@{#407335}

Use rvalue references in SimpleFeature setters, rather than passing in a
const reference.  In the generated code these setters are used in, the
values are all constructed in-place, so no copy is performed. This then
allows us to use move assignment operaters in SimpleFeature, thus avoiding
a copy.

BUG=280286

Review-Url: https://codereview.chromium.org/2172353002
Cr-Commit-Position: refs/heads/master@{#407334}

https://crrev.com/2166713002 introduce usage of STL/WTF
types for image_capture. But that translated bindings of
 array<> to const std::vector<>& which forced strange
const_cast<>s to avoid copies.

This CL bundles mime_type and data into a mojo::Struct
that is move-only, hence avoiding the copies of, potentially
large, photo frames.

BUG=630040

Review-Url: https://codereview.chromium.org/2167313002
Cr-Commit-Position: refs/heads/master@{#407333}

[Offline Pages] Add network status, save request textbox, and offline url link to offline internals page

BUG=629880,629879
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2172443004
Cr-Commit-Position: refs/heads/master@{#407332}

Cr-Commit-Position: refs/heads/master@{#407331}

Revert of Fix typo in printing.gyp (patchset #3 id:40001 of https://codereview.chromium.org/2170123003/ )

Reason for revert:
Broke "Win8 GYP (dbg)" bot.

https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/builds/978

python.exe gyp-win-tool link-with-manifests environment.x86 True initial\chrome.dll
error LNK2005: "public: static class scoped_refptr<class cloud_print::PrintSystem> __cdecl cloud_print::PrintSystem::CreateInstance(...)

initial\chrome.dll : fatal error LNK1169: one or more multiply defined symbols found

Original issue's description:
> Fix GYP build for Chrome OS to match GN
>
> Fix type in printing.gyp: printing/backend/cups_deleter{,s}.{h,cc}
>
> Disable the cloud print connector like in GN in chrome.gyp
>
> BUG=630791
>
> TEST=Ran `GYP_CHROMIUM_NO_ACTION=0 gclient sync` and verified that chrome compiles
>
> Committed: https://crrev.com/d9e819815d379eb2492514ddb8158def89314311
> Cr-Commit-Position: refs/heads/master@{#407317}

TBR=emircan@chromium.org,skau@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630791

Review-Url: https://codereview.chromium.org/2177733002
Cr-Commit-Position: refs/heads/master@{#407330}

R=sergeyberezin@chromium.org
BUG=629152

Review-Url: https://codereview.chromium.org/2169213003
Cr-Commit-Position: refs/heads/master@{#407329}

BUG=630411

Review-Url: https://codereview.chromium.org/2170243002
Cr-Commit-Position: refs/heads/master@{#407328}

BUG=None

Review-Url: https://codereview.chromium.org/2171703005
Cr-Commit-Position: refs/heads/master@{#407327}

BUG=630549
TBR=csharrison

Review-Url: https://codereview.chromium.org/2171303005
Cr-Commit-Position: refs/heads/master@{#407326}

BUG=597270
TEST=device test saw bug away

Review-Url: https://codereview.chromium.org/2167613003
Cr-Commit-Position: refs/heads/master@{#407325}

For malicious downloads, change the Dismiss button in DownloadItemView
to Discard button and cancel download when user clicks on it.

BUG=594596

Review-Url: https://codereview.chromium.org/2164723002
Cr-Commit-Position: refs/heads/master@{#407324}

BUG=627814

Review-Url: https://codereview.chromium.org/2174963002
Cr-Commit-Position: refs/heads/master@{#407323}

This should make it a little bit simpler for the somewhat common case
of a single column settings-box (20 / 60 existing two-line instances,
with more to come in internet settings).

BUG=589630
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2169193003
Cr-Commit-Position: refs/heads/master@{#407322}

Adding specific OWNERS file for Source/modules/imagecapture
(note that other potential Owners e.g. mlamouri@ are already
in Source/modules etc.)

Review-Url: https://codereview.chromium.org/2178703002
Cr-Commit-Position: refs/heads/master@{#407321}

BUG=630765

Review-Url: https://codereview.chromium.org/2169273005
Cr-Commit-Position: refs/heads/master@{#407320}

There was a bug in 23.2.1 where displayMetrics.orientation is wrong
after rotation, so we had a workaround. Now we don't need this
workaround anymore.

BUG=599048

Review-Url: https://codereview.chromium.org/2175943002
Cr-Commit-Position: refs/heads/master@{#407319}

Change log:
https://github.com/google/closure-compiler/compare/2f95290ea61dd4f1b5a3bf9d0fe3aa8e3244babf...c64418fd5518bb60aeb6a627d2bcc46a3d4be788
chrome_extensions.js: 754b5d249801020f5d71df9b7b576550f56972dc -> 462f6bc6508621ebeb7cf9a51fca7d069d2a7b85

R=dbeam@chromium.org
TBR=sergeyu

Review URL: https://codereview.chromium.org/2180623002 .

Cr-Commit-Position: refs/heads/master@{#407318}

Fix type in printing.gyp: printing/backend/cups_deleter{,s}.{h,cc}

Disable the cloud print connector like in GN in chrome.gyp

BUG=630791

TEST=Ran `GYP_CHROMIUM_NO_ACTION=0 gclient sync` and verified that chrome compiles

Review-Url: https://codereview.chromium.org/2170123003
Cr-Commit-Position: refs/heads/master@{#407317}

When a PageState update is received from the renderer process, it must
be for the current session history entry. This means that the sequence
numbers associated with the FrameNavigationEntry should match the ones
coming from the renderer process.
This CL is adding explicit check for this and a DumpWithoutCrashing to
help diagnose what cases can cause a mismatch.

BUG=628677

Review-Url: https://codereview.chromium.org/2172123004
Cr-Commit-Position: refs/heads/master@{#407316}

This is a follow-on CL to https://codereview.chromium.org/2130293003 which added the RaiseException call in memory_win.cc but missed memory.cc

BUG=614440

Review-Url: https://codereview.chromium.org/2173463002
Cr-Commit-Position: refs/heads/master@{#407315}

Revert of Fix the mobile emulator to use the correct device scale when disabled. (patchset #1 id:1 of https://codereview.chromium.org/2168313002/ )

Reason for revert:
Likely cause of webkit_tests unexpected_failures
inspector/screen-orientation-override.html

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux/67873/layout-test-results/results.html

Failure appeared on many bots:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux/builds/67873
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/15157
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10/builds/21002
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11/builds/7468
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/12746

and it seems related (change to devtools, failure in "inspector")

Original issue's description:
> Fix the mobile emulator to use the correct device scale when disabled.
>
> The mobile emulator was triggering a layout before it had reapplied the
> original viewport parameters when it was being disabled, which with
> use-zoom-for-dsf enabled was causing the wrong viewport size to be given
> to various components, like plugins and scrollbars.
>
> BUG=628501,628185
>
> Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f
> Cr-Commit-Position: refs/heads/master@{#407294}

TBR=dgozman@chromium.org,alph@chromium.org,bsep@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=628501,628185

Review-Url: https://codereview.chromium.org/2174493004
Cr-Commit-Position: refs/heads/master@{#407314}

Remove DnsPrefetchingEnabled and DisableSpdy preferences.
DnsPrefetchingEnabled was not doing anything for about year now.  DisableSpdy
has not been doing anything since SPDY/3.1 support was removed recently.

Also remove class NetPrefObserver, which does not do anything besides
registering these two preferences.

This is a follow-up to https://crrev.com/2140733002.

BUG=624095, 526773, 334602

Review-Url: https://codereview.chromium.org/2172543003
Cr-Commit-Position: refs/heads/master@{#407313}

Since almost everything was converted to Create method, now
it can be moved to private section.

While doing this, CanonicalCookieTest::Constructor had to be
converted to Create method as well.

BUG=57061
TEST=net_unittests --gtest_filter=CanonicalCookieTest.Constructor
TEST=ios_net_unittests
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2159373002
Cr-Commit-Position: refs/heads/master@{#407312}

We know for sure the initial N release for N5X/N6P will have multisample
bugs. There is evidence as well that adreno 530 drivers in existing
devices like samsung s7 is affected as well. Expand the workaround to
cover these devices.

Planning on merging back to m52

BUG=612474
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2176703002
Cr-Commit-Position: refs/heads/master@{#407311}

Fallout from:
https://codereview.chromium.org/2177473004

TBR=aberent@chromium.org,pauljensen@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2175603004
Cr-Commit-Position: refs/heads/master@{#407310}

In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both
attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but
in OpenGL 4.3 spec there is no such restriction.

This patch adds the validation in command_buffer and updates the related unittests to meet
this restriction.

BUG=629735

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2161383002
Cr-Commit-Position: refs/heads/master@{#407309}

This lifetime management for ClipboardImpl from service.cc to the window
server.

BUG=614037

Review-Url: https://codereview.chromium.org/2180593002
Cr-Commit-Position: refs/heads/master@{#407308}

Currently, the creation of any panner node causes the HRTF database to
be loaded.  However, the default panning model is "equalpower" (about
99.8%) so loading the database is a waste of time and memory.
(According to https://codereview.chromium.org/176683003/, it takes
30MB to hold the database.)

Thus, only load the HRTF database when the panning model is set to
HRTF.

Can't test this easily, but did verify with a debugger that the
database is only created when the panning model is set to HRTF and not
before.

BUG=592787
TEST=none

Review-Url: https://codereview.chromium.org/2171703003
Cr-Commit-Position: refs/heads/master@{#407307}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6e08f37..937acaa

BUG=
TEST=bots
TBR=kbr@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2173913003
Cr-Commit-Position: refs/heads/master@{#407306}

Document latency percentiles.

BUG=473337

Review-Url: https://codereview.chromium.org/2171833002
Cr-Commit-Position: refs/heads/master@{#407305}

Diff since last roll:
https://github.com/chromium/dom-distiller/compare/54d05ba208...6c16f14405

Picked up changes:
6c16f14 Warm up image cache for data URI used in tests
301ea1e Fix malformed test filter
9b606cb Remove files for drone.io
7e3b63e Fix schema.org article matching

BUG=619852

Review-Url: https://codereview.chromium.org/2173883004
Cr-Commit-Position: refs/heads/master@{#407304}