- 11 Oct, 2019 40 commits
-
-
Robbie McElrath authored
We currently store the Date header from the variations server response in the SeedInfo object and parse it in several places. This CL converts the field to a long so it only needs to be parsed once. Bug: 1010625 Change-Id: I4d87c6f9ad51e98656c04b2bae0ef6227e528888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851544 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#704944}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9f765966461e..6c2b2bb02402 git log 9f765966461e..6c2b2bb02402 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@6c2b2bb02402 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: I4b79eb00d620202ab61aa19eba7a1ad65e6e35d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854563Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704943}
-
Miyoung Shin authored
This CL converts AudioFocusManager{Ptr, Request} in chrome, components, content and services to the new Mojo type, and uses pending_remote<AudioFocusManager> in media_session.mojom. Bug: 955171 Change-Id: If94cf50ca0e051f4e0864fa5efd01e3595e70205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849732Reviewed-by:Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#704942}
-
Hayato Ito authored
Disable DeclarativeContentApiTest.RemoveAllRulesAfterExtensionUninstall on all platforms TBR=tbarzic@chromium.org BUG: 1013457 Change-Id: Ib0a3f02a340b35072d4572d22e2a7c5f27088348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855239Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#704941}
-
Hayato Ito authored
Disable DesksWindowCyclingTest.CycleShowsAllDesksWindows on OS_CHROMEOS. TBR=mukai@chromium.org BUG: 1013174 Change-Id: I38243ebf3fd4eac7348548727354c545a3df6991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855140Reviewed-by:
-
Hayato Ito authored
DISABLE TabSpinnerTest.LoadTabsOneByOne on all platforms since linux release is also flaky. TBR=malaykeshav@chromium.org BUG: 1013458 Change-Id: Ie1cc8c0574cd63823b54dce6a9e436047b3e1e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855059Reviewed-by:
-
Chong Gu authored
Add AEMU to fuchsia_package_runner template. Add Mixin for AEMU flag, apply mixin to FYI Fuchsia Bots. Add missing filter for components_unittests. Bug: 1000906 Change-Id: I495074e7d811db850c43b60dfd6e1ae052702781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793522 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#704938}
-
Anand K. Mistry authored
IronScrollManager, used by the iron-dropdown element, is capturing 'touchstart' events and canceling the default action when touching outside the dropdown. This is causing the 'mousedown' event to be suppressed, preventing the 'mousedown' listener from working on touchscreens. Listening for the 'pointerdown' event instead bypasses this issue since the event does not appear to be canceled like 'mousedown'. Bug: 1004984 Change-Id: I23dbd203baffcdd9b9f9b61a58adf7b930cfe4da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847459 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#704937}
-
Julie Jeongeun Kim authored
This CL converts MachineLearningService from machine_learning_service.mojom to new Mojo types using Remote and PendingRemote. Bug: 955171 Change-Id: I24d3cc21de28b870bcc7e428d3dd0b4e796cfd98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850683Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#704936}
-
Scott Violet authored
BUG=none TEST=none Change-Id: I41b0f0c677547f7ef7f0d94defeec5a06dcdbac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854800 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#704935}
-
Kenichi Ishibashi authored
It's better to place mojom <-> web conversions on the same place. This CL does not have behavioral changes. Bug: 937177 Change-Id: I73b6f903566091e89afa83b14a8766ced1ff67d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855018Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#704934}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/32bee0fd038e..8ba50490174a git log 32bee0fd038e..8ba50490174a --date=short --no-merges --format='%ad %ae %s' 2019-10-10 jmadill@chromium.org Use relative paths/hooks in DEPS. 2019-10-10 sugoi@google.com Vulkan: Base max renderbuffer size on max framebuffer size 2019-10-10 jmadill@chromium.org Checkout GLES 1.1 conformance from DEPS. Created with: gclient setdep -r src/third_party/angle@8ba50490174a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: Ie4e12494171398cecc477d3c9f10073dd092e7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854763Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c9af0e8a6ace..11dd6af79212 git log c9af0e8a6ace..11dd6af79212 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 achuith@chromium.org OWNERS: Chrome-related owners. Created with: gclient setdep -r src/third_party/chromite@11dd6af79212 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iaded5dd396eeac226fda46d5c92136c8e5728e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854761Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/586f2bea5b1f..54b0677aeba5 Created with: gclient setdep -r src-internal@54b0677aeba5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I853cb6e2fc527209dddd2f48c6e3a9f5513f3f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854762Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704931}
-
Wei Li authored
Use FillLayoutManager for client view; remove the use of Layout() call. BUG=1005568 Change-Id: I0692f1e9bfefcca2b1a27bfe1baf1bcf10fe9044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842409 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#704930}
-
Brandon Wylie authored
This can be used as an alternative to manually deselecting the 100+ options that are enabled by default. Bug: 1013261 Change-Id: Ia3ddde870b425e899d7edadf27919ee7b15d2135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853990 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#704929}
-
Rakina Zata Amni authored
Similar to WebUSB, pages that uses the Web Serial APIs shouldn't be frozen and enter the BFCache (at least for now). This CL marks the RenderFrameHost that uses the SerialService as disabled for BFCache. See CL for WebUSB: https://chromium-review.googlesource.com/c/chromium/src/+/1837933/ Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 Bug: 992851 Change-Id: I26f48bb309c2c2c6f2737e52c1ce533f8e03f437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851785 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#704928}
-
Kenichi Ishibashi authored
To avoid using uninitialized values in unittests. Bug: 1013381 Change-Id: I27e24af750b61998f3de61634564addf42b8bcb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854106Reviewed-by:
-
Jay Harris authored
ExperimentalBadge.set ==> navigator.setExperimentalAppBadge ExperimentalBadge.clear ==> navigator.clearExperimentalAppBadge Note: This also removes the (unused) scope parameter from the IDL files and returns a Promise<void> from both APIs, in case we ever want to promisify the API in future (see https://github.com/WICG/badging/issues/55#issuecomment-535740159). TPAC Discussion Summary: https://github.com/WICG/badging/issues/55 Summary of IDL Changes: interface ExperimentalBadge { static void set(optional unsigned long long contents); static void clear(); } changed to: partial interface Navigator { Promise<void> setExperimentalAppBadge(optional unsigned long long contents); Promise<void> clearExperimentalAppBadge(); } Bug: 719176 Change-Id: Ied825cb1a58df674d5c7de59278cbf8b6e3b32f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816002 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#704926}
-
Matt Menke authored
The class tracks which endpoints uploads have succeeded/failed to. With the introduction of NetworkIsolationKeys, seems like we should bound its size, just in case. This CL uses an MRUCache to do that. Ideally, we'd just evict URLs with no entries in the ReportingCache, but that's a fair bit more complicaed, and it's not clear if it's worth doing. Bug: 993805, 1012931 Change-Id: I169882870e5ec7728c66653cea2134313905508d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853860 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#704925}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d62ac3f0b830..3273b5efd40c git log d62ac3f0b830..3273b5efd40c --date=short --no-merges --format='%ad %ae %s' 2019-10-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a1c9c889..d66030f8 (704650:704779) Created with: gclient setdep -r src/third_party/webrtc@3273b5efd40c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Idb215b4aa343db62aa23ceac62a69b90a62fc35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854549Reviewed-by:
-
Aaron Leventhal authored
This is an improved version of the original fix, which accidentally restricted VoiceOver from navigating to elements that are partially offscreen. In this version of the fix, we still support that option, but change the internal name of it from SetVisibleOnly() to SetOnscreenOnly(), in order to avoid confusion. In addition, whether the onscreen only option is used or not, programmatically hidden elements (e.g. aria-hidden, visibility: hidden) are now filtered out of the navigation. Bug: 982408 Change-Id: I13441fe9f1e8243d4adbaf6fea9e169fc325f1ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849044 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
danakj authored
* Except EnableDeviceEmulation. Emulation on/off were the last messages. These messages should only be sent in sequence with there being a RenderFrameHost present for the RenderViewHost+RenderWidgetHost. The EnableDeviceEmulation message is sent when navigation is ready to commit, which is when the RenderWidget is still for a provisional frame. At that point the widget is not undead, and the WebFrameWidget is valid. So it's not too terrible. Once the RenderWidget is deleted instead of made undead, we can just accept messages while provisional without worry. R=avi@chromium.org Bug: 419087 Change-Id: I9ddfd81bc1ea0c448e86afe13e2b0a1b38dd6121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853675 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#704922}
-
Gyuyoung Kim authored
This CL applies pending_receiver to CreateVideoEncodeAccelerator() in VideoEncodeAccelerator interface. - Convert InterfaceRequest to mojo::PendingReceiver - Convert mojo::MakeStrongBinding to mojo::MakeSelfOwnedReceiver Bug: 955171 Change-Id: Id3d3237e8d3687c2ac4d18b7965530239ef83d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833004Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Kent Tamura authored
The original code of SpaceSplitString::Data::Contains() was equivalent to Vector::Contains(). This CL simplifies the code. This CL has no behavior changes. Change-Id: I0ed0f68e87e07bb003a7b67159982600431618f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852524Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#704920}
-
Sajjad Mirza authored
Also extract common full-codebase coverage properties to a mixin. Bug: 1010702 Change-Id: If60cc49c9040702e4f8138d46af74bbd89e204d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834951 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#704919}
-
Jaeyong Bae authored
This patch means remove tracing to make IndexedDB (and more importantly, compaction) faster. Bug: 1012883 Change-Id: I0f05171ecf8986d8cccdc151243e1de02d124090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851365 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#704918}
-
Wenbin Zhang authored
system_health_smoke_tests.py has a logic to make sure we only run the latest version of a story in smoke test. For example: Case 1: Story_A:2019 Story_A Case 2: Story_A:2018 Story_A:2019 In both cases, Story_A:2019 is expected to run, and all other versions should be listed in the _DISABLED_TESTS in order to save CQ run time. However, in the current implementation, none of the old versions in the above cases will be detected.This CL will update the logic cover the above cases. The new logic also discovered two stories which we currently run smoke tests with their older versions. In this case, those older versions now are added in the _DISABLED_TESTS. Those stories are: benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/load:social:vk benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/load:social:vk:2018 benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile/load:social:twitter benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile/load:social:twitter:2019 R=crouleau@google.com Bug: catapult:1006771 Change-Id: Ia90f38568685ca8be45710f97e91cd8ea81dc856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845792 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#704917}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6a1d77869d77..b2b51418596e git log 6a1d77869d77..b2b51418596e --date=short --no-merges --format='%ad %ae %s' 2019-10-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-10 dbeam@chromium.org git-cl: add --fixed / -x option to upload Created with: gclient setdep -r src/third_party/depot_tools@b2b51418596e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I6194a05084f3dd9fe62ba8d4bc8e86cc98385afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854551Reviewed-by:
-
Victor Costan authored
Bug: 729800 Change-Id: Iff06269a032bf22de79b84508c923fe3215c07ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852326 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#704915}
-
Brian Cui authored
This PR addresses an interaction bug with the NVDA screen reader. When the NVDA screen reader is in "scan" mode (instead of "focus" mode), pressing the Enter key when focused on a button element in the Settings pane causes the Settings pane to close unexpectedly. Before: https://i.imgur.com/GNRvdyW.gif This is because NVDA is simulating a click event triggered on the UI.Dialog element that wraps the Settings pane, which is not supposed to be clickable by the user. The default behavior for click events on the UI.Dialog is to hide the dialog. Our hypothesis is that NVDA is incorrectly targeting the UI.Dialog element in the accessibility tree, which is not meant to be directly interacted with. The fix in this PR simply disables the default behavior of clicking on the UI.Dialog for the Settings screen. This should have no side effects on existing behavior as the UI.Dialog element was never intended to be interacted with. With the hide behavior disabled, NVDA interaction acts as expected (button is pressed), and normal usage is unaffected. After: https://i.imgur.com/Gas1ydF.gif Bug: 963183 Change-Id: Ie1773ed8987dd6d42f8c9cb897fea3de5a091bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848114Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Brian Cui <brcui@microsoft.com> Auto-Submit: Brian Cui <brcui@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704914}
-
Tim Song authored
Certain feature pod buttons (e.g. accesibility) are not togglable, but are currently announced as such for ChromeVox spoken feedback. BUG=1009727 Change-Id: I2db6c3a53bb04ba677457ff5590574d2c384b503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848454 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#704913}
-
David Black authored
Previously the timer notification message was manually constructed. Now we rely on ICU APIs for better I18N support. Tested in en_US, fr_CA, ja. Bug: b:122475245 Change-Id: Idf8f375adee0aba198ad7091a2aa96bbe283c6df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660261 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#704912}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7fd7a8aef06c..9f765966461e git log 7fd7a8aef06c..9f765966461e --date=short --no-merges --format='%ad %ae %s' 2019-10-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@9f765966461e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: Iec9e20f8214f85192ed6a2727f7ce179c24f64d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854918Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d372b6c1..f505d9d8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I487f46cee3819e4726cd26322520ed1585d03ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853951Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704910}
-
John Lee authored
Previously, the tab strip was using favicon by using chrome://favicon, which depends on history and consequently did not work in incognito mode for sites the user did not visit in a normal window. Bug: 992972 Change-Id: I6407353c649876fe78c4ffb2425ebcd761e5d0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850965 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#704909}
-
Christopher Cameron authored
The profile_storage_ member of AvatarMenu is commented as "weak", but the lifetime relationship is not discussed. Use an actual weak pointer (ProfileAttributesStorage supports it already), and avoid dereferencing profile_storage_ if it is gone. Bug: 1008947, 1001215 Change-Id: I0e8a2fbb55465f1680c064c7cdb6193c93eb3e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853647Reviewed-by:
-
Marijn Kruisselbrink authored
This is in preparation for migrating native file system code to the UI thread, and decoupling it from whatever thread file system backend code actually wants to be called on. Bug: 1011534 Change-Id: I9d956dac5761380654842cdd07b67e1c7c2000d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841764 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
-
Regan Hsu authored
Bug: 1013094 Change-Id: I27d3fd476d3c747ac7eb7a90eb179c3b787baec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852420Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#704906}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/383a4e801d41..788d15f52867 git log 383a4e801d41..788d15f52867 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 rmhasan@google.com [typ] Makes changes so that Host or FakeHost can be used as file manager Created with: gclient setdep -r src/third_party/catapult@788d15f52867 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:982208 Change-Id: Ieb924d5fd330cc75976b6a6c2764e1a25506a2cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854759Reviewed-by:
-
