- 30 Jan, 2020 40 commits
-
-
Elly Fong-Jones authored
Replaced with direct use of the setters. Bug: 1011446 Change-Id: Ia054462bbe3e1585430b3fe4102c694366a78827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028197Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#736864}
-
Geoff Lang authored
This reverts commit 248bfd1f. Reason for revert: Broke some Android WebGL video tests BUG=1047201 Original change's description: > Don't create manager objects in ContextGroup when using the passthrough decoder > > These objects are not used when the passthrough command decoder is in > use. This saves several GPU memory allocations in TextureManager for > default and black textures. > > Saves ~2 MB per context. > > BUG=1046613 > BUG=1030835 > > Change-Id: I66c6acf28580742bc313d8cf79de80f7f7d98305 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028291 > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736631} TBR=zmo@chromium.org,geofflang@chromium.org,sandersd@chromium.org Change-Id: I82ca36bd0b449e743ef819fbfe6ad161b219a8d0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046613, 1030835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031164Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#736863}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/81c7a60961cc..d69935c114aa git log 81c7a60961cc..d69935c114aa --date=short --first-parent --format='%ad %ae %s' 2020-01-30 ivoc@webrtc.org Remove function that takes command-line arguments directly Created with: gclient setdep -r src/third_party/webrtc@d69935c114aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ief1fab6ba758cd46ed08c95b798a79d337352d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030589Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736862}
-
Hugo Benichi authored
chromeos::NetworkTypePattern requires a non-empty network "type", however ArcNetHostImpl does not care to check if the NetworkState is valid before checking for network of type "Tether". The NOTREACHED triggered in that case has been observed while debugging b:148431888. BUG=145960788 TEST=Compiled Change-Id: I79140461d0d628260fbf873274e73906fcfea646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030387Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Hugo Benichi <hugobenichi@google.com> Cr-Commit-Position: refs/heads/master@{#736861}
-
Peter Beverloo authored
Change-Id: Id0b2b359beebb3f97750be12853bec83042c956a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030489Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#736860}
-
Gyuyoung Kim authored
This CL migrates the legacy OverridePreference IPC message to the new Mojo in WebTestClient interface. To make WebTestClient interface include |WebPreference| native type, this CL needs to extract [Native] struct WebPreference from native_types.mojom to web_preference.mojom. Then, WebTestClient interface refers to |WebPreference| type through web_preferences_mojom target. This CL should not change any behavior. Bug: 1039247 Change-Id: I707c071169015939b84377ecca8da26cc1aa4395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011591Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#736859}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/38ebf200171d..3941f82d7c3f git log 38ebf200171d..3941f82d7c3f --date=short --first-parent --format='%ad %ae %s' 2020-01-30 szuend@chromium.org Prepare test runners for source map asyncification Created with: gclient setdep -r src/third_party/devtools-frontend/src@3941f82d7c3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032016 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If5aec86db3d373028169417cb288506209e68914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030588Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736858}
-
Erik Staab authored
Change-Id: I2438dd60e6991bddd94aa0c77b089547d8758cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029217Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#736857}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8f44c3504ca6..0ec7b8485455 git log 8f44c3504ca6..0ec7b8485455 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 borenet@google.com [infra] Update go.sum Created with: gclient setdep -r src/third_party/skia@0ec7b8485455 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I8bacc46c2f999451cf1227f4b8cb4b675b1ec18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030587Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736856}
-
Hugo Benichi authored
BUG=b:145960788 TEST=Compiled Change-Id: I43b58efe4a32b431f8b88dd792ab10af7dec137a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030386Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Hugo Benichi <hugobenichi@google.com> Cr-Commit-Position: refs/heads/master@{#736855}
-
Yoav Weiss authored
Due to performance regressions related to the field trial, it seems like the best course of action is to (temporarily) remove it, so that it won't impact stable. This CL removes the field trial configuration. Bug: 1036347 Change-Id: I12fbd9e16137d8f5e5803d8502ce80e0b907cae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023497Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#736854}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 64dcd1dc. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2f22c6a0a0a6b195b764e5ddedf2b7cc4c547790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028476Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736853}
-
Rushan Suleymanov authored
Extend ModelTypeProcessor interface to pass full commit failures. In the next patch commit failure will be passed to sharing message bridge. Bug: 1047123 Change-Id: Ieb59afe7a56e0cc23b4a0a09ff8ca7053ecbf85c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030405 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#736852}
-
arthursonzogni authored
This correspond to step 1.c from the "Unify CSP" document: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao This merges: - content::CSPDirective (removed) - network::mojom::CSPDirective (kept) Only the mojo one remains: network::mojom::CSPDirective; Future follow-up will apply do the same for ContentSecurityPolicy. The goal at the end is to have an unique mojo data structure for representing Content-Security-Policy. TBR=clamy@chromium.org Bug: 1021462 Change-Id: Ic04f491992fadb6a9a97ba6ab4327b2d7b8ad1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027339Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#736851}
-
Yuki Shiino authored
It turned out that gclient_paths.py seems not working as expected on canary build (could be a conflict with Google-internal src). Implements the similar (but simplified) logic without depending on unknown factors. Bug: 839389 Change-Id: I70032d60098c018f139bdceb78ea73996393ddfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029405Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#736850}
-
Mia Glaese authored
Bug: 1041475 Change-Id: I7fcf625aa0d037ebf655fa09170d0681cef8bb98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022925Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#736849}
-
Mikel Astiz authored
Local sync metadata belongs to one user account. Due to the distributed nature of the locally persisted sync metadata, the cache GUID is used as "epoch" to detect mismatched in edge cases like the browser crashing during shutdown and before I/O gets flushed. However, prior to this patch, the cache GUID itself has no safety mechanism to detect it maps to the intended account ID. In this patch, a new SyncPref is introduced to achieve that, in away that both prefs (cache GUID and account ID) are stored atomically. Because the pref is newly-introduced, migration logic is introduced to populate it for the first time if initially empty. Change-Id: I2cdd9f997077c4acd16e9283df8c025f51d40546 Bug: 1046237,1021527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023528Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#736848}
-
Miyoung Shin authored
This is a follow-up CL of https://crrev.com/c/2014720 and adds browser test for PermissionServiceContext after the renderer crashes. Bug: 1036779 Change-Id: I2304622adcc002ed73e4aa4efdf57feca1390430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026561 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#736847}
-
Simon Zünd authored
This CL re-writes a breakpoint web test using a new SourcesTestRunner helper introduced in https://crrev.com/c/2027427. This should not only prepare the test for the upcoming source map asyncification but also reduce the overall flakiness of breakpoint web tests. R=sigurds@chromium.org Bug: chromium:1032016 Change-Id: Id42223f38ec2a3ea68605948f91b45939a0618eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027335 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#736846}
-
Dominique Fauteux-Chapleau authored
Now that the access point is used for something more than just metrics, it should be clear that the existing values should not be used again for other purposes. Change-Id: I92eeba7e9c2ea2605b3d58476a414355f53de6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028167Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#736845}
-
Tommy Steimel authored
This CL adds the Kaleidoscope Closure compilation to the webui_closure_compile target. Bug: 1046370 Change-Id: I779bc88edffda6b722fd049bccbbb071a37eb271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026368Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736844}
-
Finnur Thorarinsson authored
On Android P the onCompletion callback isn't called if the video is super short (like fraction of a second). Bug: 1046347, 895776, 656015 Change-Id: I77673d3045a4b5a89b679a0bc2cef34ab0bedb88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027789Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#736843}
-
Ioana Pandele authored
This reverts commit 19b7b019. Reason for revert: Likely causing failures for TabHoverCardBubbleViewBrowserTest.WidgetNotVisibleOnClick TabHoverCardBubbleViewBrowserTest.WidgetNotVisibleOnMousePressAfterTabFocus on Linux MSan Bug:1047172 Original change's description: > [Tab Groups] Implement time to switch histogram. > > Records the amount of time in ms from the cursor entering the tabstrip > to tapping on a tab to switch. > > Bug: 1040657 > Change-Id: I438f53c3d3a83cead9a3feb0c62356e1322cf1c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023396 > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Reviewed-by: Connie Wan <connily@chromium.org> > Commit-Queue: Charlene Yan <cyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736721} TBR=jwd@chromium.org,cyan@chromium.org,connily@chromium.org Change-Id: Iff213feb375e247f59ce79c72616abaf164a35d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030664Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#736842}
-
Jazz Xu authored
This CL ensures the global media controls knows whether to show PiP button. Bug: 1045903 Change-Id: I9a9c680dd624c4e25a5c5ad757598c2a0ddaea3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021568Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736841}
-
Oriol Brufau authored
A DCHECK added in r659369 was supposed to check that list markers can have at most 1 child. However, it was actually checking that either there is no children or the first child has no grandchild. This patch fixes the DCHECK and moves it below, since nowadays markers with non-normal content may have more than 1 child. BUG=457718 Change-Id: If742a49ed6ac232644ae99efbf8ad16ccbacc8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028773Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#736840}
-
Clemens Arbesser authored
This CL allows the backend to specify how the autofill_assistant should summarize contacts. If the backend does not specify the new fields, autofill_assistant will fall back to the current default. Bug: b/146114527 Change-Id: I0913a427e84f95e8b8745fe135c3cffc8e26dad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027471 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#736839}
-
Vadym Doroshenko authored
Bug: 1042196 Change-Id: I82441af46e4c1a2e0e547ae47c0c9d5d79ddb90e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029514 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#736838}
-
Andrew Grieve authored
Bug: 726475 Change-Id: I6cc99d0d721c1f94203d2b9461e72ce2239b6a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029261 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Simon Que <sque@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#736837}
-
Samuel Huang authored
Previously, if a failed DevUI DFM install attempt (leading to the error page) is followed by a successful install, then the following problems arise: (A) chrome.send() is unavailable for the loaded DevUI page. (B) Addition refreshes trigger CHECK() and crashes browser. It seems that between showing the error page and showing the DevUI page (after successful install), some stale state persisted so that the active instance of NavigationRequest has bindings() holding a value without BINDINGS_POLICY_WEB_UI, so that chrome.send() would not load, leading to (A). Then (B) is triggered as an after effect. This CL is a work-around for the bug for the DevUI DFM. On initial DevUI DFM install, instead of resuming navigation to the intended DevUI page, we visit a small shim page that self-refreshes, so that stale states are cleared. This is not a full fix, since state staleness problem (and crash on refresh) still exists for error pages (in history or other tabs) other than the one that successfully triggers DevUI DFM install. Bug: 1046159 Change-Id: I775491ee165e7d2a809d93d334f93ae4bbf72cb6 Fixed: 1046159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028363 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#736836}
-
Maksim Ivanov authored
This removes the border and shadow around the smart card PIN dialog (the <security-token-pin> Polymer element) when it's shown during OOBE. Bug: 1024251 Test: powerwash Chromebook, enroll under policies with smart card support, start smart card login, check that the PIN dialog has no border or shadow Change-Id: I4355663bbc4f6de60512876282d7fbbf0e82e183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028772Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#736835}
-
Hans Wennborg authored
Bug: 1045592 Change-Id: I12461062f80c114c811858410328de3f06a0033c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028767 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#736834}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cf0595234cf2..81c7a60961cc git log cf0595234cf2..81c7a60961cc --date=short --first-parent --format='%ad %ae %s' 2020-01-30 phoglund@webrtc.org Fix public_deps presubmit and gn format fighting each other. 2020-01-30 phoglund@webrtc.org Make the dashboard upload script read protos instead of JSON. 2020-01-30 mbonadei@webrtc.org Replace some deprecated matchers. Created with: gclient setdep -r src/third_party/webrtc@81c7a60961cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029452 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id30f9d60135e3066b9c8ffd76702b5b3ff1a5d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030585Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736833}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/df2dbba832ad..38ebf200171d git log df2dbba832ad..38ebf200171d --date=short --first-parent --format='%ad %ae %s' 2020-01-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@38ebf200171d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia7253a49fff76a71b92f0b7f1b92b4def95e5cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030130Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736832}
-
Ioana Pandele authored
TBR=johnchen@chromium.org Bug: 1047164 Change-Id: I9f9399ac8f0c4a4a62163e2bb91005f633ebbbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030527Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#736831}
-
Mikel Astiz authored
Bookmarks created before 2015 may run into item ID duplicates across devices, so it's not appropriate to dedup based exclusively on the originator client item ID, unless it's a GUID. Change-Id: Ic338fcea59246f2cf4b1f2d7b43b3c4f69c7a1dc Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030407 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#736830}
-
Jérôme Lebel authored
Moving all enums into: ui/authentication/signin/signin_enums.h Bug: 971989 Change-Id: Ie19d7b5db58a8387c640b2d11e5b63b265bb73c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028130Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736829}
-
Michael Hablich authored
This is a roll-back to 8.1.307. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org Change-Id: I85ae6732d8d5869ef68d39aa9481ae6a974d6963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030409Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Auto-Submit: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#736828}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I34af891c79b76867c63adc768e950cb27406d10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030331Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736827}
-
Nicolas Ouellet-payeur authored
The buildbot linux-annotator-rel turned red [1] after this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2012950 extractor.py doesn't like that we use a constant instead of a string-literal in DefinePartialNetworkTrafficAnnotation. This CL simply replaces the constant with a string literal. [1] https://ci.chromium.org/p/chromium/builders/ci/linux-annotator-rel/20744 Bug: 1046794 Change-Id: Iee31bfcdbb2f860b96493a154858cf391b4922ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028288 Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#736826}
-
Robert Flack authored
This adds a WPT test verifying that CSS animations are composited in the order of their name within the animation-name property. Bug: 1045835 Change-Id: I8e746e1841cd4f5ca55e3e067762c2ea93e5c101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022616 Auto-Submit: Robert Flack <flackr@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#736825}
-