- 11 May, 2018 40 commits
-
-
Pavel Feldman authored
Change-Id: I368cce61bc3acedadefef6a7cc81ca22ec0327f8 TBR: dcheng for mojo touch Reviewed-on: https://chromium-review.googlesource.com/1055625 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558030}
-
Jeffrey Yasskin authored
BUG=842296 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7af43a396e06bbb662154401a3b90cedbf2477c2 Reviewed-on: https://chromium-review.googlesource.com/1055905Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558029}
-
Nick Harper authored
Change-Id: I17711baacd6f0f10f39da92d98f9941c4b9f87b9 Reviewed-on: https://chromium-review.googlesource.com/1047960Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#558028}
-
Qiang Xu authored
specs: https://screenshot.googleplex.com/zQNSgJP0d7d Bug: 793155 Test: manual Change-Id: Ic431bfd18f79c9c036007dadbbfe9a08a3c236c6 Reviewed-on: https://chromium-review.googlesource.com/1055792Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#558027}
-
chrome://flagsMoe Ahmadi authored
Adds an entry to about flags page in iOS in order to control the feature. Bug: 841758 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id61d8f4a63f0c6a89ec4c643640e1870d58c2ae7 Reviewed-on: https://chromium-review.googlesource.com/1055904 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#558026}
-
Jao-ke Chin-Lee authored
Also clean up migrated builders. BUG=793908,793913,793944 Change-Id: Iabec8c65ebb57182c4ad845072b8c3e9b3c5edac Reviewed-on: https://chromium-review.googlesource.com/1054702Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#558025}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fafa09dbe1d3..d1de725e0b53 $ git log fafa09dbe..d1de725e0 --date=short --no-merges --format='%ad %ae %s' 2018-05-11 jbudorick gclient: Prevent unprocessed deps from overriding processed ones in sync output. Created with: roll-dep src/third_party/depot_tools BUG=chromium:842235 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I683786d6e6d03e5abe897cd420bb6299c2b97b2a Reviewed-on: https://chromium-review.googlesource.com/1055823Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558024}
-
chrome://flagsEmily Stark authored
Bug: 839969 Change-Id: Id9a0ceff654f518e0adeeba74ed05dcb7f178bf2 Reviewed-on: https://chromium-review.googlesource.com/1055809Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#558023}
-
xlou authored
In printing, 2-up, 3-up, or more generally N-up refers to a page layout strategy in which multiple pages are composited onto a single page. 1. Added new select label and button "Pages Per Sheet". 2. Added functionality to pass UI settings to the print preview renderer. 3. Added a new constant for N-up printing feature. Design doc for N-up printing feature is here: https://docs.google.com/document/d/1rA91PzWDLh6CFrAupgUwv7XYSIqbSpffEnDEQrpEdEQ/ Bug: 830090 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4c9621fcfc8aa9f657960883e6c1ee981905d2bf Reviewed-on: https://chromium-review.googlesource.com/1050933Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Shirleen Lou <xlou@chromium.org> Cr-Commit-Position: refs/heads/master@{#558022}
-
Aldo Culquicondor authored
It affects drawing and hit testing. If the quad is completely outside the clip, nothing is sent to the CPU. This is going to be used to implement scrolling. Also, this CL removes the unused copy_rect. Bug: 839488 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I07c087f3d7860456587de092797349851c26502a Reviewed-on: https://chromium-review.googlesource.com/1054371 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#558021}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/746c45d5d8b1..7657336de212 $ git log 746c45d5d..7657336de --date=short --no-merges --format='%ad %ae %s' 2018-05-08 mikenichols [chromite] Capture job_name and git timing for ts_mon in cbuildbot runs. 2018-05-10 khmel arc: Retry copying resource in case race condition for android uprev 2018-05-09 achuith cros_run_vm_test: Support for --host-cmd Created with: roll-dep src/third_party/chromite BUG=chromium:829289,chromium:841937,chromium:832374 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7712f93eb43ad2661af0fe11a71a9b228ce916ad Reviewed-on: https://chromium-review.googlesource.com/1055816 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558020}
-
Devlin Cronin authored
Extension permissions can be complicated (especially around permission increases and permission warning generation). Add some documentation to the codebase for reference. Change-Id: If938a093439bd9c784bd735091c745ee7194299c Reviewed-on: https://chromium-review.googlesource.com/1054216 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#558019}
-
Mike Wasserman authored
Call CreateAndParentTopLevelWindow from WindowServiceDelegateImpl. Get the window type like ui/aura/mus/window_tree_client.cc Pass PropertyConverter, etc. args to avoid ash::WindowManager. Check access to possibly null WindowManager[Client], etc. ptrs. Add a unit test, apply properties to windows in test delegates. Bug: 837695 Change-Id: I9f474c4b2701efc110b0738ae56fb5334d2fa641 Reviewed-on: https://chromium-review.googlesource.com/1055658 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#558018}
-
Takumi Fujimoto authored
This CL enables the most basic functionalities: showing and hiding the dialog, showing sinks and their statuses (no throbber support yet), and starting and stopping tab mirroring. The dialog is still behind the ViewsCastDialog feature flag. - MRDialogControllerViews instantiates MRViewsUI and CastDialogView when a dialog is requested, and destroys them when the dialog is closed. - MRViewsUI sends CastDialogModel to CastDialogView whenever sinks or routes are updated. It also sends route requests from CastDialogView to MediaRouter. This CL depends on crrev.com/c/1020231. Bug: 826091 Change-Id: I14ed4811dd7ccdf0144c64b6f079c06d7fc0aa6e Reviewed-on: https://chromium-review.googlesource.com/1037907 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#558017}
-
Jay Civelli authored
Adds additional information to the WebContentsObserver ResourceLoadComplete notification that is required by the page load metrics code: - host IP and port for the request - the total bytes count - the raw bytes count Also passing along the RenderFrameHost as part of the callback. Change-Id: I9646221498312800488660d6b1b76abed467031b Reviewed-on: https://chromium-review.googlesource.com/1050927Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#558016}
-
Yuly Novikov authored
Bug: 839893 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib50865f70c7038bd6ba69aae675212b9f571b6c3 Tbr: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1055856Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#558015}
-
btolsch authored
Although most presentation connection state change and communication is handled directly between the two renderers involved, termination (and sometimes closing) is handled by the provider updating Media Router directly. In the case of local screens, the presentation ending always means it's terminating, so we should send that notification to Media Router. Bug: 839623 Change-Id: I11145bfd1bf165e8816c0b7431c909d59f78d2af Reviewed-on: https://chromium-review.googlesource.com/1054258Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#558014}
-
https://pdfium.googlesource.com/pdfium.git/+log/ddfa5177021f..ce7a8158376d $ git log ddfa51770..ce7a81583 --date=short --no-merges --format='%ad %ae %s' 2018-05-11 hnakashima Remove CFWL_WidgetMgr::IsFormDisabled(). Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Icda4afe2adbece934b4e0dcd081ec54b6a1e117c Reviewed-on: https://chromium-review.googlesource.com/1055851 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558013}
-
xlai authored
Bug: 571399 Change-Id: I88a9768a6004dbe2c0c2c320289903d13f719c73 Reviewed-on: https://chromium-review.googlesource.com/1055600Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#558012}
-
kylechar authored
VideoResourceUpdater currently uses LayerTreeFrameSink as the interface through which to notify the display compositor about shared bitmaps. This doesn't work UseSurfaceLayerForVideo where there is no LayerTreeFrameSink. Pull the two required functions out of LayerTreeFrameSink and into SharedBitmapReporter. LayerTreeFrameSink has SharedBitmapReporter as a subclass and doesn't implement the functions so nothing changes with regards to it. VideoResourceUpdater now takes a SharedBitmapReporter instead of a LayerTreeFrameSink. An implementation of SharedBitmapReporter that calls into mojom::CompositorFrameSinkPtr can be added trivially to support UseSurfaceLayerInVideo after this patch. Bug: 807840 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9a5a07140f8aa1614d1b647f3af1dd5d7aab2cd2 Reviewed-on: https://chromium-review.googlesource.com/1053054 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#558011}
-
Patrick Monette authored
The ModuleEventSink interface was bound on the UI thread, which caused cross-process IPC to retrieve information about a loaded module in the renderer process. A new sequence with background priority is instead used so that it doesn't impact startup. Bug: 832286 Change-Id: I5ab50bc45386c9a1ddb2888f80293d78bd768a88 Reviewed-on: https://chromium-review.googlesource.com/1037935Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
-
Aaron Leventhal authored
Fixes incorrect platform role mappings for IA2 and ATK. Adds the following new roles to Chrome: New landmark roles: docAcknowledgments, docAfterword, docAppendix, docBibliography, docChapter, docConclusion, docCredits, docEndnotes, docEpilogue, docErrata, docForeword, docGlossary, docIndex, docIntroduction, docPageList, docPart, docPreface, docPrologue, docToc Acts like a heading: docSubtitle Acts like a note: docTip, docNotice, docFootnote Acts like a section/region: docAbstract, docColophon, docCredit, docDedication, docEpigraph, docExample, docQna Acts like an image: docCover, graphicsSymbol Acts like a link: docBackLink, docBiblioRef, docNoteRef, docGlossRef Acts like a list item: docBiblioEntry, docEndnote, docFootnote Acts like a separator: docPageBreak Acts like a document: graphicsDocument Acts like a pane: graphicsObject Note: these are the internal names. In the role attribute used in HTML, the role names are lowercase and hyphenated with "doc-" or "graphics-" prefixes, e.g. “doc-endnotes”. More DPub info: Spec: https://www.w3.org/TR/dpub-aria-1.0/ Platform implementation notes: https://www.w3.org/TR/dpub-aam-1.0/#mapping_role_table More Graphics ARIA info: Spec: https://www.w3.org/TR/graphics-aria-1.0/ Platform implementation notes: https://rawgit.com/w3c/graphics-aam/master/#mapping_role_table NOTRY=true Bug: 812243, 839871 TBR: jcivelli@chromium.org,stevenjb@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If2d5ec8aca551cb1fb611cc3614f4f4617f958a9 Reviewed-on: https://chromium-review.googlesource.com/1044347 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#558009}
-
spqchan authored
A crash in the AutofillPopupControllerImplMac might be caused by checking the layout model to see if the popup is for a credit card. This CL potentially fix the issue by storing that value. Bug: 838660 Change-Id: I3bbe0b53139d4582313e4eabe91a42e6f3816f3e Reviewed-on: https://chromium-review.googlesource.com/1048969Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#558008}
-
xlai authored
As this use case is too small to be worth the effort, we archive this task and modify comments. TBR=junov@chromium.org Bug: 683172 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic1f55ed6c5a8b7ae074f7e03b8c07fa1bc7a4815 Reviewed-on: https://chromium-review.googlesource.com/1055814 Commit-Queue: Olivia Lai <xlai@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#558007}
-
Wenzhao Zang authored
In |ReloadWallpaper|, the |current_wallpaper_| should be reset, however if the current wallpaper is the preview wallpaper, it's not available from |ShowUserWallpaper| yet because the preview wallpaper hasn't been set for the user. So we need some other ways to retrieve the image. Although we can remove the reset of |current_wallpaper_| for the preview case, in that way we lose the ability to resize the preview wallpaper based on the new display size (|current_wallpaper_| stores the image after resizing, but we need the original image to go through the resizing process again in order to show an accurate preview.) So creating another callback should be a better solution. Bug: 835349 Change-Id: I6a76646eacb99dae26867303647206d316275950 Reviewed-on: https://chromium-review.googlesource.com/1052686Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#558006}
-
Xianzhu Wang authored
TBR=wangxianzhu@chromium.org Bug: 841567 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9bca44365295cd5ca2d41175a87f8ef07952dedd Reviewed-on: https://chromium-review.googlesource.com/1055825 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#558005}
-
Devlin authored
This reverts commit 1a6e52ab. Reason for revert: Re-enabled test is failing on Linux CrOS: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27415 [ RUN ] TabindexFocusDownloads/FileManagerBrowserTestWithLegacyEventDispatch.Test/0 [1570:1570:0511/120258.095371:WARNING:user_policy_manager_factory_chromeos.cc(207)] No policy loaded for known non-enterprise user [1570:1570:0511/120258.202042:WARNING:user_session_manager.cc(1096)] Attempting to save user password for non enterprise user. [1570:1570:0511/120300.805728:INFO:file_manager_browsertest_base.cc(632)] FileManagerBrowserTest::StartTest tabindexFocusDownloads [1570:1570:0511/120306.899468:INFO:CONSOLE(1169)] "Cache database creating or upgrading.", source: chrome-extension://pmfjbimdmchhbnneeidfognadeopoehp/background_scripts.js (1169) [1570:1570:0511/120306.921159:INFO:CONSOLE(5028)] "Requesting volume list.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5028) [1570:1570:0511/120306.988321:INFO:CONSOLE(4360)] "Waiting for the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4360) [1570:1570:0511/120307.027400:INFO:CONSOLE(5030)] "Volume list fetched with: 2 items.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5030) [1570:1570:0511/120307.030481:INFO:CONSOLE(5040)] "Initializing volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5040) [1570:1570:0511/120307.036408:INFO:CONSOLE(5443)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5443) [1570:1570:0511/120307.107297:INFO:CONSOLE(5040)] "Initializing volume: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5040) [1570:1570:0511/120307.107935:INFO:CONSOLE(5443)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5443) [1570:1570:0511/120307.497407:INFO:CONSOLE(5491)] "File system obtained: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5491) [1570:1570:0511/120307.537188:INFO:CONSOLE(5044)] "Initialized volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5044) [1570:1570:0511/120307.892689:INFO:CONSOLE(5491)] "File system obtained: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5491) [1570:1570:0511/120307.896753:INFO:CONSOLE(5044)] "Initialized volume: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5044) [1570:1570:0511/120307.897292:INFO:CONSOLE(5048)] "Initialized all volumes.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5048) [1570:1570:0511/120307.965385:INFO:CONSOLE(4357)] "Received the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4357) [1570:1570:0511/120312.721349:INFO:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source: (0) [1570:1570:0511/120312.837968:INFO:CONSOLE(161)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (161) [1570:1570:0511/120315.831155:INFO:CONSOLE(161)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (161) [1570:1570:0511/120318.719753:INFO:CONSOLE(161)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (161) [1570:1570:0511/120322.994251:INFO:CONSOLE(161)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (161) [1570:1570:0511/120324.716075:INFO:CONSOLE(161)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (161) [1570:1570:0511/120327.609187:INFO:CONSOLE(0)] "[SUCCESS] [tabindexFocusDownloads]", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html (0) [1570:1609:0511/120328.005035:WARNING:audio_sync_reader.cc(193)] AudioSyncReader::Read timed out, audio glitch count=10 [1570:1570:0511/120328.049612:ERROR:frame_sink_provider_impl.cc(34)] No RenderWidgetHost exists with id 3 in process 8 [1570:1570:0511/120328.049891:ERROR:frame_sink_provider_impl.cc(51)] No RenderWidgetHost exists with id 3 in process 8 [1570:1609:0511/120329.166852:WARNING:audio_sync_reader.cc(193)] AudioSyncReader::Read timed out, audio glitch count=20 [1570:1609:0511/120329.325388:WARNING:audio_sync_reader.cc(175)] ASR: No room in socket buffer.: Broken pipe (32) [1570:1570:0511/120329.451110:WARNING:event_router.cc(421)] Not all file watchers are removed. This can happen when the Files app is open during shutdown. [1570:1570:0511/120329.531088:FATAL:frame_sink_manager_impl.cc(58)] Check failed: sink_map_.empty(). #0 0x000000972721 (/b/s/w/ir/out/Release/browser_tests+0x972720) #1 0x00000f472f9c (/b/s/w/ir/out/Release/browser_tests+0xf472f9b) #2 0x00000f288153 (/b/s/w/ir/out/Release/browser_tests+0xf288152) #3 0x00001617a0e7 (/b/s/w/ir/out/Release/browser_tests+0x1617a0e6) #4 0x00001617a9ce (/b/s/w/ir/out/Release/browser_tests+0x1617a9cd) Original change's description: > Re-enable TabindexFocusDownloads/FileManagerBrowserTest > > Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. > > No-Presubmit: true > Tbr: fukino > Bug: 836254 > Change-Id: Ib9b497a92e1112a4061c6d863620b3ae07cfa252 > Reviewed-on: https://chromium-review.googlesource.com/1055252 > Commit-Queue: Noel Gordon <noel@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557884} TBR=noel@chromium.org,fukino@chromium.org,slangley@chromium.org Change-Id: I8b4ac33592cb5ff61a414416de04dea03f5d89da No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836254 Reviewed-on: https://chromium-review.googlesource.com/1055216Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558004}
-
David Tseng authored
New gestures - tap4: opens ChromeVox menus to the most recent menu used - swipe up/down, left/right within menus: performs keyboard equivalents rather than ChromeVox commands. Feature Description When using a tablet, a user navigates the page using multi finger gestures or touch exploration. When the user wishes to navigate by a specific role, a four finger tap moves ChromeVox to the most recently used ChromeVox menu. For example, navigate to www.chromevox.com. A four finger tap brings the user to the headings menu. A single finger swipe right moves to the links menu. Single finger flick down moves to the feedback link. A double tap finally moves ChromeVox back to the page and places focus on the link. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I453079ffe9900955a63caf3156ef2bfbc9188410 Reviewed-on: https://chromium-review.googlesource.com/1054220 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
-
xlai authored
To avoid confusion TBR=zakerinasab@chromium.org Bug: None Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9f1b5412790672b2792d004840bcca2fbf44c997 Reviewed-on: https://chromium-review.googlesource.com/1055753 Commit-Queue: Olivia Lai <xlai@chromium.org> Reviewed-by:
Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#558002}
-
Xianzhu Wang authored
Every call site is already passing an integral size to GraphicsLayer:: SetSize() but had to convert it to FloatSize. Also even if non-integral size was allowed, the fractional part was discarded instead of being covered by expanded layer size: https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/graphics/graphics_layer.cc?rcl=8b66f9ce6dced8ecb247d89105008867a273c698&l=1018 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ieba3dd0f1857bf6e4f0430740deaa0885bdbe8b1 Reviewed-on: https://chromium-review.googlesource.com/1055605Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#558001}
-
Kevin Bailey authored
Within the chrome://omnibox results page, adds a column that shows whether the match's URL matches an open tab, but only when 'Show all details' is selected. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9ac6e0cecf2e95593c863f4c762ba189c470d917 Reviewed-on: https://chromium-review.googlesource.com/1055619 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#558000}
-
Daniel Nicoara authored
Floating point rounding errors on ARM64 is causing a few pixel tests to have small variations from the base image. Define the fuzziness to have them pass. BUG=b:79372424 TEST=Ran cc_unittests on ARM64 device and verify they pass. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I47e7600313ea784723f1270ef7c6ea88e029e92c Reviewed-on: https://chromium-review.googlesource.com/1055820 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#557999}
-
Carlos IL authored
crrev.com/c/1055647 had an experiment name mixed up with the study name, fixing that. Change-Id: Id140d3aff38f2e96ae279651bcd3709cd4278114 Reviewed-on: https://chromium-review.googlesource.com/1055686Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#557998}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I30b80115ca4db9d23ecec6941f46b730e207bab5 Reviewed-on: https://chromium-review.googlesource.com/1055859 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557997}
-
CJ DiMeglio authored
This CL allows for the proper handling of context lost during video playback. Previously, if we lost the context while running video with cc::Surfaces enabled, we experienced a crash. With this CL, we request a new context_provider upon loss, and prevent frame submission until it is regained. The effect of this is that we seamlessly continue video playback once the context_provider is regained. Bug: 768565 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I503cacd01c0a819408e813109e5e2e03c673dd13 Reviewed-on: https://chromium-review.googlesource.com/1050801Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#557996}
-
Caleb Rouleau authored
Also upload chromedriver symbols to symbol server. Also add PRESUBMIT for FILES.cfg to prevent syntax errors like I made last time. Also fix the overall chromium PRESUBMIT to not try to run a PRESUBMIT_test.py that doesn't exist. (This was regressed by https://chromium-review.googlesource.com/c/chromium/src/+/966906 and then partially fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1015976 ) It was hitting this line: https://cs.chromium.org/chromium/tools/depot_tools/presubmit_canned_checks.py?q=%22files,+found+none+that+matched%22&sq=package:chromium&dr=C&l=511 "Out of %d files, found none that matched w=%r, b=%r in directory %s" Bug: 835950 Change-Id: I365204bb87e6f642c12ee03a646b28d28cc4abab Reviewed-on: https://chromium-review.googlesource.com/1054967Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#557995}
-
Sadrul Habib Chowdhury authored
Add a couple of investigative dumps to understand better where and how a large number of LatencyInfo objects are accumulating. BUG=834421 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ieea6e47c4a1acf5c89384048e19b742e3e21e5a8 Reviewed-on: https://chromium-review.googlesource.com/1054153Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#557994}
-
Ryan Sleevi authored
The hardcoded list of CT logs is only safe for clients that support regular updates and the capability of rapid updates, such as Google Chrome. Hardcoding a list log logs in products that are not regularly updated runs the risk of ossifying or fragmenting the CT ecosystem. To avoid accidental misuse, move from //net into //components/certificate_transparency, moving it further away from the notion as a "base service" and more into "an optional component with caveats". BUG=702062 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6be05436a916779bd5c8fcf7fe93b120bda47828 Reviewed-on: https://chromium-review.googlesource.com/1052073 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Eran Messeri <eranm@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557993}
-
Sadrul Habib Chowdhury authored
Add a speculative fix in SurfaceAggregator::Aggregate() to make sure it doesn't accumulate too many LatencyInfo objects. BUG=834421 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifd41d901050a954279b642cab972ca6ec6d560e2 Reviewed-on: https://chromium-review.googlesource.com/1053793Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
-
Nico Weber authored
Currently, generate_library_loader generates an #include line looking like: #include "out/Debug/gen/library_loaders/libudev1.h" Since this contains the (variable) name of the build dir, these files can't be cached by goma. Instead, rely on the header always being next to the cc file in practice (and add a check enforcing that), and use: #include "libudev1.h" Similarly, use LIBRARY_LOADER_LIBUDEV1_H_DLOPEN instead of LIBRARY_LOADER_OUT_DEBUG_GEN_LIBRARY_LOADERS_LIBUDEV1_H_DLOPEN as guard macro name. No intended behavior change. Bug: none Change-Id: I90dfe365e07ecc7df22d48f7ae05bc525d665dd5 Reviewed-on: https://chromium-review.googlesource.com/1054523Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#557991}
-
