- 23 Oct, 2019 40 commits
-
-
Jinsuk Kim authored
- Set the position of security icon right in preview tab header in RTL mode. - Using LinearLayout for compositor resource caused a problem in large text mode for accessibility. Reverted the caption layout back to FrameLayout, and manually adjusts the position of text view to give room for the security icon when #overlay-new-layout is enabled. Bug: 1015324, 1015300 Change-Id: Id249fec7e7447c13a60ecfbf4e4b50c4182f280b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868564 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#708472}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/308277131853..ea58518db3b8 Created with: gclient setdep -r src-internal@ea58518db3b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: None Change-Id: I9c23192d72e50dfc52c900551c6c3235582e9e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874622Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708471}
-
Dana Fried authored
Previously, label buttons could shrink down to elide some of their text (assuming elision is on) but would still report a minimum size equal to their preferred size (i.e. with all text visible). Since label buttons with elision can indeed shrink below their preferred size it makes sense for them to be able to report their actual minimum size. Change-Id: I888554bb98be6da94191fd63194d6738b2690d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874049Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#708470}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ie3cd49194cf24e55d9c34298e9e2794aeba73c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874820Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708469}
-
Xing Liu authored
The actual Chime implementation glue code lives in downstream. The public Chrome apk or app bundle only builds an empty one. We use enable_chrome_android_internal to select the correct build target. Bug: 1013386 Change-Id: Iddde5fa2c466724c94bee504abc72b0facd39b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872721Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#708468}
-
Xiaoqian Dai authored
Primarily for PM/UX testing. Currently it's still disabled by default. Bug: 997885 Change-Id: Ic2c0c3792923631056de415b6b3f23b70500c605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873289Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#708467}
-
Jinsuk Kim authored
The method is called by a class in chrome.browser.tab package in production code. Makes it a private-package method. Bug: 995903 Change-Id: I5f8b73200ae4a3c966b140a44e63cfc991f9b249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872079Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#708466}
-
Kent Tamura authored
This CL removes the following runtime flags: - ElementInternals - FormAssociatedCustomElements - FormDataEvent They have been enabled since M77, and M77 stable had no critical issues on these features. Change-Id: I13ae205072c745bc7c6e334161fa55537fff25e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874987Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#708465}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I2b0cda4f8db7d999493d8f8e2b4aa9f8496d5a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708464}
-
Jeff Yoon authored
Replicating GN Args from ios13-beta-sim Change-Id: Ide4590d5bef1b195bf0b1570fef6d76623428919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865044Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#708463}
-
K Moon authored
Instead of applying rotation layout changes immediately, rotations will compute and propose the new layout to the JavaScript layer using the "documentDimensions" message. At that point, the JavaScript layer will have the chance to compute a new zoom level (such as for various "fit-to-X" options) before the rotation is applied by posting back a "viewport" message. The overall effect is to eliminate a distracting visual flash when the rotated layout is applied immediately, followed by a zoom adjustment once the layout change is passed to the JavaScript layer. Layout changes are divided into two types: Immediate layout changes reflecting changes in the PDF plugin's state (such as new pages), implemented by RefreshCurrentDocumentLayout(); and deferred layout changes reflecting user requests (such as rotations), implemented by ProposeNextDocumentLayout(), followed by ApplyDocumentLayout(). There are two particularly subtle edge cases: 1. Layout proposals must not be skipped if there would be no change in the layout, as asynchronous layout implies proposals may still be in flight. Proposals care about the future layout state, not the current layout state. 2. Applying a layout may trigger notifications back to JavaScript, which could trigger further layout applications. The implementation must be careful not to enter an infinite loop. For simplicity, this implementation redundantly computes layout at many points. Improvements in this area are deferred to crbug.com/1013800. Bug: 885110 Fixed: 885110 Change-Id: I7b43bd3409eb14159cbd5eb5d3efbd393878257f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747170Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: K Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#708462}
-
dpapad authored
This method is using /deep/ which only worked in Shadow DOM v0. Extensions has been using SDv1 since M72, and this test is silently doing nothing (does not find any iron-icons to assert on). Fixed: 885401 Change-Id: I1ba5836bb0109337e1439f30453094d65089e822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864018Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#708461}
-
Simon Que authored
CI builders: - Linux ASan LSan Builder - Linux TSan Builder Try builders: - linux_chromium_asan_rel_ng - linux_chromium_tsan_rel_ng - gpu-try-linux-nvidia-rel - linux-rel See planned migration schedule: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 R=agable@chromium.org, bpastene@chromium.org, jbudorick@chromium.org, tikuta@chromium.org Bug: 950413 Change-Id: Idd0005d75f07245f52097315e062488845d579d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871709Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#708460}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e9c6aa24..224f10ee Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0fa1f7e4c147fa1596a632e7a25fa18103b5ac21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874443Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708459}
-
David Dorwin authored
Added for Mandoline in https://crrev.com/1431133003, they are no longer used. Change-Id: I831d9167ab7dae7debcb23da8aa2dfa964c2c127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867181Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#708458}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/05691ddbd2bc..c04792ebef46 git log 05691ddbd2bc..c04792ebef46 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 mbonadei@webrtc.org Component Build support for api/task_queue:task_queue_test. 2019-10-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fc69c6f5..83bb172f (708204:708314) Created with: gclient setdep -r src/third_party/webrtc@c04792ebef46 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I08e9c32fc9b70d297e8d3f8bf28080e0089d9870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874616Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708457}
-
Sara Kato authored
Change-Id: Ic6be666880d54dba30293c6a4142e4a7a3fe43cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871789 Commit-Queue: Sara Kato <sarakato@chromium.org> Auto-Submit: Sara Kato <sarakato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
Mitsuru Oshima (slow) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#708456}
-
David Grogan authored
We were stretching items that had auto cross margins. This patch sets a flag on FlexItem when it needs relayout due to stretching. It's not elegant but is also not intrusive. This reverts commit 2390edbd. Bug: 845235, 1015475 Change-Id: Iebefb670f2d3ae4047565077776a6d7a1ff2c2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867434 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#708455}
-
Marina Sakai authored
This CL replaces all the old GetSymbol with the new API created in CL1810511, and removes the difinition of the old GetSymbol. Bug: 715418 Change-Id: I3337dd98121f8e93102ea5839df870c8a97adf7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870158Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Marina Sakai <marinasakai@google.com> Cr-Commit-Position: refs/heads/master@{#708454}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/67fccdf0c90e..a834f39e2132 git log 67fccdf0c90e..a834f39e2132 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 ehmaldonado@chromium.org presubmit_support: Fix tests on Python 3. 2019-10-22 ehmaldonado@chromium.org depot_tools: Remove oauth2client. Created with: gclient setdep -r src/third_party/depot_tools@a834f39e2132 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1009814,chromium:1001756 Change-Id: I942ef37513095bfa1aa778eb7facb2ad1b84d5ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874642Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708453}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I7fc344032d336977a7ff80e398dc2fcee6ccd156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873630 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#708452}
-
Yusuke Sato authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/1fd712f839e2..4ed26a9a6564 $ git log 1fd712f83..4ed26a9a6 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 vsavu system_api: Add definitions for LockToSingleUser 2019-10-21 clarkchung system_api: Go proto bindings for runtime_probe 2019-10-10 yusukes Revert "system_api: Add num_cores_disabled to StartArcMiniContainerRequest" 2019-10-16 louiscollard system_api: Add allowlist_data u2fd flag Created with: roll-dep src/third_party/cros_system_api BUG=b:142144019 TEST=try Change-Id: I19e38e327f49ed6859168971667bd55445e9e88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874492 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#708451}
-
Torne (Richard Coles) authored
Log tags are automatically prefixed with "cr_" by the logging system, and may not contain dots as this often causes them to be stripped by our log sanitizers. This is now checked by presubmit, but there were many cases that predated the check. Therefore: - remove any "cr." and "cr_" prefixes from TAG values. - replace any remaining dots in TAG values with underscores. This CL has the few cases where presubmit checks required other changes to the file. Change-Id: I9fb92a5cea5d5a668f987775a0989a954c85c322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874588Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#708450}
-
Alex Gough authored
This converts IPC tags from a mixture of |int| and |unit32_t| to |class enum IpcTag| with no functional changes. Change-Id: I4bcece6f92d81851bc9fb8d9c00455012ccc811a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863575Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Auto-Submit: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#708449}
-
Matt Falkenhagen authored
This should have been part of r669741. Bug: 926114 Change-Id: I6d9b1be961bea2bdf4f476c307a455a07f02b45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870159Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#708448}
-
siyua authored
So that icon will not be highlighted if icon is hovered when animation is showing Bug: 932818 Change-Id: I2b894b48bcad73fb89739e3a551b1390e980f7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872729Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#708447}
-
Scott Violet authored
Two special cases that carry over from the old code: . LayoutDeprecatedFlexibleBox always started layout at an origin of 0, even when rtl. This gives the same behavior. . End is treated as start when rtl. BUG=1014884 TEST=fast/deprecated-flexbox/017.html Change-Id: I2d232efd0b84ab997e6262253869828d5a758eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872566 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#708446}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/be1fa7d8cddf..0b779a7c4e88 git log be1fa7d8cddf..0b779a7c4e88 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 geofflang@chromium.org GL: Emulate primitive restart when PRIMITIVE_RESTART_FIXED_INDEX is unavailable. Created with: gclient setdep -r src/third_party/angle@0b779a7c4e88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I8f522bbeeb0fbcf9dbf1e35ee7267cd6101f798f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874640Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708445}
-
Martin Barbella authored
This was inspired by crbug.com/970343, and the fuzzer catches that issue if its fix is reverted. Change-Id: I2a4037900e5c21c00b8625bdf0de4e0d349c6104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874687 Commit-Queue: Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#708444}
-
chrome://device-emulatordpapad authored
Replacing calls to the global device_emulator namespace with FireWebUIListener() and ResolveJavascriptCallback(). This is in preparation of migrating this page to Polymer3. Bug: 1015241 Change-Id: Ic77512ee3972bbe8957a293b7c1cb8082f40b9ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874586 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#708443}
-
James Cook authored
We rely on sync to provide the user's OS settings when setting up a new Chromebook. However, new devices are not guaranteed to be running the latest version of Chrome before the user's first login (it's a poor experience to have to wait to download a large OS update before being allowed to sign in). As part of go/split-settings-sync we are migrating OS prefs to new sync ModelTypes OS_PREFERENCES and OS_PRIORITY_PREFERENCES. We need to ensure that old clients still get synced updates for these preferences. When split sync is disabled, register OS pref names with the browser pref ModelTypes. This makes sync work just like it did before the split, and allows OS prefs to always be registered as SYNCABLE_OS_PREF, without conditionals on the flag. When split sync is enabled, register OS pref names with the PrefModelAssociators for both the new ModelType and the old ModelType. When a pref is changed locally, this sends updates to the sync server under both ModelTypes. However, when a sync change is received from the server we only apply the update if the change is for the new ModelType. We made a product decision not to sync updates from old clients to new clients. This helps avoid ping-pong updates between old and new clients. Bug: 1013466 Test: added to components_unittests Test: manually verified that new client with flag enabled sends updates to old client (M78), but old client changes are ignored on new client. updates Test: manually verified that client with flag disabled syncs updates in both directions with old client (M78). Change-Id: I04c494938d3526c57b8eb2f9c689acb0d4b0a3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865662 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#708442}
-
Alan Cutter authored
This CL updates label icons to no longer perform the text "slide" animation when the OS accessibility setting "prefers reduced motion" is enabled. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=417373&signed_aid=t0VJYHPUtkw0z1lDKkbiVA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=417374&signed_aid=5yX5WthdugQRYA75A6Ua8A==&inline=1 Change-Id: I79ede8bfec7c0c13b9678e2374ba16ec1aefee7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871504 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#708441}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7b3cc35cb6e5..c833c0c59253 git log 7b3cc35cb6e5..c833c0c59253 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 bryan.bernhart@intel.com D3D12: Enable sub-allocation for MSAA and non-MSAA textures. Created with: gclient setdep -r src/third_party/dawn@c833c0c59253 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I7afa2d590734a22f407f27afbf17d8ac1098ec7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874639Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708440}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6e9cdb62e782..1834bbb39c1c git log 6e9cdb62e782..1834bbb39c1c --date=short --no-merges --format='%ad %ae %s' 2019-10-22 wbbradley@chromium.org contrib: add a tool called updog.sh for finding package/board mappings 2019-10-22 vapier@chromium.org run_tests: support --py3/--py2 with --list 2019-10-22 tcwang@google.com afdo: Adapt to AFDO bits moving outside of Chrome ebuild. Created with: gclient setdep -r src/third_party/chromite@1834bbb39c1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia00354b395ee22f316de78e34c09433c45026480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874730Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708439}
-
Matt Mueller authored
This was already the case on macOS/iOS, but not on the other verifiers. Bug: 952091 Change-Id: I9819f17bc5d9695daf41aeb51b0494e7b6fafc97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872786 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708438}
-
My Nguyen authored
Change-Id: Ia7502b1b90e49b6e8e954db35bb86921c7210376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873811Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#708437}
-
Frank Tang authored
It will not need to parse the year string now. And it will not break while we switch on the harmony_intl_other_calendars flag Fixed: 1016909 Change-Id: I711d2553c29688576a252b610c101ba948f3a308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874491Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708436}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bef344f7017f..9f6271e66386 git log bef344f7017f..9f6271e66386 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 crouleau@chromium.org [Telemetry] Implement --story=<exact story names> flag. Created with: gclient setdep -r src/third_party/catapult@9f6271e66386 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:982027 Change-Id: I06d2207d70cd20c59fccd038e4b63c5047b7150d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874729Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708435}
-
Yusuke Sato authored
ARC container does not use the field and it will soon be removed from proto definition. BUG=b:142144019 BUG=b:143175953 TEST=try Change-Id: Ieabdbace116d9c70c35a031f0aee3fe648bdcd6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874580 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#708434}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8e8e4f75129b..308277131853 Created with: gclient setdep -r src-internal@308277131853 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I1baf448be5e3dd4c0d3b5917103b83bc86967456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873293Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708433}
-