- 03 Oct, 2019 40 commits
-
-
Andrew Grieve authored
Bug: 982762 Change-Id: If26bd60eaeda65d27870591908efc84981cc581f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836892 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#702580}
-
Hiroshige Hayashizaki authored
Follows https://github.com/WICG/import-maps/pull/180 that removes fetch scheme check in the spec. (Chromium already didn't have fetch scheme checks in other callers of `parse a URL-like import specifier`, so after this CL Chromium will fully align with the PR #180) Bug: 990561, 1011075 Change-Id: Ieb0c3f09ab1014d462b8ef7c898a5abe1afb5b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836972 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#702579}
-
Renjie Tang authored
Bug: 1005646 Change-Id: I3cf1a7210a0038b438d38cb375f813f4e8edf891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834026Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702578}
-
Nick Diego Yamane authored
In crrev.com/c/1813417 KeyEvent::ApplyLayout() has been modified so that it does not uses XEvent anymore, shifting the resposibility of extracting and setting DomKey/DomCode to components that translate XEvent into ui::Event. In case of ozone/x11 (and soon in Aura/X11, once it migrates its PlatformEvent to ui::Event, see crbug.com/965991), which happens in X11EventSourceDefault, which is also used in "CrOS on Linux" builds. In CrOS specifically, keyboard layout manangement follows a completely different code path and setting DomKey/DomCode at event construction causes regressions which prevent linux host keyboard layout to be used in CrOS interface. To fix it up, this adds a ifdef to not set DomKey/DomCode in CrOS. Bug: 1007389 Change-Id: Ie5c18e43625048d87583ccda275f7edca9ebc5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823795 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#702577}
-
Oystein Eftevaag authored
Also made the test a little bit more predictable. Bug: 1008387 Change-Id: I652a1032b3442bbfeed1d16e75b251e55e675221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837071Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#702576}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/608083b66e54..78c82a40409d git log 608083b66e54..78c82a40409d --date=short --no-merges --format='%ad %ae %s' 2019-10-03 sprang@webrtc.org Adds trial to always start probes with a small padding packet. Created with: gclient setdep -r src/third_party/webrtc@78c82a40409d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Id0ed2e8e5351049d8aa4c9eab0aa6481f30fc143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838518Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702575}
-
Joel Hockey authored
Static function IsEnabled is moved to be a member function of CrostiniFeatures to allow easier testing of the function, and easier testing of code which calls it. TBR=benwells@chromium.org TBR=calamity@chromium.org Bug: 1004708 Change-Id: If055e47932bcb21ccde84f92b5e8dac4e99e4e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827267 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#702574}
-
Julie Jeongeun Kim authored
This CL converts TcmallocTunables to new mojo types using PendingReceiver and SelfOwnedReceiver. Bug: 955171 Change-Id: I8860a39d62511c9e2e36943bcda37814476f7045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828673Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#702573}
-
Mohit Bansal authored
This CL adds a few tests to validate text extraction and accessibility tree for the newly enhanced accessibility support for PDFs. The tests added make use of an already available test file as well as add another test file. Bug: 981448 Change-Id: I821751efc9cf2c586c41ecdf29a071d95a52dd70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817857 Commit-Queue: Mohit Bansal <mohitb@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#702572}
-
John Budorick authored
Bug: 922145 Change-Id: Ibb6324e7a0a31bade8052da57cf29ae0c3020987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808788Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#702571}
-
Adam Langley authored
Results are in. Time to clean this up. Bug: 801302 Change-Id: Ie23c51edad45896920334f6666f02cecfac389c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832786 Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#702570}
-
Kevin Bailey authored
It appears that the arguments to a function have changed, without the comment being updated. This CL tries to update it. Change-Id: I42e9cb9306d4e844d9d13901a549c75617e002bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838432Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#702569}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1850492e30ce..c847a75f95be git log 1850492e30ce..c847a75f95be --date=short --no-merges --format='%ad %ae %s' 2019-10-03 shrekshao@google.com Fix redundant draw in DrawBaseVertexBaseInstanceTest Created with: gclient setdep -r src/third_party/angle@c847a75f95be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: chromium:3402 Change-Id: I812846ab5380f33e529efe395c9a69f46f1648e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838631Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702568}
-
Ahmed Fakhry authored
This CL fixes the top-chrome slide behavior in tablet mode for WebUI Tabstrips when the page is scrolled with touch gestures. This is handled by asking the BrowserView to give us a list of all its attached NativeViewHosts (such as the active tab's webcontents' and the WebUI tabstrip WebView's) so that we can transform the layers of their native window containers. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=1003122#c14 BUG=1003122 TEST=Manual, Expanded existing tests. Change-Id: I90ae377235219ec7cfc1a0213d88648b7d9dc179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836382Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#702567}
-
Dmitry Gozman authored
- Unused: HttpBody(), ErrorCode(), SetTickClockForTesting(), previews_state(). - Exposed for testing, but can be retrieved elsewhere: GetIPAddressSpace(). - Now passed to the single caller directly: WasBlockedAfterCSP(), AppcacheHostId(). Bug: none Change-Id: If0914a9e536d2cc64acb5ce1442bc86e9bc45b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833787Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#702566}
-
John Lee authored
- When the tab strip is closed, the newly activated tab should be moved to the beginning of the list. - When the tab strip is open, the newly activated tab should just be scrolled to. - Whenever the tab strip switches from visible to hidden, the active tab should be moved to the beginning. The idea is what when a tab is activated, the tab strip will close and the active tab will be then be moved to avoid jumping while the tab strip is animating in and out. - Regardless of whether or not the tab strip is visible, newly created active tabs should be created at the beginning of the list to enforce the MRU model. - Disable drag and drop for unpinned tabs. Bug: 1005554 Change-Id: I35f16ae111d949326533f45ce1d9494f578b774e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829555 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#702565}
-
Regan Hsu authored
* Update update_engine_client to accept (from Dbus) and provide specific eol date. * Update eol notification to show 3 eol notifications (6 month, 3 month, Eol). * Wrap notifications in a base::Feature, default-enabled flag. * Do not show notifications if user is managed. Integration test is at https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1834921 Design Doc: https://docs.google.com/document/d/10xiHcl2WT1jWYinFhX677N2B8r08jFFK4iHi0252nf8/edit?usp=sharing Bug: 998983 Change-Id: I1b6af1375909bdf59970931ca066c43c245499c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775160 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#702564}
-
John Abd-El-Malek authored
The Shell C++ class isn't used on Android (unlike in content_shell) because we want to consume WebLayer there using the idiomatic Java API. At the same time, we want to write browser tests the same way for all platforms. So fake this by creating a Shell that reuses the existing BrowserController class that was created by Java. Change-Id: I946957f39eb79cff2e84c8abda56eed98b28d0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815884Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#702563}
-
Reilly Grant authored
In r678566 the type converter for UsbDeviceInfo was removed and a UsbDevice now owns its own UsbDeviceInfo that is provided to consumers. In so doing the active_configuration field of that UsbDeviceInfo is no longer updated when ActiveConfigurationChanged() is called. This exacerbates issue 1009886 because now more platforms appear to start with no active configuration selected and causes issue 1003561. Bug: 1009886,1003561 Change-Id: Ib63c591aed33f0041b4b5cb384106c8cd34a9632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836355Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#702562}
-
Tibor Goldschwendt authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/2ecd66c696c4..93a34f0ec19e $ git log 2ecd66c69..93a34f0ec --date=short --no-merges --format='%ad %ae %s' 2019-10-01 tiborg Add assets and copy target for extra ICU data file Created with: roll-dep src/third_party/icu TBR=jshin@chromium.org Bug: 1006794 Change-Id: Ia47475f5a11e9ffc9cb51ae61f6ea0e7c934869b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838356Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#702561}
-
BUG=762641 TBR=rkc@chromium.org Change-Id: I773ca832b861fe8e87548798c0f0ae8b65abda1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838672Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702560}
-
Andrew Xu authored
It is a regression issue introduced by the CL on Hotseat. When the flag is disabled, the init of DelegateView returns early then it fails to set the layout manager. Bug: 1009609 Change-Id: Id53ee51556e10d60985abcabbbcba186d5afcc01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838472Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#702559}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0f4ac587a4ae..e5c62b37f645 git log 0f4ac587a4ae..e5c62b37f645 --date=short --no-merges --format='%ad %ae %s' 2019-10-03 thestig@chromium.org Remove use of deprecated v8::V8::SetNativesDataBlob() in PDFium. 2019-10-03 thestig@chromium.org Roll third_party/googletest/src/ 3a4503986..f2fb48c3b (6 commits) 2019-10-03 thestig@chromium.org Roll third_party/icu/ 53f6b233a..2ecd66c69 (4 commits) 2019-10-03 thestig@chromium.org Roll third_party/depot_tools/ e5641be5f..e90e5fe20 (89 commits; 25 trivial rolls) 2019-10-03 thestig@chromium.org Roll third_party/catapult/ 884c81e17..830565958 (80 commits) 2019-10-03 thestig@chromium.org Roll third_party/jinja2/ 45571de47..b41863e42 (1 commit) 2019-10-03 thestig@chromium.org Roll tools/code_coverage/ b53d904eb..4a898be73 (7 commits) 2019-10-03 thestig@chromium.org Roll third_party/libjpeg_turbo/ baa5dc242..38c693569 (2 commits) 2019-10-03 thestig@chromium.org Roll third_party/zlib/ 8c79b6c8d..ddebad26c (2 commits) 2019-09-30 thestig@chromium.org Roll third_party/freetype/src/ 432efa25b..839a02361 (6 commits) Created with: gclient setdep -r src/third_party/pdfium@e5c62b37f645 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Ia2f3437d8c66884a1d7bb2a3418aa5df83635176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838413Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702558}
-
Dana Fried authored
Bug: 1004871 Change-Id: I5f656464715fafd5e29a86594418b8e5433bd143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836218 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#702557}
-
Gaoping Huang authored
- What is dagre? - Dagre is a graph layouting library used by the graph visualizer of web_audio. It implements several research papers about layouting graph. License: MIT license. Size: The size of dagre.js 323 KB. The core of dagre.js is 83 KB. Github repo: https://github.com/dagrejs/dagre - Why should we add Dagre as a module, instead of a folder under web_audio? - Dagre is used by both web_audio and web_audio_worker. Therefore, it seems better to be a module that can be used as a dependency. web_audio_worker is a Web Worker that runs `dagre.layout()`. For more information about web_audio and web_audio_worker, here is a link to the POC CL: https://chromium-review.googlesource.com/c/chromium/src/+/1744801 Bug: 974343 Change-Id: Id81de6c171f64781baefac92abb79b691eee57a7 Tricium: disable Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749643Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#702556}
-
Francois Doray authored
Documenting the opt-out in preparation for sending the Intent to Ship which will link to this page. Bug: 980533 Change-Id: I3979d5a910ba75447b8b6dca0cf1ed0c63877c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837086 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#702555}
-
Koji Ishii authored
|InlineBoxPainterBase::::GetBorderPaintType| uses |NGPaintFragment| only to check if the fragment has a parent. |InlineFlowBoxPainter| has the same check, but painters should be created only if it is in the tree, so this check should pass. I could not figure out when and for what this check was added to |InlineFlowBoxPainter|, but if we can add the same check back if this turned out to be really needed. Also changed the function to: * Use early-return style. * Set |adjusted_clip_rect| only when it is needed. Bug: 982194, 988015 Change-Id: I9d2731acb0fb648ebf53f4cbf72475f4724aa7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832856Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#702554}
-
Sven Zheng authored
This filter will be applied to the internal bot. TEST: With this filter all tests can pass. Bug: 1010568 Change-Id: I046d3f58663c5fde47ac8fb3d099099253dd108f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836139 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#702553}
-
ziyangch authored
Bug: internal b/137872139 Test: Cast from Google Play Music, YouTube to Android TV. Change-Id: I5027e742bbe74187c6590ac6d478df92cdf9d8f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829548Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Cr-Commit-Position: refs/heads/master@{#702552}
-
Peter Wen authored
For //src/components/module_installer/OWNERS. Bug: None Change-Id: I514d999285073fca97683f70eb03bb8d31d089d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838296 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#702551}
-
Manu Cornet authored
Deprecate the |IsVisible| method, which is very ambiguous. Change-Id: I57185f589f338b23573142723ae81ebb75c571c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837251Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#702550}
-
Sergey Ulanov authored
This reverts commit ef78a44e. Reason for revert: input node is still needed. It worked correctly without due to a bug in Scenic. Original change's description: > [Fuchsia] remove input node from ScenicWindow > > Input node doesn't do anything. Scenic directs input events to > the Browser's session, since this is the session that owns the View. > > Change-Id: I34337c8dc98668fd432fb0ac413e19dbc9338b92 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704940 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Michael Spang <spang@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678057} Bug: fuchsia:37760 Change-Id: Ife02bdda703c00ed982b53230994ef1f90f7e867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838379Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#702549}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 79-3904.12-1569231291-benchmark-79.0.3923.0-r1 to 79-3904.19-1569836348-benchmark-79.0.3923.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I9bbea46e2184c4af73ee48ad02188eb5c0ac96e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838294Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702548}
-
Brian Sheedy authored
Makes maps_pixel_test upload to Skia Gold instead of to a cloud storage bucket. This will make it easier to debug failures, as the images get uploaded to the same place as the regular GPU pixel tests. Bug: 1009137 Change-Id: Ia2f19f43efa216f551c0ea47c2018e9c67981b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834825Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#702547}
-
Rahul Arakeri authored
Mac doesn't |use-zoom-for-dsf|. Hence, the ScreenSpaceTransform needs to be scaled down by the device_scale_factor for hit testing to work as intended. Bug: 1003576 Change-Id: I049e5d06d4ed6859e3e5a88b7fb61b46e8175801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588948Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#702546}
-
Joshua Peraza authored
eb0c4726f13d linux: make GetHandlerSocket() params optional Change-Id: Iafdf02b6cd814c02aa1892a8fee1bafc20b0e7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838033Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#702545}
-
David Black authored
Previously only workspace occluded bounds were checked. This handled the default virtual keyboard case but not the floating virtual keyboard case. To handle both cases, we need to check visual bounds. Bug: b:140987575 Change-Id: I6d2012c28f1202181d5db27ab5dbea6b2f51952b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836665 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#702544}
-
Mark Pearson authored
Bug: 832926 Change-Id: I2be0237188ebfd7cf15e60f9187bff7deb8ef8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831465 Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#702543}
-
Daniel Nicoara authored
This causes the Webview channel to be terminated. Don't force the Webview to not function just because some functionality isn't present. Bug: b/142069294 Test: On device Change-Id: I5b7f44a179c6b916f6fba015c5949f743aa28c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838673 Commit-Queue: Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#702542}
-
Ahmed Mehfooz authored
Change-Id: I8938d8c8db0a3275f4cc272d980c2a09576eba7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836658 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#702541}
-