GitLab

With "--log_time" optional arg, we can see each logged event's
timestamp to know how long does a task spend.

BUG=None
TEST=manual ./run_benchmark with "-v --log_time" args added.

Review URL: https://codereview.chromium.org/1079443002

Cr-Commit-Position: refs/heads/master@{#330337}

glBindTexImage2DCHROMIUM and glReleaseTexImage2DCHROMIUM will force the
texture format in the level info to GL_RGBA regardless of the internal
format used by the GLImage.

This CL address this by adding a GetFormat function to GLImage that
glBindTexImage2DCHROMIUM and glReleaseTexImage2DCHROMIUM will use when
updating the level info.

BUG=

Review URL: https://codereview.chromium.org/1140683002

Cr-Commit-Position: refs/heads/master@{#330336}

Rules for invariant varying (or in/out variable) matching are different
for ESSL 3 and ESSL 1. Use a recently added ANGLE API to choose which
rules to use based on shader version.

Tested by WebGL 2 test deqp/data/gles3/shaders/qualification_order.html

BUG=488372
TEST=WebGL 2 conformance tests

Review URL: https://codereview.chromium.org/1135733006

Cr-Commit-Position: refs/heads/master@{#330335}

The only thing we need to know per QuerySync block is its
index in the block sequence. Everything else can be
calculated from that if we just store a few numbers in
the Bucket objects.

Total memory reduction is 92%.

This is alt #2 in bug 485536.

BUG=485536

Review URL: https://codereview.chromium.org/1131913004

Cr-Commit-Position: refs/heads/master@{#330334}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4472bfd..739db8a

TBR=

Review URL: https://codereview.chromium.org/1146613002

Cr-Commit-Position: refs/heads/master@{#330333}

Cr-Commit-Position: refs/heads/master@{#330332}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2dd4f36..4472bfd

TBR=

Review URL: https://codereview.chromium.org/1127123011

Cr-Commit-Position: refs/heads/master@{#330331}

Currently, socket pairs for the IPC channels (mainly for PPAPI IPC channels) are created in nacl_helper (and nacl_helper_nonsfi).
However, to make more secure, socketpair() will be prohibited in Non-SFI mode. So, this is its preparation.

TEST=Ran bots.
BUG=358417

Review URL: https://codereview.chromium.org/1051243002

Cr-Commit-Position: refs/heads/master@{#330330}

Original review: https://codereview.chromium.org/1011683002/

Reverted because it's suspected for following flakiness issues:
http://crbug.com/485157 - Windows race
http://crbug.com/485091 - Android ThreadWatcher
http://crbug.com/485178 - interactive_ui_tests Menu* tests

PS1 is the original patch set that gets reverted.

BUG=465458, 485157, 485091, 485178
TBR=jam

Review URL: https://codereview.chromium.org/1129953004

Cr-Commit-Position: refs/heads/master@{#330329}

This completes the check-in of hunspell code into the Chromium tree.

BUG=472897
R=brettw@chromium.org
TBR=phajdan.jr@chromium.org # for checklicenses

Review URL: https://codereview.chromium.org/1135173004

Cr-Commit-Position: refs/heads/master@{#330328}

BUG=489119
TEST=manually

Review URL: https://codereview.chromium.org/1129013005

Cr-Commit-Position: refs/heads/master@{#330327}

It is possible that when
ChromeWebViewGuestDelegate::HandleContextMenu() attempts to build a
menu to display that it will receive a null pointer (if the associated
web_contents' frame tree does not have a focussed frame). In the
current code this can lead to a crash. In the short term, while we
determine if this lack of a focussed frame is an error or not, early-out
if we receive a null menu.

BUG=487419

Review URL: https://codereview.chromium.org/1139193003

Cr-Commit-Position: refs/heads/master@{#330326}

The design doc pointed to is public on chromium.org, but the
Googler-only shortener is not.  Use a public one instead so
anyone can follow it.

BUG=

Review URL: https://codereview.chromium.org/899413002

Cr-Commit-Position: refs/heads/master@{#330325}

Cr-Commit-Position: refs/heads/master@{#330324}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/33ccde6..2dd4f36

TBR=

Review URL: https://codereview.chromium.org/1126393007

Cr-Commit-Position: refs/heads/master@{#330323}

BUG=488357

Review URL: https://codereview.chromium.org/1130763005

Cr-Commit-Position: refs/heads/master@{#330322}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0698cc2..33ccde6

TBR=

Review URL: https://codereview.chromium.org/1129353008

Cr-Commit-Position: refs/heads/master@{#330321}

Presumably during destruction, the RenderView can be destroyed before
the RenderFrame (since it only holds a weak pointer to it). We need
to check whether it is alive before clearing the plugin find handler.

BUG=487146

Review URL: https://codereview.chromium.org/1123393004

Cr-Commit-Position: refs/heads/master@{#330320}

FakeProfileStore now returns the real kProfileLastUsed (from the pref
store), instead of a dummy value. This means that tests for code that
sets or manipulates the kProfileLastUsed pref will behave correctly.

AppListServceUnitTest.RemovedProfileResetsToInitialProfile now properly
tests the behaviour of RemoveProfile (that it clears kAppListProfile,
and that GetProfilePath returns the initial profile when kAppListProfile
is missing). Previously, it did not distinguish between the initial and
last used profiles.

AppListServiceUnitTest.RemovedProfileResetsToLastUsedProfileIfExists
also tests that the kAppListProfile has been set correctly.

BUG=487951

Review URL: https://codereview.chromium.org/1134533007

Cr-Commit-Position: refs/heads/master@{#330319}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3340c79a..0698cc2

TBR=

Review URL: https://codereview.chromium.org/1130343004

Cr-Commit-Position: refs/heads/master@{#330318}

DynamicSocketDataProvider only has one consumer, FtpSocketDataProvider. This CL moves the functionality of DynamicSocketDataProvider directly into FtpSocketDataProvider.

Review URL: https://codereview.chromium.org/1137183005

Cr-Commit-Position: refs/heads/master@{#330317}

All the ARM linux builders already specify this, and
armhf is the now the default for both Ubuntu and Debian.

Followup cleanup cl for the bots:
https://codereview.chromium.org/1141643004/

BUG=308256

Review URL: https://codereview.chromium.org/1140503004

Cr-Commit-Position: refs/heads/master@{#330316}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e3dad87..3340c79a

TBR=

Review URL: https://codereview.chromium.org/1135763005

Cr-Commit-Position: refs/heads/master@{#330315}

Review URL: https://codereview.chromium.org/1123393005

Cr-Commit-Position: refs/heads/master@{#330314}

This reverts https://codereview.chromium.org/1129103005/ , which turned
them off.  Now what all [blink-gc] warnings are fixed, we can turn them
on again on the warnings-as-errors 64-bit builds.

BUG=486571,467287
TBR=hans

Review URL: https://codereview.chromium.org/1131333003

Cr-Commit-Position: refs/heads/master@{#330313}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bd46509..e3dad87

TBR=

Review URL: https://codereview.chromium.org/1135323003

Cr-Commit-Position: refs/heads/master@{#330312}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2e4c5505..57cf87de

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1144743002

Cr-Commit-Position: refs/heads/master@{#330311}

ignored_directories assumes that the path separator is /.

(https://codereview.chromium.org/1072203002 did the same
change for the style plugin.)

BUG=486571

Review URL: https://codereview.chromium.org/1130823005

Cr-Commit-Position: refs/heads/master@{#330310}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/21445b8..bd46509

TBR=

Review URL: https://codereview.chromium.org/1128923007

Cr-Commit-Position: refs/heads/master@{#330309}

This code is inlined all over the place, however, there's no good
location to put it. Just factoring it out in two places, however,
doesn't really make sense, so don't do it

R=mkwst@chromium.org
BUG=478250

Review URL: https://codereview.chromium.org/1141993002

Cr-Commit-Position: refs/heads/master@{#330308}

If a link has target=_blank we don't navigate to it, but create a new tab,
and then navigate to it. To be able to write a layout test for the policy used to create the new tab, I need to dump it here too

BUG=454222
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/1129203005

Cr-Commit-Position: refs/heads/master@{#330307}

LayerTreeAsJson is useful during debugging of layer tree operations.
Adding the layer id into the information for the layer currently being
serialized. This helps the function be more usable as user knows which
layer he is looking when checking the json.

BUG=None

R=danakj,enne

Review URL: https://codereview.chromium.org/1140913002

Cr-Commit-Position: refs/heads/master@{#330306}

BUG=323462

Review URL: https://codereview.chromium.org/1128963004

Cr-Commit-Position: refs/heads/master@{#330305}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ae8e195..21445b8

TBR=

Review URL: https://codereview.chromium.org/1144723002

Cr-Commit-Position: refs/heads/master@{#330304}

Cr-Commit-Position: refs/heads/master@{#330303}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/573d924..ae8e195

TBR=

Review URL: https://codereview.chromium.org/1138003008

Cr-Commit-Position: refs/heads/master@{#330302}

    to receive the ack on browser/.

We perform a sanity check upon background page ACKing an event,
    by checking whether the ACKed message is expected to
    be ACKed. We store the pending ACK message IDs into a set
    |unacked_messages_|, but due to PostTask call to
    IncrementInFlightEventsOnUI, the event ack might arrive earlier
    than storing the pending message's ID. This results in incorectly
    kill the renderer process.

BUG=485440, 473821
Test=Rise Vision chrome app shouldn't crash anymore.

Review URL: https://codereview.chromium.org/1138643010

Cr-Commit-Position: refs/heads/master@{#330301}

When drmemory_full runs, the browser tests are slowed down enough to
timeout the user gesture indicator, which prevents autofill from
processing the input and passing the browser test. The fix is to disable
user gesture checking for all autofill browser tests except
AutofillRendererTest.IgnoreNonUserGestureTextFieldChanges.

TBR=thestig@chromium.org,estade@chromium.org
BUG=484910

Review URL: https://codereview.chromium.org/1143593003

Cr-Commit-Position: refs/heads/master@{#330300}

clang can't handle dllexported classes with only member initializers yet
(see crbug and http://llvm.org/PR23542). As a workaround, don't dllexport
this class.  This has the effect of emitting the class's constructor into
every translation unit that uses it instead of just every translation unit of
the media component, but in a way that seems nicer anyways since there's no
.cc file for this header and so currently this relies on some translation unit
in media including this header by lucky accident (else the constructor wouldn't
be defined anywhere.)

Once the clang bug is fixed we can consider adding this back; in the meantime
this seems like a tiny price to pay to get the bots back green.

Also add the .h file to the relevant gyp/gn files, else the analyze
step will make the trybots think that nothing changed when this
.h file is touched.

BUG=488634,467779
TBR=sandersd

Review URL: https://codereview.chromium.org/1133423003

Cr-Commit-Position: refs/heads/master@{#330299}

Cr-Commit-Position: refs/heads/master@{#330298}