- 16 Mar, 2018 40 commits
-
-
Donn Denman authored
Adds new feature signals from Blink about the page at the location tapped. These signals will be useful for deciding whether to trigger Contextual Search. Signals include the text run-length of the element tapped and the effective font size. BUG=754862 Change-Id: I02227479ecfae4d3b174a1845fed7c3d24e355b8 Reviewed-on: https://chromium-review.googlesource.com/920325Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#543713}
-
Peng Huang authored
Bug: 811661 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I02a7aa880ad407afe0dc2c79e8a99be90bd59bd8 Reviewed-on: https://chromium-review.googlesource.com/960582 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#543712}
-
Geoff Lang authored
Timeouts are seen accross most of the builders. TBR=iannucci@chromium.org NOTRY=true BUG=820190 Change-Id: Id7122242be4fcfe34893a305c32fa4d05f49a80b Reviewed-on: https://chromium-review.googlesource.com/966588Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#543711}
-
Adam Langley authored
AuthenticatorImpl doesn't support the callbacks being made immediately. Instead, defer them via the current MessageLoop. Change-Id: I57b43049e8dca8e1d113f86eb1ea5728e7d953a8 Reviewed-on: https://chromium-review.googlesource.com/963096Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#543710}
-
Fredrik Söderquist authored
Move the 'href' lookup to a helper function (as seen in the very similar SVGGradientElement.) Use a similar setup in SVGGradientElement equivalent method. Move attribute synchronization from LayoutSVGResourcePattern into SVGPatternElement::CollectPatternAttributes. Change the SetPatternAttributes helper to take a SVGPatternElement reference. Remove the element null-check in the LayoutObject. Bug: 769774 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I16901de05437bbeea1981f5340bec1a3e4329b50 Reviewed-on: https://chromium-review.googlesource.com/966221Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#543709}
-
Chris Hamilton authored
This thread was recently removed, and is no longer used. BUG=815225 Change-Id: I11e14933e9f30791be835034f59296bdbbedb708 Reviewed-on: https://chromium-review.googlesource.com/963597Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#543708}
-
https://skia.googlesource.com/skia.git/+log/bcc00b2a612c..6e9a4f6327d1 $ git log bcc00b2a6..6e9a4f632 --date=short --no-merges --format='%ad %ae %s' 2018-03-15 egdaniel Make TestForPreservingPMConversions helper use lazy createTextureProxy call. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I7473d080bb9cc0c855a6b1d6f1c5da809e65853c Reviewed-on: https://chromium-review.googlesource.com/965616 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543707}
-
Eero Häkkinen authored
Bug: 822721 Change-Id: If0d5768d344580ce7da3b8cf07eaacece34614eb Reviewed-on: https://chromium-review.googlesource.com/962141 Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#543706}
-
Biao She authored
This CL fix text wrapping issue. It also fixes text in Buttons do not transform to upper case. Bug: 814988 Change-Id: I1ba4d4270f5cf0d315ddf9aad4c7c3171be020e2 Reviewed-on: https://chromium-review.googlesource.com/964990Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#543705}
-
Sahel Sharify authored
https://chromium-review.googlesource.com/904547 hasn't fix the crashes. This cl checks the validity of the event router before sending the wheel end events. Bug: 791963 Change-Id: I5af23c24e5dcd9a8351ba00a8fdcfde4e2109b7d Reviewed-on: https://chromium-review.googlesource.com/964736Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#543704}
-
Greg Kraynov authored
Change-Id: I52aee8a9046f00dd2d61a8361724ffacddd51677 Reviewed-on: https://chromium-review.googlesource.com/964664 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#543703}
-
Ramin Halavati authored
Traffic annotations FYI bot cannot access some files in build_path/gen. Some Debug data is added to find out why? TBR=msramek Bug: 690323 Change-Id: I4fb716d8b843704bf48cfbb62d5b09a3791eb732 Reviewed-on: https://chromium-review.googlesource.com/966303Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#543702}
-
Emily Hanley authored
Bug: 821873 Change-Id: I957926f214481ece2f9fba1d8d6357e0b61377a5 Reviewed-on: https://chromium-review.googlesource.com/964597Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#543701}
-
Raphael Kubo da Costa authored
external/wpt/FileAPI/BlobURL/test1-manual.html and external/wpt/FileAPI/BlobURL/test3-manual.html were removed in https://github.com/w3c/web-platform-tests/pull/8612 external/wpt/quirks-mode/active-and-hover-manual.html was renamed in https://github.com/w3c/web-platform-tests/pull/8895, and the new name is now in NeverFixTests. Change-Id: I04804bfc5f9a3d37b44e5bc0f45308e6fe8bd639 Reviewed-on: https://chromium-review.googlesource.com/966289 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#543700}
-
Kevin Bailey authored
Just making const some things that can be made const. Primarily stemming from template_url_service. Change-Id: If7e368a15fcf3ada82c074f808de5fa8b7c4a878 Reviewed-on: https://chromium-review.googlesource.com/959055 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#543699}
-
Koji Ishii authored
Following bot results are included. 4203 4207 4215 4216 4218 4221 4224 4227 4229 4230 4232 4235 4236 4237 4239 4240 4250 14 lines were removed and 35 lines were deflaked by consecutive results since 4203. 4211 was manually excluded because it has 32 unexpected passes, and it is questionable. Probably it was a flaky run. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5da2f53155dbd38fcd8a4c80a05b4ee564334ec8 Reviewed-on: https://chromium-review.googlesource.com/964025 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#543698}
-
Adam Parker authored
Change-Id: If60cff3630b80ca0002287b600dd0ad31fe9d183 Reviewed-on: https://chromium-review.googlesource.com/964797Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Adam Parker <amp@chromium.org> Cr-Commit-Position: refs/heads/master@{#543697}
-
Robert Ma authored
Ideally, we should respect users' PATH when searching for Chrome binary. For now, change the order of search paths to a better approximation of the most common defaults across Linux distros. In particular, try Chrome's default installation location AT LAST, so that symlinks created by tools like update-alternatives are tried first, which means honoring users' preferences of Chrome channels. Change-Id: Ic77e439d3a3b428194af45b38bb85cfbb8a97508 Reviewed-on: https://chromium-review.googlesource.com/965444Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#543696}
-
Kevin Bailey authored
I suspect that a test wasn't timing out due to slowness, but in fact because a SINGLETON navigation was switching instead, and not waking up waiting observers. This CL adds an explicit 'wait' parameter for choosing (instead of relying on disposition). It also splits up the respective test into SINGLETON and SWITCH_TO_TAB versions (they're orthogonal) and cleans up some comments. Bug: 822071 Change-Id: I241478b7a566b0e843f92b091d8f090ffbf9011c Reviewed-on: https://chromium-review.googlesource.com/964386 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
-
Jeremy Roman authored
It is only used to printf to a FILE*, which <cstdio> already does. Change-Id: I05965cafca27d918858716ed624358a506119b96 Reviewed-on: https://chromium-review.googlesource.com/965383Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#543694}
-
Jeremy Roman authored
Now that move semantics exist, std::sort should work fine. Change-Id: I47e017da1d1d9189fac65f319859d89b455090ca Reviewed-on: https://chromium-review.googlesource.com/963983Reviewed-by:
-
Michael Lippautz authored
This fixes tests when run with enable_blink_heap_verification which checks that all marked objects on the heap have their children marked too. This is not the case for these kind of unittests. Bug: chromium:757440 Change-Id: Ie92761b7619dcf2f16fba7c2a3d3e6b0b10b0afd Reviewed-on: https://chromium-review.googlesource.com/966401Reviewed-by:
-
Avi Drissman authored
Allow it to traverse <webview> and allow the mode to be specified. BUG=659753, 819773 Change-Id: I45aaf11b6f91481a65ce40790e4e5d785c23ec1b Reviewed-on: https://chromium-review.googlesource.com/956301Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#543691}
-
Elly Fong-Jones authored
This change: 1) Allows SessionCrashedBubbleView to anchor to a rect instead of a view; 2) Has it use a rect when a Cocoa browser window is in use; 3) Has SessionCrashedBubbleViewTest use a rect when a Cocoa browser window is in use too Bug: 653966, 817408 Change-Id: I89d6327cc4df09e870891ace0b9cca151235051a Reviewed-on: https://chromium-review.googlesource.com/961501 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#543690}
-
Alexander Timin authored
After patch 954622 blink style checker started checking scheduler code. Make scheduler code mostly conform to this standard. Add exception for readability/control_flow as in many places scheduler code is easier to read without it. R=dcheng@chromium.org CC=tkent@chromium.org Change-Id: I167ad10f089f56fd3e86d41f2a6aa07b23801557 Reviewed-on: https://chromium-review.googlesource.com/964641 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Ramin Halavati authored
A removed annotation is marked deprecated. Bug: 656607 Change-Id: Ie0d56b6d6218cb261fd691b9e7b2eeaed9a352ab Reviewed-on: https://chromium-review.googlesource.com/966382Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#543688}
-
Daniel Bratell authored
third_party/llvm-bootstrap-install is sometimes created by tools/clang/update.py and should not disturb git. Change-Id: Id30390bc0e15e69661828f0124c08475539e3490 Reviewed-on: https://chromium-review.googlesource.com/966421Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#543687}
-
Reza.Zakerinasab authored
Bug: 820701 Change-Id: Ic4d4f28c9b34c41f22ff2f4daca25128f2fdf987 Reviewed-on: https://chromium-review.googlesource.com/964927Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#543686}
-
Fredrik Söderquist authored
Gradient resources are currently only using the 'linked' resource in the SVGResources object for cycle breaking and change notifications. The SVG*GradientElements also perform cycle breaking on their own, disregarding what SVGResourcesCycleSolver has done. The 'href's themselves are what risk introducing cycles for gradients at the moment, so handling them explicitly (as is already done) doesn't add any additional complexity. Mixing resources defined by the DOM with those defined by style does add complexity though. This CL stops tracking <*Gradient> href's using SVGResources, and starts tracking them using an IdTargetObserver in SVGGradientElement, much like how similar 'href's are tracked. Bug: 661598, 769774 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5538ede4170c7181098fe2308dbfa640506334f4 Reviewed-on: https://chromium-review.googlesource.com/880965 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#543685}
-
Michael Lippautz authored
With these annotations the corresponding global handles now have names in DevTools, making it easy to identify where a context is held alive. Bug: chromium:811842 Change-Id: I10df68d3024a07744e7f18a27f7c07700545a803 Reviewed-on: https://chromium-review.googlesource.com/962789Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#543684}
-
Alexander Timin authored
Post a control task to call RequestBeginMainFrameNotExpected asynchronously to avoid calling it when frame tree is dirty. R=yutak@chromium.org,dcheng@chromium.org,haraken@chromium.org BUG=820893 Change-Id: I375aa46180f20f053c13563df910d3813c22938f Reviewed-on: https://chromium-review.googlesource.com/962787Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/79b300af..386975ac Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I029b29a6b59d16e72218b1fc23ebf6fc888918c9 Reviewed-on: https://chromium-review.googlesource.com/965927Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#543682}
-
Geoff Lang authored
TBR=zmo@chromium.org BUG=749748 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0d19ab8893767bf6752c3c67813e4d0354c5e5fe Reviewed-on: https://chromium-review.googlesource.com/963070 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
Change-Id: I761e0bdd668bfcc99d03aab75cb148b83ffd4ba9 Reviewed-on: https://chromium-review.googlesource.com/965065Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#543680}
-
https://chromium.googlesource.com/catapult.git/+log/ca5cfb1a2e59..6733f341991f $ git log ca5cfb1a2..6733f3419 --date=short --no-merges --format='%ad %ae %s' 2018-03-14 perezju [soundwave] Add bug data to the database Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I7580de24cb1a10c323984d6bd5125d3304c202ab Reviewed-on: https://chromium-review.googlesource.com/965928 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543679}
-
https://skia.googlesource.com/skia.git/+log/36221f9377a7..bcc00b2a612c $ git log 36221f937..bcc00b2a6 --date=short --no-merges --format='%ad %ae %s' 2018-03-15 rmistry Output fiddleout.json in bookmaker recipe Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Ic2898a0165336907592b89ca06ee6b241895a683 Reviewed-on: https://chromium-review.googlesource.com/965613 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Alexander Timin authored
Rename WebThreadCreationParams::SetThreadName to WebThreadCreationParams::SetThreadNameForTest to clarify that in non-test code thread name is inferred from thread type. R=kinuko@chromium.org,haraken@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I359cf449dba6cb2544f65a3624ecc6761c425f7f Reviewed-on: https://chromium-review.googlesource.com/964366Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Benoit Lize authored
Bug: 816837 Change-Id: Ic31994e78c18d35fec707746973658843851e759 Reviewed-on: https://chromium-review.googlesource.com/962783Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543676}
-
Chris Nardi authored
Since data URLs are same-origin, their CSSStyleSheet elements should be accessible without throwing a SecurityError. TaintsCanvas had an appropriate check for this, but was named incorrectly for this use case. Rename TaintsCanvas to CanAccessData, reversing the boolean condition, and use the new method in CSSStyleSheet::CanAccessRules. Bug: 813826 Change-Id: Ie49eecfca92af31f27a3584a64bf494083ef4742 Reviewed-on: https://chromium-review.googlesource.com/963401Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
-
Sergey Poromov authored
After recent change, DeviceSettingsService is created before DBusThreadManager is initialized. Because of that, DeviceOffHoursController never gets information about system time synchronization and doesn't apply OffHours mode. This change swaps DeviceSettingsService and DBusThreadManager creation. Bug: 822227 Test: Trybots + manual test that OffHours are now applied. Change-Id: I8a00cbbc53add056da4296123e9bfadd461eca94 Reviewed-on: https://chromium-review.googlesource.com/964522 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#543674}
-
