- 22 Sep, 2020 40 commits
-
-
Melissa Zhang authored
This CL adds a condition that hides the "More Apps" section when there are more than 1 but less than 8 targets. Bug: 1130406 Change-Id: Id94069d3e6b3c13d313c52fe8516085da493e2ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420172 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#809225}
-
dpapad authored
Enums can be declared as standalone constants within their containing JS module. Previously they were augmented as static variables on some other class, which is unnecessary and makes the code more verbose. Specifically cleaned up: - BrowserApi.ZoomBehavior - PdfNavigator.WindowOpenDisposition - PDFMetrics.UserAction - Viewport.PinchPhase Bug: None Change-Id: I63227460ec44a5472bfc9d2b6b16f889e912e38a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421609 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#809224}
-
Dominic Mazzoni authored
Previously ChromeVox handled in-page links if you force-click on them. This change makes it so that it also handles it if the user presses Enter or mouse-clicks on a link, by responding to the scrolledToAnchor event. Testing this required enabling the test server because the browser doesn't follow same-page links in data urls. Some of the work to make use of the test server in ChromeVox tests was already done for portals, but I had to fix a tiny bug in js2gtest. how they're activated. Bug: 1130786 AX-Relnotes: ChromeVox now properly handles in-page links no matter Change-Id: I9e56f6c88fdbce35c14e692411cb7bb4a2e46db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422704 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#809223}
-
George Burgess IV authored
this statement does nothing; remove it. Bug: 1130379 Change-Id: I3eb01bfdef76b9613a17893a9651970eff736ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420915 Commit-Queue: David Trainor <dtrainor@chromium.org> Auto-Submit: George Burgess <gbiv@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#809222}
-
Wei Lee authored
As mentioned in go/cros-camera:dd:cca-default-saved-folder, we should display i18n name for camera folder and also makes it nonmodifiable. Bug: 1127587 Test: Manually tested with chained CLs. Files app works as expectation. Change-Id: Id4157bd02c130676a9c01949e37838e36a95b303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409743 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#809221}
-
Bo Majewski authored
Part 1 of n: Addresses comments that do not require rewriting any code: - using png_data->bytes without casting - renaming variable kMaxPdfSize => kMaxPdfSizeInBytes - using std::move on base::FilePath path - matching header and .cc parameter names - checking if a valid shared memory region was allocated. Bug: 1129607 Change-Id: Ib339b2b05b0e89003e21dff4ceac1a0647f74be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423065 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#809220}
-
Ilya Nikolaevskiy authored
Bug: webrtc:11956 Change-Id: Icf421840203e826a87b0db8fb69365160a6c0c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418671 Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#809219}
-
Yury Khmel authored
Main motivation of this CL was to restore access to ArcAuth.CheckinTime and ArcAuth.SigninTime. crrev.com/c/2412780 introduced suffix separation however this indirectly made access to legacy data unavailable. Initial attempt was adding empty suffix that would probably restore access to legacy data in UMA dashboard. However it possible to refactor names to align it with common ARC metrics naming. For example we frequently use TimeDelta so ArcAuth.SigninTime.unmanaged would be renamed to Arc.Auth.Signin.TimeDelta.unmanaged. This also explicitly removes intermediate names introduced CL above. That CL was landed few days ago and we don't have data that would be consumed by anybody. BUG=b:155123746 TEST=To verify in UMA dashboard. tast.arc.Optin and confirms new metrics are in chrome://histograms. Change-Id: Ic29ea01b8fb82ca538bb6444d5ee35581288a0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418849Reviewed-by:Brian White <bcwhite@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#809218}
-
Will Cassella authored
Bug: 1128657 Change-Id: I9548e1f3bfe5693871a56e23c3373f45147e52e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422091Reviewed-by:
-
Melissa Zhang authored
Adds expansion from default view to expanded view with apps list. This CL also moves Sharesheet UI classes into their own folder. Bug:1130406 Change-Id: I17824948bdb20a5e3cfa6b7ac93b0216ee43cf61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409480 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#809216}
-
Ian Kilpatrick authored
Per: crbug.com/1119873 It was possible to mutate the work queue while iterating over it. Using this it was possible to trigger a UAF. This patch converts CustomLayoutWorkTask to oilpan (not strictly required as a copy of the CustomLayoutWorkTask would have also sufficed), and now copies the Member<CustomLayoutWorkTask> before using it. Bug: 1119873 Change-Id: I3c66859af8c9a0f33fe8c7df7c30efd2913c2985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380135Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#809215}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/44dff4f2012d..1a49a5334c36 2020-09-21 johnstiles@google.com Restructure blend functions to allow for smarter inlining. 2020-09-21 johnstiles@google.com Rename 'DefaultSettings' golden outputs to 'StandaloneSettings'. 2020-09-21 jvanverth@google.com Revert "Reland "Use Microsoft's ComPtr to wrap D3D12 objects."" 2020-09-21 johnstiles@google.com Create golden outputs for SkSL blend functions. 2020-09-21 johnstiles@google.com Add convenience methods to CFG builder. 2020-09-21 egdaniel@google.com Allow client to pass in VK_IMAGE_LAYOUT_UNDEFINED into mutable state change requests. 2020-09-21 egdaniel@google.com Make GrStencilAttachment derive from GrSurface. 2020-09-21 johnstiles@google.com Remove needless do-while(false) block from inlined blend methods. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: csmartdalton@google.com Change-Id: I94683c5bcdc3c981c7337329d9b69e30437eb05f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422828 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809214}
-
Wei Lee authored
This CL replaces pwa.html and manifest.json by CameraSystemWebAppInfo to reduce the flakiness and slowness of SWA installation. Bug: 980846, 1085274 Test: Launch CCA (SWA) successfully Change-Id: I72d350077d8e8a7328572e27a16a97e4863516a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422927Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#809213}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9c946ee14364..242419022dde 2020-09-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I59d4a0406ee749df6fdc650a25db5f2bd4214117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423245Reviewed-by:
-
Sophey Dong authored
Bug: 1120093, 1129673 Change-Id: I28090ce188f331050c546802a514da33254359a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419382Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#809211}
-
jchen10 authored
Unsuppress the DirectComposition info_collection_test and trace_test for HD630(0x5912). Bug: 1079393 Change-Id: I6cdd7c146c69b7154dde27b10e9b18b5f989950a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413291 Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#809210}
-
Shakti Sahu authored
This CL sets up the video player HTML/JS files to be served locally through chrome-untrusted:// scheme. It currently uses a WebUIDataSource and will be moved to an untrusted WebUIController factory once it is ready. Bug: 1129715 Change-Id: I1d514c5f316a462547ef6e1dff78cfecbf143fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414787 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#809209}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d56d50c3..ff52c73e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8e0878ed99514033b2ea9fc43afdf83c91290571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421874Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809208}
-
Reilly Grant authored
This reverts commit fdbcb258. Reason for revert: The new flag didn't resolve the issue. Original change's description: > serial: Add option to switch enumeration methods > > A potential solution for issue 1119497 is to switch from enumerating > devices implementing GUID_DEVINTERFACE_COMPORT to using the "bus > enumerator" identified by GUID_DEVINTERFACE_SERENUM_BUS_ENUMERATOR. > > I'm putting this behind a flag so that developers can try it out in > canary-channel. If it works I can enable it by default and keep the flag > around for a couple releases in case it causes other problems. > > Bug: 1119497 > Change-Id: Icad9008799ed331c3da15e5a70e0184144c47a58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417460 > Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > Auto-Submit: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808368} TBR=reillyg@chromium.org,odejesush@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1119497 Change-Id: I3e39d5de932e94b980e7fb5f6de71a2cfa45b0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423053Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#809207}
-
Yunke Zhou authored
display:table should be removed since we are now using style from oobe-dialog. Bug: 1021608 Change-Id: I779291ef6ddd94fd83c0ed0922f53d29c4c403f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421649Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#809206}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1b436e07b1e0..5ec560fb8c75 2020-09-21 jmadill@chromium.org Add restricted trace golden image script test. 2020-09-21 jmadill@chromium.org Trace/Replay: Reset replay after taking a screenshot. 2020-09-21 ianelliott@google.com Vulkan: Further refine invalidate for depth/stencil 2020-09-21 syoussefi@chromium.org Vulkan: Disallow loadOp=LOAD for MSRTT depth/stencil textures 2020-09-21 lehoangq@gmail.com Metal: Implement PBO. 2020-09-21 ianelliott@google.com Vulkan: Fix copy-paste error in hasCopyImageView 2020-09-21 lexa.knyazev@gmail.com Metal: Implement ASTC LDR support 2020-09-21 jmadill@chromium.org Vulkan: Optimize Attribute Change Perf (5/5) 2020-09-21 jmadill@chromium.org Fix early fragment tests optimization condition. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Test: Test: DrawCallPerfBenchmark.Run/vulkan_attrib_changeTest: Test: tested with trigger.py Change-Id: Ia2ea153bd1ac41531cf7262318c035c033ca0688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422905Reviewed-by:
-
My Nguyen authored
New language settings divide into Languages and Input page. IME settings and Virtual Keyboard settings are both Input-related, so they should open Input page in the updated version. Bug: 1113439 Change-Id: I0f21cbba0600d034a9f55f526638fd2ed4e63b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422923 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#809204}
-
My Nguyen authored
Removable condition is different for Language Settings V2 as we are decoupling device language and input methods from language preference. Current view: http://screen/4ax5XVRUryvctHW Bug: 1113439 Change-Id: I0d31f7eda4a3fbe6bf10abd5654b0b0282f603b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417673 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809203}
-
Mike Wittman authored
Moves creation of Unwinders from the profiled thread to the profiler thread on Android, Windows, and Mac. This initialization is expensive on Android -- 50+ ms -- so it's important to not block the profiled thread on performing it. Mac does some work in its unwinder construction so might see a small benefit as well. This is accomplished by passing a factory function for creating the unwinders into StackSamplingProfiler rather than the unwinders themselves. The naming of the classes that create the individual unwinders in ThreadProfiler is updated to call them 'creators', to minimize confusion over multiple levels of factories. Also updates class-level documentation on how to use the profiler. Bug: 1129082 Change-Id: I791538c72dce5c0d04c4f30e2f287fef96da1db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414773 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#809202}
-
Darwin Huang authored
Ensure the RenderFrameHost is still active before use. Previously, RawClipboardHostImpl incorrectly assumed that the RenderFrameHost was guaranteed to outlive the RawClipboardHostImpl, and didn't check that the renderer was always still active. Bug: 1101509 Change-Id: I3e503634be50b1ca60e4c00131546c2337e4176a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411673Reviewed-by:
-
Nazerke authored
This CL adds a coordinator for the tabstip and adds it to BVC. Bug: 1130395,1128249. Change-Id: Ica2770c78e8ebac7656a98857897c20bde5717d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418410 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#809200}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600711078-3749581e3468596138c3e122333d23faab2aaf5f.profdata to chrome-mac-master-1600732621-efcb2b5a6f18794514e083516aa5205975064ad2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id6fde7c7c61f03d1a0eb2fa10b051941855d6c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422322Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9c00c7f418c4..092f3bde17d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1077274,chromium:1099917,chromium:1128981 Tbr: meredithl@google.com Change-Id: I9001df966cf9edf8fb3fe64d025002225357ea90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423024Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809198}
-
Wei Lee authored
We have legacy migration logic since M69 to migrate photos/videos from CCA internal storage to "MyFiles/Downloads" folder. Since we are going to change the default camera folder from "MyFiles/Downloads" to "MyFiles/Camera" and show a dialog/notification to indicate user, it is preferable to remove such migration logic to avoid increasing complexity and too many notifications when launching app. Bug: 1127587 Test: None Change-Id: I6a576cfda3f3ea4d1b97f441710ad45687cf1b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407733 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
This CL: - Adds --android-deps-dir parameter to fetch_all.py This avoids having to place the androidx build.gradle in //third_party/androidx/third_party/android_deps/build.gradle - Adds 'internalTargetVisibility' parameter to build.gradle. This will be used to enable //third_party/android_deps to depend on //third_party/androidx targets - Removes 'depsPath' parameter in build.gradle and changes fetch_all.py to ignore --android-deps-dir parameter in computation of where in build directory DEPS is copied ot. - Adds //third_party/android_deps to the 'ANDROID_DEPS' environment variable when running jetification. This fixes jetification for internal chrome BUG=1064277 Change-Id: I2165846c032071315581278036bcee4ccea97262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422518 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#809196}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cc2909804286..02ffb6f47a21 2020-09-22 agrieve@chromium.org CheckDirMetadataFormat: LocalPath() -> AbsoluteLocalPath() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1127507 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I9cdfcf2cea411021f705f35f91d1e7fc0fa22a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423184Reviewed-by:
-
Olivier Yiptong authored
This change adds the requirement for sticky user activation for the enumeration API to return a result. This will require sites to wait for a user activation on session-restore or whatever causes the page to load without user activation before accessing the API. Also, the enumeration API now consumes the transient activation. Bug: 1043306 Change-Id: I77e18795eaa22cc801145243b276c6fd29308d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414920 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#809194}
-
Akihiro Ota authored
This patch changes how lessons are organized. Previously, they were categorized by user type (new user, experienced user, developer). UXR discovered that this method of organization could make it more difficult for users to find the content they are looking for. The new strategy is to organize lessons based on content, which makes finding information easier. This patch also adds the OOBE lessons to the main menu; this will allow users to revisit the content whenever they would like to. To keep the visual styling consistent, titles were added to each of these lessons. However, this created an issue in how initial focus is placed when interactive lessons are shown; we don't actually want to focus the title for these lessons, rather the text content that instructs users which keystrokes to press. To solve this issue, this change also adds logic in tutorial_lesson.js for where to place focus when a lesson is shown. Lastly, this change fixes an issue where UserActionMonitor wasn't properly destroyed, thus continuing to block ChromeVox execution even after an interactive lesson was exited. Bug: 1124070 Change-Id: If13952d8a7b6e954fc7292e01444a59fe6a624ef AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412223 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
-
Shakti Sahu authored
This CL adds TutorialManager class to the video tutorials. Also cleaned up a few methods on the storage layer. Bug: 1130260 Change-Id: Ida331aefc538daddccd30175cd5652152cf4ab4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420779 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809192}
-
Josh Nohle authored
The ListPublicCertificates RPC has an optional field in the request where the client can list the IDs on all locally stored public certificates. Certificates with these IDs will not be returned in the response. However, this RPC is made in Chromium via an HTTP GET request, and One Platform documentation notes request-URL size limits [1]. There are ways to circumvent these size restrictions, but until the Nearby Share server makes the appropriate changes to the API, we will not send the ID list. [1]https://g3doc.corp.google.com/google/g3doc/oneplatform/http.md#long-request-url Bug: b/168701170 Change-Id: Ieec8ad883c152769006c9c8dd94a0341ff46dd3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423323 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#809191}
-
Austin Tankiang authored
Bug: 1115025, 1128870 Change-Id: Ic3deb289f3730db92b717817f594cc7d9c969868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419058Reviewed-by:
-
Filip Gorski authored
Bug: 1117078 Change-Id: I8c747c93a7217202e564036c277dc43b8146380d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422500 Auto-Submit: Filip Gorski <fgorski@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#809189}
-
Eugene Zemtsov authored
1. VideoEncodeAcceleratorAdapter calls H264AnnexBToAvcBitstreamConverter to convert H264 bitstreams 2. webcodecs::VideoEncoder and media::VideoEncoder have callbacks to report decoder config Bug: 1122955 Change-Id: I897974a04b60cdb2a5c1ce98a9812b6ca9648d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415221Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#809188}
-
Marijn Kruisselbrink authored
Creation and deletion of namespace should never be re-ordered. Creation doesn't depend on having the database open (which often allows delaying opening the database until after chrome startup has completed), however deletion does sometimes require the database. Previously part of the delete operation could be reordered to happen after later create operations, resulting in situations where state could get out of sync. This CL fixes all that by completely pausing processing incoming mojo calls while the database is being opened. This will ensure that no new namespaces get created while we're waiting for the database to be opened while in the process of deleting a namespace. Bug: 1128318 Change-Id: Iea28b92172da88d3719853a42dbb323da2522eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419124 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#809187}
-
Curtis McMullan authored
The Chromium flag for the resizable vk is no longer needed. This CL removes all code relating to the flag. BUG=b:164919876 Change-Id: Ie4de22d122ebe4c64f5d87bbfdb694ee79471275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413679Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809186}
-
