GitLab

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cc2909804286..02ffb6f47a21

2020-09-22 agrieve@chromium.org CheckDirMetadataFormat: LocalPath() -> AbsoluteLocalPath()

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1127507
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: I9cdfcf2cea411021f705f35f91d1e7fc0fa22a1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423184Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809195}

This change adds the requirement for sticky user activation for the
enumeration API to return a result. This will require sites to wait for
a user activation on session-restore or whatever causes the page to load
without user activation before accessing the API.

Also, the enumeration API now consumes the transient activation.

Bug: 1043306
Change-Id: I77e18795eaa22cc801145243b276c6fd29308d8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414920
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809194}

This patch changes how lessons are organized. Previously, they were
categorized by user type (new user, experienced user, developer). UXR
discovered that this method of organization could make it more difficult
for users to find the content they are looking for. The new strategy is
to organize lessons based on content, which makes finding information
easier.

This patch also adds the OOBE lessons to the main
menu; this will allow users to revisit the content whenever they
would like to. To keep the visual styling consistent, titles were
added to each of these lessons. However, this created an issue in how
initial focus is placed when interactive lessons are shown; we don't
actually want to focus the title for these lessons, rather the text
content that instructs users which keystrokes to press. To solve this
issue, this change also adds logic in tutorial_lesson.js for where to
place focus when a lesson is shown.

Lastly, this change fixes an issue where UserActionMonitor wasn't
properly destroyed, thus continuing to block ChromeVox execution even
after an interactive lesson was exited.

Bug: 1124070
Change-Id: If13952d8a7b6e954fc7292e01444a59fe6a624ef
AX-Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412223
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809193}

This CL adds TutorialManager class to the video tutorials. Also
cleaned up a few methods on the storage layer.

Bug: 1130260
Change-Id: Ida331aefc538daddccd30175cd5652152cf4ab4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420779
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809192}

The ListPublicCertificates RPC has an optional field in the request
where the client can list the IDs on all locally stored public
certificates. Certificates with these IDs will not be returned in the
response. However, this RPC is made in Chromium via an HTTP GET
request, and One Platform documentation notes request-URL size
limits [1].

There are ways to circumvent these size restrictions, but until the
Nearby Share server makes the appropriate changes to the API, we will
not send the ID list.

[1]https://g3doc.corp.google.com/google/g3doc/oneplatform/http.md#long-request-url

Bug: b/168701170
Change-Id: Ieec8ad883c152769006c9c8dd94a0341ff46dd3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423323
Commit-Queue: James Vecore <vecore@google.com>
Reviewed-by: James Vecore <vecore@google.com>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809191}

Bug: 1115025, 1128870
Change-Id: Ic3deb289f3730db92b717817f594cc7d9c969868
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419058Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Austin Tankiang <austinct@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809190}

Bug: 1117078
Change-Id: I8c747c93a7217202e564036c277dc43b8146380d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422500
Auto-Submit: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809189}

1. VideoEncodeAcceleratorAdapter calls H264AnnexBToAvcBitstreamConverter
   to convert H264 bitstreams
2. webcodecs::VideoEncoder and media::VideoEncoder have callbacks
   to report decoder config

Bug: 1122955
Change-Id: I897974a04b60cdb2a5c1ce98a9812b6ca9648d80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415221Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809188}

Creation and deletion of namespace should never be re-ordered. Creation
doesn't depend on having the database open (which often allows delaying
opening the database until after chrome startup has completed), however
deletion does sometimes require the database. Previously part of the
delete operation could be reordered to happen after later create
operations, resulting in situations where state could get out of sync.

This CL fixes all that by completely pausing processing incoming mojo
calls while the database is being opened. This will ensure that no new
namespaces get created while we're waiting for the database to be opened
while in the process of deleting a namespace.

Bug: 1128318
Change-Id: Iea28b92172da88d3719853a42dbb323da2522eb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419124
Auto-Submit: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809187}

The Chromium flag for the resizable vk is no longer needed. This CL
removes all code relating to the flag.

BUG=b:164919876

Change-Id: Ie4de22d122ebe4c64f5d87bbfdb694ee79471275
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413679Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809186}

This CL handles the clipboard data with the restricted access from the
multipaste menu. It implements the following things:
(1) Disable the menu item whose clipboard history data should not
be accessed through the multipaste menu.
(2) The disabled menu item should have different UI appearance.

Bug: 1106847
Change-Id: I4c58cc898a3f529a928787d6ef378eaa49f5871a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409736Reviewed-by: David Vallet <dvallet@chromium.org>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809185}

We should not add ContentsVisualOverflowRect() to VisualOverflowRect()
if a LayoutBox should clip overflow. This should include contain:paint.

This also makes the bounds of the composited layer just contain the
visible part, not all descendants.

Change-Id: Ibca5839ba4db59f3478131e0d00245070d99dc60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422150
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809184}

https://webrtc.googlesource.com/src.git/+log/d41c2a6b8aeb..edd7f9e94d43

2020-09-21 tommi@webrtc.org Check if logging for a severity is enabled at the call site.
2020-09-21 glahiru@webrtc.org Rename CancerStickCastle to RoboCaller.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I8eaf8d373cea70b2af417a406f3086270accfeea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422827Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809183}

Bug: 1130092
Change-Id: I50224da935beb436f2828ef8047435882a044452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419389Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809182}

This CL removes the NewOsSettingsSearch flag from the cc and enums
files and defaults the JS/HTML codepaths it affects to true.

Bug: 1080777
Change-Id: I0198f8a3141c3653072c8124a311dbf9beea5dc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422266Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809181}

This patch changes the content-visibility check in the inspector code
to make sure that we consider ancestor frames as locked as well.

R=chrishtr@chromium.org

Bug: 1128790
Change-Id: Ie8a4dfebb694bbe50e8c5179ccd9e8cdcc57c35b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422244Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809180}

Bug: 1048812
Change-Id: I1b93c04ca890423f2361d5f3c8211e8a926fed62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416839Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809179}

Fixed: 1094742
Change-Id: I86e65b45d34da352049f7c43d82d0e7a4ec1f615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422020
Auto-Submit: Nicholas Verne <nverne@chromium.org>
Commit-Queue: David Munro <davidmunro@google.com>
Reviewed-by: David Munro <davidmunro@google.com>
Cr-Commit-Position: refs/heads/master@{#809178}

This is a follow-up of [1] which didn't handle the case of pseudo
elements with a math display value. A reftest is added to verify the
expected behavior with pseudo elements, but will fail until the
parsing of math display values is adjusted to match what the CSSWG
agreed. However, this test checks the fix for an assertion failure
(http://crbug.com/1130127).

Bug: 6606, 1127222, 1130127

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2404789

Change-Id: I4f7c13db003f776045a934eae9be5839b3c0343f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418658Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#809177}

In EditUrlSuggestionProcessor and EditUrlSuggestionUnitTest
there is an assumption that the URL can be acquired off an
uninitialized Tab. This is currently not allowed using
the UserData pattern. I recommend if the Tab is not
initialized we pull the url off the web contents and not
store on the UserData object CriticalPersistedTabData.

Bug: 1117396
Change-Id: I0223d481b7a25722f4e6bf85e78cad45060fcbd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410346
Commit-Queue: David Maunder <davidjm@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Tomasz Wiszkowski <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#809176}

https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/3f5086309f48..e8573af9803f

$ git log 3f5086309..e8573af98 --date=short --no-merges --format='%ad %ae %s'
2020-09-13 chanheepark Add a safeguard in case matching an element take longer than the interaction timeout time.
2020-09-10 tirodkar Multi-window support for visibility check
2020-09-10 tirodkar Add optional verbose logging for AppStateTracker info.
2020-09-10 mobile-devx-github-bot Disable auto capitalization for text fields and text views to reduce flakiness.
2020-09-09 chanheepark Disable auto capitalization for text fields and text views to reduce flakiness.
2020-09-08 chanheepark Fix test failure when tested locally on iPhone 11.
2020-09-06 chanheepark Do not log element information before performing action.
2020-09-03 chanheepark UI element's respondsToSelector needs to be called on the main thread.
2020-09-01 chanheepark Modify the executeJavascript action so that it works on main thread.
2020-08-31 albertbow Rename EDOBlacklistedType to EDOBlockedType per go/respectful-code.
2020-08-28 tirodkar s/URLBlacklistRege/KeyBlockedURLRegex
2020-08-28 chanheepark Rename 'explicitRunLoopDrain' to 'explicitDrainInMainRunLoop' to be more clear.
2020-08-26 tirodkar Fix Xcode project with new assertions / keyboard work.
2020-08-25 chanheepark Deleted unused methods.
2020-08-24 tirodkar Update breaking Assertion Define Macro strings.
2020-08-24 albertbow Resolve process-ownership mismatch of isKindOfClass in EG tests.
2020-08-19 tirodkar Fix issue with typing in a UITextField of the emailAddress keyboardType.
2020-08-18 tirodkar GREYAssertions logging fix
2020-08-17 chanheepark Warn user when the application uses grey_tap() to enable UISwitch.
2020-08-14 chanheepark Adds some comment for readability.
2020-08-12 mobile-devx-github-bot Add the new EarlGrey assertions macros for Objective-C.
2020-08-12 tirodkar Add support for internal runloop push / pop methods.
2020-08-11 chanheepark Print element description on GREYLogVerbose before performing action or assertion.

Created with:
  roll-dep src/ios/third_party/earl_grey2/src

Bug: 1126944
Change-Id: Icb5737162412efc5fb0675c30f75d6e843cddc25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416745Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809175}

Some codecs require extra_data to be passed from the demuxer to decoder.
FuchsiaAudioDecoder wasn't passing that information to AudioConsumer, so
it wasn't passed to the decoder.

Bug: 1130881
Change-Id: I095c5cdd8fa99a7316af976d9a5cb748ec9027eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423304
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809174}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I42e3f16d4237ce6fd4cfbb7df8c78c5ef08f40a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422582Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809173}

Useful for downloading .sizediff from trybots and inspecting locally.

Includes minor refactoring of file_format.py

Bug: None
Change-Id: I7cf9f8a5829e0eaab6210b632713508ce279ba03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422318
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809172}

There are couple of cases where when selecting "Stay In Chrome" and
"Remember my choice" actually stores an entry with empty app_id. However
this happens randomly and cannot be reproduced easily. Add the
DumpWithoutCrashing to get a trace to help debugging. The main purpose
is to identify where the empty string get generated, because logically
it doesn't seem to be possible.

In addition to this, some early return are also added to avoid storing
the entries.

BUG=853604

Change-Id: I320f29418b606288e056d38088f266c817f812e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418279Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809171}

This CL use NTP clicks to help order the tiles.

BUG=1096224

Change-Id: I9d3ec7c9f2d8526a7ef6cd5e5f106a48b31d767a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418902
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809170}

screenshot: https://imgur.com/cbjTH0K

Bug: 1093185
Change-Id: I21eb0cdc5ad12749b7fddadd2b126dc7a1e6d501
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414650Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Cr-Commit-Position: refs/heads/master@{#809169}

MessageReceiver is responsbile for receiving serialized proto messages,
deserializing the messages, and notifying clients of the updated
messages.

Bug: 1106937
Test: unit_tests
Change-Id: I6d1c75d3f63c27213e3b85b561f6e0c3b4e47161
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419757
Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809168}

ENABLE_ARM_CFI_TABLE is in service of the sampling profiler on Android,
and is unrelated to any debugging functionality, so move it to a
buildflag header under base/profiler.

Also add the required includes to the files that use it.

Bug: 1129939
Change-Id: I884b2128fc2ab2f6f1bec2343c59134448328529
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421443
Commit-Queue: Mike Wittman <wittman@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Mike Wittman <wittman@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809167}

Bug: 1130064
Change-Id: Iedd92a96e41306e88af0d9531825adc96f27aa17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419532
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809166}

Bug: none
Change-Id: I65e77af4986544bf5ec6a9e7d8784adb228884aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422984
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809165}

This CL allows the holding space bubble to dynamically
add / remove items and resize as required when that
happens.

Bug: 1129321

Change-Id: I8b072de15628ca0fc56f23d6286026b0f6aeda69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412639
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809164}

Remove DISALLOW_COPY, use constexpr more, move constants as close to
first use as possible, etc.

This was originally motivated by wanting to change the
Combobox::set_callback() call to set_closure(); that's present here, but
I couldn't help cleaning up at least some of the rest of this too.

Switching to layout managers (from explicit positioning) also fixes some
graphical bugs that resulted from comboboxes' preferred sizes changing
after creation.

Bug: none
Change-Id: Iad0d483327a07ad865b252f5ab58e90037512125
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421029
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809163}

No change to logic. This test seems to fail consistently when it
actually runs (most bots skip this test suite entirely because they
don't have the required GMSCore version). This disables the full test
class.

Tbr: nsatragno@chromium.org
Bug: 1130845
Test: out/Default/bin/run_chrome_public_test_apk -f Fido2CredentialRequestTest.*
Change-Id: I4655c905dd36d376f6d3842b85c8698a2ba84b35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423143
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809162}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chonggu@google.com
Change-Id: Ica25552e416e0e7790865f0fb152cca9fcb9b83a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422830Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809161}

Original CL dc64daa2 was reverted by
a326c157 due to a container-overflow.
This CL fixes the container-flow.

Original commit message:

While the flag for limiting windows to the current active desk is
enabled, if a user swaps desks while the window cycle list is open, the
contents will not update to the new active desk.

This CL makes the window cycle list reset if it is open and a desk
swap occurs while the aforementioned flag is enabled.

Test: LimitedWindowCycleControllerTest.CycleShowsActiveDeskWindows
Bug: 1067327
Change-Id: I9dddd0e780db33f5b727770583e0517f12eecece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417213Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809160}

Remove DISALLOW_COPY, use constexpr more, move constants as close to
first use as possible, etc.

This was originally motivated by wanting to change the
Combobox::set_callback() call to set_closure(); that's present here, but
I couldn't help cleaning up at least some of the rest of this too.

Bug: none
Change-Id: I5539b0b9d11a534d059107f57dd91d0f65b7a0a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420778
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809159}

TBR=elklm@google.com

https://crrev.com/c/2421731 marked
external/wpt/xhr/xhr-timeout-longtask.any.html as flaky on Mac10.14, but
the same flakiness is present on Mac10.13:

https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/20098

Bug: 1130533
Change-Id: I801951c158677be84804764f41bbf9b8fe6de6bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422924
Commit-Queue: Meredith Lane <meredithl@chromium.org>
Reviewed-by: Meredith Lane <meredithl@chromium.org>
Reviewed-by: Chris Hall <chrishall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809158}

LaunchModeRecorder logs the launch mode on destruction, if set.
Launch methods now take an optional LaunchModeRecorder instance for
those callers that originate from an external launch.

This fixes two bugs: launching multiple profiles logs multiple launch
modes, and opening a profile from the user manager records a launch
mode.

Bug: 1032501
Change-Id: I6924ea27a8d1cf79e5a05a957c93536c55fc2830
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384332Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809157}

Bug: 1112397
Change-Id: I2bbdc3fb7594cbc519bbb01cf2b3a5d7d251c63b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414177Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809156}