- 26 Sep, 2019 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 01bb204b. With Chromium commits locally applied on WPT: 561a338c "Convert SensorProvider client to use BrowserInterfaceBroker" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jsbell@chromium.org: external/wpt/resources mkwst@chromium.org, jochen@chromium.org: external/wpt/subresource-integrity NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2e05e386f3d80d6f9b61acf8daa2f7b40a446f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827308Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700283}
-
Andrew R. Whalley authored
Also arrange existing reviewers in alphabetical order Change-Id: I628f0a2363b730fb26c7a7cc0afc2bdf3a8faea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826863 Auto-Submit: Andrew Whalley <awhalley@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#700282}
-
Matthew Denton authored
Change-Id: I92a979d500490786dc0c33d30bc653fa1cee214b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825379 Auto-Submit: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#700281}
-
Tom McKee authored
Before this change, any callback that was waiting for a presentation timestamp would be attached to a layer tree, buffered in the PresentationTimeCallbackBuffer and then posted to the renderer main thread once we actually wanted to run it. This change adds support for registering similar callbacks which expect presentation timestamps but the callbacks are run on the compositor thread instead of being posted back to the main thread. One of the use cases for running callbacks on the compositor thread is to support First Scroll Delay (see referenced bug). First Scroll Delay needs to compute differences between some timestamps which are only available on and relevant to the compositor thread. Bug: 922980 Change-Id: I7683022bcf639808bc3d90eb3068a9e8bacdaf84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823557 Commit-Queue: Tom McKee <tommckee@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#700280}
-
Avery Musbach authored
The bug is caused by faulty logic in IsSnappedInSplitView in the anonymous namespace in browser_non_client_frame_view_ash.cc. This function is supposed to check whether a window is in split view. It actually has the effect of checking whether the window has the same window state as a window in split view. See Issue 1008207 for two workflows that demonstrate how an overview window may have the same window state as a window in split view, meaning the logic is faulty. Workflow 2 even works in tablet mode, but that does not matter because the caption buttons are always hidden in tablet mode anyway. I see no need to add a unit test, because the present CL only removes code, and because a regression seems highly unlikely. Bug: 1008207 Change-Id: Ifc60f53677b4de50458de5d2fbcb4219773dfcea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826008Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#700279}
-
Amr Aboelkher authored
A device policy which controls the dictation accessibility feature on the login screen.The policy can be applied as a recommended or mandatory policy. Test: 1. Set the login_screen_dictation_enabled policy to True, open System Tray => "Accessibility", check that "Dictation" is displayed with a green check in the login screen. 2. Set the policy to False, open System Tray, check that "Dictation" is not displayed in the login screen. Bug: 552439 Change-Id: Iabbdf63f0b6d8a21c02bc25ef8d5295f4a72da30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815119 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#700278}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/38d889b2a677..197c3c97970b Created with: gclient setdep -r src-internal@197c3c97970b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I6650b84d53abb0e2f9a1f615a301a06d0796bacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827445Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700277}
-
Christopher Grant authored
DFMs that include both Java and native code will probably use JNI. This change introduces a reusable mechanism to load the native library and register its JNI methods. Key points: - There are 3 build variants supported: 1. Production builds with lld-generated partitions. 2. Component build (with feature code in a component). 3. Fallback release build (feature code in the main library) - For consistency, explicit JNI registration is done in both ChromeModern and Monochrome. - The Test Dummy module is moved over to use this new system. VR will join the fun in a follow-on change. - Currently, modules must supply an explicit JNI registration method. Common code will locate this method and call it, at the appropriate time, on behalf of the module. Bug: 870055 Change-Id: Id400ff00b4be65f71536a4acffdfcf93cc3bea58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822846 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#700276}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ef2033ab2793..e545db8d0486 git log ef2033ab2793..e545db8d0486 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 fmayer@google.com Merge "Fix slow pprof_builder." 2019-09-26 fmayer@google.com Merge "Move normalization header lib to include" 2019-09-26 hjd@google.com Merge "perfetto-ui: Add Android async slice tracks" Created with: gclient setdep -r src/third_party/perfetto@e545db8d0486 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I387ca13c6001fc9c923f15fbcaf014b1b43ff0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827447Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700275}
-
Thomas Tangl authored
- Profile heading "Manage people" -> "People" - Button "Open Guest window" -> "Guest" - Button "Add Person" -> "Add" - Guest icon of "Guest" button is updated - Button "Close all your windows" is removed Bug: 995720 Change-Id: I86dd1dcd14afec5b4e6d7ad911449ca9053d2910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827281Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Auto-Submit: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#700274}
-
Anton Bikineev authored
This change is needed to check canary for existing bugs caused by incorrect algorithm of page header extraction for large pages. To sherrifs: this causes regressions. The commit will be reverted in a few days. Change-Id: I0df59aa055b8783c834cfdf29717d388294fe9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827364Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#700273}
-
Mia Glaese authored
Previous CL (ttp://crrev.com/c/1792857) caused feedless builder to fail lint checks. Moved ss_feed_header to appropriate place. Bug: 982018 Change-Id: If5b7997973c9d7230287a48aee4bf16490b65ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822219 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#700272}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I77f00c39d2f6fc088eee250e3ed6e5b04374478b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808404Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#700271}
-
Fredrik Söderquist authored
Merge these two functions into one - InstanceListChanged - taking the list that changed as an argument. This is preparation for unifying this code-path with the other interval resolving code-path. Bug: 998526 Change-Id: I3727a5dfe76236bac7b6283a48d334426093d2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827278Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#700270}
-
danakj authored
Only the main frame experiences the web test bits or the emulator, but the non-delegate branch is currently dependant on them, and lives in the else case of both of these. But not having a delegate means they can't be true. Reduce our nesting and variable dependencies. R=avi@chromium.org Bug: 1006052 Change-Id: I430d5ebeaf1777b05f5318c850c45e372cbf55fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825723 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#700269}
-
Matthias Körber authored
Bug: 1007974 Change-Id: I248c8f76fb5f3ade6dfdde8f1c957d3f4708f45a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827404 Commit-Queue: Matthias Körber <koerber@google.com> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#700268}
-
Matthias Körber authored
Bug: 1007974 Change-Id: I4cb954b366dc61c93ddaac5aeccd62f75e9a3ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827405 Commit-Queue: Matthias Körber <koerber@google.com> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#700267}
-
behdad authored
Using viz::FrameTimingDetails we report three breakdowns below for the SubmitCompositorFrameToPresentationCompositorFrame stage. SubmitToReceiveCompositorFrame ReceivedCompositorFrameToStartDraw StartDrawToSwapEnd SwapEndToPresentationCompositorFrame Bug: chromium:1001523 Change-Id: I93a2ec513395a893a2ad145fed6b1dcd2e98c233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789783 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
The mis-attributed requests are rare, so calling DumpWithoutCrashing to doesn't hurt performance too much. Bug: 961614, 1006292 Change-Id: I59e1b5e7b49d03597b60d06b7846670f2cec70aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826738 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#700265}
-
ckitagawa authored
This CL adds basic subsetting support for paint previews. This depends on Harfbuzz's subsetter and is based on the implementation in SkPDFSubsetFont. Part of landing: https://chromium-review.googlesource.com/c/chromium/src/+/1786583 Bug: 1006242 Change-Id: I757543ab9a575dc829a6f2b7fc1bb9b89fef5c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816730Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#700264}
-
Matthias Körber authored
Bug: 1007974 Change-Id: I72ac0310c8c6a70f932689e866db461c4f6536e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827007 Commit-Queue: Matthias Körber <koerber@google.com> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1585d7e108ef..403f2955e7f6 git log 1585d7e108ef..403f2955e7f6 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 ba04be8c9ef9..f703443b1f67 (6 commits) 2019-09-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-09-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader cc3f09861685..30d3c8afe19c (2 commits) 2019-09-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src fb8fbb18..fbc0a229 (465 commits) 2019-09-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-26 jcgregorio@google.com Fix HOME directory in Docker containers built under cloudbuild. 2019-09-25 herb@google.com Move SkScalerContextEffects to SkScalerContext.h 2019-09-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-25 csmartdalton@google.com Move the msaa dirty rect to GrRenderTargetProxy 2019-09-25 mtklein@google.com clean up for SSSE3 bilerp 2019-09-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-25 nifong@google.com Add a test that draws subpictures within an MSKP and make it pass. 2019-09-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-25 herb@google.com Use constexpr version of min/max 2019-09-25 brianosman@google.com In AAConvexPathRenderer, don't assume that path direction can be computed 2019-09-25 nigeltao@google.com Fix calls to deprecated Wuffs API 2019-09-25 mtklein@google.com cut another multiply in SSE2 bilerp 2019-09-25 nifong@google.com Add tests that loads mskp and changes frame. 2019-09-25 mtklein@google.com cut a multiply in SSE2 bilerp 2019-09-25 csmartdalton@google.com Don't submit msaa resovle command buffers except for external IO 2019-09-25 herb@google.com Add helper SkMakeZip 2019-09-25 mtklein@google.com comment and TODO bilerp code 2019-09-25 herb@google.com Add project declaration for CMake Created with: gclient setdep -r src/third_party/skia@403f2955e7f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I67908df88af158e025b14e8a2c4cee151a2e4be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827070 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
-
Ross McIlroy authored
BUG=878390,1008001 Change-Id: Ie489575241523c5a25c7ae46a36152766dd6602a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825517 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#700261}
-
Theresa Wellington authored
Add a new BottomToolbarTest class with two simple tests that check bottom toolbar visibilty and tab switcher button click handling. Also updates chrome/android/java/.../toolbar/OWNERS file to include twellington@ and chrome/android/javatests/.../toolbar/OWNERS file to point to non-test OWNERS file. BUG=1008212 Change-Id: I46839e3b614a68af5c75bf876f3c47565db63e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825787Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#700260}
-
Vladimir Levin authored
Since the infinite float clip rect is actually pretty small (it's on the order of 10s of millions), due to fixed point math in layout unit, it can cause clips on other rects that are computed elsewhere, such as IntersectionObserver. This can cause bugs (see referenced bug) where unclipped elements are treated as clipped by the intersection observer. R=chrishtr@chromium.org, szager@chromium.org Bug: 1004196 Change-Id: Ia3e5d483cded6153ff546289fbc762b6e8922bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825579Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#700259}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fafb3471..87e5c742 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I476bf05e9c15807ad4d4093a37ca401d480b0e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827314 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700258}
-
Sebastien Lalancette authored
The test is failing in multiple OSes: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=ProtoBackgroundTracingTest.ProtoTraceReceived TBR=oysteine@chromium.org Change-Id: I29ea75c40860d31f106a709f0fddb986f02e0f5d Bug: 1008387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827499 Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#700257}
-
Aaron Tagliaboschi authored
Pretty simple aesthetic changes, but bringing in closer to spec (and fixing tests to match" Bug: 959613, 971342 Change-Id: I3a1409a73852a5e767380dbc60d0019847e3fffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647436 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#700256}
-
Kevin McNee authored
When HTMLDialogElement::RemovedFrom updates inertness, we may hit the !node.NeedsDistributionRecalc() DCHECK in FlatTreeTraversal. Workaround this by calling UpdateDistributionForFlatTreeTraversal. We shouldn't UpdateDistribution during DOM mutation, but Shadow DOM v0 will be removed, at which point the UpdateDistribution can be removed. Bug: 895511 Change-Id: If8fb3a93acbfa54e819b36fd647e56357ab9fe6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1281223 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#700255}
-
Miyoung Shin authored
This change converts GamepadMonitor mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I34b6f39335544966a2ccd3cc5e134dd1149e3fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819083 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#700254}
-
Xiaocheng Hu authored
This patch allows summations like "a + b + c" to be serialized as is without inserting redundant parentheses like "(a + b) + c" that the current implementation does. This doesn't fix all the serialization issues, but at least we are one step closer. Bug: 1008146 Change-Id: I87350fe6fb43710974cfefb21d8d136258115c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825732Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#700253}
-
Jesse Doherty authored
We still have ...:PredictedType for testing. Change-Id: I3d93a3f52d43b4aba408be336b93b1d01a385f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825303Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Jesse Doherty <jwd@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#700252}
-
Gustaf Ullberg authored
Cherry-picked from https://github.com/xiph/opus/commit/cdaf661e8d3e85770bf06db8cff12ae6be7fa2a6 The patch is needed for OPUS_GET_IN_DTX to work in Celt-only mode. Bug: b/141607706 Change-Id: Ifbf2cc13d2a03f410aeff073550b185e0d535f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825520 Auto-Submit: Gustaf Ullberg <gustaf@chromium.org> Commit-Queue: Felicia Lim <flim@chromium.org> Reviewed-by:
Felicia Lim <flim@chromium.org> Cr-Commit-Position: refs/heads/master@{#700251}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/741bab0f6ce6..89e7fcb726e9 git log 741bab0f6ce6..89e7fcb726e9 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 titovartem@webrtc.org Revert "Enable capturing from camera in PC framework" 2019-09-26 ilnik@webrtc.org VideoStreamEncoder: Don't crop and scales frames for external encoders 2019-09-26 titovartem@webrtc.org Enable capturing from camera in PC framework 2019-09-26 philipel@webrtc.org Reset |reference_finder_| on codec switch. 2019-09-26 philipel@webrtc.org Removed unused _rotation_set variable from EncodedFrame. Created with: gclient setdep -r src/third_party/webrtc@89e7fcb726e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:none,chromium:none Change-Id: Idf66c2d8490b1edca80b23549d44955a25cf1253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827442Reviewed-by:
-
Mikel Astiz authored
The concept of pending keys is about sync-ing remote updates and doesn't fit well the Cryptographer layer, which is conceptually the local Nigori model state (or part thereof). This patch addresses a TODO to simplify the core Cryptographer API and logically move such notion to SyncEncryptionHandler, currently exposed via observer APIs only. Bug: 967417 Change-Id: I0c156ac0db589c4f620b53c27a7b4352cd650c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827398 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#700249}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/442ff2ebbd66..39d142e89afb git log 442ff2ebbd66..39d142e89afb --date=short --no-merges --format='%ad %ae %s' 2019-09-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 973d0e538292..7bc047326e06 (1 commits) Created with: gclient setdep -r src/third_party/angle@39d142e89afb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:None Change-Id: I75be9ae481f52abca0036bdd1bdf856007b14f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827441Reviewed-by:
-
Vadym Doroshenko authored
Bug: 949519 Change-Id: I96148de31cb627ed14a5df6f779a24703c0046fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827420Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#700247}
-
Nico Weber authored
For helpers.h, move the GOOGLE_CHROME_BUILD into just the cc file, so that the dep on //build:branding_buildflags doesn't have to be a public_deps and to make branding affect internal APIs less. I'm hoping to do more changes that move GOOGLE_CHROME_BUILD / GOOGLE_CHROME_BRANDING from header files going forward. Bug: 961769 Change-Id: I63f20a91b474865acaee2369900ed7677220468a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822718 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Vasilii Sukhanov authored
Bug: 998496 Change-Id: I57223f7c0b0923ff84ede9fdff18772e23423c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827400 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Oleg Davydov authored
We still need them, so move expiration time six moths forward. Also synchronize owners of them. Bug: 1006981, 1006985, 1006992 Change-Id: I172d600d0162223d0b8d556a578d90ce6f5722e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824080Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#700244}
-
