Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 19 May, 2014 7 commits
    • nhiroki@chromium.org's avatar
      ServiceWorker: DB functions should return status code instead of boolean (2) · 844203eb
      nhiroki@chromium.org authored 
      Part1: https://codereview.chromium.org/275103004/

This change makes the following functions return status code instead of boolean.
- GetRegistrationsForOrigin()
- GetAllRegistrations()
- LazyOpen()
- ReadDatabaseVersion()

Other remaining functions will be fixed in the following CLs.


BUG=372704
TEST=should pass all existing tests

Review URL: https://codereview.chromium.org/287843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271329 0039d316-1c4b-4281-b951-d872f2087c98
      844203eb
    • nasko@chromium.org's avatar
      Create RenderFrameProxyHost at time of swap-out instead of commit. · 5a7100d5
      nasko@chromium.org authored 
      This CL moves the creation of RenderFrameProxyHost earlier in the timeline of cross-process navigation. Instead of waiting until commit time, it creates it at the time SwapOut message is sent to the old RenderFrameHost.
It also creates the renderer-side RenderFrameProxy object. Since now both sides have proxies, when in swapped out state, RenderFrameHost and RenderFrame send their messages through the proxies. This both helps verify proxies exist and paves the way of removing the notion of swapping out frames.

BUG=357747

Review URL: https://codereview.chromium.org/281663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271325 0039d316-1c4b-4281-b951-d872f2087c98
      5a7100d5
    • thakis@chromium.org's avatar
      linux: Lower static initializer expectations by 2 (chrome) / 3 (nacl_helper) after r271321. · ccb4b647
      thakis@chromium.org authored 
      BUG=94925
TBR=willchan@chromium.org

Review URL: https://codereview.chromium.org/293503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271324 0039d316-1c4b-4281-b951-d872f2087c98
      ccb4b647
    • thakis@chromium.org's avatar
      Revert of Revert of Elimate NOTIFICATION_GOOGLE_URL_UPDATED... · 85ee7aaf
      thakis@chromium.org authored 
      Revert of Revert of Elimate NOTIFICATION_GOOGLE_URL_UPDATED (https://codereview.chromium.org/294563002/)

Reason for revert:
Things cycled green before this revert became active on the testers.

Original issue's description:
> Revert of Elimate NOTIFICATION_GOOGLE_URL_UPDATED (https://codereview.chromium.org/284343003/)
> 
> Reason for revert:
> speculative, browser_tests stated timing out on all non-dbg win main waterfall test bots, with a message such as
> 
> 
> E:\b\depot_tools\python276_bin\python_slave.exe E:\b\build\scripts\slave\runisolatedtest.py --test_name browser_tests --builder_name "Win7 Tests (1)" --checkout_dir E:\b\build\slave\Win7_Tests__1_\build E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.exe -- E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.exe --brave-new-test-launcher --test-launcher-bot-mode --test-launcher-total-shards=3 --test-launcher-shard-index=0 --lib=browser_tests --gtest_print_time --gtest_output=xml:E:\b\build\slave\Win7_Tests__1_\build\gtest-results\browser_tests\browser_tests.xml --test-launcher-summary-output=c:\users\chrome~2\appdata\local\temp\tmpfbmzn9
> 
> E:\b\depot_tools\python276_bin\python_slave.exe E:\b\build\slave\Win7_Tests__1_\build\src\tools\swarming_client\isolate.py run --isolated E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.isolated -v -- --no-cr --test-launcher-bot-mode --test-launcher-total-shards=3 --test-launcher-shard-index=0 --gtest_output=xml:E:\b\build\slave\Win7_Tests__1_\build\gtest-results\browser_tests\browser_tests.xml --test-launcher-summary-output=c:\users\chrome~2\appdata\local\temp\tmpfbmzn9
>  INFO         isolate(685): CompleteState.load_isolate(E:\b\build\slave\Win7_Tests__1_\build, E:\b\build\slave\Win7_Tests__1_\build\src\chrome\browser_tests.isolate, {}, {}, {'EXECUTABLE_SUFFIX': '.exe'}, False)
>  INFO         isolate(156): normalize_path_variables(E:\b\build\slave\Win7_Tests__1_\build, {}, E:\b\build\slave\Win7_Tests__1_\build\src\chrome)
>  INFO  isolate_format( 57): determine_root_dir(E:\b\build\slave\Win7_Tests__1_\build\src\chrome, 80 files) -> E:\b\build\slave\Win7_Tests__1_\build\src
>  INFO         isolate( 84): recreate_tree(outdir=E:\b\build\slave\Win7_Tests__1_\isolate-2014-05-18gqemnl, indir=E:\b\build\slave\Win7_Tests__1_\build\src, files=9443, action=4, as_hash=False)
>  INFO         isolate(1266): Running ['E:\\b\\depot_tools\\python276_bin\\python_slave.exe', '../testing/test_env.py', u'..\\out\\Release/browser_tests.exe', '--test-launcher-bot-mode', '--no-cr', '--test-launcher-bot-mode', '--test-launcher-total-shards=3', '--test-launcher-shard-index=0', '--gtest_output=xml:E:\\b\\build\\slave\\Win7_Tests__1_\\build\\gtest-results\\browser_tests\\browser_tests.xml', '--test-launcher-summary-output=c:\\users\\chrome~2\\appdata\\local\\temp\\tmpfbmzn9'], cwd=E:\b\build\slave\Win7_Tests__1_\isolate-2014-05-18gqemnl\chrome
> 
> command timed out: 600 seconds without output, attempting to kill
> program finished with exit code 1
> 
> Original issue's description:
> > Elimate NOTIFICATION_GOOGLE_URL_UPDATED
> > 
> > This CL moves the remaining client of the NOTIFICATION_GOOGLE_URL_UPDATED
> > notification to instead register a callback with GoogleURLTracker and
> > eliminates the notification. It also migrate the GoogleURLTracker unittest from
> > listening for the notification to listening for the callback.
> > 
> > BUG=373261,373237
> > TBR=thakis
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271313
> 
> TBR=pkasting@chromium.org,blundell@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=373261,373237
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271320

TBR=pkasting@chromium.org,blundell@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=373261,373237

Review URL: https://codereview.chromium.org/287233007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271323 0039d316-1c4b-4281-b951-d872f2087c98
      85ee7aaf
    • mattm@chromium.org's avatar
      Add chrome/common/net/OWNERS, chrome/third_party/mozilla_security_manager/OWNERS · e6cd4557
      mattm@chromium.org authored 
      Also add rsleevi to c/b/net/OWNERS

BUG=none

Review URL: https://codereview.chromium.org/291553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271322 0039d316-1c4b-4281-b951-d872f2087c98
      e6cd4557
    • thakis@chromium.org's avatar
      tcmalloc: Only include cpu profiler in profiling=1 builds. · d03bd35e
      thakis@chromium.org authored 
      tcmalloc's cpu profiler code introduces several static initializers, and it's never
used on user machines.  So only include it in profiling=1 builds.
(The comment for profiling% in build/common.gypi even says that this
flag controls if cpuprofiler is used.)

BUG=94925
R=willchan@chromium.org

Review URL: https://codereview.chromium.org/287333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271321 0039d316-1c4b-4281-b951-d872f2087c98
      d03bd35e
    • thakis@chromium.org's avatar
      Revert of Elimate NOTIFICATION_GOOGLE_URL_UPDATED (https://codereview.chromium.org/284343003/) · f8917890
      thakis@chromium.org authored 
      Reason for revert:
speculative, browser_tests stated timing out on all non-dbg win main waterfall test bots, with a message such as


E:\b\depot_tools\python276_bin\python_slave.exe E:\b\build\scripts\slave\runisolatedtest.py --test_name browser_tests --builder_name "Win7 Tests (1)" --checkout_dir E:\b\build\slave\Win7_Tests__1_\build E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.exe -- E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.exe --brave-new-test-launcher --test-launcher-bot-mode --test-launcher-total-shards=3 --test-launcher-shard-index=0 --lib=browser_tests --gtest_print_time --gtest_output=xml:E:\b\build\slave\Win7_Tests__1_\build\gtest-results\browser_tests\browser_tests.xml --test-launcher-summary-output=c:\users\chrome~2\appdata\local\temp\tmpfbmzn9

E:\b\depot_tools\python276_bin\python_slave.exe E:\b\build\slave\Win7_Tests__1_\build\src\tools\swarming_client\isolate.py run --isolated E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.isolated -v -- --no-cr --test-launcher-bot-mode --test-launcher-total-shards=3 --test-launcher-shard-index=0 --gtest_output=xml:E:\b\build\slave\Win7_Tests__1_\build\gtest-results\browser_tests\browser_tests.xml --test-launcher-summary-output=c:\users\chrome~2\appdata\local\temp\tmpfbmzn9
 INFO         isolate(685): CompleteState.load_isolate(E:\b\build\slave\Win7_Tests__1_\build, E:\b\build\slave\Win7_Tests__1_\build\src\chrome\browser_tests.isolate, {}, {}, {'EXECUTABLE_SUFFIX': '.exe'}, False)
 INFO         isolate(156): normalize_path_variables(E:\b\build\slave\Win7_Tests__1_\build, {}, E:\b\build\slave\Win7_Tests__1_\build\src\chrome)
 INFO  isolate_format( 57): determine_root_dir(E:\b\build\slave\Win7_Tests__1_\build\src\chrome, 80 files) -> E:\b\build\slave\Win7_Tests__1_\build\src
 INFO         isolate( 84): recreate_tree(outdir=E:\b\build\slave\Win7_Tests__1_\isolate-2014-05-18gqemnl, indir=E:\b\build\slave\Win7_Tests__1_\build\src, files=9443, action=4, as_hash=False)
 INFO         isolate(1266): Running ['E:\\b\\depot_tools\\python276_bin\\python_slave.exe', '../testing/test_env.py', u'..\\out\\Release/browser_tests.exe', '--test-launcher-bot-mode', '--no-cr', '--test-launcher-bot-mode', '--test-launcher-total-shards=3', '--test-launcher-shard-index=0', '--gtest_output=xml:E:\\b\\build\\slave\\Win7_Tests__1_\\build\\gtest-results\\browser_tests\\browser_tests.xml', '--test-launcher-summary-output=c:\\users\\chrome~2\\appdata\\local\\temp\\tmpfbmzn9'], cwd=E:\b\build\slave\Win7_Tests__1_\isolate-2014-05-18gqemnl\chrome

command timed out: 600 seconds without output, attempting to kill
program finished with exit code 1

Original issue's description:
> Elimate NOTIFICATION_GOOGLE_URL_UPDATED
> 
> This CL moves the remaining client of the NOTIFICATION_GOOGLE_URL_UPDATED
> notification to instead register a callback with GoogleURLTracker and
> eliminates the notification. It also migrate the GoogleURLTracker unittest from
> listening for the notification to listening for the callback.
> 
> BUG=373261,373237
> TBR=thakis
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271313

TBR=pkasting@chromium.org,blundell@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=373261,373237

Review URL: https://codereview.chromium.org/294563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271320 0039d316-1c4b-4281-b951-d872f2087c98
      f8917890
  3. 18 May, 2014 31 commits
  5. 17 May, 2014 2 commits