- 16 Dec, 2020 40 commits
-
-
Morten Stenshorne authored
The offsets stored in NGLink are "paint offsets", which include any offsets caused by relative positioning. The fragment builder, on the other hand, expects "layout offsets", which shouldn't include that. The fragment builder adds the relative offset on its own at the right time. I struggled with coming up with a very sensible test, since fragmentation of out-of-flow descendants is incorrectly affected by the inset specified on their relatively positioned containing block (see crbug.com/1158387 and crbug.com/1158756 ). Bug: 1079031 Change-Id: I803dd89a11be2ba9179e20ea06d0b709d08ab534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593005Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#837692}
-
Jesse Schettler authored
Update all fonts in the Scan app to conform to the spec. Spec: https://carbon.googleplex.com/cros-ux/pages/scanning Before and after: http://shortn/_w86cpakDzE Bug: 1059779 Change-Id: I8c9018bc7978a176e0de5846ed8753b21395b15e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594210 Auto-Submit: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#837691}
-
Illia Klimov authored
Flash has been deprecated since M87. User-visible code was removed in M88. In this CL, I remove the last ContentSettingsType::PLUGINS non-critical call sites. Bug: 1149393 Change-Id: I6436e9d3c34f6dfd578538e6a1e7df06ae3bbffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584163 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#837690}
-
Becca Hughes authored
This reverts commit a4ee82d6. Reason for revert: Kaleidoscope has been turned down Original change's description: > Add metric for Kaleidoscope derived watchtime > > This adds a UKM metric to BasicPlayback that contains > whether the playback has come from a page that was > opened by Kaleidoscope. This is so we can track watchtime > that is attributable to Kaleidoscope. > > Ukm-Privacy-Review: https://docs.google.com/document/d/1XOeGNU34FlSv_rrs5TTovpc9gTyT4IQ3Rdy2T7oyLGQ/edit?usp=sharing > > BUG=1152935 > > Change-Id: Icc6047abddf1f4f1389c09a639e9a8c49c8f24ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558691 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835001} TBR=sky@chromium.org,dalecurtis@chromium.org,jwd@chromium.org,beccahughes@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1152935 Change-Id: Ie518f3b240341b75f867e2528aa6037731fb0bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595492Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#837689}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6bf9e131d05a..0c031adc5339 2020-12-16 treehugger-gerrit@google.com Merge "tp: Fix span_left_join for empty RHS tables" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I749f9187f6c1732b2306085d6585c75230789b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595990Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837688}
-
Xianzhu Wang authored
Bug: 1152869 Change-Id: Ie68a761a3cd2a81dcdd3de6d2469d64146c3f596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591907 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#837687}
-
Thomas Lukaszewicz authored
This CL limits the height of the Feedback dialog to the maximum available height of the user's screen. This CL also fixes the cancel / show buttons to the bottom of the window so that they remain visible in the overflow state. Also fixes a mismatch in feedback height constants. Dialog with overflow: https://drive.google.com/file/d/1tPJumvN2NmlSj5pI5htr18QHBJKCi6W9/view?usp=sharing Dialog with no overflow: https://drive.google.com/file/d/1OB1arIhF4t0cWfKZdTYGrmuk2vCWcczR/view?usp=sharing Bug: 1065889 Change-Id: If49afa489445df770063d3b7feda889900bcfdcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586759Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#837686}
-
Jonathan Wright authored
Reload the generate_build_files module after checking out the new BoringSSL hash to pick up assembly files generated for newly supported platforms. Without this change, the assembly files generated for newly supported platforms will not be committed as part of the roll. Change-Id: I7dbeefc650b3dfc52b73bd9a98fecf7f55e1910f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593639Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#837685}
-
Matt Menke authored
Currently, the test fails when all ExpectCT partitioning options is enabled, because its call to AddExpectCT() uses an empty NetworkIsolationKey, while its other calls use a specific transient key. This CL fixes the test to pass in the same transient key. This CL doesn't modify the test to enable ExpectCT partitioning, since that has to be done before the TransportSecurityState is constructed. Bug: 969893 Change-Id: Ie36e8d0fc8c10028f57925d393309dd3e1658faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595628Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#837684}
-
Anne Lim authored
AutofillCacheServerCardInfo is fully rolled out, so removing flag. Fixed: 1077617 Change-Id: I850f8f4cda663dcfb8303742df1a9abe7ee58d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593154Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#837683}
-
Christopher Cameron authored
Change "p3" color space to "display-p3". This is the name used in the specification and in the CSS color level 4 specification (which is shipping on Safari). Of note is that is that the color gamut media queries use "p3" instead of "display-p3". This could be intentional (reflecting the P3 *primaries* common to DCI P3 and Display P3 *color spaces*), or may be accidental. Change ImageDataColorSettings to ImageDataSettings. Right now all of the settings are for color, but the spec doesn't put color in the name because of future plans to add other settings (like premultiplied alpha). The largest remaining inconsistency is that "pixelFormat" versus "storageFormat" and "uint8" versus "unorm8". R=yiyix TBR=fserb Bug: 1083693 Change-Id: I8e6d476a17fd2fca8da6b7901bb1098253a61559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594269 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#837682}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df1712b41e9f..6bf9e131d05a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I37d3b0c2a214ae804a86edfaf14f0e64b304b2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595517Reviewed-by:
-
David Tseng authored
On official builds, the unified status tray appears to be inactive; test always fails. Re-enable for non-officila builds, which still exercises views UI + STS reading. R=akihiroota@chromium.org Fixed: 1158879 Change-Id: I2fc7b4e6bb922c6d60aa819a73ce3a41b3afc003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595491 Auto-Submit: David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#837680}
-
Sergei Glazunov authored
Move the problematic include under the ENABLE_BACKUP_REF_PTR_IMPL flag. Change-Id: I15340b867bb51fda4894ea260bdd8ac59f666e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595369 Auto-Submit: Sergei Glazunov <glazunov@google.com> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#837679}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9e5d60a44d42..2d976f379ec5 2020-12-16 wolfi@chromium.org Remove "blackbox" - refactor CallStackSidebarPane 2020-12-16 brgoddar@microsoft.com Network: Fix Har Importer 2020-12-16 wolfi@chromium.org Remove "blackbox" - rename css classes 2020-12-16 andoli@chromium.org [module.json extensions] Add 'localizableTitle' field to ViewRegistration interface 2020-12-16 tvanderlippe@chromium.org Enable no-implicit-coercion ESLint rule for test/ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1082789,chromium:1134103,chromium:1152082,chromium:1158442 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib91615c86137cb460f2f0ae3eb10a1ba509f5eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595813Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I777b4d57b5c1ee687563a6b4ecf719489dd00894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595687Reviewed-by:
-
Bailey Berro authored
This change adds an additional status code so that we can notify the receiver when there is no connection mediums. Bug: 1156391 Change-Id: I966269142071e3d793bfb31d86a9127ae5af92b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594308 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#837676}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Icac335812c91f36aa4ba686847e89e3d3352d31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595688Reviewed-by:
-
Mason Freed authored
It seems that we can (now) get a null ContainingShadowRoot() at [1], after the removal of Shadow DOM v0 in [2]. This change should hopefully keep from crashing in that situation, while we figure out how to duplicate this crash. [1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/html/html_slot_element.cc;l=742;drc=c78893f538264a54306acedcc747ec1e63faa97a [2] https://chromium.googlesource.com/chromium/src/+/e9aef1ba859e5942b9e8f5396380008b4443f69d Bug: 1159328 Change-Id: Ic6819e518402902c4a71167cf98662c112036993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595967 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#837674}
-
Ben Joyce authored
Change-Id: Ib8577b9041b6fe025389509173cd104b13c742da Bug: 989569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436319Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#837673}
-
Brandon Wylie authored
Bug: 1158585 Change-Id: I6a3949bfb80574a9ef9e3b4101b53f748f47f732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593920 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837672}
-
Edward Lesmes authored
Bug: 1113033 Change-Id: If2735b362dbb8e18742a28be16d28840f57c52a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593972 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#837671}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/24e738a6..df6c3b4a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8ec40187a87d36ff006b68ae62f6c7d099720e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595509Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837670}
-
Mike Taylor authored
This CL rewrites the tests contained in charset-tests.html, chromium-tests.html,and comma-tests.html. It also creates httpCookieTest (inside cookie-test.js) and rewrites tests to use it. The idea is that we probably want to have a domCookieTest in the future, and this will make it less messy. Relates to https://github.com/web-platform-tests/wpt/issues/26190 Bug: 1152798 Change-Id: If5fa785b5b14c2596445ab1c7ac0926209f04314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568750 Commit-Queue: Mike Taylor <miketaylr@chromium.org> Auto-Submit: Mike Taylor <miketaylr@chromium.org> Reviewed-by:
Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#837669}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/352fcae17686..772ccd850137 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC smcgruer@google.com,jdoerrie@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1043080 Tbr: smcgruer@google.com,jdoerrie@google.com Change-Id: I7e1afc636788a15b04fd2388b66c7866ee411d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594098Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837668}
-
Olivier Li authored
By default only histogram reporting is activated to avoid overloading crash/ with reports. Bug: 1157943 Change-Id: I49777e96a969922e0c172ed3468e40e8fe4c38ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587370Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#837667}
-
Ehimare Okoyomon authored
Bug: 1158288 Change-Id: Idd673cd14b82aebb7a1b75ee142042e6a0e340a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590724 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
Changing "Sanity-check" to "Confidence check". go/chrome-signin-inclusive Change-Id: Ib50a43a987840806aec95a37f037552ad0a8f1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594771 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#837665}
-
Peter E Conn authored
Change-Id: Ia5dda55e22af49b0b035d9b615664eed68b62c17 Bug: 1157970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587162 Auto-Submit: Peter Conn <peconn@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#837664}
-
Becca Hughes authored
Change-Id: I28a323037b8a7d6131a1ab3e36eb6fba0da61447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595513 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#837663}
-
Matt Menard authored
Makes print servers selector dropdown width only expand to the width of the search input. Previously it would expand to the bounds of the print preview dialog below it. Bug: b:168650771 Change-Id: I9c3eef88b1fe9efaf4ac9ab27f44c4f5bfded01a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586376 Commit-Queue: Matt Menard <mattme@google.com> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#837662}
-
Michael Checo authored
Screenshots: WiFi only description - http://shortn/_COo6l2R5JA Mobile Data description/label - http://shortn/_EgYNIQqZYG Bug: 1158614 Change-Id: I912c45602e9c88ac874e499020c4a3c8a9d9f6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594067Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Nancy Wang authored
This reverts commit 93ae228e. Reason for revert: <INSERT REASONING HERE> This CL relands CL:2586647, which is reverted because breaks the test: PluginVmFilesTest.LaunchPluginVmApp The reason is |mock_window| is accessed after free, because after the end of the test, when launcher_item_controller is destroyed, |mock_window| is accessed. Modify the test case, to set the controller, so that |mock_window| can be removed from |launcher_item_controller|'s windows list. Modify AppWindowBase, to check whether widget_ is null in GetNativeWindow to avoid crash, because widget_ is null in the test case. So CL:2586647 can be relanded again. Change-Id: I50cb7b138bda0e588ad97b62297a855df48c0239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592077Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837660}
-
Xida Chen authored
This CL converts the ErrorCallback in the mtp_device_async_delegate.h to a base::RepeatingCallback. We use a RepeatingCallback instead of OnceCallback because in the MTPDeviceDelegateImplLinux::CopyFileFromLocal this callback is used twice. Bug: 1152278 Change-Id: I002dceb79ebf017c138b1d0aaf5d85d8d161be83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593477Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#837659}
-
Stephen McGruer authored
Also moved previously generally disabled tests to only be disabled on ChromeOS because they only appear to be flaky there according to crbug.com/1157649 TBR=oshima@chromium.org Bug: 1157649 Change-Id: Ia9dec49edcea6fc5f0e47f0fc74f30699adf1270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595830Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#837658}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/54174aefa84c..6bf9e131d05a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7eb33ff5561022ba9ff48ff207654bb3ea983d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595508Reviewed-by:
-
Mila Green authored
Here is the new state: $ launchctl list | grep GoogleUpdater - 0 com.google.GoogleUpdater.update - 0 com.google.GoogleUpdater.wake.89.0.4357.0 - 0 com.google.GoogleUpdater.update-internal.89.0.4357.0 $ launchctl list com.google.GoogleUpdater.update { "LimitLoadToSessionType" = "Aqua"; "MachServices" = { "com.google.GoogleUpdater.update.mach" = mach-port-object; }; "Label" = "com.google.GoogleUpdater.update"; "OnDemand" = true; "LastExitStatus" = 0; "Program" = "/Users/milagreen/Library/Google/GoogleUpdater/89.0.4357.0/GoogleUpdater.app/Contents/MacOS/GoogleUpdater"; "ProgramArguments" = ( "/Users/milagreen/Library/Google/GoogleUpdater/89.0.4357.0/GoogleUpdater.app/Contents/MacOS/GoogleUpdater"; "--server"; "--service=update"; "--enable-logging"; "--vmodule=*/updater/*=2"; ); }; $ launchctl list com.google.GoogleUpdater.update-internal.89.0.4357.0 { "LimitLoadToSessionType" = "Aqua"; "MachServices" = { "com.google.GoogleUpdater.update-internal.89.0.4357.0.mach" = mach-port-object; }; "Label" = "com.google.GoogleUpdater.update-internal.89.0.4357.0"; "OnDemand" = true; "LastExitStatus" = 0; "Program" = "/Users/milagreen/Library/Google/GoogleUpdater/89.0.4357.0/GoogleUpdater.app/Contents/MacOS/GoogleUpdater"; "ProgramArguments" = ( "/Users/milagreen/Library/Google/GoogleUpdater/89.0.4357.0/GoogleUpdater.app/Contents/MacOS/GoogleUpdater"; "--server"; "--service=update-internal"; "--enable-logging"; "--vmodule=*/updater/*=2"; ); }; Bug: 1143718 Change-Id: I66289cebf8d35acc63cbbc9c5e3d46d7da283df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594118Reviewed-by:Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#837656}
-
Sigurd Schneider authored
Transfering SABs via postMessage will be prohibited soon. This CL adds an inspector issue if such an attempt is made so as to provide a warning for this breaking change to users. The warning is only filed once per execution context to not impair performance during the transition period (getting the source position and sending the issue to the front-end has quite some overhead). Once the transfer is forbidden (postMessage throws on SABs then), the warning will be filed on every attempt. Bug: chromium:1138945 Change-Id: I6c0596afa2276118a3e6e6de1a1410fa76e9aaa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593087Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#837655}
-
Angela Yoeurng authored
Bug: 1129612 Change-Id: I12d09d4699505b26df91058a9bbf74f3cb2f0e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590507Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Auto-Submit: Angela Yoeurng <yoangela@chromium.org> Cr-Commit-Position: refs/heads/master@{#837654}
-
David Bokan authored
This CL converts two calls to base::Bind into base::BindOnce in hid_api.cc This requires converting: - HidDeviceManager::GetApiDevices - DevicePermissionsPrompt::AskForHidDevices To using a OnceCallback. Both methods can store the callback but always clear it after the only invocation site so we're guaranteed this only runs once. Bug: 1152268 Change-Id: I07a9f50c5eb57b987de220408e8d7f9249bed8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593563Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#837653}
-
