GitLab

A static code analyzer reports an error in usb_midi_output_stream.cc, which
is a message_size_table buffer overflow. This CL fixes the code.
Note that the reported error never happens and hence the fix doesn't change
the behavior.

BUG=427616

Review URL: https://codereview.chromium.org/694733002

Cr-Commit-Position: refs/heads/master@{#302560}

BatteryStatusServiceTest.AddCallbackAfterUpdate
BatteryStatusServiceTest.RemoveOneCallback
BatteryStatusServiceTest.TwoCallbacksUpdate

These tests fail on DrMemory bots and locally on Windows.

NOTRY=true
TBR=timvolodine
BUG=429942

Review URL: https://codereview.chromium.org/699823002

Cr-Commit-Position: refs/heads/master@{#302559}

The AppCacheUpdateJob::URLFetcher cancels redirects in general.
This change allows redirects that are generated by the data
reduction proxy bypass mechanism. This is a workaround until
crbug.com/429505 is resolved.

BUG=429011

Review URL: https://codereview.chromium.org/695193002

Cr-Commit-Position: refs/heads/master@{#302558}

We are going to use this property from the JS side to know whether a task is generated from generic file handler or not.
Generic file handler is a file handler which can handle any type of file.

e.g.
These are generic handlers.
"types": ["*/*"]
"types": ["*"]
"types": ["*/*", "image/jpeg"]
"extensions": ["*"]
"extensions": ["*", "jpg"]

These are not generic handlers.
"types": ["image/jpeg"]
"types": ["image/*"]
"extensions": ["jpg"]
"extensions": ["jpg", "png"]

BUG=414566
TEST=out/Release/unit_tests --gtest_filter=FileManagerFileTasksTest.IsGenericFileHandler:FileManagerFileTasksComplexTest.FindFileHandlerTask_Generic

Review URL: https://codereview.chromium.org/686393002

Cr-Commit-Position: refs/heads/master@{#302557}

This fixes the call of device.PushChangedFiles; see example of correct usage here: https://code.google.com/p/chromium/codesearch#chromium/src/build/android/provision_devices.py&q=PushChangedFiles

This change should fix the breakage of the chrome-proxy tests that was
introduced in https://codereview.chromium.org/656383002/.

BUG=429313

Review URL: https://codereview.chromium.org/689213002

Cr-Commit-Position: refs/heads/master@{#302556}

Review URL: https://codereview.chromium.org/703433003

Cr-Commit-Position: refs/heads/master@{#302555}

BUG=390086

Review URL: https://codereview.chromium.org/693433002

Cr-Commit-Position: refs/heads/master@{#302554}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a6ca5a0..7c11aad

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/699813002

Cr-Commit-Position: refs/heads/master@{#302553}

The MacViews "chrome" compile regressed in r301203

This adds a stub that just returns
scoped_ptr<ConstrainedWindowViewsClient>(nullptr) and fixes some
NativeWindow/NativeView inconsistencies (popup_manager->GetHostView()
returns a view).

The component is compiled on MacViews, since it will eventually be
needed. At link time for `chrome`, everything except the a pure virtual
destructor call will be culled since they are unused, but this approach
keeps component usage consistent with the test targets, which do have
the whole component.

note that components_unittests ConstrainedWindowViewsTest.* all pass on
a MacViews build except for one check against a dialog size
(constrained_window_views_unittest.cc line 142).

BUG=390755, 410499

Review URL: https://codereview.chromium.org/699553002

Cr-Commit-Position: refs/heads/master@{#302552}

https://codereview.chromium.org/699643002 moved
gpu_memory_buffer_factory_x11.cc to *_linux.cc. Since Ozone provides its
own implementation there are multiple definitions of the same symbol.

BUG=none
NOTRY=true
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/688493003

Cr-Commit-Position: refs/heads/master@{#302551}

It2me is currently behind a flag on Chrome OS.  This CL enables It2me on Chrome
OS in the webapp when the flag is enabled.  It also removes the function
remoting.runningOnChromeOS() which does exactly the same thing as
remoting.platformIsChromeOS().

Review URL: https://codereview.chromium.org/695363002

Cr-Commit-Position: refs/heads/master@{#302550}

BUG=427707
NOTRY=true
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/684253005

Cr-Commit-Position: refs/heads/master@{#302549}

This makes adb_reverse_forwarder.py a little more convenient
to use.

BUG=429859

Review URL: https://codereview.chromium.org/684383004

Cr-Commit-Position: refs/heads/master@{#302548}

Retrieve font metrics from skia if DirectWrite is enabled for font metrics calculations in the chrome browser UI.

The previous patch for getting the correct font metrics from DirectWrite https://codereview.chromium.org/692633003/
was wrong as it did not return the correct font metrics in all cases.

Getting the metrics from skia ensures that we get the same font metrics which would be used by skia for rendering.

Changes in this patch are as below:-
1. Removed DirectWrite factory code from PlatformFontWin. The PlatformFontWin::ConvertGDIFontToDirectWriteFont
   function has been replaced by the CreateHFontRefFromSkia function. This function is called if DirectWrite is
   enabled in the browser which sets a static bool on the PlatformFontWin class.

BUG=428645,427804,427802

Review URL: https://codereview.chromium.org/696913002

Cr-Commit-Position: refs/heads/master@{#302547}

BUG=

R=mmenke, rdsmith, jwd

TEST=NetInternalsTest.netInternalsTourTabs
     NetInternalsTest.netInternalsExport*/Import*
     NetInternalsTest.netInternalsSdchView*

Review URL: https://codereview.chromium.org/423813002

Cr-Commit-Position: refs/heads/master@{#302546}

BUG=429915
NOTRY=true

Review URL: https://codereview.chromium.org/705483002

Cr-Commit-Position: refs/heads/master@{#302545}

This should get the v2 launch test to start passing again.

BUG=424690

Review URL: https://codereview.chromium.org/703453003

Cr-Commit-Position: refs/heads/master@{#302544}

Review URL: https://codereview.chromium.org/685983004

Cr-Commit-Position: refs/heads/master@{#302543}

Most changes are updates to the mojom syntax for modules.

R=viettrungluu@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/698883005

Cr-Commit-Position: refs/heads/master@{#302542}

The reauth is needed to acquire the user's password to add a new cryptohome
key for sign-in.

BUG=409427

Review URL: https://codereview.chromium.org/668213003

Cr-Commit-Position: refs/heads/master@{#302541}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c51b33e..fca5a7c

TBR=morrita@chromium.org,vsevik@chromium.org

Review URL: https://codereview.chromium.org/695403005

Cr-Commit-Position: refs/heads/master@{#302540}

visa-mdpi is missing, so it's a placeholder for now.

NOTRY=true
TBR=dtrainor@chromium.org
BUG=400904

Review URL: https://codereview.chromium.org/698173002

Cr-Commit-Position: refs/heads/master@{#302539}

Move the Developer Website and Licenses links in the App Info dialog to
below the description, if they exist. Change the 'View in Webstore' link
to always display directly under the app name, even if a developer
website is already provided.

BUG=423252

Review URL: https://codereview.chromium.org/691253002

Cr-Commit-Position: refs/heads/master@{#302538}

This is a temporary fix to a bug where the popup is shown then immediately
hidden as a result of the keyboard showing. Reverting to the old two click
behavior, on Android only, until we can fix the underlying issue.

BUG=423464

Review URL: https://codereview.chromium.org/695953003

Cr-Commit-Position: refs/heads/master@{#302537}

I misunderstood how ObjectiveC handled pointers declared with __weak.
This change resolves the issue by nil'ing things out in
[TabController dealloc], the standard solution.

Introduced by: https://codereview.chromium.org/688523002/

BUG=429605

Review URL: https://codereview.chromium.org/699013002

Cr-Commit-Position: refs/heads/master@{#302536}

This pulls in the following Native Client changes:

r14010: (shyamsundarr) allow 16 bit xadd (including atomic version) in ia32.
r14013: (hidehiko) Non-SFI mode: Add MSG_TRUNC and MSG_CTRUNC to sys/socket.h
r14014: (yyanagisawa) Exponential backoff sleep time on WindowsError.
r14015: (shyamsundarr) enable 16 bit cmpxchg in ia32.
r14017: (maruel) Normalize paths in pnacl/driver/driver_tools.py.
r14019: (mcgrathr) toolchain_build: Switch gcc to 4.9 branch

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk,linux_chromium_dbg

Review URL: https://codereview.chromium.org/698973002

Cr-Commit-Position: refs/heads/master@{#302535}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/37dd331..a6ca5a0

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/701593003

Cr-Commit-Position: refs/heads/master@{#302534}

The TitleCondensed string property is now used to pass strings
for accessibility.  This gets around the inability to
set the content description normally for the custom menus.

BUG=293658

Review URL: https://codereview.chromium.org/691113005

Cr-Commit-Position: refs/heads/master@{#302533}

Add a new FindTextData class to store the index to avoid all the size_t
to int casts.

BUG=416696

Review URL: https://codereview.chromium.org/691273003

Cr-Commit-Position: refs/heads/master@{#302532}

Review URL: https://codereview.chromium.org/690213004

Cr-Commit-Position: refs/heads/master@{#302531}

BUG=397019

Review URL: https://codereview.chromium.org/687323003

Cr-Commit-Position: refs/heads/master@{#302530}

R=lcwu@chromium.org,byungchul@chromium.org
BUG=429837

Review URL: https://codereview.chromium.org/687723005

Cr-Commit-Position: refs/heads/master@{#302529}

BUG=none
TBR=asargent

Review URL: https://codereview.chromium.org/697903002

Cr-Commit-Position: refs/heads/master@{#302528}

These are uninteresting because they are not keyboard keys and because
they are redundant with button presses & MT contacts in gestures. We
could possibly pass on the "tool" used (BTN_TOOL_*) for touch, but we
currently don't use it.

BUG=none
TEST=ran chrome on link_freon, no more "unknown key" errors

Review URL: https://codereview.chromium.org/703493002

Cr-Commit-Position: refs/heads/master@{#302527}

Now that the CDM is generating SessionKeysChange events, it is no
longer necessary to intercept Update() and Load() promises and
call ResumePlayback() when they are resolved.

BUG=370251,413413
TEST=existing EME tests pass

Review URL: https://codereview.chromium.org/697203003

Cr-Commit-Position: refs/heads/master@{#302526}

BUG=378741
TEST=Start Chrome with --enable-new-profile-management. You'll need to
create a supervised user so that Lock is available to signed in profiles.
Lock a profile, and in the User Manager type an incorrect password. Once
the error bubble shows up, resize the User Manager. The bubble should be
repositioned along with its parent pod.

Review URL: https://codereview.chromium.org/698023004

Cr-Commit-Position: refs/heads/master@{#302525}

On ChromeOS, Chrome links in the remoting host, which isn't gn-ified yet.
I'm not quite sure why app_shell doesn't work, but it might be the same
issue.

TBR=cmasone@chromium.org
BUG=424337

Review URL: https://codereview.chromium.org/697223004

Cr-Commit-Position: refs/heads/master@{#302524}

Use the existing views API (views::Widget::GetWidgetForNativeView()) to
get any existing views::Widget for an athena::Activity, instead of asking
its ActivityViewModel.

BUG=none
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/702473005

Cr-Commit-Position: refs/heads/master@{#302523}

Also measure the number of frame loads for comparison, and the number of Flash instances created while we are at it.

BUG=403800

Review URL: https://codereview.chromium.org/687273004

Cr-Commit-Position: refs/heads/master@{#302522}

Currently both of two are measured by one metric, but there is no meaning of JavaScript measurements in application test and of Speed Index in micro benchmark. This patch separate the two types of performance tests into different page_sets, and different measurements.

BUG=372759
TEST=./tools/perf/run_benchmark --browser=android-chrome-shell service_worker.service_worker
TEST=./tools/perf/run_benchmark --browser=android-chrome-shell service_worker.service_worker_micro_benchmark

Review URL: https://codereview.chromium.org/688563002

Cr-Commit-Position: refs/heads/master@{#302521}