- 11 Sep, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9a7e7b08a74e..4331ba7ac01d 2020-09-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from ccab4cc42372 to d19622688af4 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Ida51c42eae42a3c94f0add7668d9e769ee30a87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406139Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806164}
-
Jan Wilken Dörrie authored
This mitigation was added during the launch of Password Sync USS. Since deleting all sync metadata is intrusive and unprecedented, the feature toggle was added as safety mechanism and has always been enabled by default. Looking at UMA, it's safe to drop this feature. It is doing the right thing in the rare occasion of failure in reading sync metadata. Bug: 1126051 Change-Id: I8c19b60d30d1d1389b2ab9078ace3f5b0af078dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404448Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#806163}
-
Jordan Oroshiba authored
PermissionInfo.Type contained a subset of ContentSettingTypes. Since both this and the previously existing ContentSettingException.Type needed to be translated to and from ContentSettingType for save, these intermediary types only created more obfuscation of what is happening in the code. Bug: 1103597 Change-Id: Ie8bb7dbf388c48042291e1d2cb403299c35cefad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340878 Commit-Queue: Jordan Oroshiba <oroshiba@google.com> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#806162}
-
Anthony Cui authored
Consolidate translation check and execution logic between TranslateManager and RenderViewContextMenu Consolidated logic by having RenderViewContextMenu::ExecTranslate call TranslateManager::InitiateManualTranslation, and RenderViewContextMenu::AppendPageItems call TranslateManager:CanManuallyTranslate. Bug: 898168 Change-Id: If91cf98626f73d0c357522f8fdca840695185bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385636Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Anthony Cui <cuianthony@chromium.org> Cr-Commit-Position: refs/heads/master@{#806161}
-
Adam Langley authored
A GCMDriver is needed in order to register a handler and, by exposing this accessor, users need only get an InstanceIDDriver. Change-Id: I49cc32e6e78a418ca9352745cf07ec4ee2e256aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405533 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#806160}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I521dc064f7ae4522b25a3c7c003d608616acba05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401521 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#806159}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0b1f73521ce7..3103138c4fb2 2020-09-11 szuend@chromium.org [ts] Type-check sources/Plugin.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5b1426300df6454d42dfc24de37d79dd3a7b5320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406138Reviewed-by:
-
Maksim Sisov authored
DisplayRenderer uses DisplayColorSpace to get suitable output buffer format for Reshape(). However, Wayland didn't set that and default value (RBGA_8888) was used instead. This didn't work well as Wayland may have crashed because this specific buffer format wasn't supported. My observation showed that Chromium supports either BGRA_8888 or RGBA_8888 as default buffer formats. Thus, figure out, which of them is supported and use that when creating Display. This fixes a crash that results in the following error - wl_display@1.error(zwp_linux_buffer_params_v1@16, 7, "failed to import supplied dmabufs: Unsupported buffer format 875708993") Bug: 1123382, 1121912 Change-Id: I7b3745726143f9c71db5bc8942be9933e67b7a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401041 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806157}
-
Mario Sanchez Prada authored
These two methods are the only ones, among those that implement the mojom::FrameHost interface in RenderFrameHostImpl, that are kept in the public section of RFHI instead of being private, as it's the case for the other methods of mojom::FrameHost. Doing some quick investigation, I found out that the only places where these methods are directly accessed from outside of RFHI are related to tests (i.e. either tests or test-focused helpers), so it seems like it would make sense to move these 2 methods, along with the other ones, to the private section and adapt those tests and test-related helpers that need access to them. This CL does that, hopefully making it clearer in the future that the implementation of mojom::FrameHost should be private to RFHI. Bug: 1093920, 1102421 Change-Id: I5bf23c59082eb982d152083f96d264522cc58a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403261Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#806156}
-
Richard Knoll authored
Synchronizing displayed notifications helps to clean up already closed notifications from the NotificationDatabase. This implements this functionality for ChromeOS via the MessageCenter. Bug: None Change-Id: I660f2263451ca734887da63f0c7ab43cd12ab2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391087 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
After https://crrev.com/c/2260642, Aura/X11 was ported to the Ozone infraestructure for cursor loading. That meant removing CursorLoaderX11, which implemented cursor theme changes. In Ozone, cursor theme support was explicitly initialized after LinuxUI was built. This CL enables the same code path for Aura/X11. Additionally, add a DCHECK to make sure CursorThemeManager is always initialized in X11 builds. Bug: 1126830 Change-Id: Ia9e9bbbd9d277df2a432f3cb344d3b30b9551f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401621Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#806154}
-
Chris Lu authored
Bug: 1107489 Change-Id: I2604a982f3a31ed7be5d8b74eb6fe5aae2564fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404377 Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#806153}
-
Christian Biesinger authored
R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1083010 Change-Id: I0fd5bd70b2a1ce8017d4499c525b382ed8066c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403840 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#806152}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/948b3a05550b..d05e532c6bd2 2020-09-11 cwallez@chromium.org Fix typo in README.md If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I7980a114f76bfa750cfe1cdf42f9d22118ba9ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406133Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/60c25a303fac..f5c373b5fb1d 2020-09-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4bbb1de3..55b6d728 (805973:806095) 2020-09-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a3dcf9ef..4bbb1de3 (805834:805973) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib16855a5307cdfcb00c84292c94faea1243ca0ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406134Reviewed-by:
-
Vidhan authored
This CL improves the readability of form_structure_unittest.cc by reducing the redundant code and introducing form field factory. Bug: 1127001 Change-Id: I172d738847af114d16a11f68356cc5fb01e68f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332704 Commit-Queue: Vidhan Jain <vidhanj@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#806149}
-
Christoph Schwering authored
FormStructure::GetIdentifierForRefill() is not stable across dynamic changes. If a cache update happens before the refill is executed, the identifier may change in the meantime and we may thus refer to the wrong form. Bug: 1114787 Change-Id: I6792829192414e8e52d239b62899ea45e0465a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404162Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
-
Alexandre Courbot authored
ContinueChangeResolution() had a DCHECK() that made sure that no CAPTURE buffers were queued when the method was called. This is incorrect ; especially for stateful decoders where we passively queue all CAPTURE buffers as they become available, and can also happen with stateless decoders as well. BUG=b:168193954 TEST=video.DecodeAccelVD.h264_resolution_switch does not raise this trigger anymore on hana-kernelnext. Change-Id: Ia86e99e59a1665fe21f7c21eccee36c75840d0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405346 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806147}
-
Alexandre Courbot authored
This makes clang-tidy happy. BUG=None TEST=Chromium builds for hana-kernelnext. Change-Id: I386a88e33ebc3d10c6c570e281b26936180dc333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405345 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
-
Christian Biesinger authored
R=ikilpatrick@chromium.org Bug: 1083010 Change-Id: I2c3bfe0990df216e499142194d4ecb20cd9405e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401502 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Nela Kaczmarek authored
This change implements a callback mechanism to notify callers when a response comes from Google Affiliation API. The mentioned mechanism is being used in WellKnownChangePasswordState. Bug: 1108279 Change-Id: Ic70883ad4569770b1e3a0af6c254c39568be886a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398482 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#806144}
-
Alex Rudenko authored
node_id_to_number_focused_children_ could contain not only Element instances resulting in a DCHECK failure when a non-element node was converted to Element using To<Element> in InspectorCSSAgent::ResetPseudoStates. This resulted in a crash on ChromeOS and stack buffer overflow on other platforms. Fixed: 1123526 Change-Id: I7d29f4813ced44be7303e8c6060750863cf0851a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403473Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#806143}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/617d3f67c3d9..5dc147f282ab 2020-09-11 hjd@google.com Fix clock_tracker.cc 2020-09-11 ssid@google.com Merge "Avoid race in accessing log count" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iaa37af738397a74c6953449f17ed856287acd9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406132Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/44c9ca6a2c0e..d9ddf43a38c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC orphis@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: orphis@google.com Change-Id: I014e334ab708e71f06627a5cff15316aa8483222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406094Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806141}
-
Garrett Beaty authored
These compile targets are currently specified in recipe configuration. They were missed previously because the builders were configured to read a different source side spec file. Bug: 1091004 Change-Id: I2e4ec7017334dbd3c84dede9e519acaf8b81a5bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404750Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#806140}
-
Jan Wilken Dörrie authored
This change unifies the kEditPasswordsInDesktopSettings and kPasswordEditingAndroid features flags into a single kEditPasswordsInSettings flag. It also deletes chrome://flags#password-editing-android and uses chrome://flags#edit-passwords-in-settings instead. Bug: 377410, 1126051 Change-Id: I73b031c772f66a3cfb594985b39ab47b94510a0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403467 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Carlos Caballero authored
This seems to be causing some tests to flake. Tests fail because page A is not being cached which is strange (at that point in the test we haven't done anything yet). So the theory is that the initialization might have some pending tasks (note no RunLoop::RunUntilIdle) that might interfere with the caching. The initialization is not really needed (that is the default) so we can just remove that line. Bug: 1126494 Change-Id: I03e5f7238966ac346e484a9f7072f442aa917159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402939Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#806138}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5eb6da2205cd..0b1f73521ce7 2020-09-11 jacktfranklin@chromium.org Migrate AccessibilitySidebarView to TypeScript 2020-09-11 changhaohan@chromium.org Complete ARIA tree support to Computed pane 2020-09-11 szuend@chromium.org [ts] Type-check sources/OutlineQuickOpen.js with TypeScript 2020-09-11 patrick.brosset@microsoft.com Layout: Avoid shrinking color swatches in layout panel 2020-09-11 szuend@chromium.org [ts] Remove unnecessary @ts-nocheck from sources/CoveragePlugin.js 2020-09-11 chrche@microsoft.com [Loc] Avoid unnecessary escodegen calls in presubmit 2020-09-11 patrick.brosset@microsoft.com Layout: Scroll to the grid container when the go-to-grid icon is clicked 2020-09-11 petermarshall@chromium.org Add owners for scripts/localization 2020-09-11 szuend@chromium.org [ts] Remove unnecessary @ts-nocheck from sources/ScriptOriginPlugin.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1109177,chromium:1116989,chromium:1125511,chromium:1125958 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1058114a25c7f966741ac02022419f1db3a64ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405971Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599659830-8ef8811788e74327dac6ace27b47b5f70375bbf0.profdata to chrome-win32-master-1599781911-129feccf91ed1046080abe39627e119a3ba44fb5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I3286de9a0ff12f5a7f46f610b03cc6448996bc0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405878Reviewed-by:
-
Florent Castelli authored
This reverts commit 1bef8501. Reason for revert: Tests failing on bots Bug: 1127298 Original change's description: > [fuchsia] Enable UDPSocketTest.JoinMulticastGroup > > Assert after each send call to better pinpoint future problems. > > The test passes locally. > > Fixed: 1125855 > Change-Id: I30d5c7bd2bc14fbd9547b1eb6d309d7556274891 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404483 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Tamir Duberstein <tamird@google.com> > Cr-Commit-Position: refs/heads/master@{#806111} TBR=wez@chromium.org,kinuko@chromium.org,tamird@google.com Change-Id: I3fa647ceff4886c11b0de980a058b99c3c6d1bde No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404932Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#806135}
-
sandromaggi authored
These can be abstracted and unified. Bug: b/168107066 Change-Id: I0983ee22dd5980d09adb5a9e162f1c6a9eaa5f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404342 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#806134}
-
Maxim Kolosovskiy authored
scripts Bug: 1095627 Change-Id: Ic7a328d7c0df70bd2c51e14df4c75cf95d2df079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404785Reviewed-by:
-
https://crrev.com/c/2336321Fergal Daly authored
Remove the null-check on GetFrameTree(). It's not needed now that interstitials are gone. Move FrameTree::CreateRenderViewHost's call to RegisterRenderViewHost into RenderViewHostImpl's constructor. Now both registration and unregistration is managed by RenderViewHostImpl. Bug: 1072817 Change-Id: I551919f586dff006256a34162d263cfd468f8c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387882 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#806132}
-
sandromaggi authored
This continues the effort to make |WebController| actions use |ElementFinder::Result| instead of |Selector|. Bug: b/168107066 Change-Id: Idfa4e86075d4c650740ac5d7a325243c4d73d850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401103 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
-
Benoit Lize authored
On Windows 64 bits, alignof(std::max_align_t) is 8, but we need 16 for operator new(). This is not the case on Linux for instance, and in https://chromium-review.googlesource.com/c/chromium/src/+/2219498 we followed the standard for malloc(), but not for operator new. Make sure we respect the more stringent of the two criteria. Bug: 998048 Change-Id: I01f060d710f11adb5fb41dc8d332c1c690c2b508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404444 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#806130}
-
Friedrich Horschig authored
This CL removes unused variations along with the dead code they were enabling. Bug: 1124732 Change-Id: I729a2ed83e9652f74859477a6943a77b871e68b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404344Reviewed-by:
-
Christian Dullweber authored
It shouldn't be necessary to fetch each WebsiteSetting individually as they are already fetched GetSettingsForOneType and we don't have important sites settings that override other settings (e.g. based on scope, different provider or incognito mode). Change-Id: Ieb3c7aba739746daa782e0c31175e4e103b76bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403480Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#806128}
-
Rohit Agarwal authored
This CL adds the support of linking CustomTabIncognitoManager instance with a WindowAndroid object instance. This would enable querying the non primary OTR profile from the CustomTabIncognitoManager instance. This CL is step [1] for the refactoring the TabModelImpl to take in profile as an argument. [1] go/incognito-cct-profile-passing-support Bug: 1099642 Change-Id: I0b4e0e3959247925f41292ce8b15855aa8fe4347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396336 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#806127}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0c8f66c7169c..9a7e7b08a74e 2020-09-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 30a5da05 to fe51fcb5 (441 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Ib254d266772dfdcc15934d6970cfab26b8ca5f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405981Reviewed-by:
-
Mariia Shvedchenko authored
This CL provides new structure MatchingPattern that replace using single regular expressions, but store more information about concret pattern. Also it contains splitted MatchType into MactchFieldTypes and MatchAttributes and sceleton of PatternProvider class. Change-Id: I5acebf12aafaca67ae87260b2c897bdf35a38bea Bug: 1121990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385282Reviewed-by:
-
