GitLab

Test CorrectEventFiringTest.testSubmittingFormFromFormElementShouldFireOnSubmitForThatForm has become flaky on Android Chromium build bot.
Disabling test.

Bug: chromedriver:2286
Change-Id: I6f2fca1b9f74669a3796f1b9868f6314e541b882
Reviewed-on: https://chromium-review.googlesource.com/1014713Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551362}

Adds early returns to XRWebGLDrawingBuffer if the drawing buffer client
is null. This fixes a segfault that was causing a renderer crash when
exiting (or entering?) WebXR presentation.

Bug: 833620
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iaf03bff95f542da63e871b1abf8a96e1b0b29d7f
Reviewed-on: https://chromium-review.googlesource.com/1014480Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551361}

Just one more step in Removing the Physical Web from Chrome.

BUG=826540

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2b99e83a64a0c655c37569cb7d9f0924bbfb6948
Reviewed-on: https://chromium-review.googlesource.com/988954Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551360}

This reverts commit c3884364.

Reason for revert: This has unintended consequences for Android Webview. Reverting so that the logic can be updated to not log the field for webview when the CL is relanded.

Original change's description:
> Update system_profile.proto. Populate app_package_name
> 
> Bug: 833214
> Change-Id: I5552bdca37a2e3e20a039b9a0ca316f4480b1217
> Reviewed-on: https://chromium-review.googlesource.com/1010055
> Commit-Queue: Shuo Weng <shuow@google.com>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551296}

TBR=asvitkine@chromium.org,wychen@chromium.org,shuow@google.com

Change-Id: I3c14d6f4b1a565d651c69be5d11a28959149f0c7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 833214
Reviewed-on: https://chromium-review.googlesource.com/1014205Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551359}

Bug: 829893
Change-Id: I892ab0504e87ea2c6f65bdf932b030e6a7589f2b
Reviewed-on: https://chromium-review.googlesource.com/998982Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551358}

https://pdfium.googlesource.com/pdfium.git/+log/6b26e1ae6932..3900ddb64f30

$ git log 6b26e1ae6..3900ddb64 --date=short --no-merges --format='%ad %ae %s'
2018-04-17 thestig Add a virtual CPWL_Wnd::GetText() method.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Idd6d94a554ab292fea802bd28549f1e82b4a3d69
Reviewed-on: https://chromium-review.googlesource.com/1014953
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551357}

Don't depend on //base for webrtc standalone build,
because it breaks webrtc compilation

Bug=none

Change-Id: I68bb4400e858a008ba6dfb7debfe6f6a6237b9ca
Reviewed-on: https://chromium-review.googlesource.com/1013574Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Artem Titov <titovartem@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551356}

NOTRY=true
TBR=dmazzoni@chromium.org

Change-Id: I52c8cb2287f31554f5c6faab740ebd701b135eed
Reviewed-on: https://chromium-review.googlesource.com/1013693
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551355}

The method that now draws all our textures was missing a dedicated trace
event.  Add it for easier developer profiling.

BUG=
R=tiborg

Change-Id: I05e318b49dac4f36e768cba5010228904d06053a
Reviewed-on: https://chromium-review.googlesource.com/1014332Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551354}

This is allowing the user to use Tab and up/down keys to navigation
throughout the menu. It can also be closed using the Escape key.

This change also trap the focus inside the menu while it's visible and
make it so that hovenig an item will move the focus to it, like most
menus will do.

This is mostly for accessibility so users can interact with the
controls using only a keyboard. The change applies to both the overflow
menu and the text track list.

Bug: 821131
Change-Id: I22db341d0d55a8e3297b3c7a18c92331e296cd9e
Reviewed-on: https://chromium-review.googlesource.com/1013478Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551353}

Opening multiple custom tabs in quick succession can lead to flakiness,
so load a new URL in the same tab instead.

Also use the correct icon for offline pages.

Bug: 833569
Change-Id: I87e83f65bd8883146398e5ddd9dfd7a7acd2a5c8
Reviewed-on: https://chromium-review.googlesource.com/1013923Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551352}

GURLUtils.getOrigin returns an origin formatted with a trailing slash
because it calls GURL::GetOrigin which returns a GURL, then serializes
this URL. This seems to be incorrect behaviour as more generally an
origin is serialized without a trailing slash.

GURLUtils.getOrigin is used by AwGeolocationPermissions.java where the
returned value is saved to the user's Android Preferences. This means
that changing its behaviour would be tricky.

For now, I'm updating Origin.java to serialize without a trailing
slash and documenting the deviance in behaviour between the two.

Bug: 827161
Change-Id: Ia70f8a60263742b28477f969cc075dcb97062f48
Reviewed-on: https://chromium-review.googlesource.com/1013483Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551351}

Fix another race condition in frame detach sequence, found by stress
testing.

Change-Id: Ie342733a8627bfd36074d38b73209c751ba519dc
Reviewed-on: https://chromium-review.googlesource.com/1014506Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551350}

Feature has been approved to launch in M67, see
https://crbug.com/817854.

Bug: 816837
Change-Id: Ibe2699ad633b3c9ae01cbfff91293a6ab7a77859
Reviewed-on: https://chromium-review.googlesource.com/1013487Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551349}

This cl adds TODO to remove the dependency on aura::Window in Keyboard
Shortcuts Viewer. In addition, this cl removes unused deps and include.

Bug: 833673
Test: Manual
Change-Id: Icc4fd0726cace1971674e371bb5053b20575933b
Reviewed-on: https://chromium-review.googlesource.com/1014663Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551348}

Bug: 828031
Change-Id: Ie16b147a49c08ea743b482e8bb7fc0a04b22938a
Reviewed-on: https://chromium-review.googlesource.com/1011783
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551347}

Bug: 646113,799482
Change-Id: Ib8bd6fa6b9bda30133b135778a47058d7e8efc1c
Reviewed-on: https://chromium-review.googlesource.com/1012438Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551346}

PrintJobWorkerOwner has very little implementation that is actually
shared between PrintJob and PrinterQuery (task_runner_). Moreover,
in all cases where PrintJobWorker refers to its owner, only one of the
two subclasses is actually acceptable. Make this more clear by removing
this class.

Bug: None
Change-Id: Icaf5ff15ee5856dcade54fc4b64bb92539dc7a6f
Reviewed-on: https://chromium-review.googlesource.com/1013118Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551345}

After https://chromium-review.googlesource.com/c/chromium/src/+/581748
we no longer flatten SharedBuffers in GetRequestBodyForWebHTTPBody()
but instead pass segmented data downstream (multiple DataElements).

This minimizes unnecessary reallocations/copies in general, but relies
on downstream clients being able to handle segmented data (or flatten it
on the fly if really needed).

Turns out WebRequest's FormDataParsers assume the input buffers are
flattened (or segmented along expected chunk boundaries for multipart).

This CL adds a buffering mechanism to ParsedDataPresenter which flattens
consecutive byte segments before passing down to the parser.

BUG=831169

Change-Id: Ibea9193ff783cad0c80bb9722f719ff063b65720
Reviewed-on: https://chromium-review.googlesource.com/1011322
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551344}

This CL aims to mojofy the last one legacy IPC
ServiceWorkerMsg_ServiceWorkerStateChanged, then service worker code
finally enter the pure Mojo world!

Currently ServiceWorkerRegistrationObject and ServiceWorkerContainer are
channel-associated interfaces. For correctness, ServiceWorkerObject
needs to have FIFO ordering with those interfaces, which means it would
need to be a channel-associated interface as well. But when used for
service worker execution contexts, we have been binding
channel-associated interfaces on the IO thread rather than the service
worker thread due to constraints of channel-associated interfaces.[1]
But we want ServiceWorkerObject to be bound on the service worker
thread. Actually we want SWContainer and SWRO to be bound on the service
worker thread too instead of bouncing to the IO thread. Until now, we
have worked around this using hacks like CallbackWrapperOnWorkerThread
to mediate between the IO thread and service worker thread. But we do
not want to keep doing these hacks. Since we no longer have legacy IPCs,
there is no need for these interfaces to be channel-associated
interfaces. So this CL makes these no longer channel-associated
interfaces so they can be bound on the service worker thread directly.
[1] https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/RDO46Py0F3s

Based on the above analysis, this CL goes a long way to introduce
ServiceWorkerObject interface. This CL:
ps#1 - firstly decouples EmbeddedWorkerInstanceClient interface from the
   world of Channel-associated interfaces, makes it use a dedicated Mojo
   message pipe, this turns out to make its several attached interfaces
   not be Channel-associated interfaces, either, like
   ServiceWorkerRegistrationObject, ServiceWorkerHost etc.
ps#2 - then, for service worker execution contexts, starts to bind
   endpoints for interfaces like ServiceWorkerHost,
   ServiceWorkerObject[Host], ServiceWorkerRegistrationObject[Host] etc.
   on the service worker thread directly, rather than binding them on
   the IO thread and using PostTask to actually send/receive Mojo
   messages on the worker thread, this had been forced to be so because
   they were Channel-associated interfaces before.
ps#6 - after the above preparations, introduces ServiceWorkerObject
   interface and mojofies the state changed legacy IPC, it's also
   associated with EmbeddedWorkerInstanceClient interface and now we can
   just bind its receiver endpoint directly on the service worker
   thread.

Follow-up work:
  - CL https://chromium-review.googlesource.com/c/chromium/src/+/981898
    Associate all interfaces living on the service worker thread with
    ServiceWorkerEventDispatcher interface rather than current
    EmbeddedWorkerInstanceClient interface. This will not only guarantee
    the FIFO ordering with ServiceWorkerEventDispatcher, but also make
    all Mojo messages dispatch skip the main thread completely to avoid
    possible congestion.
  - Fix the layout test
    external/wpt/service-workers/service-worker/skip-waiting-installed.https.html
    which becomes flaky due to this CL.
  - Remove channel-associated interfaces entirely for service worker
    code. This CL makes interfaces for SW execution contexts to be not
    channel-associated. A follow-up CL will make the same change for
    interfaces for SW client contexts.

BUG=772788,783071

Change-Id: I3a6a666a41b4edc2289dceee6e071ef9510e2012
Reviewed-on: https://chromium-review.googlesource.com/967863
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#551343}

Add UKM for time before a popup is closed and whether it was closed due to
user gesture or not.

Bug: 825875
Change-Id: I9cd9abf40ee11c8404c7629b62cbdadc6b4069c9
Reviewed-on: https://chromium-review.googlesource.com/1005317
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551342}

The parameters to setup_toolchain changed, adding an OS parameter and a
filename for the environment file.

Additional fixes:
- Add missing base file to list of files
- vs_toolchain should output Windows paths properly escaped

Change-Id: I0e05bf34c8b603f16b901e76164e480121ed9d14
Reviewed-on: https://chromium-review.googlesource.com/1013926Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Yngve Pettersen <yngve@vivaldi.com>
Cr-Commit-Position: refs/heads/master@{#551341}

This patch is to implement unified user consent dialog. This dialog is
not used yet. This dialog will be used by ChromeSigninViewController in
the workflow of sign-in.


This dialog has 2 goals:
  - Asks to the user to choose an account
  - Shows the user consent to the user

Some assets are not ready and are shown in red. The strings are not
final neither.

Implementation:
with identity:
https://drive.google.com/open?id=1ebwI5_pmWCuz09x-zJQYCuJIKxKoLVH5
https://drive.google.com/open?id=1WUdN_NtzF74tn28HaRwpqbUZ3L2vtJS8
https://drive.google.com/open?id=1zSBHzGsk-vwuhL4fJQw0vsDZ7sDzCwnk
https://drive.google.com/open?id=1rWf_KT6hnKHUvtEoAYA3wr7koyepXEXF
without identity:
https://drive.google.com/open?id=1HQjRFu_cODRzKY2ZKpyJ7hTjJMXPjEui

Mock:
https://docs.google.com/presentation/d/1cZfr5FGWGSy0PNaQ8uzik0alLAH-5glh1vsb030vha8/edit?ts=5aba5455#slide=id.g353bc22139_3_19

Related to previous patch:
crrev.com/c/995417
Related to next patch:
crrev.com/c/1010346

Bug: 827072
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I706c6024ff59d1c7870a39afcc04443e88dcb6dc
Reviewed-on: https://chromium-review.googlesource.com/1009906
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551340}

This is a reland of 961ea628
Chromium r550608 has rolled clang to r329921, which includes the build fix.

Original change's description:
> Revert "Add more unbundle packages to sysroots"
>
> This reverts commit b828d53c.
>
> Reason for revert: Causing a build failure on Google Chrome Linux x64
> https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/29741
>
> /b/c/b/Google_Chrome_Linux_x64/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: duplicate symbol: exp2f@GLIBC_2.2.5
> >>> defined in obj/third_party/swiftshader/src/OpenGL/compiler/swiftshader_opengl_compiler/Intermediate.o
> >>> defined in obj/third_party/swiftshader/src/Renderer/swiftshader_renderer/Context.o
> /b/c/b/Google_Chrome_Linux_x64/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: duplicate symbol: exp2f@GLIBC_2.2.5
> >>> defined in obj/third_party/swiftshader/src/OpenGL/compiler/swiftshader_opengl_compiler/Intermediate.o
> >>> defined in obj/third_party/swiftshader/src/Renderer/swiftshader_renderer/Sampler.o
> /b/c/b/Google_Chrome_Linux_x64/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: duplicate symbol: powf@GLIBC_2.2.5
> >>> defined in obj/third_party/swiftshader/src/Renderer/swiftshader_renderer/Surface.o
> >>> defined in obj/third_party/swiftshader/src/Shader/swiftshader_shader/Constants.o
> /b/c/b/Google_Chrome_Linux_x64/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: duplicate symbol: powf@GLIBC_2.2.5
> >>> defined in obj/third_party/swiftshader/src/Renderer/swiftshader_renderer/Surface.o
> >>> defined in obj/third_party/swiftshader/src/Common/swiftshader_common/Math.o
>
> Original change's description:
> > Add more unbundle packages to sysroots
> >
> > The new packages are necessary to test unbundling of flac, libxslt, and zlib.
> >
> > BUG=800977
> > R=​thestig
> > TBR=mark
> >
> > Change-Id: I2c5f88b3819ce000e906cf303fdffa30bdde84cb
> > Reviewed-on: https://chromium-review.googlesource.com/981451
> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#549303}
>
> TBR=thakis@chromium.org,thestig@chromium.org,thomasanderson@chromium.org,mark@chromium.org
>
> Change-Id: I90188d22140d7cdd60f8bbea5b0e88705e498988
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 800977
> Reviewed-on: https://chromium-review.googlesource.com/1003532
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549314}

Bug: 800977
Change-Id: I6b5deb3cd3c2d6ab77dfd904eb641744b88d2231
Reviewed-on: https://chromium-review.googlesource.com/1012903Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551339}

TBR=tandrii@google.com

Bug: 776496
Change-Id: Ibca4e9ee732042e95fa10843f79d44c099bbaab9
Reviewed-on: https://chromium-review.googlesource.com/1010799Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551338}

Proposal: https://docs.google.com/document/d/1KrKEWSK64es3W3LYKQUpvwMzUJqTz8owFGXuJQqeXzs/edit?usp=sharing

Bug: 806936
Change-Id: Id086f9835a710cf2165f4ba8bd07904229301b67
Reviewed-on: https://chromium-review.googlesource.com/946554
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551337}

Yes, I would like to subscribe to your newsletter, please. :)

Bug: None
Change-Id: I212dd5a7a9a3394490e51d5a416ec5fa8c1685c3
Reviewed-on: https://chromium-review.googlesource.com/1014579Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551336}

That way, we can keep around the old paint fragment while we wait for
a final new one.

This patch fixes a dcheck failure when enabling fragment caching.

R=kojii@chromium.org,eae@chromium.org

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I763446ab3411c828a636317421fd398f500be67f
Reviewed-on: https://chromium-review.googlesource.com/1012499Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551335}

This is part of migration from username check to Gaia id check.
Desktop policies are validated in UserCloudPolicyStore, that will now
receive AccountId with Gaia id where it's possible to populate it
from AccountInfo.

BUG=780792
TEST=Unit/browser tests updated.

Change-Id: I7f7620e4ff6c1630975e8f6b7d808c629d90716a
Reviewed-on: https://chromium-review.googlesource.com/1005348Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551334}

https://webrtc.googlesource.com/src.git/+log/365381fdf1cd..6dfc8d6ef3b2

$ git log 365381fdf..6dfc8d6ef --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:827917,chromium:None,chromium:590625,chromium:None,chromium:None,chromium:none,chromium:none,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:none


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Icc418e420f561e22812bf43676d3ed5425a42659
Reviewed-on: https://chromium-review.googlesource.com/1014943
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551333}

This patch simply moves the location where the compressed
locale .pak files are stored within the final Chrome and
Monochrome APKs, from assets/<locale>.pak to
assets/locales/<locale>.pak

The reason to do this is to allow language-dependent
splits in the future, which will require apkbuilder.py
to support an option to place the files under a
directory like assets/locales#<lang>/<locale>.pak,
where <lang> is the language code of each corresponding
locale.

Note that these files are never accessed directly from
Chromium, instead they are extracted at startup time
if needed to the application's private data directory,
and the uncompressed file there is what Chrome will
later memory-map from native code.

In detail:

- Modify chrome/android/BUILD.gn to ensure that the
  compressed locale pak files are placed under
  assets/locales/

- Modify write_build_config.py to not use the directory
  of locale pak files when generating the Java locale
  lists for COMPRESSED_LOCALES and UNCOMPRESSED_LOCALES.

- Modify ResourceBundle.java to deal with the new list
  format when looking for uncompressed locales.

- Modify ResourceExtractor.java to deal with the new
  list format and the new locations.

BUG=820459
R=agrieve@chromium.org,dtrainor@chromium.org,tedchoc@chromium.org

Change-Id: Ia0caef3514a1ccfa72fe0ab1ff6fc1bf418377a6
Reviewed-on: https://chromium-review.googlesource.com/1010352
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551332}

TBR=fukino@chromium.org

Bug: 833049, 832192, 833752, 832799, 832798
Change-Id: I7d3316f2deae4f0e415e41a95211ee1f105cdf32
Reviewed-on: https://chromium-review.googlesource.com/1015003Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551331}

Original cl reviewed on https://chromium-review.googlesource.com/727464

Reason for revert: The original cl causes the following regression and
with browser side fling and async wheel events it's not needed anymore.

Regression: Touchpad scrolling disables wheel scrolling since GSU events
generated from wheel scrolling get filtered here:
https://cs.chromium.org/chromium/src/content/browser/renderer_host/input/gesture_event_queue.cc?q=Gesture_Event_queue&dr=C&l=130

fling_in_progress_ gets reset on GFC which is received when the user
puts their fingers on touchpad, so if the user scrolls with touchpad
first and then starts a subsequent wheel scrolling no GFC will be
received after the GFS and fling_in_progress_ will be still true while
GSU events from wheel scrolling are arriving.

Bug: 817479, 717205
Change-Id: I3997f756430df432aab37e5af77e1409dc8e0225
Reviewed-on: https://chromium-review.googlesource.com/1014415Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551330}

This reverts commit 82d9545a.

Reason for revert: compile failures on ios-simulator-xcode-clang and ios-device-xcode-clang builders:
 * https://uberchromegw.corp.google.com/i/chromium.mac/builders/ios-simulator-xcode-clang/builds/46343
 * https://uberchromegw.corp.google.com/i/chromium.mac/builders/ios-device-xcode-clang/builds/57515

Original change's description:
> [base] Add missing methods to base::span
> 
> This change implements constructors for base::span that allow the
> construction from a pair of pointers, std::arrays and containers
> supporting base::data and base::size, e.g. std::initializer_list.
> In addition, this change adds operator().
> 
> Bug: 788913
> Change-Id: Ibc280eef1c7e47a5a27e92503dda3614ef5513a4
> Reviewed-on: https://chromium-review.googlesource.com/981139
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551313}

TBR=dcheng@chromium.org,jdoerrie@chromium.org

Change-Id: Ia967227caa3a24a10df2ab4c5fa4ee03dddf0f29
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 788913
Reviewed-on: https://chromium-review.googlesource.com/1014761Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551329}

Removed src/components/ButtonBar/src/private/MDCButtonBarButton+Private.h

Bug: 833726
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I141ee872a3255039f35a5bb9bf0aecd77277b435
Reviewed-on: https://chromium-review.googlesource.com/1014499Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551328}

- Use uniform initialization syntax when calling ExpectGetAccounts,
  rather than manually building an std::vector.
- Use range-based for.

Bug: none
Change-Id: I5e31970086c806791baf588ca9f382a91d0be6af
Reviewed-on: https://chromium-review.googlesource.com/1013584Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551327}

Makes the omnibox popup presenter use autolayout to display the
popup view controller. The correct height of the popup is then
communicated by means of intrinsicContentSize of the popup table view.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I521adfbff62c3c42e7120fb7bb5f7f5b09bfd2b3
Bug: 821817
Reviewed-on: https://chromium-review.googlesource.com/978177Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551326}

This CL update the hidden property of the toolbar buttons based on the
current size class each time the button checks if it should be
displayed in the current size class, even if the result is the same as
the current hidden property.

Bug: 828767
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iec39f2bb5ca80c78d7a04e0225a9f048c09d0f28
Reviewed-on: https://chromium-review.googlesource.com/1013527Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551325}

This change:
1) Draws exterior borders on menus, even if MenuConfig says not to use them,
   if the NativeTheme is in high contrast mode;
2) Draws separators in black instead of grey in high contrast mode on Mac;
3) Draws a heavy (2pt) border around the selected item in high contrast mode
   on Mac

Screenshots are attached to the bug as comment #10.

Bug: 829347
Change-Id: I8ffd7adbae5b35751c18b77a9e8b6564926f7012
Reviewed-on: https://chromium-review.googlesource.com/1010245
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551324}

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /content/browser/site_per_process_browsertest.cc

This is another scripted pass done by a slightly modified version of
https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which
has a better notion of "scope".

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed.

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=kenrb@chromium.org

Bug: 781352
Change-Id: Ie0c1d1908812adc327f0777d552c7e4c97433d80
Reviewed-on: https://chromium-review.googlesource.com/1014781
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551323}