- 23 Sep, 2020 40 commits
-
-
Hao Li authored
- Add query set with the types of occlusion query, pipeline statistic query and timestamp query. - Add extension of timestamp query. - Add query APIs: createQuerySet on device. writeTimestamp on command encoder, render encoder and compute encoder. resolveQuerySet on command encoder. - Now timestamp query is available on D3D12 backend, other backends are WIP. Bug: dawn:434 Change-Id: Icfdb17da7f406bfd1d6e903503b103391d9c7d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415572 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#809704}
-
Yuki Shiino authored
Makes .gni files of file lists a little cleaner. Change-Id: I10045a56809949cdd158de067439a27dfde0125d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424366Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#809703}
-
wutao authored
This patch shows two related photos together when device is in landscape orientation. Major changes: 1. Only show paired photos in landscape mode. 2. Use flex layout to dynamically add and show the secondary image. 3. If the primary image is fetched, it will be shown in the UI. 4. If the primary image is not fetched, then will ignore the secondary image, i.e. read from cache. 5. If the second image is fetched, it will be added to the UI if the screen orientation is landscape. 6. There is a 8px wide separator between two photos. 7. Only update the cache with primary image. 8. Paired photos share the same attributes. Screenshot: https://screenshot.googleplex.com/9UirWBGxheYVqV4 Bug: b/157080996 Test: added new tests. Change-Id: I25fb18104f317ffad629bbf7d1fcc5302806cf20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407176 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#809702}
-
Hiroshige Hayashizaki authored
Purely mechanical change to follow a PRESUBMIT recommendation. Bug: 1111134 Change-Id: Ic1674e98d977326f3666469fe53145912e6d5ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419052Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#809701}
-
David Bienvenu authored
Also fixes a few cpp lint errors. No functional changes. Bug: 1010217 Change-Id: Ibdbac42980740d26392812b39f86859b238b7a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422964 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#809700}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: none Change-Id: I82ca433269e300a2e7745b661be3f7a85f8117a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425325 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#809699}
-
Jun Mukai authored
It seems c_icu symlink is also created along with /c symlink for ChromeOS build (/c is for chromeos-chrome package, /c_icu is for chrome-icu package). It's better to ignore it for the same reason. Bug: none Test: build_packages with chromeos chroot environment Change-Id: Iad0a4addac492580601a16faa26ec34ed2fe77e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425123Reviewed-by:
Honglin Yu <honglinyu@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#809698}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df9a5f7482ce..aad83522fd17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC horo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: horo@google.com Change-Id: I798644c8da266945de1b361fbf17c4418f231062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425515Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809697}
-
Noel Gordon authored
The test does not actually display the text file in test. Document the bug and error symptom (site not reached error shown in the preview). Make the test return IGNORE_APP_ERRORS: fixing issue 1064855 causes it to fail because the reason for the error is detected earlier, and will log a console.error and hence FAIL this test. Bug: 1131298, 1064855 Change-Id: I5351cf572bcf2ec3399ed7ad7130029f99209dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423756 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#809696}
-
Jun Mukai authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/79326efe26e5..aef20f06d47b $ git log 79326efe2..aef20f06d --date=short --no-merges --format='%ad %ae %s' 2020-09-17 mukai Fix the build config regarding icu_disable_thin_archive 2020-09-22 zarvox [build] Clean up no_rtti config handling 2020-09-16 hidehiko icu: Expand is_linux to is_linux || is_chromeos. 2020-09-11 fdegans [fuchsia] Bring more changes from the Fuchsia copy 2020-09-01 fdegans Upstream Fuchsia changes in build file 2020-06-29 adetaylor Add CPEPrefix. Created with: roll-dep src/third_party/icu Bug: 1129473 Change-Id: I4a97eb577118be241dd9f8f1306439c6d1eaec29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425287Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#809695}
-
Jun Mukai authored
This reverts commit 22a5368c. Reason for revert: This roll breaks ChromeOS build as discussed in crbug.com/1129473. The fix https://chromium.googlesource.com/chromium/deps/icu.git/+/aef20f06d47ba76fdf13abcdb033e2a408b5a94d should be included (see crrev.com/c/2425287) Original change's description: > Roll ICU 79326efe..83b2ac66 > > https://chromium.googlesource.com/chromium/deps/icu.git/+log/79326efe..83b2ac66 > 83b2ac66 [fuchsia] Bring more changes from the Fuchsia copy > 368b1cb1 Upstream Fuchsia changes in build file > fb520a53 Add CPEPrefix. > > Bug: 1124037, fuchsia:56362 > Change-Id: Ia77c08b48668de4315b44d3b72a3a3e23d722494 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412548 > Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809634} TBR=fdegans@chromium.org,jshin@chromium.org,ftang@chromium.org Change-Id: I49d0e15b5089f840e2cd27ba024a22dfeb4bce8a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1124037 Bug: fuchsia:56362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425390Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#809694}
-
Dave Tapuska authored
The compositor viewport wasn't getting set correctly for platforms that didn't use DSF and had a scale factor on the display. Ensure it is correct. This was caused by https://chromium-review.googlesource.com/c/chromium/src/+/2402116 incorrectly using size_ assuming it was the same for the viewport pixel rect, but that is not the case for platforms without Zoom for DSF (such as Mac). BUG=1131162 Change-Id: Ie07ad887cf8dd511689a91011c928997c3587b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425195Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#809693}
-
Gouarb Kundu authored
This change removes the pp::Var dependency from core PDF code by converting the incoming pp::Var data to base::Value and updating the core PDF code to work with base::Value instead of pp::Var. The pp::Var types of PP_VARTYPE_OBJECT and PP_VARTYPE_RESOURCE do not have any valid conversion to base::Value and hence have added NOTREACHED() in those cases. Bug: 1094049 Change-Id: I3f6e54b04878e10d0d0ae860a6b1e8446e7e04e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413707 Commit-Queue: Gourab Kundu <gourabk@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#809692} -
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I0de1dce089f6f153d654eb7a6c81c41f4991f596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425510Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809691}
-
Muyao Xu authored
Bug: b/155490708 Change-Id: I6b866618dc8a3a5c484f299be71aa68103728a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422578Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Cr-Commit-Position: refs/heads/master@{#809690}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d2ea1c89..e0d5b2a8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iad8fb1349908cbbbb6991a5ea39310bfd10d65a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424768Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809689}
-
Josh Simmons authored
Extend this UMA expiry date until Chromium M94. Bug: 1088965 Change-Id: Iab8091f5ecc562de6b75aeefeb5923bebc88d729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418752Reviewed-by:
Anand K Mistry <amistry@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#809688}
-
Keishi Hattori authored
CheckIsNotDestroyed() will be used to ensure LayoutObject is not used after the Destroy() call once LayoutObject is moved to GarbageCollected. CheckIsNotDestroyed() should be the first statement for all methods on LayoutObject and its subclasses. Bug: 1030176 Change-Id: I4862ad8d068311b8cccf3881b21f0d62f787c333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409837 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#809687}
-
Sergey Ulanov authored
FuchsiaAudioRenderer::FlushInternal() is called when seeking media stream. It's supposed to flush all pending buffers, so playback can resume from the new position. Problem was that there may be a demuxer read that's still pending when the function is called. Results of that read were still used after flush, but they may correspond to the previous position in the stream (before seek). As result the packet returned by the pending seek was sitting in the head of the queue blocking playback of all other packets for the new position after seek, breaking audio playback. This change updates FuchsiaAudioRenderer::OnDemuxerStreamReadDone() to drop results if FlushInternal() was called while the demuxer read operation was pending. Bug: b/167613125 Change-Id: I134eb54f5729194d419226bc2df53012a32c8d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422886 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809686}
-
Jazz Xu authored
Bug: 1131022 Change-Id: Ifb73b41adfee89dc72487dd5e34a061f188c93c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423358Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809685}
-
Min Qin authored
This CL uses the proper result type for suggestions from QT. BUG=1130176, 1128851 Change-Id: Ibb5748683a3e3d347c330a076d9e7fa2258a5f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425125Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809684}
-
James Hawkins authored
Bug: 1045266 Test: OSSettingsInternetConfig* Change-Id: Iea02f06dcf1f322b787d6bc0122e07a25b97f2cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425065 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#809683}
-
Yan, Shaobo authored
- Add rule to check imageBitmap state and throw invalid state error exception if imageBitmap has been closed. - Add rule to check depth of copySize and throw range error exception if depth of copySize is larger than 1. - Allow noop copy and modify validation rule to support on border source origin. BUG=966582 Change-Id: I9ce4fa6ec152a538cf88c42bb0b9cee634f55b54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402584Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Cr-Commit-Position: refs/heads/master@{#809682}
-
Peter Kasting authored
This will be convenient for various callers. Bug: 772945 Change-Id: I044f791aafe079d0728aabea20e0e287bbf045ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425142 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#809681}
-
Jae Hoon Kim authored
Metrics changed: - Installer.Recovery.Reason - change owner + add chromeos-core-services - P2P.Server.ClientCount BUG=chromium:1089203, chromium:1088866 TEST=none Change-Id: Ie4330b8178a7a857b99616af763ffa09947a14fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422441 Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#809680}
-
Raphael Kubo da Costa authored
This method is not used anywhere, including SensorProviderProxy's friends, so get rid of it for simplicity's sake. Change-Id: Ibf9484f935372d733ab4d4dda991cb53c6cfeb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421368 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#809679}
-
Ahmed Fakhry authored
BUG=1110719 Change-Id: Id09e4e9b336d12acb99ad648e0dd3ad83130185f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425066Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#809678}
-
Josiah K authored
Bug: 1131153 AX-Relnotes: N/A Change-Id: I3405fbbe612eeacb54673509a2b7f039eb279555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424678 Commit-Queue: Josiah Krutz <josiahk@google.com> Auto-Submit: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#809677}
-
Miguel Casas authored
Decoding a bitstream in VA has two steps: one, submitting the parsed parameters and encoded chunk as VABufferIDs, and two, executing the decode. This CL transfers managing the lifetime of the VABufferIDs to VP8VaapiVideoDecoderDelegate, avoiding vaCreateBuffer() calls. vaapi_utils' FillVP8DataStructures() needs to be changed to operate on VA-API structs passed as parameter, which in turn forces a bit of changes in the webp decoder. This is verified via chrome:tracing and codepen.io/full/qzYXba that plays 4 1280x572 VP8 videos at the same time. Tracing is captured for a few seconds, and basically we avoid calling the vaCreateBuffer(), which takes ~50us every time, reducing the overall decode time from ~0.439ms to ~0.307ms on my CML (kohaku), ~25% reduction. Improvements are of course extremely small, the advantages of this CL are in reducing lock/unlock churn and associated contention. This benefit grows with the amount of decodes (e.g. Meet grid scenarios). Bug: b/166646505 Change-Id: I6b0e2dc21ad94e2e1c9ab3696fba037d5b88830b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412132 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#809676}
-
Wei Lee authored
Temporarily makes CCA non-resizeable until it supports responsive UI. Bug: 980846 Test: Tested that CCA (SWA) is not resizeable Change-Id: Ib6b093aac7ae728427ac315f225ec39d44dfd041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415920Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#809675}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b44af6625286..ee7ae7aba2c9 2020-09-23 jmadill@chromium.org Skip another slow test on Win/Intel/D3D11. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I8a965e94cb932728c29176f302099af7a7df4b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425503Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809674}
-
Michael Bai authored
ContentCapture was triggered by ContentCaptureConsumer, the ContentCaptureTriggeringForExperiment feature is used to trigger the ContentCapture independently, so we can get unbiased experiment result. We enabled this feature to run an experiment in M86. Now we need to disable it to prevent ContentCapture being triggered unconditionally in production in M87 and beyond. By disabling this feature, ContentCapture will lack the test coverage because it isn't triggered. To overcome this issue, this patch enables experiment in fieldtrial and disabled ContentCapture by default in production, so it is only triggered when necessary in production, but we still have enough test coverage in various bots. Also, removed an unused fieldtrial setting. Bug: 1114819 Change-Id: I9c2a5c5dcea9697020b372cef660289c42243470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422148Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#809673}
-
Kunihiko Sakamoto authored
We would like to deprecate FirstMeaningfulPaint histograms, but this one is still used in an active finch experiment. Bug: 1117109 Change-Id: I1c90559b97bd77500a3e2c2146e5c493829011b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417773Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#809672}
-
Mason Freed authored
The current view-source page uses quirks mode, break-word, and tables, which is a very slow Layout code path. This CL removes quirks mode. Bug: 920571 Change-Id: I011ebd1ef3ab3f0588886342530f3ddaa2468527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424574 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#809671}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I6aba3e75327af90929adb8f952f909c2940f81e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425427Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809670}
-
Rachel Carpenter authored
This means that folks trying to navigate to chrome://help-app in a browser will instead get the Help app opening as a standalone window. Change-Id: I30941dc66f4c9528edfc0ead92d3d9551bc13d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398604 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#809669}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600775907-1d0a614b540ad15c6823911f93c081428c564ce9.profdata to chrome-mac-master-1600819087-f4efc7f723c6812144192ebd4eb5f53f5a4e9534.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I729b8c4981097238ee255441568add0755b8c277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425506Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809668}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ic16c64e9a7eae1ff757632f89e65e8c7223c167e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425403Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809667}
-
Raphael Kubo da Costa authored
r762075 ("ExecutionContext post-migration cleanup - mdoules/ q-s"), part of the changes that moved ExecutionContext from Document to LocalDOMWindow, removed the condition in InitSensorProxyIfNeeded() that would cause it to have a nullptr |sensor_proxy_|. Remove the check in Sensor::Activate(), but add a DCHECK to avoid regressions. Change-Id: If29238fb7772599a3a4636e25535c51669d5da11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421448 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#809666}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9bcb0cadf78f..df9a5f7482ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC horo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1131087,chromium:783819,chromium:912681 Tbr: horo@google.com Change-Id: I9705bba1d79fcda023b1626c74b71d6f629ea048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425247Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809665}
-