- 08 Aug, 2019 40 commits
-
-
Jeffrey Kardatzke authored
When data was redacted with context, previously just a unique numeric identifier was put in place of the data. This wasn't obvious to users of the logs because sometimes one number was just getting replaced with another. This is now made clear so that even when we redact with context, we put a redaction identifier in place of what we removed. This change also enhances serial number redaction to cover a wider range of occurrences of serial numbers in logs. BUG=chromium:940884 TEST=Unit tests pass, manually inspected uploaded feedback report Change-Id: I57e9a7f612be30eb0823fd0bb9d13ffc16bd3a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740132Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#685291}
-
Lukasz Anforowicz authored
Context and behavior implemented + expected before and after the CL =================================================================== A content::RenderFrameImpl stores |subresource_loader_factories| that are used for all requests/XHRs/etc initiated by the frame. We don't currently swap the RenderFrame when committing another same-process document (this future work is tracked by https://crbug.com/936696). The URLLoaderFactory for handling http/https requests contains a |request_initiator_site_lock| in network::URLLoaderFactoryParams. This lock limits what network::ResourceRequest::request_initiator may be used. The lock is currently used in various, security-sensitive features like CORB, CORP, Sec-Fetch-Site. In the future the lock may be consulted for all requests handled by the NetworkService (see https://crbug.com/920634 and also https://crbug.com/961614). When a cross-origin, same-process navigation commits, then: - The commit IPC carries a bundle of |subresource_loader_factories|. The new |subresource_loader_factories| should be used by the newly committed document. - Before committing the new document, the old document's unload handler needs to run. The unload handler needs to use the old |subresource_loader_factories| (e.g. because otherwise |URLLoaderFactoryParams::request_initiator_site_lock| might not match the document origin). The problematic behavior before this CL ======================================= Before the CL, content::RenderFrameImpl::CommitNavigationWithParams would start using the new |subresource_loader_factories| before running the unload handler of the old document (i.e. before calling blink::WebNavigationControl::CommitNavigation on |frame_|). The CL adds WPT tests that fail when the old, incorrect behavior happens. The new test initiates a beacon request from a frame's unload handler and verifies the Sec-Fetch-Site request header associated with this request. The header depends on the correct request_initiator_site_lock / on using the correct URLLoaderFactory. The fixes in this CL ==================== This CL introduces the |call_before_attaching_new_document| callback that is taken by blink::WebNavigationControl::CommitNavigation and called *after* finishing running the old document's unload handler and *before* the new document can initiate any requests of its own. This fix is a bit icky. In the long-term the callback can be avoided if the |subresource_loader_factories| are stored in a per-document object (i.e. if we swap RenderFrame on every document change, or if we replace RenderFrame with a RenderDocument - see https://crbug.com/936696). The CL adds a TODO to call this out. The fix had to refactor BuildServiceWorkerNetworkProviderForNavigation to make sure that it uses the |new_loader_factories| (even though they have not yet been passes to SetLoaderFactoryBundle). The fix also refactored GetLoaderFactoryBundleFromCreator to a separate method, so that setting the creator-based factories can also be postponed to |call_before_attaching_new_document|. Bug: 986577 Change-Id: If0209df61b0305ec43b5179bfdc1b9f8668a88b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716084Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#685290}
-
Alexander Timin authored
R=shaseley@chromium.org Change-Id: Ie4f837610914c63732c8cda2025cf508aefa2f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744414 Commit-Queue: Scott Haseley <shaseley@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#685289}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0fe515a8..07b2fa3a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie94fe02e93149e3b789bac99fab2b0e63338d577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744051Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685288}
-
John Abd-El-Malek authored
Also remove all the now unused members of ProfileIOData. Bug: 908955 Change-Id: I391673049673112feab970d7f24e0a6a2d7b4df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742844 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#685287}
-
Martin Robinson authored
There is very little risk to doing this and this causes IsChildOfLeaf to disappear from the pprof profile. Having to call this during the creation of the platform object introduced O(n^2) complexity to the accessibility tree. Bug: 986295 Change-Id: I9d051fe5a7d3392be6c4500a0382dd7a3812f202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736674Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#685286}
-
Chris Harrelson authored
SVG foreign objects always have PaintLayers now, since they are stacking contexts. The filter and clip-path are applied by PaintLayerPainter. Therefore we shouldn't try to apply them in SVGForeignObjectPainter, nor should we early-out if they "fail" to apply. Bug: 989673 Change-Id: I4a20da8f8ea85d377b25d8376d591f36f172d854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743256 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#685285}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 77-3849.0-1564392858-benchmark-77.0.3865.16-r1 to 78-3849.0-1565003983-benchmark-78.0.3877.0-r1 The AutoRoll server is located here: https://autoroll.skia.org/r/cros-orderfile-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I622a3386911a530fbb6fd5d78d0e73b654911489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741305Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685284}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fa26b6523911..f51ce3d98c68 Created with: gclient setdep -r src-internal@f51ce3d98c68 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:954450,chromium:None Change-Id: Ia396dc4309eacf0ecb25a7e4cb886e14ea69b307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742900Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685283}
-
arthursonzogni authored
On same-site navigations, the browser reuses the current RenderFrameHost, even if the current RenderFrameHost is crashed. Instead of reviving the crashed one, we should get a new RenderFrameHost. This can be seen as a small step in the direction of RenderDocument, which intend to get a new RenderFrameHost every time, even if the previous RenderFrameHost is not crashed. https://docs.google.com/document/d/1C2VKkFRSc0kdmqjKan1G4NlNlxWZqE4Wam41FNMgnmA/edit Bug: 981339 Change-Id: I17b11abe759906a7f360abeaa45f0bfc77e08768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688957 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#685282}
-
Jan Wilken Dörrie authored
This change introduces utility functions necessary to compute username hashes for the password leak detection feature. Bug: 986298 Change-Id: I8ba0ad8d2f085d2385ec1ed76cf64de9d1403e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741969 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#685281}
-
Wei-Yin Chen (陳威尹) authored
These animation tests too flaky on KitKat bots. Bug: 991706, 981409, 981341 Change-Id: I7673786f0886abedb2450df9137e856286c667ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743229Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#685280}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b307d657e8b7..0b1c529c6e47 git log b307d657e8b7..0b1c529c6e47 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 khokhlov@google.com Merge "Trace processor: Export perfetto trace stats to JSON" Created with: gclient setdep -r src/third_party/perfetto@0b1c529c6e47 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I438192290b493178d659bbb26533014cc853e38d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742899Reviewed-by:
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/4dfd5af70191b068aebe567b8e29ce108cee85ce..81080a729af568f7b5fde92b9170cc17065027c9 Bug: none Change-Id: I8594a6383f0d0977c8978f316685b1aa17c40f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743128 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#685278}
-
Julian Pastarmov authored
s/SafeBrowsing/Safe Browsing/gi s/set to true of left unset/set to true or left unset/ BUG=none Change-Id: Ie3b3c705a02ee28ff4c9369b879ac7c5b85e89a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738857 Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#685277}
-
Christian Biesinger authored
Tested: python3 src/build/linux/sysroot_scripts/install-sysroot.py --arch=x86 Bug: 941669 Change-Id: I23ad9c9e9e03df4d54e0961432a1cc11d5cce41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742194 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#685276}
-
dpapad authored
Specifically: - Deleting checked-in, settings/test_util.m.js - Auto-generate equivalent file at the correct location (one level up) - Update chrome://test references - Update BUILD.gn deps to depend on the js_modulizer() target, and ensure the generated file is available in test bots (via |data| deps) - Update test_data_source.cc to also look at gen/chrome/test/data/webui/ when processing chrome://test requests Bug: 965770 Change-Id: I6243986b3297fbb949220034fe88622adc320fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742832Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#685275}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8e2aad881bcc..8bd58eb928c3 git log 8e2aad881bcc..8bd58eb928c3 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 rnasri@google.com Update which screenshots are considered in calculating the metric Created with: gclient setdep -r src/third_party/catapult@8bd58eb928c3 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:983638 Change-Id: I1455688caf27653968665b909b1225f368ac2bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742901Reviewed-by:
-
Roman Kuksin authored
Change-Id: Ief54847dc4d06fe1620d9dafb1df29e3104f000d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735458Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#685273}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9f64ec44. With Chromium commits locally applied on WPT: 329c91e5 "Attempt to make test more stable" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I1d58126b9c4ecac18069d462a2a65ee9ebc0b826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744050Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685272}
-
Manu Cornet authored
Bug: 973482, 973446 Change-Id: I20d801d414f24f6bba4e155a7d6f1c7020a07eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743186Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#685271}
-
Jacob DeWitt authored
Per the latest WebXR spec, XRInputSource.gamepad.id must be the empty string. Update the browser and layout tests to actually check this. Also update the browser tests that run on Windows to check the profiles array contents against expected values for WMR and OpenVR. Bug: 989114, 942201 Change-Id: I36dff42cff55728d5d90384623623ea871d3a13e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742439 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#685270}
-
Bence Béky authored
Remove unused FLAGS_quic_headers_stream_id_in_v99. Sync values of flags with update_flags.py. Change-Id: I807595a7cbe26cf203e722120dbd2afba8fcdd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742214 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#685269}
-
Marijn Kruisselbrink authored
With network service shipped everywhere these tests should not and indeed appear to not flake anymore. Bug: 800898 Change-Id: I2cc59a6a5917e57629f1087e4868e636f2f72d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742733 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#685268}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e86a8560f202..4c833efb60a1 git log e86a8560f202..4c833efb60a1 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 tobine@google.com Vulkan: Enable sampler objects 2019-08-08 iannucci@chromium.org [infra/config] Actually set properties_j in the right place. 2019-08-08 tobine@google.com Sampler::syncState now returns angle::Result 2019-08-08 m.maiya@samsung.com Vulkan: Support the vertex_type_2_10_10_10_rev format 2019-08-08 jdarpinian@chromium.org Reenable extra_warnings config for angle_utils Created with: gclient setdep -r src/third_party/angle@4c833efb60a1 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Bug: chromium:973721 Change-Id: Iada1cf88d1a514decd2c0dd060e35d5d2bc27f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744281Reviewed-by:
-
Matt Simmons authored
R=yusufo@chromium.org Change-Id: Iffd4d640e373c721ade6c4a30417f64629987c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742519Reviewed-by:
-
Michael Lippautz authored
- Move trivial initializers to declaration site - Move Visit* methods to private section - Remove unused parameter around Persistent APIs Bug: 982754 Change-Id: Iec4102f1466a8b65251aa69892d041f450ac069e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743636 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#685265}
-
Peter Boström authored
This dead code is fairly confusing when searching for usages of the ContentsWebView. Bug: None Change-Id: I3e074609853aaca9c122ce0ab2ebde10c00dc9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743192 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#685264}
-
Matthew Webb authored
This CL makes the fingerprint enrollment + completion animation available to other platforms outside of CrOS. Bug: 974046 Change-Id: Ia5b87a98be543296dd4c1bbbfb10f6e71a1d58ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724898Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Matthew Webb <noviv@google.com> Cr-Commit-Position: refs/heads/master@{#685263}
-
Allen Bauer authored
An OTR profile is needed for the HaTS dialog which hosts a WebView used to present the survey to the user. Using a freshly created OTR profiles will (hopefully) ensure that no PII information is sent with the request for the survey content and when the response is sent back. This OTR profile needs to be destroyed once the dialog is dismissed. Since the WebView renderer may not shutdown synchronously, the destruction of the profile can only happen once the renderer is gone. Bug: 807714 Change-Id: I4cff23071f288ad6825a116e687f7775812777e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726269Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#685262}
-
Martin Robinson authored
Typically, Views nodes that have an unknown role are one of a variety of views. The ATK_ROLE_PANEL is a more accurate classification for these. For other nodes with an unknown role we can use ATK_ROLE_UNKNOWN. Bug: 866344 Change-Id: Ifae26ec0f04487abfec86d57df7914ab459967cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741921Reviewed-by:
-
Avery Musbach authored
The present CL adds a unit test OverviewSessionTest.AddDisplay to verify that overview mode ends when a display is added. Bug: 988839 Change-Id: I529f45bb5120bf03affcb07b0075050c296ee25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743854Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#685260}
-
ssid authored
leveldb_proto is a component that allows storing proto objects in a leveldb database. A client can get a leveldb_proto database by calling a static method. This simple API made it easy for developers to integrate leveldb_proto in their components, this resulted in a large amount of clients, with each one using a unique leveldb instance. Having multiple db instances increases memory consumption, as each database caches frequently used contents. There has been an effort to move leveldb_proto databases from multiple instances to a shared instance, to decrease memory consumption and simplify configuration. As part of this effort there have been many changes to the database retrieval API. Our first approach was to use a ProtoDatabaseProvider instead of a static method. This provider owns the shared instance, so there should be one provider per Profile. To do this we created it with a ProtoDatabaseProviderFactory, which was a BrowserContextKeyedServiceFactory. Some clients need to initialize their database in reduced mode, so they don't have access to a BrowserContext/Profile. Instead they have a SimpleFactoryKey, which is moved to a Profile once a full startup occurs. Our second approach was to change our ProtoDatabaseProviderFactory to a SimpleKeyedServiceFactory. This worked for most clients, but some of them need to initialize their database from BrowserContext itself, which can't access SimpleFactoryKey because it lives in //components/keyed_service. This CL removes ProtoDatabaseProviderFactory, ProtoDatabaseProvider is now created and owned by StoragePartition for all cases except for reduced mode. In reduced mode the DB provider is created by StartupData, and then it transfers it to StoragePartition when initializing in full mode. In addition we also removed IOS's ProtoDatabaseProviderFactory, ProtoDatabaseProvider is now created and owned by BrowserState. Bug: 943354 Change-Id: I7cdeca4bff33a910969e21ed3d879938cf43842c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656712Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#685259}
-
Robert Sesek authored
Change-Id: I8fcc58fb170a55c0e4afeedf401474ce63273093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742613 Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#685258}
-
Jeremy Roman authored
Avoid it entirely where the input is constant ASCII. Change-Id: I76944b318f75ac188d53c1903687e74b26dde83d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743258 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Raphael Kubo da Costa authored
kRotationDOMMatrix has not been used since commit 7e8c0421 ("[sensors] Fix orientation sensor layout test"). Change-Id: I2c85083df36e778acc0512bb8212a18f564334d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742132 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This is a follow up of [1], where these files were Onion soup'ed. [1] crrev.com/c/1731644 BUG=923394 R=guidou@chromium.org Change-Id: Ia0138ca8e0b3ed26c5614fd0d2ca2367bc8be266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744047 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#685255}
-
Scott Little authored
This reverts commit 0d6bba53. Reason for revert: Broke webkit_layout_tests on WebKit Linux Leak bot: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/2935 Original change's description: > Fix sending scrollend on main thread snap > > This CL sends scrollend event if GSE is being > handled on the main thread after the snap (if > the snap has started after GSE). It also takes > care of sending scrollend event for snap after > fling. > > Bug: 907601 > Change-Id: I21aba5d098b25ddc765d78a7792ec8a2fb7987cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743253 > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#685217} TBR=bokan@chromium.org,nzolghadr@chromium.org Change-Id: Ib7901d4284565f8cd636e1e4064163750bf08d4e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 907601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744517Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#685254}
-
Matthew Jones authored
This reverts commit a5cf7b8f. Reason for revert: Breaking Android WebView L bot/tests: https://ci.chromium.org/p/chromium/builders/ci/Android%20WebView%20L%20%28dbg%29/8779#overview-tab java.lang.AssertionError: Android WebView is missing the following declared Blink interfaces: interface OffscreenCanvasRenderingContext2D interface OffscreenCanvas : EventTarget interface HTMLCanvasElement : HTMLElement.method transferControlToOffscreen . Interfaces which are intentionally not exposed in WebView need to be added to not-webview-exposed.txt Original change's description: > Disable viz-dependent features on WebView > > This adds a flag to disable: > - window.OffscreenCanvas > - Context2DCreation.desynchronize. > - HTMLCanvasElement.transferControlToOffscreen > > Bug: 940953 > Change-Id: If774e41adbaa6bef94a058f783225b27e5d0669a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736804 > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Fernando Serboncini <fserb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#685170} TBR=boliu@chromium.org,chrishtr@chromium.org,alexmos@chromium.org,fserb@chromium.org,wfh@chromium.org Change-Id: Ie8105469766f1182c9f6d44c263bc180e5067c2e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 940953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744516Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#685253}
-
Clark DuVall authored
This path is no longer used now that NavigationLoaderOnUI is default. Bug: 979264 Change-Id: Iacfd172d4f1eaa742f642b712279841995db4cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744285 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
