GitLab

Only EventWithLatencyInfo uses [Can]Coalesce() from WebInputEventTraits.
WebInputEventTraits gets used for IPC stuff so is kinda sensitive, but
EventWithLatencyInfo isn't involved with IPC. So, coupling these
together also makes refactoring unnecessarily difficult.

E.g. the coupling means that if we want to move EventWithLatencyInfo to
a component, then WebInputEventTraits and a bunch of dependencies that
EventWithLatencyInfo doesn't care about need to come as well.

To decouple, the guts of [Can]Coalesce() moves to a new .cc file for
EventWithLatencyInfo. The types are known, so we get some added type
safety versus WebInputEventTraits which isn't templatized in the .h. The
instantiations in the .cc become a bit simpler and the runtime type
checks and static casts behind in web_input_event_trait.cc's Apply(..)
are not required.

BUG=615948
TBR=jochen@chromium.org (iwyu)

Review-Url: https://codereview.chromium.org/2111593003
Cr-Commit-Position: refs/heads/master@{#403402}

They are unused because they are used by magic.
They are missing translations to save file size
(see http://crbug.com/450548)

BUG=621771

Review-Url: https://codereview.chromium.org/2102183003
Cr-Commit-Position: refs/heads/master@{#403401}

In rare circumstances (more often with ASAN), a call to

[window performSelector:@selector(close) withObject:nil afterDelay:0];

doesn't get run when ViewsTestBase::TearDown() does
  base::RunLoop run_loop;
  run_loop.RunUntilIdle();

ViewsTestBase then destroys other stuff. And, when the posted selector
eventually gets executed, bad stuff happens.

To fix, post a "regular" task, invoking -[NSWindow close]. Use a block
to retain the window receiving the close.

BUG=624648

Review-Url: https://codereview.chromium.org/2115453002
Cr-Commit-Position: refs/heads/master@{#403400}

BUG=620178

Review-Url: https://codereview.chromium.org/2118723002
Cr-Commit-Position: refs/heads/master@{#403399}

BUG=457811
R=dgozman

Committed: https://crrev.com/b08177119dcdbf407492ca84065a6cff32fd78b0
Review-Url: https://codereview.chromium.org/2094903002
Cr-Original-Commit-Position: refs/heads/master@{#402313}
Cr-Commit-Position: refs/heads/master@{#403398}

Cr-Commit-Position: refs/heads/master@{#403397}

This patch fixes incorrect handling of <bad-string-token> inside
@namespace/@import rules. Currently a url(<bad-string-token>) is
incorrectly interpreted as url(url).

The added tests pass in Firefox.

BUG=607095,607500

Review-Url: https://codereview.chromium.org/1930823002
Cr-Commit-Position: refs/heads/master@{#403396}

This removes an extra '}' that accidentally got added in
http://crrev.com/20447ead8ba4b9bf3310da0d80a23a199aba1d60

BUG=625014

Review-Url: https://codereview.chromium.org/2111383002
Cr-Commit-Position: refs/heads/master@{#403395}

When a date picker has a suggestion list it's supposed to be the same
width as the input element. With use-zoom-for-dsf on I discovered that
it was too wide because the width that was being passed in was using
"root frame" coords that were not scaled correctly.

BUG=621221

Review-Url: https://codereview.chromium.org/2095113002
Cr-Commit-Position: refs/heads/master@{#403394}

This CL adds an item "Other users" on the storage manager, which shows the total
disk size used by other users.
Cryptohome API was added by https://chromium-review.googlesource.com/#/c/356641

BUG=591958
TEST=manually tested on link/minnie
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2111043003
Cr-Commit-Position: refs/heads/master@{#403393}

Revert of [Mac/GN] Explicitly link ApplicationServices wherever CoreGraphics is linked. (patchset #2 id:20001 of https://codereview.chromium.org/2092513002/ )

Reason for revert:
After https://crrev.com/42e3c3e7125d the build warns if it detects this incompatibility.

Original issue's description:
> [Mac/GN] Explicitly link ApplicationServices wherever CoreGraphics is linked.
>
> The 10.11 SDK has an incompatibility with a OS X 10.7 deployment target.
> ApplicationServices re-exports CoreGraphics, but due to a bug, the dylib
> compatibility version from the re-exported framework gets confused with
> the version of the framework doing the re-export.
>
> This only manifests itself in the component build because individual
> components depend on CoreGraphics directly instead of ApplicationServices.
> In the static library build, the transitive collection of libs ensures that
> ApplicationServices gets linked before CoreGraphics when linking the
> Chromium Framework, so this doesn't occur.
>
> To hack around the issue, specify ApplicationServices in libs ahead of
> CoreGraphics so that the correct compatibility version is picked up. After
> the deployment is updated to 10.8+ (https://crbug.com/580152) these hacks
> can be removed.
>
> BUG=620127
> R=mark@chromium.org
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://chromium.googlesource.com/chromium/src/+/5f7bc190c7ffeda2a2c56161b371bc16750fac2c

TBR=mark@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=620127

Review-Url: https://codereview.chromium.org/2118563002
Cr-Commit-Position: refs/heads/master@{#403392}

Network emulation is a desktop-only feature, so Android testing needs to be disabled.

BUG=chromedriver:984

Review-Url: https://codereview.chromium.org/2115723002
Cr-Commit-Position: refs/heads/master@{#403391}

Context is not final so there is no need to create a wrapper for it.
We extend MockContext directly in our fakes.

Adds a new setHasAndroidLocationPermission that sets a new factory
for LocationUtils to return true or false.

Follow up patch of http://crrev.com/2038753004

Review-Url: https://codereview.chromium.org/2100313003
Cr-Commit-Position: refs/heads/master@{#403390}

Added imageHeight, imageWidth, mediaArtist, mediaTitle and mediaMimeType.
Also added strings for metadata which will be implemented later.

Demo: https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhMDU4bGhTNW5CbDg/view?usp=sharing

BUG=613465,624129
TEST=manually.

Review-Url: https://codereview.chromium.org/2109563002
Cr-Commit-Position: refs/heads/master@{#403389}

* //ash/system/chromeos/bluetooth
* //ash/system/chromeos/enterprise
* //ash/system/chromeos/supervised
* //ash/system/chromeos/tray_caps_lock.*

Purely mechanical, no functional changes.

BUG=619636
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2108403004
Cr-Commit-Position: refs/heads/master@{#403388}

This matches the behavior of the existing history page.

BUG=623014
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2106363002
Cr-Commit-Position: refs/heads/master@{#403387}

TBR=jam@chromium.org
BUG=605318, 618468

Review-Url: https://codereview.chromium.org/2113893003
Cr-Commit-Position: refs/heads/master@{#403386}

And also verify draw transform calculations where the destination is
not the root.

BUG=622372
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2112973003
Cr-Commit-Position: refs/heads/master@{#403385}

while borrowing the lab device to do the debugging

BUG=618089

Review-Url: https://codereview.chromium.org/2114813002
Cr-Commit-Position: refs/heads/master@{#403384}

By this CL, Google sites shown in Drive folder have correct icon, file-type description, and file extension.

BUG=597210
TEST=manually confirmed

Review-Url: https://codereview.chromium.org/2113723003
Cr-Commit-Position: refs/heads/master@{#403383}

Users who don't have first setup complete, but are signed in without sync
suppressed, are in an invalid state, likely from previous issues in the
sign in flow. We were purging their sync data over-aggressively on startup
previously, causing a resync of the control types on each restart. Now we
simply leave the data around, and only purge if the user is actually signed
out.

BUG=624915

Review-Url: https://codereview.chromium.org/2113453006
Cr-Commit-Position: refs/heads/master@{#403382}

BUG=NONE
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2110663007
Cr-Commit-Position: refs/heads/master@{#403381}

There is no reason why the methods should be non-const. More importantly
it allows us to pass the observer as a const reference to lambdas or
callbacks that need to check its properties.

BUG=580406

Review-Url: https://codereview.chromium.org/2096043002
Cr-Commit-Position: refs/heads/master@{#403380}

Revert of Link to DirectWrite directly, instead of calling LoadLibrary (patchset #8 id:180001 of https://codereview.chromium.org/2029343002/ )

Reason for revert:
Breaks aura_demo target

Original issue's description:
> Link to DirectWrite directly, instead of calling LoadLibrary
>
> BUG=
>
> Committed: https://crrev.com/7561063aa78a31c73506f666c9eeccf45fe3dc07
> Cr-Commit-Position: refs/heads/master@{#403344}

TBR=scottmg@chromium.org,jam@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2117683002
Cr-Commit-Position: refs/heads/master@{#403379}

The existing 'deadline' heuristic has proven to be very flawed on some
systems, for reasons explained in the bug. This change adds a new
experimental heuristic, activated via a new command-line switch, for lab
testing: --cast-encoder-util-heuristic=backlog<N>

If the new heuristic proves to work well across our lab's gamut of test
systems, a future change will remove the command-line switch and make
the new heuristic the default.

BUG=chrome-os-partner:54806

Review-Url: https://codereview.chromium.org/2108373002
Cr-Commit-Position: refs/heads/master@{#403378}

Review-Url: https://codereview.chromium.org/2113173002
Cr-Commit-Position: refs/heads/master@{#403377}

Add QUIC unittest to make sure QuicStreamFactory does not pool sessions if
PrivacyMode differs.

Review-Url: https://codereview.chromium.org/2113873002
Cr-Commit-Position: refs/heads/master@{#403376}

There's a bug where when you activate a pending tree, the active
tree does not get the test_properties(), so if you BuildLayerList on
the active tree, the layer list drops all its layers except the root.

In fixing this, I struggled with understanding where and when tests are
building layer lists and property trees, and made some changes.

Now the test properties build the layer list when AddChild/RemoveChild
happens, which is consistent with SetRootLayerForTesting.

Also, the BuildLayerListAndPropertyTreesForTesting() and (the new)
BuildPropertyTreesForTesting() methods will now always build the trees
by setting needs_rebuild = true internally.

Also, cleaned up a bunch of LayerTreeHostImpl tests, to not have special
PrepareToDraw paths that build property trees, and just do it in the
tests.

R=ajuma, jaydasika@chromium.org
BUG=311404
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2106273002
Cr-Commit-Position: refs/heads/master@{#403375}

This CL adds closure compilation settings for several directories within
MD settings.

BUG=425627
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2112033002
Cr-Commit-Position: refs/heads/master@{#403374}

The test occasionally fails with

menu_runner_cocoa_unittest.mm:182: Failure
Expected: (runner_->GetClosingEventTime())
    <= (ui::EventTimeForNow() - base::TimeTicks())),
actual: 13647.4s vs 0.002s

It happens because menu_runner_impl_cocoa.mm uses
base::TimeTicks::Now(), but the test uses ui::EventTimeForNow() to set
expectations. Usually this isn't a problem, but if another unit test in
the same process has created a ui::EventGenerator, this sets a mock time
source with ui::SetEventTickClockForTesting(..) which isn't cleared when
the EventGenerator is destroyed.

Fix both problems. The EventGenerator destructor should reset the global
state it created, and menu_runner_impl_cocoa.mm should use
ui::EventTimeForNow() for better consistency.

BUG=623455, 624555

Review-Url: https://codereview.chromium.org/2094193002
Cr-Commit-Position: refs/heads/master@{#403373}

This field was added in https://crrev.com/dd933bda0baa6a13ab0120f0056a2b783e459efb
to limit foreign fetch to only intercept requests made from secure contexts,
but wasn't set for shared and service worker initiated requests. So this
fixes intercepting requests made from shared and service workers by a
foreign fetch service worker.

BUG=540509

Review-Url: https://codereview.chromium.org/2110163002
Cr-Commit-Position: refs/heads/master@{#403372}

This allows restarting OptIn flow for managed Arc in case user
re-activates it after stopping.

BUG=b/29121091
TEST=Manually on device for managed Arc (@google.com) and
     non-managed Arc (@gmail.com). In both cases OptIn can be
     restarted after canceling it.

Review-Url: https://codereview.chromium.org/2111733002
Cr-Commit-Position: refs/heads/master@{#403371}

This change adds support for the following NSAccessibility attributes:
NSAccessibilityEnabledAttribute
NSAccessibilityFocusedAttribute
NSAccessibilityInsertionPointLineNumberAttribute
NSAccessibilityNumberOfCharactersAttribute
NSAccessibilityPlaceholderValue
NSAccessibilitySelectedTextAttribute
NSAccessibilitySelectedTextrangeAttribute
NSAccessibilityVisibleCharacterRangeAttribute

ui::AX_ATTR_PLACEHOLDER was also not used outside of Blink, so support this
attribute as well.

Add tests for all of these attributes and plumb through textfield change
notifications for ui::AX_EVENT_TEXT_CHANGED, ui::AX_EVENT_VALUE_CHANGED, and
ui::AX_EVENT_TEXT_SELECTION_CHANGED.

BUG=610591

Review-Url: https://codereview.chromium.org/2106953005
Cr-Commit-Position: refs/heads/master@{#403370}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/44fb68ed1d6d..fd47e24b0e09

$ git log 44fb68ed1..fd47e24b0 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2109393003
Cr-Commit-Position: refs/heads/master@{#403369}

Metrics have to be persisted to disk and one possibility
is to simply use file-backed memory which leaves the
responsibility to the OS. It is simple and reliable but
there are concerns about what impact this could have on
performance.

Enabling this as an experiment will allow direct
collection of real data as to how Chrome is affected
by it and thus make possible an informed decision about
whether to use it or not.

BUG=546019

Review-Url: https://codereview.chromium.org/2010173005
Cr-Commit-Position: refs/heads/master@{#403368}

This CL includes strings for the network screen.

BUG=604119
TEST=NONE

TBR=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2112123002
Cr-Commit-Position: refs/heads/master@{#403367}

First version of this CL was reverted (cl/2119733002).

The fonts page includes a few very large <settings-dropdown-menu> instances.
While implementing force-rendering for the purposes of "search within settings"
it was revealed that it occupied about 1.3s of the main thread to render itself.
There are two separate improvements bundled in this CL.
 1) Replace <paper-item> with a simple styled <div>. This change alone reduces
    total rendering time from 1.3s to 0.25s.
 2) Use the new initialCount feature for dom-repeat to yield, instead of
    rendering the entire template all at once.

BUG=602896,608535
TEST=Click on "Customize fonts", observe how much faster the subpage opens.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2114793002
Cr-Commit-Position: refs/heads/master@{#403366}

* Pull out the CompatibilityTextInputLayout from the EditorTextField
  so it can be used elsewhere.

* Switch to using the CompatibilityTextInputLayout instead of the
  FloatLabelLayout in the autofill preferences.

* Put the AutoCompleteTextView in its own XML file so that the imeOptions
  will be accepted properly by Android.

* Set the statusbar color to black for fullscreen windows like the
  app does.

BUG=603635

Review-Url: https://codereview.chromium.org/2113493002
Cr-Commit-Position: refs/heads/master@{#403365}

BUG=623648
TEST=KeyboardControllerTest.DisplayChangeShould

Review-Url: https://codereview.chromium.org/2101023002
Cr-Commit-Position: refs/heads/master@{#403364}

In order to build translate_core_browser from projects built
with gyp, variations is needed as a dependency.

BUG=

Review-Url: https://codereview.chromium.org/2115453004
Cr-Commit-Position: refs/heads/master@{#403363}