- 16 Aug, 2014 40 commits
-
-
chromeos-lkgm@google.com authored
Cr-Commit-Position: refs/heads/master@{#290110} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290110 0039d316-1c4b-4281-b951-d872f2087c98
-
vmiura@chromium.org authored
Previously texture resource sync points were waited on a just-in-time basis, just before drawing with the texture. This change moves all sync point waits ahead of drawing a frame, to ensure that we don't switch GLContexts in the middle of drawing. BUG=394547 Review URL: https://codereview.chromium.org/411643002 Cr-Commit-Position: refs/heads/master@{#290109} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290109 0039d316-1c4b-4281-b951-d872f2087c98
-
rch@chromium.org authored
Add new histograms to confirm that PINGs are outstanding when a QUIC connection times out with open streams. Review URL: https://codereview.chromium.org/464363005 Cr-Commit-Position: refs/heads/master@{#290108} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290108 0039d316-1c4b-4281-b951-d872f2087c98
-
jdduke@chromium.org authored
Tentatively trigger haptic feedback when ContentViewCore is directed to show the the paste popup. While there are no guarantees that such a commend was triggered by a long press gesture, it should still be a usability improvement. Also trigger feedback when the selection is updated via a repeated long press gesture. BUG=150151,399619 Review URL: https://codereview.chromium.org/467303002 Cr-Commit-Position: refs/heads/master@{#290107} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290107 0039d316-1c4b-4281-b951-d872f2087c98
-
rtenneti@chromium.org authored
Slight improvement to QUIC version negotation debug logging. Merge internal change: 73319950 https://codereview.chromium.org/477813003/ Improve QUIC's SentEntropyManagerTest and removing a test from QuicConnectionTest that tests no code in QuicConnection. Merge internal change: 73298415 https://codereview.chromium.org/479463002/ quic_session.h doesn't need to include util/gtl/linked_hash_map.h. Merge internal change: 73256287 https://codereview.chromium.org/477863003/ Fix comment for QUIC handshake message tag COPT. Merge internal change: 73256108 https://codereview.chromium.org/474133002/ Not used in production. Add InRecovery() method to QUIC send algorithm interface, and pass slow start bool to bandwidth recorder. We still want to generate bandwidth estimates while in slow start, and include this information in the STK proto. We also need to know when we are in recovery mode so we can avoid calculating estimates. Merge internal change: 73239536 https://codereview.chromium.org/479443002/ Add a flag to enable QUIC's BBR congestion control by default instead of Cubic in order to test and gather logs on internal servers. Merge internal change: 73146298 https://codereview.chromium.org/477863002/ Add a QuicSustainedBandwidthEstimator class. Not yet used. Followup change list in progress (not ready for review, but in case you want to see intended usage) which does the following: 1) Use this in the QuicSentPacketManager. 2) Detect substantial differences between subsequent sustained bandwidth estimates. 3) Send estimates to client in server config update. internal change list: 72831442 Merge internal change: 73132177 https://codereview.chromium.org/477053002/ Re-add the QUIC DCHECK to ensure packets are always sent in the order of increasing sequence number. Merge internal change: 73128051 https://codereview.chromium.org/469383004/ Change to optimize QUIC's RetransmittableFrames::HasCryptoHandshake by storing it once when the crypto frame is added to RetransmittableFrames. Merge internal change: 73125935 https://codereview.chromium.org/467263003/ Add an Update method on QuicAlarm which contains a granularity. Also change the idle network timeout to be 1 second shorter on the client and 1 second longer on the server. Change saves ~2% of CPU according to an EndToEndTest profile. Merge internal change: 73125905 https://codereview.chromium.org/471313002/ R=rch@chromium.org Review URL: https://codereview.chromium.org/476023002 Cr-Commit-Position: refs/heads/master@{#290106} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290106 0039d316-1c4b-4281-b951-d872f2087c98
-
liyanhou@chromium.org authored
provider API When an extension/app with notificationProvider permission shows a user information about sources of the notifications, the notifiers. When the user wants to allow or disallow one notifier, NotifyOnPermissionLevelChanged can be used to inform the notifier that its permission level was changed. BUG=397197 Review URL: https://codereview.chromium.org/468813002 Cr-Commit-Position: refs/heads/master@{#290105} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290105 0039d316-1c4b-4281-b951-d872f2087c98
-
hansmuller@chromium.org authored
For each interface Foo, the Mojo JavaScript bindings now generate a pair of functions: |validateFooRequest(validator)| and |validateFooResponse(messageValidator)|. For each Mojo struct type, an additional |validate(validator)| method is generated. All of the validate methods return a validationError; validationError.NONE if the message is valid or not recognized. The JS validator class has been extended to validate structs, arrays, and handles. The generated methods are unit tested, in the same way as their C++ counterparts, by reading test messages and expected results from /mojo/public/interfaces/bindings/tests/data/validation/. Currently the two pointer overflow test cases are skipped because they depend on reading 64 uints, which the test message file parser can't handle at the moment. JS doesn't support 64 bit integers. 53 bits is the limit for integer Numbers. The message router still only checks the validity of incoming message headers. I'd like to integrate the router with the new validation code in a separate commit. BUG=386808 Review URL: https://codereview.chromium.org/468713002 Cr-Commit-Position: refs/heads/master@{#290104} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290104 0039d316-1c4b-4281-b951-d872f2087c98
-
jbauman@chromium.org authored
Keep track of which Surfaces were included in a Display last frame, so if a new frame is enqueued in a Surface the Displays containing it will tell their clients to redraw. This way the browser compositor doesn't have to commit if only the renderer contents changed. BUG= Review URL: https://codereview.chromium.org/432093003 Cr-Commit-Position: refs/heads/master@{#290103} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290103 0039d316-1c4b-4281-b951-d872f2087c98
-
kbr@chromium.org authored
The Perf bots don't invoke these tests via isolates. BUG=401985 Review URL: https://codereview.chromium.org/481473003 Cr-Commit-Position: refs/heads/master@{#290102} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290102 0039d316-1c4b-4281-b951-d872f2087c98
-
noms@chromium.org authored
(Hopefully for the last time). This is based on treib's patch 476703002 The problem that this CL is fixing is that it was a mess to tell whether a user had a default name/avatar (Lemonade) because we randomly assigned it at a profile creation time (in old, legacy cases), and then they synced it because that's what sync does, or because they did that on purpose. The idea being, of course, that if we randomly called them Lemonade and they have a Gaia name, we should use the latter, but if they synced "bob", we should use the sync name. Ok. Here's how this works now: - there's a preference for the profile name, and a preference "if it's default" - if this preference is not set, we assume this is a legacy created profile, so if it is named First User or Lemonade, the user probably didn't change that. This sets a "kIsUsingDefaultNameKey" preference in the ProfileInfoCache - if the ProfileInfoCache has a profile with a kIsUsingDefaultNameKey, then it uses a Gaia name if it's available. - the moment the user changes the name of a profile, it stops being default. So even if I change the profile name from Lemonade to Pickles, even though Pickles is one of the default profile names, we allow this insanity. - a similar dance is done for the default avatar/gaia avatar, only here we maintain two preferences, because the ProfileInfoCache holds both the gaia and the profile avatar. Profiles, right? <3 BUG=394586 Review URL: https://codereview.chromium.org/476993002 Cr-Commit-Position: refs/heads/master@{#290101} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290101 0039d316-1c4b-4281-b951-d872f2087c98
-
dominik.rottsches@intel.com authored
0.9.35 contains a couple of fixes for the CoreText shaper backend, which are required to work on removing the CoreText codepaths in Blink. Review URL: https://codereview.chromium.org/475363002 Cr-Commit-Position: refs/heads/master@{#290100} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290100 0039d316-1c4b-4281-b951-d872f2087c98
-
noms@chromium.org authored
TrimString ftw. BUG=403753 Review URL: https://codereview.chromium.org/474123002 Cr-Commit-Position: refs/heads/master@{#290099} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290099 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@chromium.org authored
BUG=394644 Review URL: https://codereview.chromium.org/469803005 Cr-Commit-Position: refs/heads/master@{#290098} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290098 0039d316-1c4b-4281-b951-d872f2087c98
-
qinmin@chromium.org authored
This change adds a mapping between m3u8 extension and its mime type. For android, we need to handle HLS streams separately later on BUG=400145 Review URL: https://codereview.chromium.org/471193002 Cr-Commit-Position: refs/heads/master@{#290097} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290097 0039d316-1c4b-4281-b951-d872f2087c98
-
tbarzic@chromium.org authored
When user clicks on the easy-unlock icon on "Click to enter" lock screen (i.e. when lock screen auth type is USER_CLICK), the lock screen changes to state in which password is required to unlock the screen. This adds new auth state FORCE_OFFLINE_PASSWORD which, unlike OFFLINE_PASSWORD, can't be changed to any other. BUG=397363 TBR=asargent@chromium.org Review URL: https://codereview.chromium.org/456943003 Cr-Commit-Position: refs/heads/master@{#290096} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290096 0039d316-1c4b-4281-b951-d872f2087c98
-
rtenneti@chromium.org authored
of net-internals page. connection-options also includes enable-pacing argument which is displayed as PACE. Fixes the rch's comments in https://codereview.chromium.org/471613002/ R=rch@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/470493004 Cr-Commit-Position: refs/heads/master@{#290095} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290095 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
This change is to move the logic of retransmission from AudioSender/ VideoSender to CastTransportSender. With this change AudioSender and VideoSender will not handle packets any more. They will simply see frames. Retransmission is now handled by CastTransportSender. Added two more public methods for CastTransportSender: * CancelSendingFrames Cancel sending certain frames. * SendFrameForKickstart Sends the last packet of a frame to kick start the session. cast_simulator shows no regression. BUG=393042 Review URL: https://codereview.chromium.org/445933002 Cr-Commit-Position: refs/heads/master@{#290094} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290094 0039d316-1c4b-4281-b951-d872f2087c98
-
slamm@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/477463002 Cr-Commit-Position: refs/heads/master@{#290093} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290093 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
[20526:20526:0815/151613:1174431576:FATAL:touch_exploration_controller.cc(763)] Check failed: false. tap timer fired in unrecognized state: CORNER_PASSTHROUGH #0 0x7f485532361e base::debug::StackTrace::StackTrace() #1 0x7f48553ba882 logging::LogMessage::~LogMessage() #2 0x7f485314bcfc ui::TouchExplorationController::OnTapTimerFired() #3 0x7f485314af2b ui::TouchExplorationController::RewriteEvent() #4 0x7f48531c89a6 ui::EventSource::SendEventToProcessor() #5 0x0000005f6bc0 ui::EventSourceTestApi::SendEventToProcessor() #6 0x0000005f396f ui::test::EventGenerator::DoDispatchEvent() #7 0x0000005f1480 ui::test::EventGenerator::Dispatch() #8 0x00000051a1a5 ui::TouchExplorationTest::AssertCornerPassthroughWorking() #9 0x0000005153fb ui::TouchExplorationTest_ActivateLeftCornerPassthrough_Test::TestBody() #10 0x0000005a49f3 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>() #11 0x00000059005e testing::internal::HandleExceptionsInMethodIfSupported\u003C>() #12 0x000000583ed5 testing::Test::Run() #13 0x0000005845db testing::TestInfo::Run() In ActivateLeftCornerPassthrough, ActivateRightCornerPassthrough, and SingleTapLongPress tests. > Modified state flow for touch explore released in touch_exploration_controller. > > Now when performing single tap, the tap timer to begin one finger passthrough is not started. This problem originally arose because touch explore released state and single tap released state are treated similarly in the code, but one finger passthrough should be a state reachable only from single tap released. > > Another state change is that if the user presses in single tap/touch explore released and there is no previous touch exploration location, the user is redirected to the wait state. > > TEST=TouchExplorationTest.SingleTapLongPress > BUG=402544 > > Review URL: https://codereview.chromium.org/465543003 TBR=evy@chromium.org Review URL: https://codereview.chromium.org/483443002 Cr-Commit-Position: refs/heads/master@{#290092} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290092 0039d316-1c4b-4281-b951-d872f2087c98
-
mlerman@chromium.org authored
Track additional timing stats about signing in users Specifically, track if signin took place during first run, and also track how long since Chrome Install the signin took place. BUG=357693 Review URL: https://codereview.chromium.org/466043002 Cr-Commit-Position: refs/heads/master@{#290091} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290091 0039d316-1c4b-4281-b951-d872f2087c98
-
meacer@chromium.org authored
HTTP auth prompts show a blank interstitial which causes the omnibox to show the correct URL and page contents to clear in order to prevent phishing. The logic for this interstitial currently checks only for the visible URL. This misses the case where the user navigates directly the URL: The URL of the resource with HTTP Auth will be the same as the visible entry so no interstitial will be shown. This patch adds a check to see if the last committed entry is also different then the URL of the resource with HTTP Auth. BUG=396961 TEST=LoginPromptBrowserTest.* Review URL: https://codereview.chromium.org/410373003 Cr-Commit-Position: refs/heads/master@{#290090} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290090 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Revert of Rotate screen in response to accelerator or device orientation sensors. (patchset #12 of https://codereview.chromium.org/431183003/) Reason for revert: Speculative, athena_unittests and ui_unittests started failing in this build:http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/2771 ==6568==ERROR: AddressSanitizer: heap-use-after-free on address 0x60700000ba10 at pc 0x00000167d52a bp 0x7fff95f266f0 sp 0x7fff95f266e8 READ of size 8 at 0x60700000ba10 thread T0 #0 0x167d529 in DeleteInternal base/memory/ref_counted.h:190:44 #1 0x167d529 in Destruct base/memory/ref_counted.h:153 #2 0x167d529 in Release base/memory/ref_counted.h:181 #3 0x167d529 in ~scoped_refptr base/memory/ref_counted.h:289 #4 0x167d529 in ~SystemUIImpl athena/system/system_ui_impl.cc:27 #5 0x167d529 in athena::(anonymous namespace)::SystemUIImpl::~SystemUIImpl() athena/system/system_ui_impl.cc:26 #6 0x167d257 in athena::SystemUI::Shutdown() athena/system/system_ui_impl.cc:49:3 #7 0x577fa6 in athena::ShutdownAthena() athena/main/athena_launcher.cc:92:3 #8 0x57645f in athena::test::AthenaTestHelper::TearDown() athena/test/athena_test_helper.cc:98:3 #9 0x575266 in athena::test::AthenaTestBase::TearDown() athena/test/athena_test_base.cc:53:3 #10 0x505bc8 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #11 0x506906 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #12 0x51cb85 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #13 0x51c176 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #14 0x51c176 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #15 0xac6fb4 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #16 0xac6fb4 in base::TestSuite::Run() base/test/test_suite.cc:227 #17 0xabe39d in Run base/callback.h:401:12 #18 0xabe39d in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498 #19 0xabf0de in base::LaunchUnitTestsSerially(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:564:10 #20 0x4d7bba in main athena/test/athena_unittests.cc:51:10 #21 0x7fd394e3476c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 #22 0x4d795c in _start (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__3_/build/src/out/Release/athena_unittests+0x4d795c) 0x60700000ba10 is located 0 bytes inside of 72-byte region [0x60700000ba10,0x60700000ba58) freed by thread T0 here: #0 0x452fcb in operator delete(void*) (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__3_/build/src/out/Release/athena_unittests+0x452fcb) #1 0x168323d in DeleteInternal base/memory/ref_counted.h:190:44 #2 0x168323d in Destruct base/memory/ref_counted.h:153 #3 0x168323d in Release base/memory/ref_counted.h:181 #4 0x168323d in ~scoped_refptr base/memory/ref_counted.h:289 #5 0x168323d in athena::OrientationController::OrientationController(scoped_refptr\u003Cbase::TaskRunner>) athena/system/orientation_controller.cc:66 #6 0x167cfea in SystemUIImpl athena/system/system_ui_impl.cc:23:61 #7 0x167cfea in athena::SystemUI::Create(scoped_refptr\u003Cbase::TaskRunner>) athena/system/system_ui_impl.cc:42 #8 0x577db0 in athena::StartAthena(aura::Window*, athena::ActivityFactory*, athena::AppModelBuilder*) athena/main/athena_launcher.cc:73:3 #9 0x576159 in athena::test::AthenaTestHelper::SetUp(ui::ContextFactory*) athena/test/athena_test_helper.cc:90:3 #10 0x503eb1 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12 #11 0x503eb1 in testing::Test::Run() testing/gtest/src/gtest.cc:2430 #12 0x505bc8 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #13 0x506906 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #14 0x51cb85 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #15 0x51c176 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #16 0x51c176 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #17 0xac6fb4 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #18 0xac6fb4 in base::TestSuite::Run() base/test/test_suite.cc:227 #19 0xabe39d in Run base/callback.h:401:12 #20 0xabe39d in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498 #21 0xabf0de in base::LaunchUnitTestsSerially(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:564:10 #22 0x4d7bba in main athena/test/athena_unittests.cc:51:10 #23 0x7fd394e3476c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 previously allocated by thread T0 here: #0 0x452a8b in operator new(unsigned long) (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__3_/build/src/out/Release/athena_unittests+0x452a8b) #1 0x167cfb5 in SystemUIImpl athena/system/system_ui_impl.cc:23:61 #2 0x167cfb5 in athena::SystemUI::Create(scoped_refptr\u003Cbase::TaskRunner>) athena/system/system_ui_impl.cc:42 #3 0x577db0 in athena::StartAthena(aura::Window*, athena::ActivityFactory*, athena::AppModelBuilder*) athena/main/athena_launcher.cc:73:3 #4 0x576159 in athena::test::AthenaTestHelper::SetUp(ui::ContextFactory*) athena/test/athena_test_helper.cc:90:3 #5 0x503eb1 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12 #6 0x503eb1 in testing::Test::Run() testing/gtest/src/gtest.cc:2430 #7 0x505bc8 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #8 0x506906 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #9 0x51cb85 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #10 0x51c176 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #11 0x51c176 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #12 0xac6fb4 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #13 0xac6fb4 in base::TestSuite::Run() base/test/test_suite.cc:227 #14 0xabe39d in Run base/callback.h:401:12 #15 0xabe39d in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498 #16 0xabf0de in base::LaunchUnitTestsSerially(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:564:10 #17 0x4d7bba in main athena/test/athena_unittests.cc:51:10 #18 0x7fd394e3476c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 TBR=oshima NOTRY=true NOTREECHECKS=true Original issue's description: > Rotate screen in response to accelerator or device orientation sensors. > > BUG=385295 > TEST=Press Ctrl+Shift+F3, screen rotates. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290007 Review URL: https://codereview.chromium.org/475533008 Cr-Commit-Position: refs/heads/master@{#290089} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290089 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=none TBR=achaulk@chromium.org Review URL: https://codereview.chromium.org/468633003 Cr-Commit-Position: refs/heads/master@{#290086} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290086 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
Cr-Commit-Position: refs/heads/master@{#290085} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290085 0039d316-1c4b-4281-b951-d872f2087c98
-
vadimsh@chromium.org authored
R=iannucci@chromium.org BUG=399054 NOTRY=true Review URL: https://codereview.chromium.org/478843002 Cr-Commit-Position: refs/heads/master@{#290083} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290083 0039d316-1c4b-4281-b951-d872f2087c98
-
jamescook@chromium.org authored
Perform NaCl initialization during app_shell's startup path similar to how Chrome initializes it. * Refactor some of the lazy background page impulse code into ProcessManager so it can be shared with Chrome BUG=400577 TEST=manual tests of app_shell, existing ProcessManager unit tests and browser tests Review URL: https://codereview.chromium.org/437503004 Cr-Commit-Position: refs/heads/master@{#290082} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290082 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
BUG=399067 Review URL: https://codereview.chromium.org/472733002 Cr-Commit-Position: refs/heads/master@{#290081} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290081 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
--scripts-require-action flag is on. The flag requirement is because we haven't confirmed this is safe, but we need something like it for testing the flag. BUG=404243 R=rdevlin.cronin@chromium.org Review URL: https://codereview.chromium.org/475333006 Cr-Commit-Position: refs/heads/master@{#290080} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290080 0039d316-1c4b-4281-b951-d872f2087c98
-
asargent@chromium.org authored
BUG=404252 TBR=rockot@chromium.org Review URL: https://codereview.chromium.org/467133004 Cr-Commit-Position: refs/heads/master@{#290079} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290079 0039d316-1c4b-4281-b951-d872f2087c98
-
gunsch@chromium.org authored
R=byungchul@chromium.org,lcwu@chromium.org BUG=403966 Review URL: https://codereview.chromium.org/469023004 Cr-Commit-Position: refs/heads/master@{#290078} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290078 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
Building blink events requires more data than we currently pass through mojo::EventPtr. That data is available on the side that has the base::NativeEvent, so we now send both the view relative location and the system location through. This also lets us drop a DEPS on "ui/events" from the html viewer. Eventually, we'll want our own event types, but this works for now. BUG=403514 Review URL: https://codereview.chromium.org/478523002 Cr-Commit-Position: refs/heads/master@{#290077} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290077 0039d316-1c4b-4281-b951-d872f2087c98
-
cthomp@chromium.org authored
BUG=384635 Review URL: https://codereview.chromium.org/402293002 Cr-Commit-Position: refs/heads/master@{#290076} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290076 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Remove a non-const pass-by-reference while we are at it. Review URL: https://codereview.chromium.org/470693003 Cr-Commit-Position: refs/heads/master@{#290075} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290075 0039d316-1c4b-4281-b951-d872f2087c98
-
ernstm@chromium.org authored
R=vmpstr@chromium.org, enne@chromium.org, danakj@chromium.org BUG=403829 Review URL: https://codereview.chromium.org/478723002 Cr-Commit-Position: refs/heads/master@{#290074} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290074 0039d316-1c4b-4281-b951-d872f2087c98
-
guohui@chromium.org authored
1. stack the link and button in the upgrade tutorial card 2. limit the width of the title label to accomodate long names. 3. increase the height of signin view 4. adds missing 'x' button BUG=403572, 399663, 403105 R=asvitkine@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/465313003 Cr-Commit-Position: refs/heads/master@{#290073} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290073 0039d316-1c4b-4281-b951-d872f2087c98
-
achaulk@chromium.org authored
This is an output surface that displays the content using overlays and render-to-FBO, instead of the usual system-managed framebuffer. Implementation to follow in another CL. BUG=380861 TBR=stevenjb Review URL: https://codereview.chromium.org/433543002 Cr-Commit-Position: refs/heads/master@{#290072} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290072 0039d316-1c4b-4281-b951-d872f2087c98
-
guohui@chromium.org authored
BUG=332205 R=rogerta@chromium.org Review URL: https://codereview.chromium.org/476213002 Cr-Commit-Position: refs/heads/master@{#290071} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290071 0039d316-1c4b-4281-b951-d872f2087c98
-
miu@chromium.org authored
This change closed the build tree for Linux and ChromiumOS bots due to failing interactive_ui_tests: http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests&number=12979 > Omnibox: Prevent Asynchronous Suggestions from Changing Default Match > > Calls to the suggest server may normally result in a new inline > autocompletion. This can be disruptive because it means pressing enter > may bring the user to different places depending on how long he/she > waits after typing the last key. > > This change prevents new suggestions from becoming the default match. > In other words, the default match is only allowed to change on a > keystroke, not due to a reply coming back from the server. > > The consequence of this change is that if previously we'd show an > inline suggestion on a server reply, now we only show it one keystroke > later. I think this trade-off (one keystroke versus inconsistent > omnibox behavior) is a good one to make. > > We still end up with default matches (inline autocompletions within > the omnibox) from the suggest server after this change. Here's an > example of why: > > User types "facebo" > We send a suggest server request. > Server asynchronously returns "facebook" as a top suggestion, > beating the server-provided verbatim score for "facebo". > We decide not to show it within the omnibox. It's instead shown > somewhere in the dropdown. > User types "o". > We send a suggest server request. > We reuse our cached suggestions and suggestion scores. <<< THE KEY > We show "facebook" as an inline suggestion because it beats > the default verbatim score that gets assigned to "faceboo". > (This is the score that we assign by default without having > yet received the most recent suggest server response.) > We receive the response, which includes "facebook" as a top > suggestion, beating the server-provided verbatim score > for "faceboo". > We show "facebook" as an inline suggestion. i.e., we decide > not to demote it because it was already being shown inline > > TESTED: > unit tests plus interactive tests (facebook.com/l, google.com/a) > > BUG=398135 > R=msw@chromium.org > > Review URL: https://codereview.chromium.org/471673002 TBR=mpearson@chromium.org Review URL: https://codereview.chromium.org/477293002 Cr-Commit-Position: refs/heads/master@{#290070} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290070 0039d316-1c4b-4281-b951-d872f2087c98
-
mlerman@chromium.org authored
(either ones blocking guest mode in particular or guest mode). Follow-up to the CL http://codereview.chromium.org/385073008 CL is currently blocked on crbug.com/394413. No more, it landed! BUG=306322 Review URL: https://codereview.chromium.org/471973003 Cr-Commit-Position: refs/heads/master@{#290069} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290069 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
Removing as bug http://crbug.com/284662 is fixed. BUG=284662 Review URL: https://codereview.chromium.org/469213008 Cr-Commit-Position: refs/heads/master@{#290068} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290068 0039d316-1c4b-4281-b951-d872f2087c98
-