- 02 Oct, 2019 40 commits
-
-
Juan Antonio Navarro Perez authored
These will still be reported as regular measurements. Bug: 1003530 Change-Id: I207540eeaa4447b01536ab4205712d0822c1c91a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828904Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#701974}
-
Paul Lewis authored
This adds tests for common/SegmentedRange that broadly match those of the original layout tests. Bug: 1009443 Change-Id: I60a986c2568bd46bb0f9ba64a85b42d24b54b40f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831910Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#701973}
-
Henrik Boström authored
See https://crbug.com/1010418. TBR=livvielin@chromium.org, jdonnelly@chromium.org, pkasting@chromium.org NOTRY=True Bug: 1010418 Change-Id: Ide19821fa54dc1033c216799352cd37445f5d143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835497Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#701972}
-
Adam Rice authored
The WebSocketStream explainer describes being able to pass an AbortSignal object to the WebSocketStream constructor to abort the handshake. This wasn't implemented yet in Blink. Implement it. Bug: 983030 Change-Id: I9d96bf145a4978867dd8ae98a13af9ad9cff752c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827116Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#701971}
-
Yi Su authored
Since we are using Xcode11 beta6 for compiling right now, FontSizeJsTest can be re-enabled. Bug: 983776 Change-Id: Id3a36a9fb5666ff5eca1f20f3c7fad4b194a070b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816497Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#701970}
-
Keishi Hattori authored
BodyJsonConsumer::DidFetchDataLoadedString() was binding ScriptValue which is a traceable disallow new type. This shouldn't be allowed as GC fails to trace them. This CL - adds a check disallowing binding traceable disallow new types. - adds WrapDisallowNew() to wrap a disallow new type in a GarbageCollected class, making it possible to be referenced off heap from a Persistent. - fixes BodyJsonConsumer::DidFetchDataLoadedString() Bug: 1009740,1009944 Change-Id: I7b15b46550b9994f0b7982c3508de9c3e7ff66be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833039 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#701969}
-
Michael Lippautz authored
Blink stand-alone GCs are used in testing and on thread termination. Such GCs iterate Blink->V8 references (global handles) to find the corresponding V8->Blink references that should be treated as roots. On WorkerOrWorkletGlobalScope dispose we also clear the DOMWrapperWorld that holds the Blink->V8 references (global handles). In the case a stand-alone GC happens at this point, WorklerOrWorkletGlobalScope is reclaimed. Access through the JS wrapper back references results in UAF. Bug: chromium:1003729 Change-Id: Iba0cb340a2037445947920888596ea7ecf7c32da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833825Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#701968}
-
Oleg Davydov authored
Whether we have loaded or not valid verified_contents.json is an internal detail of ContentHash class, which doesn't need to be exposed to clients. The only external usage of this is passing it to ContentVerifier::TestObserver. But TestObserver and its implementations never used this flag since TestObserver introducing in https://codereview.chromium.org/1250473002. Therefore it is possible and makes sense to change it to overall success flag. Bug: 796395 Change-Id: Ibd48b998a4c42d68e30549a4078184179f5593e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810358Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#701967}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2025b9840119..d9682cc2dc22 git log 2025b9840119..d9682cc2dc22 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@d9682cc2dc22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I6c4583fca4abf7fbffe576f724f84c14d5f78937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834865Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701966}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/23dacd6b..17fcc592 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic35d98f42682be42c6fc1f0da0a355abe305097f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833571Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701965}
-
Jérôme Lebel authored
Change-Id: Ie811205717b62316aee37790249bb8c92b00f7ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833591 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#701964}
-
Mikel Astiz authored
No behavioral changes: the API and implementation of SyncServiceCrypto are decoupled from the enum that is designed for SyncEncryptionHandler, a lower-level interface. Bug: 1010189 Change-Id: Icd8d3124a93a928535894f877b64ade53bcd1e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834226 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#701963}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1c934fade666..dec74f3ff6ec git log 1c934fade666..dec74f3ff6ec --date=short --no-merges --format='%ad %ae %s' 2019-10-02 csmartdalton@google.com Remove an assumption that fOpsTask != nullptr Created with: gclient setdep -r src/third_party/skia@dec74f3ff6ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: Ieb5631db34e5a9924dc80d0f5d7cad8d83e73de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834864Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701962}
-
Christian Dullweber authored
Whether the button is shown depends on sites.length but the dependecy was not declared, so the button didn't show up. Also hide the button when there is a filter as the filter can't be applied to third-party cookie deletion yet. Bug: 987177 Change-Id: Id36a286ed73da404446c8b98dabbf3751b5658e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831874 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#701961}
-
Kuo Jen Wei authored
Bug: 980812 Test: Send intent from ARC++ app, see if result is correctly return to app. Change-Id: I2810a31879abf80657aa75becde3e2a99ddcf1ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804940 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#701960}
-
Edward Jung authored
- Adjust the padding around the checkbox for RTL layouts. - Reduce the size of the bottom nav button container fade for mobile layouts. - Bottom padding adjustments on the content and detail content for mobile screen sizes. Bug: 968173,1006232 Change-Id: I14e78825ce8fe357dbf7ac89efe3af9bb76e6f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834082Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#701959}
-
Jérôme Lebel authored
Adding comments, fixing @property and @synthesize, and moving all private methods together. Related to: crrev.com/c/1718370/4/ios/chrome/browser/ui/authentication/signin_promo_view_mediator.mm#275 Bug: 988060 Change-Id: Ic4986ea549bb6ade54afb0fe8a86e0fe8edda10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824463 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#701958}
-
Colin Blundell authored
Part of the elimination of the legacy IPC system. Bug: 1007300 Change-Id: I3c8f3e0e17c157be07b494217e8cbe87edbb990f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832802 Auto-Submit: Colin Blundell <blundell@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#701957}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in ui/display to the recommended methods/types. Bug: 1007849 Change-Id: I4f884da0b9cc4c3bfd248082d963f40c377e887a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831913 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#701956}
-
François Beaufort authored
This CL redefines GPUOrigin3D as not only a GPUOrigin3DDict, but also a sequence of unsigned long as specified in https://gpuweb.github.io/gpuweb/#typedefdef-gpuorigin3d Bug: 877147 Change-Id: Ifa8dfef0891b1018fd497a30b8a9b5d4a05c91a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828905 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#701955}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb06828e0343..b4eef2d93601 Created with: gclient setdep -r src-internal@b4eef2d93601 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I5fdf25a1c4a485f48a775dde93baf0dd905a2607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834862Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701954}
-
Javier Ernesto Flores Robles authored
Change-Id: I2fd0addc01c22156ac1623aec262908d240f5087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832217 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#701953}
-
Kent Tamura authored
This CL implements the option F in [1]. Add Material-like theme as a platform-matching theme. [1] https://github.com/tkent-google/std-switch/issues/6#issuecomment-499842423 Bug: 972476 Change-Id: I643d36b0a4750191d45e7e6cfe2ae320826e3f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832128 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#701952}
-
Arthur Hemery authored
Excluding for failure: org.chromium.content.browser.InterstitialPageTest#testCloseInterstitial Bug: 1007276 Change-Id: Idb1914d3692d98d5ec77cdf46dede5ebd34594e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832274 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#701951}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in components/favicon to the recommended methods/types. Bug: 1007688 Change-Id: I2554067448ac8ac8d27776a7c0e9d1977568cd57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832809 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#701950}
-
Dave Tapuska authored
These classes are no longer used. BUG=978694 Change-Id: I81d129a579f5123eaf1fab86413831169116b073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833315 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#701949}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/85c67b5e08ee..44b32176ee48 git log 85c67b5e08ee..44b32176ee48 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 paulthomson@users.noreply.github.com fuzz: add shrinker-temp-file-prefix (#2928) 2019-10-01 stevenperron@google.com Add continue construct analysis to struct cfg analysis (#2922) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@44b32176ee48 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Bug: None Change-Id: Icf9307dd168cbfb74270451cb39c153542c29db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834666Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701948}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f22f16d3c0a8..8c3bb48f5870 git log f22f16d3c0a8..8c3bb48f5870 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 85c67b5e08ee..44b32176ee48 (2 commits) Created with: gclient setdep -r src/third_party/angle@8c3bb48f5870 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: chromium:None Change-Id: I7480174af3daeae1f751592991b1719ab2611c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834665Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701947}
-
Dave Tapuska authored
RevocableBinding is going to go away. Change to use a direct Receiver interface. BUG=978694 Change-Id: Ib936e500b8e203ac1cbbe739867ff671bb1f22fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834074Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#701946}
-
Fredrik Söderquist authored
Bug: 998526 Change-Id: I719ef2eff9da643c94e848b1f885fd18028ea657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831809Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#701945}
-
Mikel Astiz authored
The old name was misleading because the notion of for-decryption is used in other places like PassphraseRequiredReason with a different meaning. Instead, let's reflect in the name what the function actually does, which is similar to IsPassphraseRequired (independently of reason) but verifies that at least one affected datatype is preferred (selected by the user). Bug: 1010189 Change-Id: Ic75bbcca3e6a902ebd70625a0ad9c1b83ee737aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835351Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#701944}
-
Gauthier Ambard authored
Xcode11 / iOS 13 starts to return different values for navigator.platform IS_IOS checks value of navigator.platform. iOS 13 iPads are returning "MacIntel" for both simulator and devices. Changed regex to accept that. Bug: 1008774 Change-Id: I25000d5baf48cc5476415cfe4d284c3dcd6652b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832210 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#701943}
-
Alan Cutter authored
Placeholder apps are pending installation completion. Attempting to update them will collide with PendingAppManager attempting to finish installing them. Bug: 926083 Change-Id: I0c9e5f61dd8e60ccd0af190b0b8cfb63a1115a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830250 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#701942}
-
Javier Ernesto Flores Robles authored
Add the illustration to be used in the password breach screen. Bug: 1008862 Change-Id: Iae1f4fe0a8bf342d1e9feecc4abd26752d9c5b30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833476Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#701941}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5eac9d301390..2025b9840119 git log 5eac9d301390..2025b9840119 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 tandrii@google.com recipes: update to stop using legacy properties. Created with: gclient setdep -r src/third_party/depot_tools@2025b9840119 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:877161 Change-Id: I8b8efd4f9cdf64518ad045c15227f59396b6ba80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834664Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701940}
-
Darren Shen authored
Add a new struct representing a pending key event as we'll be adding new data to the key event in a follow up patch. Change-Id: I87040818e619236e2e514173ce66db64e66a1177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816197 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#701939}
-
Rune Lillesveen authored
Continue to use ParentOrShadowHostNode() unless the FlatTreeStyleRecalc runtime flag is enabled, in which case we use the flat tree parent. Bug: 972752 Change-Id: Ieb09ba6dcd341825403451ce1a17f86a965cf089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832215Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#701938}
-
Arthur Hemery authored
Followup CL addressing comments by arthursonzogni@ on: https://chromium-review.googlesource.com/c/chromium/src/+/1738451 Bug: 990816 Change-Id: Ibc1610c188e3082a049695dcd1c89dd3f710d264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832819 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#701937}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/98592f6c5dbe..929f3ba81e6e git log 98592f6c5dbe..929f3ba81e6e --date=short --no-merges --format='%ad %ae %s' 2019-10-02 vapier@chromium.org cros_build_lib: rework RunCommandError.result API Created with: gclient setdep -r src/third_party/chromite@929f3ba81e6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic3a4378578af23de38938105f368c90264350a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834663Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701936}
-
Alexandre Courbot authored
ARC++ imported buffers can use a different stride than the one requested by ProvidePictureBuffers(). Make sure to update the buffer stride at the time of the first buffer import, and create the image processor at that time. Bug: b:139901663 Test: Video playback in Chromium and ARC++ on Kukui. Change-Id: I65a26fae11f92bd240a7c32ead2fdb69c20d5377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832126 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#701935}
-