- 30 Apr, 2018 40 commits
-
-
Christos Froussios authored
It is flaky TBR=caitkp@chromium.org Bug: 838124 Change-Id: If142522d8c3cbf996775deabfb3e03012b192908 Reviewed-on: https://chromium-review.googlesource.com/1034902Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#554749}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 50cce18b. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16549 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure TBR=lukebjerring No-Export: true Change-Id: I16eb56232d372474f53c53c9f92b0c60f1228d23 Reviewed-on: https://chromium-review.googlesource.com/1034596 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#554748}
-
csharrison authored
This is all dead code now that PlzNavigate has shipped. This CL should have no intended behavior changes. Bug: 789577 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ifcf05eee1a4486cdf89b8f658bbd2212f0b74bc5 Reviewed-on: https://chromium-review.googlesource.com/1022631 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#554747}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b77ccdf1..1c736c3e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If331770a463194d68b6aa5064f7da7a157207097 Reviewed-on: https://chromium-review.googlesource.com/1034598Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#554746}
-
Aleks Totic authored
Anonymous blocks were passing indefinite block percentage resolution size to their children. The fix is to handle anonymous blocks like we do anonymous fragments, and use ParentPercentageResolutionSize(). Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I147e92570a60b84aa0b840201542d98c0517e82e Reviewed-on: https://chromium-review.googlesource.com/1034094Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#554745}
-
Reza.Zakerinasab authored
Bug: 837963 TBR: junov@chromium.org Change-Id: Ifa500e548d67c87034829b51b230b2d5152c4c1f Reviewed-on: https://chromium-review.googlesource.com/1034463Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#554744}
-
Leonard Grey authored
This reverts commit 5e0ca406. Reason for revert: https://crbug.com/837825 Original change's description: > Don't try to update window title on non-titled browsers > > This causes two unnecessary layouts of BrowserView, each of which causes > three layouts of ToolbarView, each of which causes a whole bunch of > things to happen. > > ChromeOS is excluded since even on a tabbed browser, it relies on > the title to be updated to set the accessibility title. > > Bug: 835983 > Change-Id: I4a62579f8fae394a6c11eb7c8632da176452b00d > Reviewed-on: https://chromium-review.googlesource.com/1024828 > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554040} TBR=ellyjones@chromium.org,lgrey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 835983 Change-Id: I238505c04e1943ce45d69e46c18f633c376acc02 Reviewed-on: https://chromium-review.googlesource.com/1034762Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#554743}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Idfa47ca98804e2f2f9ac6c7a3f4e6a76bffd328d Reviewed-on: https://chromium-review.googlesource.com/1034782 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554742}
-
Peter K. Lee authored
To enable relayout of Infobar based on experiment flags, consolidation helps with wholesale changes of these layout constants. Bug: 804652 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0764fb5b8c0b85723f6a3e24169d345f6ea24497 Reviewed-on: https://chromium-review.googlesource.com/1033502Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#554741}
-
Raphael Kubo da Costa authored
[LegacyArrayClass] was removed from the spec in https://github.com/w3c/fxtf-drafts/issues/280, and was dropped from WebIDL altogether in https://github.com/heycam/webidl/pull/551. Change-Id: I1d43d3af24dd61e3ec5e8a2423ce9e492c9f5e39 Reviewed-on: https://chromium-review.googlesource.com/1034060Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#554740}
-
Greg Kraynov authored
Required in order to move Blink's scheduler/base to //base. Bug: 783309 Change-Id: I3d6b183a1639988f54b6104cba8543d27d8f410f Reviewed-on: https://chromium-review.googlesource.com/1033745Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#554739}
-
Randy Rossi authored
This is the start of porting the automation extension api found in /chrome into cast. The duplicated code will eventually be de-duped when time permits. (Please refer to 78586840 for more info on this). Some implementation methods are stubbed temporarily until more supporting classes are brought in. PS 1 is baseline for copied files. Modifications on top of that in PS >=2 Bug: 73383411 Test: None Change-Id: Id9307fa875b5f16cd337a1529713e4c795f99212 Reviewed-on: https://chromium-review.googlesource.com/1030712 Commit-Queue: Randy Rossi <rmrossi@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554738}
-
Elly Fong-Jones authored
The infobar isn't supported at all in MacViews builds. TBR=andrewhayden@chromium.org Bug: 834754 Change-Id: I476fe3e1373d26d1c013011f1a33fbfce80a9ad1 Reviewed-on: https://chromium-review.googlesource.com/1032758Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#554737}
-
Tim Schumann authored
The MockDelegate was unused and very out of date. Change-Id: Ibae0116fb2a078df4d2fa37b4c0a6e0c80e25aac Reviewed-on: https://chromium-review.googlesource.com/1034688Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#554736}
-
https://skia.googlesource.com/skia.git/+log/efb4d08dd43c..58b90f7f1757 $ git log efb4d08dd..58b90f7f1 --date=short --no-merges --format='%ad %ae %s' 2018-04-27 liyuqian Raise exceptions from child threads to the main thread Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I41ed7729e923026c60c51f98ff7104c2f61d4d3e Reviewed-on: https://chromium-review.googlesource.com/1034461 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554735}
-
Christos Froussios authored
The test fails very often, and sometimes times out. See bug. No-try: true No-presubmit: true Bug: 838120 Change-Id: Ibdc63e23418b47757b53f079bb2841f35d9cf65c Reviewed-on: https://chromium-review.googlesource.com/1034802 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
-
Justin Cohen authored
Bug: 833941 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iecd425473551185e2c0ff381480a7bddd46cb108 Reviewed-on: https://chromium-review.googlesource.com/1034219Reviewed-by:
-
Francois Doray authored
When a task posted to TaskScheduler waits on a WaitableEvent, the pool capacity is automatically incremented after a short delay (https://cs.chromium.org/chromium/src/base/synchronization/waitable_event_win.cc?l=72&rcl=c60b0bcd6830c32c30128867e55a53f27642df5f and https://cs.chromium.org/chromium/src/base/synchronization/waitable_event_posix.cc?l=166&rcl=c60b0bcd6830c32c30128867e55a53f27642df5f and https://cs.chromium.org/chromium/src/base/synchronization/waitable_event_mac.cc?l=115&rcl=c60b0bcd6830c32c30128867e55a53f27642df5f). This is desirable in production (if a task blocks for a long time, another thread is created and the number of tasks that are using the CPU stays constant). However, it is undesirable when a WaitableEvent is used in TaskScheduler tests, because it leads to hard to predict changes of pool capacity. This CL adds a ScopedClearBlockingObserverForTesting annotation to all WaitableEvent::Wait that happen in code that tests SchedulerWorkerPoolImpl, to avoid these hard to predict changes of pool capacity. The annotation is not needed when the WaitableEvent::Wait doesn't happen on a thread managed by SchedulerWorkerPoolImpl, because that already has no effect on pool capacity. Bug: 768436 Change-Id: Ie166ca55f914d89c5dd0fe6dad9ae1533e0f6c29 Reviewed-on: https://chromium-review.googlesource.com/1033533Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#554732}
-
Manuel Rego Casasnovas authored
This patch modifies LayoutBox::ComputeReplacedLogicalWidth|HeightUsing() so it's aware of the orthogonal flow cases. For example to compute the relative widths of replaced elements, if the element direction is perpendicular to its containing block it should use the containing block height instead of the width. BUG=837146 TEST=external/wpt/css/css-writing-modes/sizing-percentages-replaced-orthogonal-001.html Change-Id: I655c984703e2073be9a3a649ac79a63f8c136cc0 Reviewed-on: https://chromium-review.googlesource.com/1029852Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#554731}
-
Mikel Astiz authored
Instead of reading progress markers from the directory, use the UpdateHandler interface, which is supported in USS as well. Some optional but somewhat related test changes are bundled in this patch, although they are not required to pass tests. Bug: 836289 Change-Id: I5a62f27a92aa089a2aa19d4a50aa680c38387c3f Reviewed-on: https://chromium-review.googlesource.com/1033752 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Christos Froussios authored
The following test crash consistently virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-cookies-redirect.any.html virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-cookies-redirect.any.worker.html virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-preflight-star.any.html virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-preflight-star.any.worker.html virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-preflight.any.html virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-preflight.any.worker.html virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-redirect-preflight.any.html virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-redirect-preflight.any.worker.html virtual/outofblink-cors/external/wpt/service-workers/service-worker/fetch-canvas-tainting-video-cache.https.html virtual/outofblink-cors/external/wpt/service-workers/service-worker/fetch-canvas-tainting-video.https.html No-try: true No-Presubmit: true Bug: 838057 Change-Id: I327e21e628b34b710f4df2f2b171bbf80363893a Reviewed-on: https://chromium-review.googlesource.com/1034689Reviewed-by:
-
Juan Antonio Navarro Perez authored
Depends on: https://chromium-review.googlesource.com/c/catapult/+/1032790 Bug: 831199 Change-Id: If395a0a33ba5ae7cb64db11c693a43030aad1838 Reviewed-on: https://chromium-review.googlesource.com/1032748Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#554728}
-
Noel Gordon authored
The test extension comments say they send commands to the browser test (FileManagerBrowserTestBase) harness. OnMessage() processes them: call that routine OnCommand instead, to make it clear that it processes the command messages sent by the test extensions. No change in behavior, no new tests. Bug: 833834 Change-Id: Ifea9996804dbc59b434f2b3cf3e5564172e1a22a Reviewed-on: https://chromium-review.googlesource.com/1034614 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#554727}
-
Christos Froussios authored
This reverts commit c4189fd6. Reason for revert: Reverting caused other, bigger failures. I will disable the test instead. Original change's description: > Revert "OOR-CORS: store more information to CORSErrorStatus on preflight errors" > > This reverts commit 1f675b46. > > Reason for revert: Breaks builder WebKit Linux Trusty ASAN > > Original change's description: > > OOR-CORS: store more information to CORSErrorStatus on preflight errors > > > > Current implementation does not store rejected method or header > > information to CORSErrorStatus on CORS-preflight checks, and > > results in missing hint parameter on CreateErrorString() in Blink. > > This patch provides required information to generate right error > > messages, and fixes some crashed layout tests. > > > > Bug: 803766, 836741 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > > Change-Id: If4de6b916a77d204812a7b010e39080bf059bc9e > > Tbr: kinuko@chromium.org > > Reviewed-on: https://chromium-review.googlesource.com/1030670 > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#554642} > > TBR=kinuko@chromium.org,toyoshim@chromium.org,yhirano@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 803766, 836741, 838057 > Change-Id: Ia8eb9bf63b1b0c6edda93eb7d45c1bb20d26a7b7 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Reviewed-on: https://chromium-review.googlesource.com/1034532 > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554712} TBR=kinuko@chromium.org,toyoshim@chromium.org,yhirano@chromium.org,cfroussios@chromium.org Change-Id: Iaf20d807cf9f71976a3d1c8a46678afb48682029 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 803766, 836741, 838057 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1034702Reviewed-by:
-
Timothy Loh authored
This patch adds a override_app_name field to AppLaunchParams, which is used when launching Crosh (for the Crostini Terminal) to set it to a value that the CrostiniAppWindowShelfController can identify as a Crostini App. Similar to v1 packaged apps which prefix with "_crx_", we prefix with "_crostini_". Previously, the opened window (crosh) would be separate to the Terminal if it were pinned from the App List. Pinning the crosh to the shelf resulted in an icon that only opened chrome://extensions. This patch fixes this so the opened window is the same as a pinned terminal from the App List. Bug: 824549 Change-Id: Ifef0d5b476c5389639c0436ba272037710245ea6 Reviewed-on: https://chromium-review.googlesource.com/1034555Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#554725}
-
Christos Froussios authored
The test is failing and the offending CL cannot be trivially reverted. TBR=rjwright@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 838097 Change-Id: I1f32a74ab6693f0532c9edc2cbc0af554b2ae656 Reviewed-on: https://chromium-review.googlesource.com/1034684Reviewed-by:
-
Anita Woodruff authored
This reverts commit 10f4dd89. Reason for revert: Build failures on 3 bots BUG=838082 Original change's description: > [Cronet] Build maven modules and test by building sample app with gradle > > This change builds maven modules for Cronet. > Each maven module includes: > 1. POM file defining module and listing dependent modules > 2. Jars > 3. Proguard files (optional) > 4. Native libraries (optional) > 5. Resources (optional) > 6. Javadocs (optional) > We build four maven modules: > 1. cronet-api: the Cronet API > 2. cronet-embedded: the Cronet native implementation > 3. cronet-fallback: the Cronet fallback implementation > 4. cronet-common: Cronet implementation in common with #3 and #4 > > To test the maven modules, this change builds the Cronet sample app using gradle. > You can install and run the resulting app by: > ninja -C out/Debug cronet_maven_test_build > adb install -r out/Debug/cronet_maven/test/build/outputs/apk/debug/test-debug.apk > adb install -r out/Debug/cronet_maven/test/build/outputs/apk/androidTest/debug/test-debug-androidTest.apk > adb shell am instrument -w org.chromium.cronet_sample_apk.test/android.support.test.runner.AndroidJUnitRunner > > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I5ed27e86f3e01dc3a6441ab449bbe942553343af > Reviewed-on: https://chromium-review.googlesource.com/998019 > Commit-Queue: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org> > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554608} TBR=pauljensen@chromium.org,kapishnikov@chromium.org,estevenson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I2779ce28f4df2b8dfe8dd2fcf5fc5a3a850c8ee0 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1034534Reviewed-by:
Anita Woodruff <awdf@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#554723}
-
https://webrtc.googlesource.com/src.git/+log/9546f37c0366..28899d0791c4 $ git log 9546f37c0..28899d079 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie46357fefd6577ad7ed11c6329114c34a1f126f2 Reviewed-on: https://chromium-review.googlesource.com/1034459 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554722}
-
Eric Robinson authored
This fixes the origin for the ad iframe to properly account for srcdoc contents by using the Renderer's origin rather than building one ourselves. Bug: 818666 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I00953f8147e46a097099225b8a15d8248ce1f352 Reviewed-on: https://chromium-review.googlesource.com/986673 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#554721}
-
Dominic Farolino authored
As per https://github.com/whatwg/fetch/pull/585, the fetch() API's default credentials mode should be set to same-origin in the Request constructor. I2s: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WOAtshyL2As R=yhirano@chromium.org, yoav@yoav.ws Bug: 759543 Change-Id: Id5cb8c747c41385edcc13775fdd18e1f27e7c3c9 Reviewed-on: https://chromium-review.googlesource.com/981512 Commit-Queue: Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#554720}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/63b7a5b2..b77ccdf1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ie4ef4dc8c4d637956a226dc6c617150849c8ab1c Reviewed-on: https://chromium-review.googlesource.com/1034436Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium be22fa30. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16540 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cvazac@akamai.com, igrigorik@chromium.org: external/wpt/server-timing TBR=lukebjerring No-Export: true Change-Id: I346fcc166be121da74d8abf42da119c31f7c75ae Reviewed-on: https://chromium-review.googlesource.com/1034592 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Noel Gordon authored
These MapString* helpers are only used by TestEntryInfo, so move them into TextEntryInfo as internal static helpers. Also update MapString* comments and their argument names (output does not really work for me). Bug: 833834 Change-Id: Iaef563ab140df5ae1163f2bc9dff72243f78a2c5 Reviewed-on: https://chromium-review.googlesource.com/1034485Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#554717}
-
Mikel Astiz authored
The counters must be updated analogously to how DirectoryCommitContribution::ProcessCommitResponse() does it. AFAIK, the bug affects tests and debug UIs only. Bug: 836289 Change-Id: I91b519bda573133305f31524a0ecb328f7748a11 Reviewed-on: https://chromium-review.googlesource.com/1033872 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#554716}
-
Elad Alon authored
This would prevent a sub-class adding data members after the WeakPtrFactory. Bug: 826206 Change-Id: Idb81d4e677915391a248fc148f1d7ccfbeb852c3 Reviewed-on: https://chromium-review.googlesource.com/1032614Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#554715}
-
Greg Thompson authored
This allows it to be in force during session restore. This CL also gently reduces heap usage during blacklist preparation and moves regular blacklist prep to a non-blocking background thread. BUG=827173 Change-Id: Ibabae7111b6e005ea0433567a8dff840ce2cd156 Reviewed-on: https://chromium-review.googlesource.com/1032744Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#554714}
-
Mikhail Pozdnyakov authored
DevTools currently supports setting mock sensor data that is exposed to the web through a 'deviceorientation' event. Mock data sent this way should also be exposed by the Generic Sensors-based sensor objects. This CL is re-using the existing DevTools infra and UI and thus it brings a dependency from the 'deviceorientation' module to the 'sensor' module in Blink. In the future there should be Generic Sensor-specific extension to the browser protocol and a more sophisticated UI. Note: Unlike 'deviceorientation' events, page reload is required, to bring the overriden device orientation data into action for the `OrientationSensor`-based classes. A dedicated console message is shown to notify the user. Bug: 816478 Change-Id: If6f7371ab20790e30a41cee52636cd0a92715065 Reviewed-on: https://chromium-review.googlesource.com/1024172 Commit-Queue: Alexander Shalamov <alexander.shalamov@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#554713}
-
Christos Froussios authored
This reverts commit 1f675b46. Reason for revert: Breaks builder WebKit Linux Trusty ASAN Original change's description: > OOR-CORS: store more information to CORSErrorStatus on preflight errors > > Current implementation does not store rejected method or header > information to CORSErrorStatus on CORS-preflight checks, and > results in missing hint parameter on CreateErrorString() in Blink. > This patch provides required information to generate right error > messages, and fixes some crashed layout tests. > > Bug: 803766, 836741 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: If4de6b916a77d204812a7b010e39080bf059bc9e > Tbr: kinuko@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/1030670 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554642} TBR=kinuko@chromium.org,toyoshim@chromium.org,yhirano@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 803766, 836741, 838057 Change-Id: Ia8eb9bf63b1b0c6edda93eb7d45c1bb20d26a7b7 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1034532Reviewed-by:
-
Kevin Marshall authored
All executables are run within packages now, so there is no more need to support both packaged and non-packaged execution modes. The transitional codepaths to handle both cases are no longer needed. This CL removes the bootfs mode from the local SDK builder script. Bug: 805057 Change-Id: I01bf0223a70f440de675d4ec2434248f973f3eb6 Reviewed-on: https://chromium-review.googlesource.com/1033475Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#554711}
-
Christos Froussios authored
This reverts commit 209edd56. Reason for revert: The test SplitViewWindowSelectorTest.DragToClose is flaky (mostly failing) on builder Linux Chromium OS ASan LSan Tests e.g. https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27234 Original change's description: > overview: Initial patch for overview swipe to close. > > Adds ability to drag the overview item up or fling the item up to close > the window. A later cl will add the fling animation. The feature is > hidden behind a newly added flag. > > Test: added test coverage > Bug: 828646 > Change-Id: I8e66fb3ed2a642deb6a833f30e9b7674d56b0fee > Reviewed-on: https://chromium-review.googlesource.com/1014490 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554651} TBR=oshima@chromium.org,xdai@chromium.org,sammiequon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 828646, 838061 Change-Id: I3eaedf6f764120131b4da729c7425056ef2bd018 Reviewed-on: https://chromium-review.googlesource.com/1033673 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
-
