- 03 Feb, 2020 40 commits
-
-
Daniel Rubery authored
This CL makes all call sites explicitly indicate which scans are allowed to be performed. Change-Id: I5f0211594de3d48b8c45f15f260461f298088bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032016 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#737923}
-
Nnamdi Theodore Johnson-Kanu authored
Before this CL, when a device had an end of life (EOL) date set, we would show a message in the future tense telling the user when the EOL date would occur. This was confusing if the device had already passed the EOL date, since that date should have been in the past tense. This CL adds a new, past-tense string and displays it when appropriate. Fixed: 1045687 Change-Id: I09c17a00a2c67fda505feabd30d216a09e5e25e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033342Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#737922}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/78f5b92a0b6b..6da434932c2e git log 78f5b92a0b6b..6da434932c2e --date=short --first-parent --format='%ad %ae %s' 2020-02-03 lalitm@google.com Merge "tp: make sql value accessors const" 2020-02-03 treehugger-gerrit@google.com Merge "processor: Allow fallback to tid/pid_overrides for new-style TrackEvents" Created with: gclient setdep -r src/third_party/perfetto@6da434932c2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9f884db17da20abbcf54130a42db553fb12de4c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036340Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737921}
-
Daniel Nicoara authored
Simplify the resizing logic. We're only supposed to be resized by the embedder, so only resize when we're told to. This way we no longer need to worry about the case when a WebContents is embedded inside another WebContents as there's no size updates on the main one. Bug: b/147376354 b/148398442 Test: Verified resizes are applied to the EXO surface. Change-Id: I70d2578bfe91018680b052af3dccf698c5303c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032201Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#737920}
-
Ana Salazar authored
Sets the height of the arrow button to match the bounds of the other shelf buttons to place the tooltip at the same height. Bug: 1043009 Change-Id: I7c83a825c41a5378eefc520023dcc25e6e25de64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033821Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#737919}
-
Avi Drissman authored
This reverts commit 50cf1bfe. Reason for revert: give people time to update Original change's description: > Require the 10.15 SDK to build Chromium. > > BUG=1023913 > > Change-Id: Ibd15e2c76413639c0caf8d1d255add07a815bcdf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033986 > Auto-Submit: Avi Drissman <avi@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737904} TBR=avi@chromium.org,rsesek@chromium.org Change-Id: I38a384dcec4cfca06a4de27e20a9c52d78e5dfea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1023913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036378Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#737918}
-
Avi Drissman authored
This reverts commit 2a99fe61. Reason for revert: going to give people some leeway Original change's description: > Update documentation for requiring the 10.15 SDK. > > BUG=1023913 > > Change-Id: Ib92e5904843229f4e4d1d1fb2cdfa12cfb8db54f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032077 > Auto-Submit: Avi Drissman <avi@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737908} TBR=ellyjones@chromium.org,avi@chromium.org Change-Id: I647d4d86ed348608251f5b3b3d2fb07bb43040a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1023913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036633Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#737917}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/522a6a0e..43c981c9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id997a7f457f487cbab2a95de23f6f10bd0453693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035721Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737916}
-
Andrew Luo authored
Change-Id: I1a7c3150565a92624a6b4042b5cee296fbb1486c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035067Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#737915}
-
James Cook authored
SplitSettingsSync will allow the user to opt-out of browser sync. However, IdentityAccessor::GetPrimaryAccountInfo() assumes the user has consented to browser sync. The usage in AccountManager code isn't related to browser sync consent. Switch to using the "unconsented" primary account. On Chrome OS this account always exists for the logged-in user account, whether or not the user consented to browser sync. See go/cros-sync-mock and go/cros-primary-account for details. on enrolled device, see screen/v3dTEPoVGyg Bug: 1042400 Test: updated existing browser_test Test: Account manager WebUI shows correct domain for primary account Change-Id: Ied51c6aec99b34436a8c308a1ab0d2a569e00a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031642 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737914}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db9ce1e03ccc..ba64534cd9d9 Created with: gclient setdep -r src-internal@ba64534cd9d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1045987 Tbr: jbudorick@google.com Change-Id: Iea79598ca0d1dfed62de797f1f0ee1bf4e5455c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036339Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737913}
-
Regan Hsu authored
This CL copies strings used by the OS Reset page from browser settings to OS settings, and removes strings unused the browser settings. Bug: 967888 Change-Id: I0ab9db7d0380748c4439453277df53de7e6f9a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029265 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#737912}
-
Peter Kasting authored
* Use temps for some minor repeated expressions, whose calculation will get slightly more cumbersome later. * Other minor code movement to reduce later diffs. Bug: none Change-Id: I87d466901608191d9be3ecd0cbeea256e68e2937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021462 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#737911}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/1ccc65258d95..76cf904a4fd4 git log 1ccc65258d95..76cf904a4fd4 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 jophba@chromium.org Improve raspberry pi documentation 2020-02-03 jophba@chromium.org Issue 98: Offer message for aac codec Created with: gclient setdep -r src/third_party/openscreen/src@76cf904a4fd4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I4745775e39e9d9f22e6fcfef597f9c9055785640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036335Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737910}
-
Sam Sebree authored
Revert "[Controls Refresh] Regression: Focus is not seen on color selector icon when the focus is traversed using Tab key." This reverts commit 2292ef33. Reason for revert: Change got in while missing a few WPT baselines for mac builds Original change's description: > [Controls Refresh] Regression: Focus is not seen on color selector icon when the focus is traversed using Tab key. > > This change addresses the bug in which the color picker selection > ring gets placed in the top left corner after closing a color picker > with (255,255,255) is selected. > > Bug: 1046648 > Change-Id: Idb82a962c0ba40338c4a38c5c5526dea7339c5a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032420 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Sanket Joshi <sajos@microsoft.com> > Commit-Queue: Sam Sebree <sasebree@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#737900} TBR=tkent@chromium.org,masonfreed@chromium.org,sajos@microsoft.com,sasebree@microsoft.com Change-Id: Ida95ca36bc3cd1b68af1518c1cfd6d41d76a75e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036437Reviewed-by:
Sanket Joshi <sajos@microsoft.com> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#737909}
-
Avi Drissman authored
BUG=1023913 Change-Id: Ib92e5904843229f4e4d1d1fb2cdfa12cfb8db54f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032077 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#737908}
-
Rayan Kanso authored
The information is extracted from the shortcuts.xml resource if present in the WebAPK. This is needed to diff with a new WebApkInfo generated from the web app manifest for update decisions. Bug: 1045588 Change-Id: Ibe5284d22799e5d5d5c37e53da3da95c6903a5ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027417 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#737907}
-
rajendrant authored
Records the image bytes, subframe image bytes, media bytes as UKM from the PLM infra. UKM privacy review doc: https://docs.google.com/document/d/133SsQTd3L5ryQaI-q1rZsh6EeTsE_HxDFlthjlXi4CU/ Bug: 1047325 Change-Id: Ib77da45c07a2f55bea77a9750b4c69c7584ecf5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032002Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#737906}
-
Victor Costan authored
The change makes all proto fields optional, and slightly simplifies the decoding logic. CookieChangeSubscription::Serialize() sets all the proto's fields, so the change is only relevant for corrupt protos. In this case, proto3 will report default values for missing fields. The change is compatible with previously written data, as proto2 and proto3 use the same on-disk format. Bug: 729800 Change-Id: I06b08ce003b571b716bccd540fa15918ea925bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036393Reviewed-by:
Ayu Ishii <ayui@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#737905}
-
Avi Drissman authored
BUG=1023913 Change-Id: Ibd15e2c76413639c0caf8d1d255add07a815bcdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033986 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#737904}
-
Daniel Murphy authored
This is a reland of 71d64a4f Original change's description: > [IndexedDB] Remove child policy permissions for blobs from IndexedDB > > Now that blobs from IndexedDB are backed & read by the IndexedDB system, > they are no longer sent to the renderer as files. This means no content > policy changes or grants are necessary. > > Tracking document: > https://docs.google.com/document/d/18suNOOzuEJbqgRJF0MB2VqdTyYqS4cvI2PGaCpyPXSw/edit?ts=5de6dc30&pli=1#heading=h.tw2iw2qfgduj > > Bug: 1015212 > Change-Id: If3d2fd80b3254f19a56ab16ed7fc39cf5f0cf684 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955813 > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: enne <enne@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#722617} Bug: 1015212 Change-Id: I4edcd6b1c79005c78c5ecf859cb6807559013a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036431Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#737903}
-
Yuke Liao authored
This CL cleans up the experiments to give all the builders a clean start before enabling the feature on by default, and the reason is that it will be easier to compare the cycle time before and after to measure the impact. Bug: 838735 Change-Id: I7809eafa0d3294d90087e8dde4928a5e88704a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036512Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#737902}
-
chrome://discardsSebastien Marchand authored
This has been accidentally removed in https://chromium-review.googlesource.com/c/chromium/src/+/1994427/10/chrome/browser/ui/webui/discards/discards_ui.cc#b215 Change-Id: Id5de050d8c1fa84ce0137abd87c1650b35aef084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036190Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#737901}
-
Sam Sebree authored
[Controls Refresh] Regression: Focus is not seen on color selector icon when the focus is traversed using Tab key. This change addresses the bug in which the color picker selection ring gets placed in the top left corner after closing a color picker with (255,255,255) is selected. Bug: 1046648 Change-Id: Idb82a962c0ba40338c4a38c5c5526dea7339c5a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032420Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Sanket Joshi <sajos@microsoft.com> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#737900}
-
Ana Salazar authored
To show the app list a user can scroll up from the shelf with the touchpad or the mouse. This gesture needs to ignore the australian and the reverse scroll to feel more natural for the user. Bug: 1035918 Change-Id: I3de6cac2b84bbfbba5a0f678a529222797078ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004952Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#737899}
-
Demetrios Papadopoulos authored
Bug: 1026426 Change-Id: I28820e7694879716d8883f7ba2d2a4c9780b48f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032090 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#737898}
-
Khushal authored
Using this flag is not supported on particular chipsets. R=liberato@chromium.org,vikassoni@chromium.org Bug: 1021007 Change-Id: I8b4e29e2789884463b555cb989f5c7278b7fce50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036374 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#737897}
-
Avi Drissman authored
Chromium compiles with the 10.14 SDK, so remove old code that handled the case where it compiled with previous SDKs. Also update property accesses to use property syntax. Bug: 1044838 Change-Id: Ib7f2e5cd2cfc436dd815e5861d0448262f43955c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021024 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#737896}
-
Peng Huang authored
The crash is because DirectRenderer schedules a primary plane as overlay, however the previous submitted frame has been released due to reshaping. To fix it, we need to make sure to redraw the whole frame if reshape is requested. Bug: 1044678,1048149 Change-Id: Id978fbce86a6481e976828ccea51abf883ac642f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030627 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#737895}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5ddc34ca3de6..23e2ad174cfa git log 5ddc34ca3de6..23e2ad174cfa --date=short --first-parent --format='%ad %ae %s' 2020-02-03 sgilhuly@chromium.org SkiaDawn: Connect GrIOType in onWrapBackendTexture 2020-02-03 scroggo@google.com Allow decoding without color conversion 2020-02-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-03 robertphillips@google.com Make exoticformats GM a bit easier to triage Created with: gclient setdep -r src/third_party/skia@23e2ad174cfa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: Idf85ec6c79d051ce29d04687f63cd28e3a566473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036332Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737894}
-
Ahmed Mehfooz authored
Bug: 1011049 Change-Id: I99996411a41f0383dd252b758663bb0f6b12276d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032793 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737893}
-
Kramer Ge authored
RasterDecoder may not be using GL backend. Turn off gpu.device category if GrContext isn't GL. Next step is implemeing GPUTiming with non GL backends. Bug: 1018725 Change-Id: I95c4d25361297d9ee34165d4a1eedbed97ff5102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033627Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#737892}
-
Daniel Rubery authored
This CL extends the expiry of SBDownloadFeedback.FileErrors, SBClientDownload.DownloadRequestNetError, and SBClientDownload.DownloadRequestDuration. We're launching features related to download scanning in M81, and these histograms will continue to be useful for that launch. Fixes: 1046004, 1041535 Change-Id: I8ef90468916800e53376cd511889afd8d92529f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032511Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#737891}
-
Tom Anderson authored
views::NonClientView has 2 things: a views::NonClientFrameView and a views::ClientView. We were previously only invalidating the layout on the ClientView after a state change. This was causing the browser frame to paint as if it were still maximized after restoring from a maximized state on Linux. Invalidating the layout of the frame view fixes the issue. BUG=1046122 R=sky Change-Id: I7da525efe1f436564ffffb410afe294e901e5d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033759Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#737890}
-
John Delaney authored
This metrics are no longer being used. The original intention was to look at page level limits on ad bytes after loading. This intervention is no longer being pursued in favor the frame level Heavy Ad Intervention. The TTI metric is also difficult to understand in practice due to the complexity of TTI. AdBytesPerSecond is also recoverable in UKM using PageLoad_ForegroundDuration which is more desirable. Bug: 1040613 Change-Id: Ia13107354b434dc6fb00f40c1b46b5532966f40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994163Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737889}
-
Daniel Cheng authored
- Use updated kMaxValue convention for representing the histogram boundary. While it doesn't matter much here, not having a sentinel value is generally preferred (especially if the enum is used in switch statements). - Default to using the function instead of the macro. The macro is more performant, but the UMA recording paths here aren't on the critical path - Switch away from blink::EnumerationHistogram Bug: 742517, 1047547 Change-Id: Ibdcbb312dc1157d6284bdb0de8c9a3b2a591de62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032417Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#737888}
-
Daniel Rubery authored
XSD files are opened the same way as XML files, and should be treated equivalently. Bug: 1024190 Change-Id: Ief9ed22c433b51ffe9d16cb9578fa7a61118140e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032720Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#737887}
-
John Delaney authored
Currently, whitelist rules in the easylist are not always deduplicated by the rule. It is possible for there to be two separate lines with the same rule but different domains. This CL adds an awk command during filter list generation which combines these lines. This shrinks the filter list size by 1.7% and reduces the number of overall rules by 4.7% on the current list. Bug: 1048224 Change-Id: Ib3e71e9b371605380cfc5600fe8a92f5898f5b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033987 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737886}
-
Christopher Cameron authored
It used to be that setting the contents of a CALayer to an IOSurface that has an HDR color space, and setting that the CALayer wants extended range content was sufficient to display HDR content. This was an undocumented behavior, and macOS has recently fixed it (made it not work). The documented way to get HDR is to use a CAMetalLayer. Unfortunately, one cannot call setContents (or provide a pre-existing IOSurface) to this API. As a consequence, we need to perform a copy from the IOSurface to the CAMetalLayer. Add HDRCopierLayer subclass of CAMetalLayer, which overrides setContents to blit the specified contents to the CAMetalLayer. Add tests for this. It appears that the test suite is not running, because most of the tests are broken. Fix all the tests (next step there is to add them to bots, but that will get a separate patch). Bug: 976426 Change-Id: I8115f2ad19f9a9fd3d1018d2bde7132f7bcfc6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033906 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#737885}
-
Toni Barzic authored
Clicking app list button while app list is shown should hide the app list. The click is handled by AppListPresenterDelegate first, and the delegate dismisses the app list if the event is outside certain parts of UI. The logic is supposed to be no-op if the event is targeting home button, but it does not work for app list button on the secondary screen (as it compares the display root window coordinates with screen coordinates), so when clicking app list button on secondary display, AppListPresenterDelegateImpl dismisses the app list before the event is handled by home button, at which point the app list is shown again (in peeking state). This cl fixes the logic to use correct coordinates - additionally, uses View::HitTestPoint to test whether the event should be handled by home button (the home button uses custom event targeter, and HitTestPoint takes this into account). BUG=1047769 Change-Id: I18fd36bfff1583ab4cf1e78cd5732cb8525ef174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033071Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#737884}
-