GitLab

BUG=314766
NOTRY=true

Review URL: https://codereview.chromium.org/61493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233546 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=unit_tests
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/59423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233545 0039d316-1c4b-4281-b951-d872f2087c98

This moves the block of code that adds the "?" from one place to another.
Its original location was wrong because it incremented
|inline_autocomplete_offset| before passing it to FormatUrl().
This could change how FormatUrl() would correct inline_autocomplete_offset
when its value is near the end of the formatted string.
This is wrong.

In both locations, in effect we are adding the "?" prefix after FormatUrl()
runs.  This means we should correct the inline_autocomplete_offset value
to compensate for the extra character "?" only after FormatUrl() runs.

This fixes the bug.

I also added a test that would've caught this issue.

BUG=313451

Review URL: https://codereview.chromium.org/62153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233544 0039d316-1c4b-4281-b951-d872f2087c98

This was reverted because it caused some timeouts. The reland is the same as the
original but I now preseved the original timeout values of Page.enable and
Page.disable.

> util.WaitFor polls which is not appropriate for PerformActionAndWaitForNavigate.
>
> Since DispatchNotifications blocks in recv until it gets some data, there is no
> need to poll at an interval. Instead, we should call recv again as soon as
> possible after dispatching a notification.
>
> In the case of the image decoding measurement, it runs timeline recording. There
> were so many timeline messages to receive that we were not always getting to the
> important Page.navigate message before timing out.
>
> Example:
> http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%281%29/builds/27098
>
> BUG=314375
>
> Review URL: https://codereview.chromium.org/47013004

TBR=kbr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/61483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233543 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314909

Review URL: https://codereview.chromium.org/57463011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233542 0039d316-1c4b-4281-b951-d872f2087c98

BUG=315395
TEST=interactive_ui_tests --gtest_filter=*CancelDragTabToWindowIn*Display

Review URL: https://codereview.chromium.org/61443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233541 0039d316-1c4b-4281-b951-d872f2087c98

BUG=299149

Review URL: https://codereview.chromium.org/61403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233540 0039d316-1c4b-4281-b951-d872f2087c98

Since we now keep the canvas around in the ContentLayerUpdater, we often
end up getting small invalidations that paint on a large canvas. In those
cases, instead of clearing the entire canvas to transparent, clear only the
portion that will be repainted.

BUG=313494

Review URL: https://codereview.chromium.org/61403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233539 0039d316-1c4b-4281-b951-d872f2087c98

BUG=315276

Review URL: https://codereview.chromium.org/61283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233538 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233537 0039d316-1c4b-4281-b951-d872f2087c98

This member has been unused and uninitialized since r204409,
but it looks like we forgot to actually remove the member.

BUG=NONE
TEST=trybots

Review URL: https://codereview.chromium.org/61163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233536 0039d316-1c4b-4281-b951-d872f2087c98

Disable ExternallyConnectableMessagingTest.WebConnectableWithEmptyTlsChannelIdAndClosedBackgroundPage on Linux official bot.

This test fails intermittently on official Linux bot with TIMED OUT error. See http://crbug.com/315264 for more details.
 

BUG=315264

Review URL: https://codereview.chromium.org/61063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233535 0039d316-1c4b-4281-b951-d872f2087c98

This is a better solution for long term for http://crrev.com/44453003 .

BUG=133476
TEST=none

Review URL: https://codereview.chromium.org/54463009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233534 0039d316-1c4b-4281-b951-d872f2087c98

Split SyncBackendHost into SyncBackendHost, SyncBackendHostImpl and
SyncBackendHostCore.

The SyncBackendHost class is now a pure virtual interface.  It is the
contains the interface exposed to the ProfileSyncService.

The SyncBackendHostImpl class implements the functionality of the
SyncBackendHost.  It contains most of the code that used to reside in
SyncBackendHost.

The SyncBackendHostCore is the old SyncBackendHost::Core under a new
name.  It's been moved out of the SyncBackendHost's .cc file and into
its own, publicly declared class.  This will hopefully enable better
testing in the future.

This is a pure refactoring change.  It should have no impact on program
behavior.

BUG=312999

Review URL: https://codereview.chromium.org/61183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233533 0039d316-1c4b-4281-b951-d872f2087c98

Icons loaded asynchronously needed to cause a relayout instead of just
a change to the layout manager.

R=jianli@chromium.org
BUG=315244

Review URL: https://codereview.chromium.org/61003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233532 0039d316-1c4b-4281-b951-d872f2087c98

The skia glyph cache can use up to 4 GDI handles per cache entry (1 HFONT,
1 HBITMAP, 2 HDCs). There's a global (session-wide) limit of GDI handles
at 10k on some version of windows, so we need to keep the per-process handle
count well below this limit to avoid exhaustion. This sets the limit at 64
cache entries so the skia glyph cache will stay under ~256 handles per process.

BUG=314387

Review URL: https://codereview.chromium.org/60933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233531 0039d316-1c4b-4281-b951-d872f2087c98

This adds "2-clause BSD" and "3-clause BSD" to whitelisted licenses.
This is only a wording issue, since "BSD 2-clause" and "BSD 3-clause"
are already whitelisted.

This makes third_party/mach_override pass webview license check, even
though that particular library is not used by webview.

BUG=315381
NOTRY=true
TBR=joth

Review URL: https://codereview.chromium.org/62663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233530 0039d316-1c4b-4281-b951-d872f2087c98

This CL centers the font height when cap height is not supported (actually it's CrOS and Linux).  This behavior is the same before http://crrev.com/54353002 .

BUG=314688
TEST=Test manually.

Review URL: https://codereview.chromium.org/59873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233529 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302696
R=darin@chromium.org, derat@chromium.org

Previously committed in r233414, but reverted in r233416 because it collided with r233347.

Review URL: https://codereview.chromium.org/52823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233528 0039d316-1c4b-4281-b951-d872f2087c98

There was a legitimate bug here, but it only occurred on non-aura builds.
On aura builds, the code was still incorrect but by luck exhibited the
correct behavior.

The confusion about this behavior comes from the fact that prior to
r232828, we allowed Desktop and Metro instances of chrome to run 
simultaneously, depending on which shortcut you clicked.  As of r232828, 
all shortcuts lead to the same browser experience, and we store the 
"stickiness" in the registry and the launch experience is based entirely 
off of the value stored in the registry.

As a result, the code here which was incorrect, and which is fixed in this 
patch, only matters for non-Aura.


BUG=314034

Review URL: https://codereview.chromium.org/60823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233527 0039d316-1c4b-4281-b951-d872f2087c98

For DEPS reasons (this file needs to reference the views directory in an
upcoming CL).

BUG=299250

Review URL: https://codereview.chromium.org/60323007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233526 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233525 0039d316-1c4b-4281-b951-d872f2087c98

git log 141ef86..e98b112 --date=short --format="%ad %an %s" | sed 's/@chromium\.org//'
2013-11-05 Marc-Antoine Ruel Make licensecheck.pl happy by tweaking the license header.
2013-11-05 Marc-Antoine Ruel Update copyright to the Swarming Authors and codereview.settings.
2013-11-05 Marc-Antoine Ruel Update colorama to 5a3100113a3a.
2013-10-30 vadimsh Report all swarming and isolate fatal errors in a consistent way.
2013-10-28 csharp Set the Swarm Test encoding to UTF-8

This removes the need to blacklist colorama for license check.

R=vadimsh@chromium.org,boliu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/59913006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233524 0039d316-1c4b-4281-b951-d872f2087c98

In ::OnXEvent(), we notify of a change in the window, even if the |state_| of the window stays the same. Checking that there was actually a state change would prevent some wasted calls.

BUG=None

Review URL: https://codereview.chromium.org/59873006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233523 0039d316-1c4b-4281-b951-d872f2087c98

BUG=234078
TEST=none

Review URL: https://codereview.chromium.org/59863006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233522 0039d316-1c4b-4281-b951-d872f2087c98

Input elements typed "text", "search", "tel", "url", "email"　 and "number" are text input field: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#attr-input-type

context.type should represent those types. 

BUG=311514

Review URL: https://codereview.chromium.org/47553010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233521 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302724

Review URL: https://codereview.chromium.org/61213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233520 0039d316-1c4b-4281-b951-d872f2087c98

It's empty on Blink side now. Rather than implementing it or leave it empty,
just stop calling it. In Chromium, content::NotificationProvider never goes
away.

BUG=none

Review URL: https://codereview.chromium.org/36073007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233519 0039d316-1c4b-4281-b951-d872f2087c98

This CL updates all references to the WebKit namespace outside of content,
chrome, and components.

TBR=darin@chromium.org
BUG=295096

Review URL: https://codereview.chromium.org/61553006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233518 0039d316-1c4b-4281-b951-d872f2087c98

Remove RenderWidgetHost::AddCreatedCallback as part of removing that pattern. The tests which use this are disabled since a RenderWidget isn't used for AutoFill anymore according to the bug. So when the test is rewritten a new way will have to be found. In the meantime we should remove this so that more callers don't get added.

BUG=277617
R=lazyboy@chromium.org

Review URL: https://codereview.chromium.org/63803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233517 0039d316-1c4b-4281-b951-d872f2087c98

BUG=301510
TEST=http://www.dbtv.no/?vid=2750870727001 plays
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/63643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233516 0039d316-1c4b-4281-b951-d872f2087c98

Addressed nit comments of http://crrev.com/59193005 .

BUG=315056
TEST=none

Review URL: https://codereview.chromium.org/59513006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233515 0039d316-1c4b-4281-b951-d872f2087c98

This match enables to initialize the input mode indicator when multiple input methods are available.

BUG=315007

Review URL: https://codereview.chromium.org/59413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233514 0039d316-1c4b-4281-b951-d872f2087c98

This CL updates all references to the WebKit namespace in content.

TBR=darin@chromium.org
BUG=295096

Review URL: https://codereview.chromium.org/63253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233513 0039d316-1c4b-4281-b951-d872f2087c98

SmoothnessMetricUnitTest mixes testing of TimelineModel,
SmoothnessMetric, and RenderingStats. This patch adds a dedicated unit test
for RenderingStats only. It creates a TimelineModel directly, without using
TraceEventTimelineImporter (which has its own unit test). RenderingStatsUnitTest
verifies that RenderingStats extracts the correct events from the model.

This patch also fixes a bug in TimelineModel.FindTimelineMarkers uncovered
by the new test.

SmoothnessMetricUnitTest itself will be refactored in a separate CL.

R=nduca@chromium.org, tonyg@chromium.org
BUG=314877

Review URL: https://codereview.chromium.org/59403008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233512 0039d316-1c4b-4281-b951-d872f2087c98

The platform-specific implementations of NativeViewport have a bunch of
duplicated code. This CL centralizes that code in the cross-platform
controller class.

R=ben@chromium.org

Review URL: https://codereview.chromium.org/59383011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233511 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=unit_tests

Review URL: https://codereview.chromium.org/59343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233510 0039d316-1c4b-4281-b951-d872f2087c98

This is a repeat of https://chromiumcodereview.appspot.com/11553016/, using the
New Advanced Technology™ in https://chromiumcodereview.appspot.com/54373011/.

BUG=278554
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/58803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233509 0039d316-1c4b-4281-b951-d872f2087c98

("more" = "everything but the Android-only targets")

R=sky@chromium.org, sky

Review URL: https://codereview.chromium.org/63393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233508 0039d316-1c4b-4281-b951-d872f2087c98

The change to UMA aligns metrics for the data reduction proxy on
Android and iOS.

BUG=241518

Review URL: https://codereview.chromium.org/59113012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233507 0039d316-1c4b-4281-b951-d872f2087c98