GitLab

instead of using assets.

BUG=708218
TBR=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2836493002
Cr-Commit-Position: refs/heads/master@{#467743}

This CL adds a new resource type field to the manifest proto.
ResourcePrefetchPredictor begins to use this field to prefetch all resources of
one resource type before another.

Also we prioritize stylesheets above scripts since this CL. Stylesheets are
almost always critical, scripts are not. It's clear win in the case if we're
fetching resources from manifests because we don't have information about
request priority in manifests. Thus we can't separate critical scripts from
non-critical ones.

BUG=699115

Review-Url: https://codereview.chromium.org/2831233004
Cr-Commit-Position: refs/heads/master@{#467742}

We have fast-path for invisible collapsed borders. Treating zero-
width as invisible can improve performance in the case.

Also move core/style/CollapsedBorderValue.h to core/layout because
the structure is not used by any style code.

This CL will reduce frame time of PerformanceTests/Mutation/background-change-with-zero-width-collapsed-borders.html (in
https://codereview.chromium.org/2842313002/) by about 50%.

Review-Url: https://codereview.chromium.org/2842323002
Cr-Commit-Position: refs/heads/master@{#467741}

Android 4.2 and below has a problematic RTL implementation. Force
formatted URLs to display in LTR.

BUG=709417

Review-Url: https://codereview.chromium.org/2839843002
Cr-Commit-Position: refs/heads/master@{#467740}

This CL lists success.html as an webview accessible resource for
the sign-in extension.

This CL adds an exception for sign-in extension when for loading
webview accessible resources.

BUG=709117
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2831183003
Cr-Commit-Position: refs/heads/master@{#467739}

Some utility processes don't have a Service Manager connection.

BUG=715840

Change-Id: Ie6ba83ef9e2b64986a04a301c96764a9fe7c6f7c
Reviewed-on: https://chromium-review.googlesource.com/488463Reviewed-by: Ben Goodger <ben@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467738}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c46500e9c5b7..67894d267da3

$ git log c46500e9c..67894d267 --date=short --no-merges --format='%ad %ae %s'
2017-04-27 hjd [tracing] Fix crash in getObjectInstanceColor due to typo

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Id10e90b6759d9a8419c3e56bc2a7fd4b2e76feb4
Reviewed-on: https://chromium-review.googlesource.com/489062
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467737}

The current implementation is using the service worker database (is based on
level DB) to store payment instrument data. The other SW features also use
the same way.
The instrument key is mapping with database key directly, So, the database key
might be conflict with other SW related features such as push notification.
To avoid this problem, this CL adds a prefix to instrument key.

BUG=661608
TEST=existing tests

Review-Url: https://codereview.chromium.org/2847533003
Cr-Commit-Position: refs/heads/master@{#467736}

R=rijubrata.bhaumik@intel.com,mcasas@chromium.org
BUG=698853

Review-Url: https://codereview.chromium.org/2848533002
Cr-Commit-Position: refs/heads/master@{#467735}

Forward declaring of enums without specifying a type is illegal. These
forward declarations only worked because they weren't needed. They were
found by VC++'s overzealous C4471 warning.

R=raymes@chromium.org

Review-Url: https://codereview.chromium.org/2835943003
Cr-Commit-Position: refs/heads/master@{#467734}

It was added as an empty executable https://codereview.chromium.org/9274003/
and never grew to more than that, except that the cc file isn't even
referenced from any .gn file now that the gyp build is gone.

BUG=661774

Review-Url: https://codereview.chromium.org/2848593003
Cr-Commit-Position: refs/heads/master@{#467733}

BUG=715232

Review-Url: https://codereview.chromium.org/2844543002
Cr-Commit-Position: refs/heads/master@{#467732}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3338869a..227fee38

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2845983003
Cr-Commit-Position: refs/heads/master@{#467731}

BUG=715962

TBR=rnephew@chromium.org

Review-Url: https://codereview.chromium.org/2850483002
Cr-Commit-Position: refs/heads/master@{#467730}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=bartfab@chromium.org

Review-Url: https://codereview.chromium.org/2837083002
Cr-Commit-Position: refs/heads/master@{#467729}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=bartfab@chromium.org

Review-Url: https://codereview.chromium.org/2834413003
Cr-Commit-Position: refs/heads/master@{#467728}

After processing overlay candidates we used to remove the overlay rects
from the damage rect.
The assumption was that all the overlays would be opaque.

Since we started allowing alpha blended overaly, we should avoid
subtracting from the damage when blending might be allowed.
Otherwise any element animating below a transparent overlay might
not be updated.

We haven't noticed any problem so far since partial update was disabled
on Mali. crrev.com/2829543003 enables empty swap, surfacing the problem
when the damage region is a subset of a transparent overlay.

BUG=705290
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2842383003
Cr-Commit-Position: refs/heads/master@{#467727}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2843563002
Cr-Commit-Position: refs/heads/master@{#467726}

This flag should be on by default in all non-test cases, so this patch
removes the flag altogether.

BUG=696864
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2781183002
Cr-Commit-Position: refs/heads/master@{#467725}

BUG=none

Review-Url: https://codereview.chromium.org/2852443002
Cr-Commit-Position: refs/heads/master@{#467724}

Revert of [blink] Unique pointers in Platform.h (patchset #6 id:100001 of https://codereview.chromium.org/2846843002/ )

Reason for revert:
Broke the tree

Original issue's description:
> [blink] Unique pointers in Platform.h
>
> Make Platform::*Create methods return a unique_ptr instead of a raw pointer
> to explictly state ownership logic.
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2846843002
> Cr-Commit-Position: refs/heads/master@{#467710}
> Committed: https://chromium.googlesource.com/chromium/src/+/d548cc04b6568f8edc08853940134707fcd6c455

TBR=haraken@chromium.org,clamy@chromium.org,tdresser@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2850593002
Cr-Commit-Position: refs/heads/master@{#467723}

This patch replaces some instances of unordered_map with flat_map. This
is done for cases where we can reason out that the number of elements
contained is small.

R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2847553002
Cr-Commit-Position: refs/heads/master@{#467722}

libbase is needed when using compiled_action targets (these are
helper programs compiled for use later in the build), but it doesn't
currently build for the host inside the CrOS sysroot because the
toolchain doesn't include the libatomic library. libbase does, however,
seem to compile without the -latomic flag.

TEST=Revert 5e671fff, compile elm
BUG=710006, 710841

Review-Url: https://codereview.chromium.org/2823303003
Cr-Commit-Position: refs/heads/master@{#467721}

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2841833002
Cr-Commit-Position: refs/heads/master@{#467720}

This CL moves ScriptWrappable.h/cpp and all its dependencies to platform/bindings. The
original header for each file is not deleted, but is modified to point to the new header
in platform/bindings (This will be cleaned up in follow-up CLs).

BUG=682322

Review-Url: https://codereview.chromium.org/2843603002
Cr-Commit-Position: refs/heads/master@{#467719}

If a Frame has non-overlay scrollbars, the visualViewport's dimensions
should exclude them. In order to know whether the Frame has scrollbars,
we need to perform any pending layouts.

This was only broken for iframes as the main frame viewport size
depends on page scale. Page scale depends on layout to determine
the minimum/initial page scale so we already performed layout when the
main frame's viewport was queried.

BUG=714829

Review-Url: https://codereview.chromium.org/2842343002
Cr-Commit-Position: refs/heads/master@{#467718}

The object is quite large, this class doesn't need to know about
it. This is intended to ease refactoring.

BUG=715525

Review-Url: https://codereview.chromium.org/2845103002
Cr-Commit-Position: refs/heads/master@{#467717}

Revert of 📺 Move fullscreen web content to a new Activity. (patchset #11 id:200001 of https://codereview.chromium.org/2807663002/ )

Reason for revert:

Findit(https://goo.gl/kROfz5) identified CL at revision 467705 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I3MWU5OGNkZjE0ZjE4Y2I5NjdhNzM4NTc4MjZmNmU4YzU2OGNlYTAM

Original issue's description:
> Move fullscreen web content to a new Activity.
>
> Introduce the FullscreenMediaActivity and move Tabs to it when entering
> fullscreen and away from it when leaving fullscreen.
>
> BUG=709042
>
> Review-Url: https://codereview.chromium.org/2807663002
> Cr-Commit-Position: refs/heads/master@{#467705}
> Committed: https://chromium.googlesource.com/chromium/src/+/b71e98cdf14f18cb967a73857826f6e8c568cea0

TBR=mlamouri@chromium.org,bauerb@chromium.org,twellington@chromium.org,yusufo@chromium.org,peconn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=709042

Review-Url: https://codereview.chromium.org/2849533004
Cr-Commit-Position: refs/heads/master@{#467716}

Revert of Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag. (patchset #2 id:20001 of https://codereview.chromium.org/2843913003/ )

Reason for revert:
broke clang-clankium-tot-builder crbug.com/716075

(FullscreenWebContentsActivityTest not updated)

Original issue's description:
> Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag.
>
> The flag should only be set by tests and will allow all autoplay related
> restrictions such as autoplay policy and background playback to be
> disabled.
>
> BUG=714676
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2843913003
> Cr-Commit-Position: refs/heads/master@{#467692}
> Committed: https://chromium.googlesource.com/chromium/src/+/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6

TBR=dalecurtis@chromium.org,jam@chromium.org,mlamouri@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=714676

Review-Url: https://codereview.chromium.org/2851453003
Cr-Commit-Position: refs/heads/master@{#467715}

- Browser goes into VR Browsing Mode when the user inserts the phone into the headeset.
- Browser will then automatically go into presentation mode if page requests present in onvrdisplayactivate handler.
- In a follow-up CL, browser should tentatively go into presentation mode if page is listening for onvrdisplayactivate (and exit presentation if page does not request present).

BUG=703315

Review-Url: https://codereview.chromium.org/2850483003
Cr-Commit-Position: refs/heads/master@{#467714}

Since we currently don't support vulkan on chrome, we just add our dummy
Vulkan headers to chromes skia includes so we can the vulkan headers for
type declarations.

BUG=

Review-Url: https://codereview.chromium.org/2843823003
Cr-Commit-Position: refs/heads/master@{#467713}

* Use kFoo for enums.
* Don't need to use mojom to test serialization of structs.

BUG=NONE

Review-Url: https://codereview.chromium.org/2843413002
Cr-Commit-Position: refs/heads/master@{#467712}

It's easy to get this wrong and use Set instead, which can invoke author script
in unexpected places. This is a convenient helper that does the right thing,
similar to blink::V8ObjectBuilder.

A unit test and two "real-world" uses are included.

BUG=

Review-Url: https://codereview.chromium.org/2845463002
Cr-Commit-Position: refs/heads/master@{#467711}

Make Platform::*Create methods return a unique_ptr instead of a raw pointer
to explictly state ownership logic.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2846843002
Cr-Commit-Position: refs/heads/master@{#467710}

At the moment SensorProxy is the only source of error notification for the Sensor class instances, however soon other error notification sources will turn up (e.g. permission subsystem), so we must guarantee that stopping of a Sensor due to an error is reflected on platform side.

BUG=606766

Review-Url: https://codereview.chromium.org/2839963004
Cr-Commit-Position: refs/heads/master@{#467709}

Previously, whenever the shell_apk in shell_apk_version.gni there was a period
of time during which
- Chrome tries to update the WebAPK because the "shell_apk" version with which
  Chrome is compiled with was updated
- The WebAPK server is unable to fulfill the update request because the new
  ShellAPK has not yet been uploaded to the WebAPK server

This CL splits shell_apk_version in shell_apk_version.gni into two variables:
|template_shell_apk_version| and |expected_shell_apk_version|

The new flow for updating android/webapk/shell_apk will be:
1) Write CL which:
   - Makes changes to code in android/webapk/shell_apk
   - Increments |template_shell_apk_version|
   This will:
   - Update the template ShellAPK which is built on the official build bot
   - Trigger an alert that the ShellAPK on the WebAPK Minting Server needs to
     be updated
   - Does not affect the "WebAPK update logic".
2) Upload new ShellAPK template to the WebAPK Minting Server
   At this point:
   - new WebAPK installs will have the updated shell.
   - Chrome will still not request updates to the new ShellAPK version
3) Write CL which:
   - Increments |expected_shell_apk_version|
   This will:
   - cause Chrome to request updates to the new ShellAPK version

BUG=708053

Review-Url: https://codereview.chromium.org/2827233006
Cr-Commit-Position: refs/heads/master@{#467708}

Currently textQuads and ComputeTextRects algorithm is
mostly same. The difference of behaviour of these two functions
can be handled efficiently by using templates.

This CL is the Second patch set to achieve the above behaviour.
This CL introduces ComputeTextBounds as template function, which
will  be used by computeTextRects only in this patch.

BUG=691198

Review-Url: https://codereview.chromium.org/2839633002
Cr-Commit-Position: refs/heads/master@{#467707}

This "hidden" base class was forcing two virtual calls to reach a Frame from a WebFrame. It is now one virtual call away.

BUG=713798

Review-Url: https://codereview.chromium.org/2837593002
Cr-Commit-Position: refs/heads/master@{#467706}

Introduce the FullscreenMediaActivity and move Tabs to it when entering
fullscreen and away from it when leaving fullscreen.

BUG=709042

Review-Url: https://codereview.chromium.org/2807663002
Cr-Commit-Position: refs/heads/master@{#467705}

It is no longer necessary to list all the apk targets as separate
modules now that we have the _all pseudo module. Having the separate
modules resulted in bugs where Android Studio could not distinguish
between prod code and test code since some modules viewed dirs as prod
and some as test. The --split-projects flag can be used to see the
dependency graph, and when only a single module will be generated, the
_all pseudo module will not replace it.

For android studio's _all pseudo module, move all known test dirs to
androidTest instead of main so that they are properly displayed when
filtered.

BUG=620034

Review-Url: https://codereview.chromium.org/2837863002
Cr-Commit-Position: refs/heads/master@{#467704}