- 03 Feb, 2020 40 commits
-
-
Saurabh Nijhara authored
This CL includes adding device policy MinimumChromeVersionEnforced which accepts a list of minimum required version configurations and selects the best configuration in the order of preference min_version>warning_period>eol_warning_period. The policy restrictions are then applied on the basis of this config. This is the first CL in the implementation of Minimum Chrome Version. The subsequent CLs will include unittests and handling of different cases as critical updates, end-of-life, dusty devices, metered connections, update required screen. Bug: 944838 Change-Id: Ib1aadea43ea5692349b89ab54c1b58890ee27f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007570Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#737747}
-
Saurabh Nijhara authored
This CL adds a new browser test for captive portal on the update required screen. Bug: 944838 Change-Id: Iaf40f8668e762dd33cf5f80372f947a5bed60aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019108 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737746}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/42bf253e3e43..09a9f1ba72d5 git log 42bf253e3e43..09a9f1ba72d5 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 srte@webrtc.org Adds simulated time controller API. 2020-02-03 srte@webrtc.org Accept undecoded frame pairs in VideoLayerAnalyzer Created with: gclient setdep -r src/third_party/webrtc@09a9f1ba72d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id43553e8e035a92dbaad3569b3275ddc977a2470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035598Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737745}
-
Michael van Ouwerkerk authored
* Adds a pulse_interval constructor argument and getter to DeviceInfo. * Adds a pulse_interval field to the DeviceInfoSpecifics proto. Bug: 1030266,1048112 TBR=jeffreycohen Change-Id: I81bda5f8fb8e9356943b3b38e9036b7a7a9bf4e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031028 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#737744}
-
Marc Treib authored
TBR=wangxianzhu@chromium.org Bug: 1048113 Change-Id: Ib5eb4bc816f02cfdef0b7968cc2c8c92cd1601f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034525Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#737743}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1863ec3f932b..c1a0ada7d208 Created with: gclient setdep -r src-internal@c1a0ada7d208 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I028f5c25d0dfd25a9663e83af6196de88848d4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035594Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737742}
-
Nico Weber authored
...except on Android, where this fires once in libunwind's arm32 code, which we'll have to fix first. Bug: 1016947 Change-Id: I5f64a1805736a30f1cf4050e9ec0ceb4ff4eae2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032791 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#737741}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: If9b0212fee64f28d35cc320a806bd54f4488ac7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035533Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737740}
-
Jan Scheffler authored
This cl adds support to the audits agent to collect and persist issues similar to how console messages are handled. Bug: chromium:1039607 Change-Id: Ie818516fd019bc9c6efa03888ab7dad5705e4d7f Design-Doc: https://docs.google.com/document/d/1F6R5Bpb3qHNzGPNBSXwEJ_eP8L-anIj0WinxOIyAh54/preview Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991507Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#737739}
-
Nazerke authored
This CL modernizes the ManageSyncSettingsCoordinator to remove the public property for dispatcher and to update the coordinators implementation to get it from self.browser. Bug: 1029346 Change-Id: I395a6235682f3983126dd546ca11f2b3192e5e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033258 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#737738}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e27cd5339842..b6b755afe678 git log e27cd5339842..b6b755afe678 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 tvanderlippe@chromium.org Migrate workspace_diff/ to import cross-module 2020-02-03 tvanderlippe@chromium.org Prepare AuditsService for audits_worker change 2020-02-03 aerotwist@chromium.org [e2e] Update helper to use hosted mode instead of file protocol Created with: gclient setdep -r src/third_party/devtools-frontend/src@b6b755afe678 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1047667 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9f208b875ebe4c31cfb804d05a50e98bdaa7403b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035593Reviewed-by:
-
Marc Treib authored
TBR=dtrainor@chromium.org Bug: 1048100 Change-Id: I747ea99ddcd9d41b598818784c872460b0591e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033449Reviewed-by:
-
Clemens Arbesser authored
Bug: b/145043394 Change-Id: I37d416be30ccbf46d990548566f3d2521c7baeef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033152Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#737735}
-
Pâris MEULEMAN authored
This fixes three tests: - blob-popup.https.html checked for a random string to be empty, which makes test expectations unreliable, use length instead. - coop-navigated-popup.https.html had a failure in the cleanup, trying to use a non-existent object. This change defines the broadcast channel beforehand and uses the proper variable name. - historical/coep-navigate-popup-unsafe-inherit.https.html had an invalid expectation that navigating a popup from a COOP: same-origin document to a COOP: unsafe-none document should not create a new browsing context group. Bug: 922191 Change-Id: Ife24aee4369a3a25bbff32a2fe5e8c29abb2d468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030902 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#737734}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9d56b0113fff..42bf253e3e43 git log 9d56b0113fff..42bf253e3e43 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 phoglund@webrtc.org Migrate static imports of org.mockito.Matchers. Created with: gclient setdep -r src/third_party/webrtc@42bf253e3e43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5f4328f83f5837a698a6ccd9fcfab45fcb88068c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035369Reviewed-by:
-
Yuki Shiino authored
A set of overloading of ToV8({ScriptWrappable,EventTarget,Node, DOMWindow}*) has been expected to be used for each class, however, it turned out that ToV8(ScriptWrappable* value) is used even when |value| is a DOMWindow. Example case) void Func(ScriptWrappable* value) { ToV8(value); // resolved to ToV8(ScriptWrappable*) } Func(window); // ToV8(ScriptWrappable*) is invoked This patch removes ToV8(DOMWindow*) overloading and moves the special-handling of DOMWindow from ToV8 into DOMWindow::Wrap so that the special-handling always works. Change-Id: I483ba3293ce6736428947525e7a13d38c6071783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996111Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#737732}
-
Marc Treib authored
TBR=chenwilliam@chromium.org Bug: 1044505 Change-Id: I18af5ad3da693eec837cbce5c21968f4b106a322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033073Reviewed-by:
-
anina koehler authored
When running tests from device_cloud_policy_manager_chromeos_unittest.cc, GMOCK warnings about uninteresting mock function calls are appearing. Similar to ConnectManager(), a helper method ShutdownManager() was created and expect calls for MockCloudExternalDataManagers Connect() and Disconnect() methods were added in the helper methods. Bug: 1046259 Change-Id: Ibb371bcf8bdaaf04974737f616e4081f8a994b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012281 Commit-Queue: Anina Koehler <aninak@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#737730}
-
Marc Treib authored
TBR=kylechar@chromium.org,agawronska@chromium.org Bug: 1048073 Change-Id: Ie3822f2e9be287f31222fc24b0010d97ae799b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033516Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0d9543d525ec..1863ec3f932b Created with: gclient setdep -r src-internal@1863ec3f932b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If9cec59d0492743f4586d6f698f6929863bff53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035363Reviewed-by:
-
Jihwan Marc Kim authored
Existing PasswordManager::BuildSuggestions helper is quite convoluted, reorder the parameters. Bug: 1046756 Change-Id: I82e50d08954bae9f94268759800051c6eb20465f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032627Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#737727}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3610dd0daf0f..e27cd5339842 git log 3610dd0daf0f..e27cd5339842 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 aerotwist@chromium.org [e2e] Have Mocha resolve on end instead of suite end 2020-02-03 szuend@chromium.org [cleanup] Minor code cleanups in BreakpointManager Created with: gclient setdep -r src/third_party/devtools-frontend/src@e27cd5339842 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1047672 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifbbb6d36c189b8d6558c9f4925b7693ee18b2ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035367Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7b430041e7fc..784967be4d56 git log 7b430041e7fc..784967be4d56 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 ddrone@google.com Add a message for LatencyInfo.Flow Created with: gclient setdep -r src/third_party/perfetto@784967be4d56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: If697bb558f577e2368ef9ab3e75c46b71842e748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035366Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I7c8391cfd5f26de9a4aee4f2b223e913650f42fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033053 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#737724}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-4025.0-1580122052-benchmark-81.0.4019.0-r1 to 81-4025.0-1580122052-benchmark-81.0.4044.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I0afd37e7c83ab1bb925e57c8b7365624df484aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035368Reviewed-by:
-
Saurabh Nijhara authored
This CL updates the update_required_dialog to handle cases for no network present, metered network, eol reached and update required. Bug: 944838 Change-Id: I5bf028251cbf88b5048697fcbc903faf2f665b51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007642 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
-
Rune Lillesveen authored
The html spec talks about script blocking stylesheets[1], but we do script blocking in body by pausing the html parser. The APIs for doing that for the XML parser had empty implementations which meant that querying style from a script after an external stylesheet resource would not wait for the stylesheet to load. [1] https://html.spec.whatwg.org/multipage/semantics.html#interactions-of-styling-and-scripting Bug: 1043944, 917116 Change-Id: I08422fa0608db8972154a8b19854906e154dfdd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012021 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#737721}
-
Oriol Brufau authored
Since r731964, if you clicked a ::marker originated by a ::before or ::after, and you read the 'path' property of the event, the first node in the array might be the ::before or ::after pseudo-element. Actually it was fine if you clicked the contents (text or image) of the ::marker. But it's possible to make the ::marker taller than its contents by setting a big 'line-height'. Then you could click inside the ::marker but outside its contents, and reproduce the problem. That was wrong, as described in pseudo_element.h, > Pseudo element are not allowed to be the inner node for hit testing. This patch fixes it by making PseudoElement::InnerNodeForHitTesting iterate ancestors until it finds one which is not a pseudo-element. Bug: 1048000, 457718 TEST=external/wpt/css/css-pseudo/marker-hit-testing.html Some checks fail in legacy because the marker ignores 'line-height'. Change-Id: I7bed7d0824638b0c7f4b63a744a3ca4978285445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030973Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#737720}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2dd9ed07760d..43a0a815b814 git log 2dd9ed07760d..43a0a815b814 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 cwallez@chromium.org Fix examples running with the wire. Created with: gclient setdep -r src/third_party/dawn@43a0a815b814 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I6ca96eb1c5fc6bfdda150e4b3be6f60629171f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035360Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds a base::Feature for the Password Check feature by renaming the existing Leak History feature that so far hasn't been used. It also adds logic to expose the feature to the Desktop settings. Bug: 1047726 Change-Id: Ieb5b29d1a3cee6cd866502864251d40cbf93ab8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033446 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Marc Treib authored
This reverts commit db4b7168. Reason for revert: New WebTime* tests are failing on MSan, crbug.com/1048043a Original change's description: > Adds WebTimeActivityProvider. > > This CL adds WebTimeActivityProvider which is > BrowserListObserver, a TabStripModelObserver, > AppServiceWrapper::EventListener, and > WebTimeNavigationObserver::EventListener. It is hosted > in AppTimeController. > > The instance of this class observes > the TabStripModel of each Browser in BrowserList. It also > observes the WebTimeNavigationObserver instances of each WebContent > hosted in each Browser window. The instance also observes > AppServiceWrapper to learn about the activation/deactivation of > chrome application windows. > > WebTimeActivityProvider informs its observers when Chrome becomes > Active, Active with whitelisted content or inactive. > > Bug: 1034551 > Change-Id: I7d7dd3624ea4fb764c13e35f0ef542759cee8933 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020522 > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737492} TBR=agawronska@chromium.org,yilkal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1034551, 1048043a Change-Id: Id065ff05c0b67ed514a034455c40a8ab71f7280e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033515Reviewed-by:
-
Nazerke authored
This CL only removes DCHECK of browserstate which is not used. Instead of that DHECK for browser is added as the coordinator is already using the initializer with a browser instance. Change-Id: I7094d68f7e6d3f235b34f49b9eec8bb126d76fb6 Bug: 1029346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033352Reviewed-by:
-
Kenichi Ishibashi authored
The reference was tentatively added to move some code from ServiceWorkerStorage to ServiceWorkerRegistry but it isn't needed any more. Bug: 1039200 Change-Id: I59ac327e120bfd82d87c3c81b95d6da3d629dd5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035230 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#737715}
-
Simon Zünd authored
This CL re-writes a breakpoint web test using a new SourcesTestRunner helper introduced in https://crrev.com/c/2027427. This should not only prepare the test for the upcoming source map asyncification but also reduce the overall flakiness of breakpoint web tests. This CL superseeds the current in-flight CL https://crrev.com/c/2022642 which will be abandoned. R=sigurds@chromium.org Bug: chromium:1032016 Change-Id: Id5bcd9d3913a2f83c029f52da33e484c61f0c9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030464Reviewed-by:
-
Nazerke authored
This CL modernizes the BadgePopupMenuCoordinator to use the superclass -initWithBaseViewController:browser: initializer. Also this CL updates showcase coordinator for Badge Popup Menu Coordinator. Bug: 1029346 Change-Id: Ib683cdb45452b90412e953a4c9a25495ef2389f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033161Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fed0dda178e6..326c900efd28 git log fed0dda178e6..326c900efd28 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src bd4b3a888fca..e85fe4c3cc9f (3 commits) 2020-02-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 79b36b640692..41a7302e9c62 (3 commits) Created with: gclient setdep -r src/third_party/angle@326c900efd28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: Iac9e6d7bbcf7ddc98031b792ff80a948552ad8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035166Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7e6ae2798c52..3610dd0daf0f git log 7e6ae2798c52..3610dd0daf0f --date=short --first-parent --format='%ad %ae %s' 2020-02-03 bmeurer@chromium.org [karma-tests] Add unit tests for StringOutputStream. Created with: gclient setdep -r src/third_party/devtools-frontend/src@3610dd0daf0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ida574cd6f54b514bc0efc91aca1536f6bdc2f126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035354Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5bec61a84538f758f48027e76ab428f48f2be953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035357Reviewed-by:
-
Owen Min authored
In chrome.enterprise.reportingPrivate.getDeviceInfo API, screen lock secured flag now check if user has password on Windows. The code behavior matches SecureConnect native host: 291830502 Bug: 1047785 Change-Id: Iffc94d9cf179f85f353b8d245b90f5dd759c4bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031703 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#737709}
-
Marc Treib authored
TBR=yaoxia@chromium.org Bug: 1047921 Change-Id: I5883ab91335fb7faa0a7ee45d93b5535b2cca794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033513Reviewed-by:
-
