- 11 Mar, 2020 40 commits
-
-
Mathias Bynens authored
This patch removes a redundant attribute/value pair from the internal blurredVision filter definition. `in="SourceGraphic"` is the implicit default per [1] and [2]: > If no value is provided and this is the first filter primitive, > then this filter primitive will use SourceGraphic as its input. [1]: https://www.w3.org/TR/SVG11/filters.html#CommonAttributes [2]: https://drafts.fxtf.org/filter-effects-1/#CommonAttributes Bug: chromium:1003700 Change-Id: Idc2aaaf435e5ef57e00cfc0341d53214812001c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094667Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#749167}
-
Eric Leese authored
This functionality is now being tested in the devtools e2e test suite. Furthermore the existing test tests against incorrect behavior, so it would block fixing the behavior in dev tools. Bug: chromium:670180 Change-Id: I677de297f8494bbb334c0df58eebd493e9648fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096590Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#749166}
-
Hui Yingst authored
A previous CL https://crrev.com/748972 records metrics for toggling two-up view mode in the PDF viewer. This is a follow-up CL, which adds the enumerations used for two-up view actions' metrics. Bug: 51472 Change-Id: Iae03eaea36d07ebdbe4eb52df5e50709b2e13d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097495 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#749165}
-
Fergal Daly authored
There was only one site populating these and it was not necessary (it was already skipping population if this was a new browsing instance). This is a pre-factor for https://crrev.com/c/2084038 Change-Id: I585160d2533fc5adfbe317a1ace2166b8a378915 Bug: 1059678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094579Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#749164}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: Ib12f5472b9f9becf1bb30f4fdc966d3c06576fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097506Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749163}
-
Patrick Monette authored
This is a temporary CHECK() to help diagnose an existing crash. The goal is to turn it into a dcheck once the issue is solved. Bug: 1058705 Change-Id: I985d38759dcbfdd00ccdea896c1630fa925cf35f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097175 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#749162}
-
Artem Sumaneev authored
New metrics are similar to policy invalidations metrics. But, unlike the latter, remote commands invalidations use only user and device scopes because device local account scope does not exists for remote commands. BUG=chromium:1045008 TEST=Manual testing Cq-Depend: chromium:2078213 Change-Id: I7bd7cbe6c0403ab39548761f39003b07811c8443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023834Reviewed-by:
Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Artem Sumaneev <asumaneev@google.com> Cr-Commit-Position: refs/heads/master@{#749161}
-
arthursonzogni authored
(pure refactor) Before this patch, the BrowsingInterfaceBinder collected all the attributes needed to bind the CacheStorage: - process, - origin - COEP - COEP_reporter (in the next patch) and binded it. After this patch, this work is done by the classes representing the context on which the CacheStorage is requested: - RenderFrameHostImpl, - DedicatedWorker, - SharedWorker, - ServiceWorker The code is slightly shorter and simpler. It will allow all theses classes to provide their own COEP and COEP_reporter. This will be used by the following patch in the branch. Bug: 1059727, 1031542 Change-Id: Ic142da4f023b20c3ae25e98a179203c8d2bdfc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096453 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#749160}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/45c5398037c4..d0748eb038be git log 45c5398037c4..d0748eb038be --date=short --first-parent --format='%ad %ae %s' 2020-03-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 014968c3b6b3..2ff8b6a6f4d5 (4 commits) Created with: gclient setdep -r src/third_party/angle@d0748eb038be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: Ia8f328db44e12fa93303c182754ac26ade219a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098061Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749159}
-
Wez authored
Bug: 1055483 Change-Id: Ic4a205e0c801bbd1ccc4e4cbf80cfd7aff099f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087616 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#749158}
-
Kamila Hasanbega authored
This reverts commit 8a27ec89. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20Full/158215? Original change's description: > Safe Browsing: Add UMA to measure time since last database update > > This adds UMA to record whether the Safe Browsing local database has > received an update, and if so, how much time elapsed since the last update > was received. These metrics are recorded whenever the local database is > queried. > > While these metrics do not distinguish between a successful update and > an unsuccessful update, an existing metric (SafeBrowsing.V4Update.Result) > already records whether updates are successful or not. > > These metrics will allow us to compare database freshness on iOS to freshness > on desktop, to evaluate changes we can make to update the database more > frequently on iOS. > > Bug: 1055863 > Change-Id: I12d6b672e3d274b40fa71fc99d44419380d340a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087415 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Commit-Queue: Ali Juma <ajuma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749150} TBR=ajuma@chromium.org,isherman@chromium.org,kkhorimoto@chromium.org,vakh@chromium.org Change-Id: Idcb6347f6b5181b1530952671ffdd68feb2266c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1055863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096592Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#749157}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ddebab41. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" 2594f643 "Fix timeout in update-and-send-events-replacment.html" 6cf14026 "webrtc: add more BUNDLE assertions" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I225b33e00568a0bba20c74fede40a110255a1e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093541Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749156}
-
Richard He authored
In build/util/version.gni, `public_android_sdk` is used when `target_os == "android"`. But in build/config/android/config.gni, it's defined only when `is_android || is_chromeos`. This PR fixes `public_android_sdk` not defined error when `target_os == "android"` and host toolchain (linux) used. Change-Id: I41f75ac629ea5009a5e1e404918d256be0cbe77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096799Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Richard He <linyhe@microsoft.com> Cr-Commit-Position: refs/heads/master@{#749155}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ia698d29207f821b5cdb7fab5644c4bf11343ac61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093540Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749154}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/16ae92a4ee52..ca10816d6c22 git log 16ae92a4ee52..ca10816d6c22 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 bclayton@google.com Kokoro: Update clang-8 URL Created with: gclient setdep -r src/third_party/swiftshader@ca10816d6c22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I255133ebfa973d91f07be69b389f33c19ba54e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098057Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749153}
-
Clemens Arbesser authored
This allows ShowListPopup to optionally also write the names of the selected item(s), not just the indices. This is important for several reasons. First, it allows the generic_ui to directly use those names for other interactions, which currently is not possible because of the lack of an interaction which extracts values by index. Second, in many cases backend may not be interested in the selected indices at all. Matching indices back to items is tedious and unnecessary. Also moved the corresponding test from the CollectUserData action to the dedicated ShowGenericUi action. Bug: b/145043394 Change-Id: Iec9b3ff7ed00f2daba3fffbc125eba9b87741a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093439Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#749152}
-
Joshua Pawlicki authored
This reverts commit 9fcd7541. Reason for revert: breaks compile (bad merge) Original change's description: > Revert "Cros: Report metrics for the animation of traslucent background" > > This reverts commit 64465df5. > > Reason for revert: Speculative revert to fix use-of-uninitialized member flake / crash; see https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8886180914914709040/+/steps/browser_tests/0/logs/Deterministic_failure:_PublicSessionOobeTestImpl__x2f_PublicSessionOobeTest.NoTermsOfService__x2f_4__status_CRASH_/0 > > ==18002==WARNING: MemorySanitizer: use-of-uninitialized-value > #0 0x5640af44e1e6 in ui::AnimationMetricsRecorder::OnAnimationEnd(base::Optional<int>, float) ./../../ui/compositor/animation_metrics_recorder.cc:64:14 > #1 0x5640af4e4b37 in ui::LayerAnimationElement::ProgressToEnd(ui::LayerAnimationDelegate*) ./../../ui/compositor/layer_animation_element.cc:669:34 > #2 0x5640af4fbb95 in ui::LayerAnimationSequence::ProgressToEnd(ui::LayerAnimationDelegate*) ./../../ui/compositor/layer_animation_sequence.cc:147:35 > #3 0x5640af513c54 in ProgressAnimationToEnd ./../../ui/compositor/layer_animator.cc:476:13 > #4 0x5640af513c54 in ui::LayerAnimator::FinishAnimation(ui::LayerAnimationSequence*, bool) ./../../ui/compositor/layer_animator.cc:622:5 > #5 0x5640af519c6d in ui::LayerAnimator::StopAnimatingInternal(bool) ./../../ui/compositor/layer_animator.cc:533:5 > #6 0x5640af489c93 in StopAnimating ./../../ui/compositor/layer_animator.h:198:26 > #7 0x5640af489c93 in ui::Layer::CompleteAllAnimations() ./../../ui/compositor/layer.cc:1128:12 > #8 0x5640af3c6ff1 in aura::Window::~Window() ./../../ui/aura/window.cc:124:14 > #9 0x5640af3ca7ac in aura::Window::~Window() ./../../ui/aura/window.cc:119:19 > #10 0x5640a9a51655 in views::NativeWidgetAura::~NativeWidgetAura() ./../../ui/views/widget/native_widget_aura.cc:0:0 > #11 0x5640a9a51b9c in views::NativeWidgetAura::~NativeWidgetAura() ./../../ui/views/widget/native_widget_aura.cc:1054:39 > #12 0x5640a99ba714 in views::Widget::~Widget() ./../../ui/views/widget/widget.cc:185:5 > #13 0x5640b72c7e39 in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:354:1 > #14 0x5640b72c7f9c in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:350:33 > #15 0x5640b7319b53 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #16 0x5640b7319b53 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #17 0x5640b7319b53 in ash::Shelf::ShutdownShelfWidget() ./../../ash/shelf/shelf.cc:377:19 > #18 0x5640b724c95f in ash::RootWindowController::CloseChildWindows() ./../../ash/root_window_controller.cc:659:11 > #19 0x5640b741f9c5 in ash::Shell::CloseAllRootWindowChildWindows() ./../../ash/shell.cc:1269:19 > #20 0x5640b741532a in ash::Shell::~Shell() ./../../ash/shell.cc:720:3 > #21 0x5640b741fd3c in ash::Shell::~Shell() ./../../ash/shell.cc:589:17 > #22 0x5640b9be4d75 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #23 0x5640b9be4d75 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #24 0x5640b9be4d75 in ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() ./../../chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc:245:19 > #25 0x5640a5abe85d in ChromeBrowserMainParts::PostMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1721:29 > #26 0x564094a9d525 in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:1136:32 > #27 0x56409b175e3f in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() ./../../content/browser/browser_main_loop.cc:1095:13 > #28 0x56409b17ea9a in content::BrowserMainRunnerImpl::Shutdown() ./../../content/browser/browser_main_runner_impl.cc:178:17 > #29 0x56409b165bd4 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:49:16 > #30 0x5640a3b3284b in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10 > #31 0x5640a3b3284b in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10 > #32 0x5640a3b311b2 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12 > #33 0x5640b1028f28 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:455:29 > #34 0x56409f705fd0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 > #35 0x5640a762696a in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3 > #36 0x5640a53fb49d in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:299:20 > #37 0x5640960c6b50 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 > #38 0x5640960c6b50 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2663:3 > #39 0x5640960cb24d in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2845:11 > #40 0x5640960cd5f9 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2977:28 > #41 0x564096106f6e in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5518:44 > #42 0x5640961053fd in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 > #43 0x5640961053fd in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5105:10 > #44 0x5640a5902835 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2472:46 > #45 0x5640a5902835 in base::TestSuite::Run() ./../../base/test/test_suite.cc:458:16 > #46 0x5640a5393dd1 in BrowserTestSuiteRunnerChromeOS::RunTestSuite(int, char**) ./../../chrome/test/base/browser_tests_main_chromeos.cc:37:23 > #47 0x5640a773a27e in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:375:31 > #48 0x5640a5394f45 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:246:10 > #49 0x5640a5393bb8 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:52:10 > #50 0x7f194b36282f in __libc_start_main /build/glibc-LK5gWL/glibc-2.23/csu/../csu/libc-start.c:291:0 > #51 0x56408b4293c9 in _start ??:0:0 > > Uninitialized value was created by a heap deallocation > #0 0x56408b497790 in operator delete(void*) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cpp:74:44 > #1 0x5640b72c7d74 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #2 0x5640b72c7d74 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #3 0x5640b72c7d74 in ~unique_ptr ./../../buildtools/third_party/libc++/trunk/include/memory:2587:19 > #4 0x5640b72c7d74 in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:354:1 > #5 0x5640b72c7f9c in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:350:33 > #6 0x5640b7319b53 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #7 0x5640b7319b53 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #8 0x5640b7319b53 in ash::Shelf::ShutdownShelfWidget() ./../../ash/shelf/shelf.cc:377:19 > #9 0x5640b724c95f in ash::RootWindowController::CloseChildWindows() ./../../ash/root_window_controller.cc:659:11 > #10 0x5640b741f9c5 in ash::Shell::CloseAllRootWindowChildWindows() ./../../ash/shell.cc:1269:19 > #11 0x5640b741532a in ash::Shell::~Shell() ./../../ash/shell.cc:720:3 > #12 0x5640b741fd3c in ash::Shell::~Shell() ./../../ash/shell.cc:589:17 > #13 0x5640b9be4d75 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #14 0x5640b9be4d75 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #15 0x5640b9be4d75 in ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() ./../../chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc:245:19 > #16 0x5640a5abe85d in ChromeBrowserMainParts::PostMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1721:29 > #17 0x564094a9d525 in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:1136:32 > #18 0x56409b175e3f in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() ./../../content/browser/browser_main_loop.cc:1095:13 > #19 0x56409b17ea9a in content::BrowserMainRunnerImpl::Shutdown() ./../../content/browser/browser_main_runner_impl.cc:178:17 > #20 0x56409b165bd4 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:49:16 > #21 0x5640a3b3284b in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10 > #22 0x5640a3b3284b in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10 > #23 0x5640a3b311b2 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12 > #24 0x5640b1028f28 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:455:29 > #25 0x56409f705fd0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 > #26 0x5640a762696a in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3 > #27 0x5640a53fb49d in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:299:20 > > Original change's description: > > Cros: Report metrics for the animation of traslucent background > > > > This animation happens during transition between hotseat states. > > > > Bug: 1058609 > > Change-Id: Iff1f81625e6de2bf6dc6dcfee09225c4d16cc53e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088641 > > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > > Reviewed-by: Manu Cornet <manucornet@chromium.org> > > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > > Commit-Queue: Ana Salazar <anasalazar@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#748806} > > TBR=rkaplow@chromium.org,newcomer@chromium.org,manucornet@chromium.org,anasalazar@chromium.org > > Change-Id: I28dfaa49cae6e27801975a2863c013b9f9a5edca > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1058609 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097507 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749146} TBR=rkaplow@chromium.org,waffles@chromium.org,newcomer@chromium.org,manucornet@chromium.org,anasalazar@chromium.org Change-Id: I9eb448a6d4ea88624c9535a30cdfa519fc431d50 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1058609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097508Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#749151}
-
Ali Juma authored
This adds UMA to record whether the Safe Browsing local database has received an update, and if so, how much time elapsed since the last update was received. These metrics are recorded whenever the local database is queried. While these metrics do not distinguish between a successful update and an unsuccessful update, an existing metric (SafeBrowsing.V4Update.Result) already records whether updates are successful or not. These metrics will allow us to compare database freshness on iOS to freshness on desktop, to evaluate changes we can make to update the database more frequently on iOS. Bug: 1055863 Change-Id: I12d6b672e3d274b40fa71fc99d44419380d340a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087415Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#749150}
-
Danyao Wang authored
This CL plumbs RenderFrameHost into InstallablePaymentAppCrawler so it can be provided to ManifestIconDownloader to download the icon in the correct frame that initiated the PaymentRequest. The ManifestIconDownloader was previously changed to expect the global frame routing ID instead of RenderFrameHost* (crrev.com/c/2085752). This will be changed to use RenderFrameHost* directly in a subsequent CL per a post-commit comment. After this change, all payments code can also be cleaned up to look up WebContents* from the RenderFrameHost* instead of retaining both. This will also be cleaned up in a subsequent CL. Bug: 1055360 Change-Id: Ic431b04ff88d1ac0235172391c9697bbd0ec8fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097242Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#749149}
-
Luciano Pacheco authored
Add tests for fix on CL:2097775. Bug: 1059016, 1058547 Change-Id: Ib172082ede64943008b0778a6ba4031dec23bb04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097798 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#749148}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f4941654a1fe..55e502897c6e git log f4941654a1fe..55e502897c6e --date=short --first-parent --format='%ad %ae %s' 2020-03-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-11 jacktfranklin@chromium.org Allow TypeScript to import `ls` directly 2020-03-11 leese@chromium.org More tests for scripts shared between workers 2020-03-11 petermarshall@chromium.org [lighthouse] Add a tooltip for the 'Simulated Throttling' setting Created with: gclient setdep -r src/third_party/devtools-frontend/src@55e502897c6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1047091,chromium:670180 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9b96404fd096ac554a76499715e919c784981c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098060Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749147}
-
Joshua Pawlicki authored
This reverts commit 64465df5. Reason for revert: Speculative revert to fix use-of-uninitialized member flake / crash; see https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8886180914914709040/+/steps/browser_tests/0/logs/Deterministic_failure:_PublicSessionOobeTestImpl__x2f_PublicSessionOobeTest.NoTermsOfService__x2f_4__status_CRASH_/0 ==18002==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5640af44e1e6 in ui::AnimationMetricsRecorder::OnAnimationEnd(base::Optional<int>, float) ./../../ui/compositor/animation_metrics_recorder.cc:64:14 #1 0x5640af4e4b37 in ui::LayerAnimationElement::ProgressToEnd(ui::LayerAnimationDelegate*) ./../../ui/compositor/layer_animation_element.cc:669:34 #2 0x5640af4fbb95 in ui::LayerAnimationSequence::ProgressToEnd(ui::LayerAnimationDelegate*) ./../../ui/compositor/layer_animation_sequence.cc:147:35 #3 0x5640af513c54 in ProgressAnimationToEnd ./../../ui/compositor/layer_animator.cc:476:13 #4 0x5640af513c54 in ui::LayerAnimator::FinishAnimation(ui::LayerAnimationSequence*, bool) ./../../ui/compositor/layer_animator.cc:622:5 #5 0x5640af519c6d in ui::LayerAnimator::StopAnimatingInternal(bool) ./../../ui/compositor/layer_animator.cc:533:5 #6 0x5640af489c93 in StopAnimating ./../../ui/compositor/layer_animator.h:198:26 #7 0x5640af489c93 in ui::Layer::CompleteAllAnimations() ./../../ui/compositor/layer.cc:1128:12 #8 0x5640af3c6ff1 in aura::Window::~Window() ./../../ui/aura/window.cc:124:14 #9 0x5640af3ca7ac in aura::Window::~Window() ./../../ui/aura/window.cc:119:19 #10 0x5640a9a51655 in views::NativeWidgetAura::~NativeWidgetAura() ./../../ui/views/widget/native_widget_aura.cc:0:0 #11 0x5640a9a51b9c in views::NativeWidgetAura::~NativeWidgetAura() ./../../ui/views/widget/native_widget_aura.cc:1054:39 #12 0x5640a99ba714 in views::Widget::~Widget() ./../../ui/views/widget/widget.cc:185:5 #13 0x5640b72c7e39 in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:354:1 #14 0x5640b72c7f9c in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:350:33 #15 0x5640b7319b53 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 #16 0x5640b7319b53 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 #17 0x5640b7319b53 in ash::Shelf::ShutdownShelfWidget() ./../../ash/shelf/shelf.cc:377:19 #18 0x5640b724c95f in ash::RootWindowController::CloseChildWindows() ./../../ash/root_window_controller.cc:659:11 #19 0x5640b741f9c5 in ash::Shell::CloseAllRootWindowChildWindows() ./../../ash/shell.cc:1269:19 #20 0x5640b741532a in ash::Shell::~Shell() ./../../ash/shell.cc:720:3 #21 0x5640b741fd3c in ash::Shell::~Shell() ./../../ash/shell.cc:589:17 #22 0x5640b9be4d75 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 #23 0x5640b9be4d75 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 #24 0x5640b9be4d75 in ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() ./../../chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc:245:19 #25 0x5640a5abe85d in ChromeBrowserMainParts::PostMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1721:29 #26 0x564094a9d525 in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:1136:32 #27 0x56409b175e3f in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() ./../../content/browser/browser_main_loop.cc:1095:13 #28 0x56409b17ea9a in content::BrowserMainRunnerImpl::Shutdown() ./../../content/browser/browser_main_runner_impl.cc:178:17 #29 0x56409b165bd4 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:49:16 #30 0x5640a3b3284b in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10 #31 0x5640a3b3284b in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10 #32 0x5640a3b311b2 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12 #33 0x5640b1028f28 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:455:29 #34 0x56409f705fd0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 #35 0x5640a762696a in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3 #36 0x5640a53fb49d in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:299:20 #37 0x5640960c6b50 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #38 0x5640960c6b50 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2663:3 #39 0x5640960cb24d in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2845:11 #40 0x5640960cd5f9 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2977:28 #41 0x564096106f6e in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5518:44 #42 0x5640961053fd in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 #43 0x5640961053fd in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5105:10 #44 0x5640a5902835 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2472:46 #45 0x5640a5902835 in base::TestSuite::Run() ./../../base/test/test_suite.cc:458:16 #46 0x5640a5393dd1 in BrowserTestSuiteRunnerChromeOS::RunTestSuite(int, char**) ./../../chrome/test/base/browser_tests_main_chromeos.cc:37:23 #47 0x5640a773a27e in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:375:31 #48 0x5640a5394f45 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:246:10 #49 0x5640a5393bb8 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:52:10 #50 0x7f194b36282f in __libc_start_main /build/glibc-LK5gWL/glibc-2.23/csu/../csu/libc-start.c:291:0 #51 0x56408b4293c9 in _start ??:0:0 Uninitialized value was created by a heap deallocation #0 0x56408b497790 in operator delete(void*) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cpp:74:44 #1 0x5640b72c7d74 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 #2 0x5640b72c7d74 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 #3 0x5640b72c7d74 in ~unique_ptr ./../../buildtools/third_party/libc++/trunk/include/memory:2587:19 #4 0x5640b72c7d74 in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:354:1 #5 0x5640b72c7f9c in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:350:33 #6 0x5640b7319b53 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 #7 0x5640b7319b53 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 #8 0x5640b7319b53 in ash::Shelf::ShutdownShelfWidget() ./../../ash/shelf/shelf.cc:377:19 #9 0x5640b724c95f in ash::RootWindowController::CloseChildWindows() ./../../ash/root_window_controller.cc:659:11 #10 0x5640b741f9c5 in ash::Shell::CloseAllRootWindowChildWindows() ./../../ash/shell.cc:1269:19 #11 0x5640b741532a in ash::Shell::~Shell() ./../../ash/shell.cc:720:3 #12 0x5640b741fd3c in ash::Shell::~Shell() ./../../ash/shell.cc:589:17 #13 0x5640b9be4d75 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 #14 0x5640b9be4d75 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 #15 0x5640b9be4d75 in ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() ./../../chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc:245:19 #16 0x5640a5abe85d in ChromeBrowserMainParts::PostMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1721:29 #17 0x564094a9d525 in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:1136:32 #18 0x56409b175e3f in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() ./../../content/browser/browser_main_loop.cc:1095:13 #19 0x56409b17ea9a in content::BrowserMainRunnerImpl::Shutdown() ./../../content/browser/browser_main_runner_impl.cc:178:17 #20 0x56409b165bd4 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:49:16 #21 0x5640a3b3284b in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10 #22 0x5640a3b3284b in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10 #23 0x5640a3b311b2 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12 #24 0x5640b1028f28 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:455:29 #25 0x56409f705fd0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 #26 0x5640a762696a in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3 #27 0x5640a53fb49d in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:299:20 Original change's description: > Cros: Report metrics for the animation of traslucent background > > This animation happens during transition between hotseat states. > > Bug: 1058609 > Change-Id: Iff1f81625e6de2bf6dc6dcfee09225c4d16cc53e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088641 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: Ana Salazar <anasalazar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748806} TBR=rkaplow@chromium.org,newcomer@chromium.org,manucornet@chromium.org,anasalazar@chromium.org Change-Id: I28dfaa49cae6e27801975a2863c013b9f9a5edca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1058609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097507Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#749146}
-
Kamila Hasanbega authored
This reverts commit 30e93e6f. Reason for revert: Suspect revert https://ci.chromium.org/p/chromium/builders/ci/GPU%20Mac%20Builder/184286? Original change's description: > Move the canMakePayment toggle to the Payments settings subpage > > When the privacy settings redesign is enabled, this setting will be > removed from the privacy card. However, it needs to be resurfaced > somewhere else. > > See https://docs.google.com/presentation/d/1Y1hSAUri9SuKtByE1xNv0-1TxbgbUFHPhwWS77fcEEE/ > for more background. > > Bug: 1032584 > Change-Id: Ia2a5b45625ba42223a1ccecd8f2b790d289bc95d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090424 > Commit-Queue: Martin Šrámek <msramek@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749142} TBR=dpapad@chromium.org,msramek@chromium.org,sauski@google.com Change-Id: I999ed803eb652e4aaa15aff51c09e7d2ad1f4567 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1032584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096591Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#749145}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ccdbaf215f0c..029aa0d6eb2c git log ccdbaf215f0c..029aa0d6eb2c --date=short --first-parent --format='%ad %ae %s' 2020-03-11 treehugger-gerrit@google.com Merge changes I0cbe7c90,I6e4a3344 Created with: gclient setdep -r src/third_party/perfetto@029aa0d6eb2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2ee9031c1b5448c2bab8b9907c05c41a7b235f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098058Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749144}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/59f3b71c04de..78964c1e0afa git log 59f3b71c04de..78964c1e0afa --date=short --first-parent --format='%ad %ae %s' 2020-03-11 marinaciocea@webrtc.org Transform encoded frames in RtpVideoStreamReceiver. 2020-03-11 hbos@webrtc.org [Adaptation] Rename and move resource adaptation module/processor stuff. 2020-03-11 mbonadei@webrtc.org Fix 'all' build on Android platforms. 2020-03-11 mbonadei@webrtc.org Fix 'all' build on non Android platforms. Created with: gclient setdep -r src/third_party/webrtc@78964c1e0afa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If9190e16470196673372be9edf9d5f8ec30b73f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098056Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749143}
-
Martin Šrámek authored
When the privacy settings redesign is enabled, this setting will be removed from the privacy card. However, it needs to be resurfaced somewhere else. See https://docs.google.com/presentation/d/1Y1hSAUri9SuKtByE1xNv0-1TxbgbUFHPhwWS77fcEEE/ for more background. Bug: 1032584 Change-Id: Ia2a5b45625ba42223a1ccecd8f2b790d289bc95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090424 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#749142}
-
Henrique Ferreiro authored
Internals::getCurrentCursorInfo() was logging hotspot and image attributes unconditionally. Those should only be available for custom cursors. Bug: 1040499 Change-Id: I9c59b425e922cfa15deb891ea70cb13c3eacd522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095095 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#749141}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1f3ddf528e98289f50aba61df62586875d831ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098055Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749140}
-
Jan Wilken Dörrie authored
This change implements guarding the automatic checking of an edited password on the leak detection and safe browsing prefs. Bug: 1049205 Change-Id: I0874933615a67ee837f3b5d8b8284cfec214eb79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096757 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749139}
-
Viktor Semeniuk authored
This change fixes problem with layout when username/url is too long to display fully. The end is truncated. Bug: 1059334 Change-Id: I0b6d42d500c51835330b04daf75a921070022410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095724Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#749138}
-
danakj authored
Currently the visible_viewport_size is passed to each RenderView separately from other properties which are passed down through the RenderWidget/local root hierarchy. This moves the property into the standard waterfall flow. Prior logic to determine the value was spread out between various implementations of RenderWidgetHostViews, with RenderWidgetHostViewChildFrame doing some tricky (and incomplete for portals) checking to see if it is the main frame of a nested frame tree/WebContents. Now RenderWidgetHostImpl contains the logic to decide which visible_viewport_size to use, using the RenderWidgetHostView for main frames (nested and top level). For child widgets it always uses the value received from the parent. This change may cause child widgets to receive the value a bit slower than before as it has to bounce through the RenderWidget hierarchy to get to them, but it will allow them to all be synchronized for display to the user. It will also cause child frames inside a nested WebContents to get the value of their parent instead of their own RenderWidgetHostView, which is more correct. Based on a previous CL that was reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1863512 R=avi@chromium.org, dcheng@chromium.org, wjmaclean@chromium.org Change-Id: Ia5b99f48266ad758592f088e13a23002d90ba05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083916Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#749137}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0340292972b9..21beacccb930 git log 0340292972b9..21beacccb930 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 egdaniel@google.com Revert "Experiment with no longer avoiding uploading same uniforms in vulkan." Created with: gclient setdep -r src/third_party/skia@21beacccb930 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: Id0793f6241a33ac80de9db6423323163f5e6ea66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097934Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749136}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1422f8e60e7b..3ea855dea97e Created with: gclient setdep -r src-internal@3ea855dea97e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1046374 Tbr: jbudorick@google.com Change-Id: I88dda459750f1fb11f17efadac8152c81bb02e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097933Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749135}
-
Wei Lee authored
When taking photo, there are two stages: 1. Click shutter button -> Shutter is done 2. Shutter is done -> Captured image is returned and save We already have 'photo-taking' event to measure (1) + (2) and 'photo-capture-post-processing' for (2). It will be helpful to have a 'photo-capture-shutter' for (1) as well. In addition, to measure performance for front camera and back camera respectively, we can add events with facing information in their names. Therefore, the ones without facing information are the average metrics and the ones with facing information are results for specific facing. Bug: b/149454553 Test: tast run [DUT] camera.CCAUIPerf Change-Id: I5889ddde4df7c1b3ca4a71ba1c1c0f1628af2fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087501Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#749134}
-
Johannes Kron authored
Set capture time to the NTP timestamp of the video frame for remote video sources. Compensate for NTP offset. Bug: 1011581 Change-Id: I75916d53503141bab7fd88cebe52c4aee83652fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095007Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#749133}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e4aabc8bab65..7004f998c7ba git log e4aabc8bab65..7004f998c7ba --date=short --first-parent --format='%ad %ae %s' 2020-03-11 phoglund@google.com Fix parsing of summary options. Created with: gclient setdep -r src/third_party/catapult@7004f998c7ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: eseckler@google.com Change-Id: I3fc0238f99f183e767e08efe6ee2abb2b6fffcf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097931Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749132}
-
Kamila Hasanbega authored
This reverts commit a9816cf6. Reason for revert: [Sheriff] suspecting this cl might cause https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/2376 to fail. Original change's description: > Merge blink-specific video_capture_types typemap into the original > > This is inspired on [1], by kinuko@. > > [1] https://crrev.com/c/2016524 > > BUG=704136 > R=dcheng@chromium.org, guidou@chromium.org > > Change-Id: Ib51d558858d831aa1d3ba96345d3986b5afc0c54 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096387 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Cr-Commit-Position: refs/heads/master@{#749108} TBR=dalecurtis@chromium.org,haraken@chromium.org,tsepez@chromium.org,guidou@chromium.org,tonikitoo@igalia.com Change-Id: I565415e378bd5cecd53b24335a39a3b1bc393bd0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 704136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095111Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#749131}
-
Colin Blundell authored
This CL eliminates the last //chrome dependence of ExternalNavigationHandler.java, on ChromeFeatureList.java. To do so it componentizes the one feature that ExternalNavigationHandler uses into //components/external_intents via a minimal ExternalIntentsFeatureList.java. Bug: 1031465 Change-Id: If3c81a1d03516a4d71a98126c939255f74296616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096559 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#749130}
-
Yutaka Hirano authored
Implements https://github.com/mikewest/corpp/pull/10 Bug: 1052764 Change-Id: I76464069d3a0a4ea1463a2e626f5e0b355f175ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091326 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#749129}
-
arthursonzogni authored
For every CacheStorage request, bind it with the correct COEP value. A difficulty: the browser process do not always have the correct value at startup for new ServiceWorker. It would requires PlzServiceWorker to be implemented first. Instead, this keeps track of the CacheStorage requests and bind them later when the COEP value will be known. Bug: 1058787, 1031542 Change-Id: I7abcadf67d9627c82c295d5a05430ee9c6bca109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095060 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#749128}
-