- 30 Jul, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/994ce8cf2300..398c654ce7be 2020-07-29 johnstiles@google.com Enable ClangTidy 'undelegated constructor' warning. 2020-07-29 johnstiles@google.com Fix DebugCanvas(SkIRect) constructor. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I7476be79e8efe85a95c6d781238e1e8b3f3a3669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327748Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793003}
-
Toshiki Kikuchi authored
This CL allows AutoSnapController to check if DragWindowFromShelfController is restoring windows after dragging. AutoSnapController uses kAnimationsDisabledKey to skip auto snapping after transient hide & show operations by DragWindowFromShelfController. But kAnimationsDisabledKey may be used in other locations so we should not rely on it. This CL also cleans up auto snapping trigger conditions. BUG=chromium:1107306 TEST=DragWindowFromShelfControllerTest.HideWindowDuringWindowDragging* TEST=SplitViewControllerTest.AutoSnapFromMinimizedState Change-Id: Ibc4f72558db3cf0efa070a77e44d3247b79d9ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303337 Commit-Queue: Toshiki Kikuchi <toshikikikuchi@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#793002}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596045560-aec562928bab06d0692bf930829a43aa15a04f06.profdata to chrome-mac-master-1596066946-9bc35ac8d47ba630ab3266f0e7f4e21ad19fc745.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: Idf892429f8ac623b41e06c796670855378a06229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328133Reviewed-by:
-
Alexander Surkov authored
Bug: 1100991 AX-Relnotes: n/a Change-Id: I89ecbf3b950c9d70bf9a579bfe4b9b02da6b83dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323503 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#793000}
-
Toni Baržić authored
This reverts commit e3564580. Reason for revert: The issue that was causing crashes during the test seems to be resolved. Original change's description: > Sheriff: Disable GestureNavigationScreenTest.FlowTest on MSAN > > Bug: 1109714 > Change-Id: If2ed226e624c78a97c8a7fe5434520464295eba9 > No-Try: True > Tbr: achuith@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320129 > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791900} TBR=achuith@chromium.org,adithyas@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1109714 Change-Id: I652c676041a8f25635dec7b9b7cf0995f6ffbd55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327318Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#792999}
-
Andrew Moylan authored
This adds a short note to show how methods should be 'deleted' while still keeping interface ordinals in the range [0, N-1]: Interfaces should use placeholder method names. Change-Id: I8bfb2ba589c194d0b7603727c392b2b32a9ce6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242691 Auto-Submit: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#792998}
-
Adam Ettenberger authored
This is a reland of ffc377fd Revert CL : https://chromium-review.googlesource.com/c/chromium/src/+/2321113 Reason for revert : expected-uia-win7.txt files were incorrect for - All/DumpAccessibilityEventsTest.AccessibilityEventsAriaComboBoxNext/uia - All/DumpAccessibilityEventsTest.AccessibilityEventsListboxNext/uia See: https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/69290 Updated win7 baseline files : - content/test/data/accessibility/event/aria-combo-box-next-expected-uia-win7.txt - content/test/data/accessibility/event/listbox-next-expected-uia-win7.txt - content/test/data/accessibility/event/menulist-collapse-next-expected-uia-win7.txt Original change's description: > Fire UIA SelectionItem events on aria-checked changes for radio buttons > > According to the following spec radio and menuitemradio should expose > UIA SelectedItem.IsSelected when aria-checked is set : > https://www.w3.org/TR/core-aam-1.1/#mapping_state-property_table > > This CL ensures that radio / menuitemradio fire appropriate > SelectionItem events, and whenever a SelectionItem changes its > selection state that we also fire a Property Changed event for > SelectionItem.IsSelected. > > AX-Relnotes: Fire missing events for ARIA radio/menuitemradio when aria-checked changes. Narrator will now announce selected state changes for this scenario. > Bug: 1102580 > Change-Id: I72f479e25f61b0ddffc28f73d4a9c34e8dc4ecb8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212982 > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#791802} Bug: 1102580 Change-Id: Icb6e2f6fb10a1b752a03f470fc158ac3da56fb3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321053Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#792997}
-
James Vecore authored
Nearby watchlist had a trailing '|' which was causing problems. Change-Id: I497bcd8af9f51144638f54642722bd4ba1425f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328016 Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#792996}
-
Bo Liu authored
If nothing ever called GetJavaObject, then don't bother creating the java object from the destructor. In practice though this should never happen, but just to be safe. Change-Id: I396569e5a7df380a6cbf49417972442710ea4e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327188Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#792995}
-
Joel Hockey authored
Windows files gets a few system files/folders created, and we want them to be hidden by default. Bug: b/161766694 Change-Id: I4694cca3abe081da0f2b4d0fa941ace0d4448c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321986Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#792994}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/21b6343f..d640d034 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibcaa4b9bf75bb6b3b2afec562a13f80113a76bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327572Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792993}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. The files LacrosManager, LacrosLoader, etc. were confusing developers since the word "lacros" is only supposed to be used by the lacros-chrome browser. This CL renames the files to avoid this confusion. In order to avoid confusion in ash-chrome, the classes have been moved to the namespace crosapi. Change-Id: I148c3fe107ce3eaadeab13a569c6921746ffd71e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325087 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#792992}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I08d2ef403596089f4ce890ea4c6fe638246d71ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325100Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792991}
-
Avi Drissman authored
Bug: 1105907 Change-Id: Ib35f5ba08945da527a2a9374b9f11bc221bf393e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325099Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792990}
-
Anand K Mistry authored
This closes a TODO to remove the few remaining usages of DBusMethodCallStatus and migrate to using base::Optional<> to indicate success/failure. Bug: 1109627 Change-Id: Ie0f0937a01e5914e54dd985fbbb7c53e4086c0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281770 Commit-Queue: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#792989}
-
Kalvin Lee authored
This change * completes the implementation of ResolvePrinters(), * updates the corresponding unit tests to pass, * fixes a bug in PpdMetadataManager::GetPrinters(), and * fixes a bug in PpdMetadataManager::OnLocalesFetched(). Bug: chromium:888189 Test: chromeos_unittests --gtest_filter='PpdProviderTest.ResolvePrinters*' Change-Id: I5d30a3d1bcb4db91b62551ef940813d0fde178be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315390 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#792988}
-
Daniel Classon authored
Add deep links for bluetooth settings: turn bluetooth on/off, pair device, unpair device, connect device, disconnect device. Ensured that focusing works correctly when paired/unpaired list loading async and handled a conflict with Focus Row Behavior. Bug: 1084154 Change-Id: Ib91a80ceacc7a424d657560668bbd7ff6f380b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305194Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Daniel Classon <dclasson@google.com> Cr-Commit-Position: refs/heads/master@{#792987}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e4a7f92a. With Chromium commits locally applied on WPT: 3bd086b0 "Make CSP default-src without 'unsafe-eval' block eval in iframes" 6d63b58a "Split iceGatheringState tests into separate files & update expectations" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I6ce4f87074530058f0b2220ee26c051b768358ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327616Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792986}
-
Mei Liang authored
This OverviewModeController wrapper is originally introduced in crrev.com/c/1484734 for the purpose of showing GTS correctly, then gradually, this wrapper becomes primarily for attaching observers as early as possible and avoiding null checks. This CL removes the wrapper and allows other components to use the new API, getOverviewModeBehaviorSupplier(), to attach the observers. The getOverviewModeBehavior() method now only uses in tests. Change-Id: Ie3fdfad94b443e7ba054d75e89c15af692df4604 Bug: 1108496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314557Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#792985}
-
Sophie Chang authored
Bug: 1110487 Change-Id: I43e28b7291211b5bfe73461b14ef2b9ebb7aa62b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327843 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#792984}
-
Juliet Levesque authored
Construct the high-level contact, certificate, and local device data manager instances in the Nearby Share service. Their lifetimes mirror that of the service. Add public accessor functions to these managers in the service. Bug: 1093634 Change-Id: I2d0ce3189d05a0f59c42ecce432802b594b363ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316855 Commit-Queue: Juliet Levesque <julietlevesque@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#792983}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3e5d86a2375a..343f63643b43 2020-07-29 robertocn@google.com [resultdb] Bump up the cipd pin of rdb in depot_tools 2020-07-29 vapier@chromium.org cros: raise python version requirement to 3.6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110107,chromium:997354 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Test: Test: `cros_sdk` still works Change-Id: If2b9d209603ed4363839b2287a4fa0ef04c31e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327740Reviewed-by:
-
Minoru Chikamune authored
For now, there is no proper role for BlinkIsolate. So this CL deletes the BlinkIsolate class. Bug: 1105403 Change-Id: Ifc562ae891f7233ae0e9513c7ee3a30fff293493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320289 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#792981}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d019af80a3a9..cc846039201d 2020-07-29 cnorthrop@google.com Capture/Replay: Fix GetTexImage on Luminance If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Test: Test: angle_end2end_test --gtest_filter="*GetTexImage*" Change-Id: I14713e7bbc30a0b25cc89255534a7ba5bdb9bdbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327656Reviewed-by:
-
Justin Cohen authored
This reverts commit ee4eb865. Reason for revert: Breaks ios-simulator-full-configs/25351 Original change's description: > [iOS] Add fieldtrial config for IOSRequestDesktopByDefault > > Bug: None > Change-Id: Iea882e82e5573edaf917d8f3d976d876e2120de9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317789 > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792621} TBR=mpearson@chromium.org,gambard@chromium.org Change-Id: I1819597f0a0a2477aebd70066c5edf732527b4e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328031Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#792979}
-
Devlin Cronin authored
Update chrome/browser/extensions/process_manager_browsertest.cc to use WebContentsConsoleObserver instead of ConsoleObserverDelegate. This allows us to observe console messages added without overriding the existing delegate of the WebContents. Bug: 1034150 Change-Id: I887ead0ef81b5ea8b76dbf0696c48882a2fb48cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327146Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792978}
-
Chris Lu authored
These metrics will log user actions in the fullscreen promo modal and taps on the NTP promo link. Bug: 1107489 Change-Id: I310e5b57d4624c26a62613f97dd2c5ccca35b186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321840 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#792977}
-
David Black authored
ClipboardData can be potentially large. Example: user opens a large document and does Ctrl+A then Ctrl+C. This being the case, we should try to minimize the number of extraneous copies we retain in memory to track Clipboard history unless we have a strong need. This CL switches the backing container of ClipboardHistory to a double linked list. Sort order by recency is enforced at insertion time. Also done in this CL: - Just minor nit of removing "clipboard history" from ClipboardHistory members to avoid redundancy. Bug: 1109292 Change-Id: Ib859a0df78b1f68b4de3ae4d31817d3219de408f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317714 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#792976}
-
Zhuoyu Qian authored
In the function WebFrameWidgetImpl::HandleInputEvent, it looks like not need to check LocalRootImpl(), this patch removes it. Change-Id: I13ff011721e748875635b8894a57501a71efeb84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318893Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#792975}
-
Brandon Wylie authored
Bug: 1110965 Change-Id: I22163cec177e51309e3730f5158df63b4240cf8b TBR=ioanap@chromium.org Change-Id: I22163cec177e51309e3730f5158df63b4240cf8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327861Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#792974}
-
Marijn Kruisselbrink authored
Instead of claiming success and writing 0 bytes. Bug: 1045918 Change-Id: I729ecff8753d0486f101fdf0e801509363636a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316440 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792973}
-
Chris Lu authored
This change saves the last time an HTTP(S) link was opened. It will be used to identify default browser usage. Bug: 1107489 Change-Id: I27fed2285dd42a44bbdcfa6c4043a12b4bc30e5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320079 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
-
Brian Ho authored
Currently, SkiaRenderer does not support RGBA_TEXTURE CopyOutputRequests which are used in Chrome OS for screen rotation animations [1] (among other things). As part of a larger effort to enable SkiaRenderer on Chrome OS, this CL implements RGBA_TEXTURE support in SkiaOutputSurfaceImplOnGpu::CopyOutput: 1. Refactor SharedImageFactory ownership out of DirectContextProviderDelegateImpl (used only for the use_gl_renderer_copier bypass) and directly into SkiaOutputSurfaceImplOnGpu. 2. Create a SharedImage and its Skia representation in CopyOutput and blit the request rect from the source into the output SkSurface. 3. Send the SharedImage's mailbox back through the CopyOutputResult with a release callback that destroys the SharedImage. 4. Enable SKIA_GL tests in cc_unittests. [1] https://source.chromium.org/chromium/chromium/src/+/master:ash/rotator/screen_rotation_animator.cc;l=214;drc=b15cb5fd43aff2d181355401d99e47e2e44aa61f?originalUrl=https:%2F%2Fcs.chromium.org%2F Bug: 1046788, 971257, 1098435 Change-Id: I62d41390828ed0c79a1dc29c508efc748924ce06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302733Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#792971}
-
Yoichi Osato authored
Bug: 1007815 Change-Id: I1f05b1d64a821a64815c95e778b04e3ff08ca023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325334Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#792970}
-
Glen Robertson authored
This allows us to be more confident we are covering a wide set of possible Web Apps rather than having correlations in fields due to repeated reuse of the low-entropy suffix bits. It also makes reading/writing the test more clear (expresses more intent and less implementation). Change-Id: I7f7d522ebac4b25972470b524892e9a6e2ae5450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325530 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#792969}
-
Tomasz Wiszkowski authored
This change includes the report of number of zero-prefix search suggestions shown to the user via assisted query stats. Bug: 1110414, b/159807386 Change-Id: I1258961a9328b8082feb77b5da9e839b6c8c1953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324114 Commit-Queue: Ender
💬 =🕐 (ping me for faster reviews) <ender@google.com> Reviewed-by:Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#792968}
-
nancylingwang authored
Sometimes, when the unit tests finish, the icon files are deleted, however, ArcAppIcon::ReadFile is still called, so DCHECK(base::PathExists(path)) could cause the crash. Modify ArcAppIcon to check the file path and whether the file exists again when read the file to avoid crash. BUG=1106782 Change-Id: Ida3544228f9f722646622e022ac44c5186295cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326791Reviewed-by:
Long Cheng <lgcheng@google.com> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#792967}
-
Maxime Charland authored
The manual calculation of label width in layoutSubviews seems to cause problems for AutoLayout and on some iPhone models, AutoLayout has to break some constraints that make the main button smaller than its content. Removing the whole layoutSubviews method helps resolve the layout problems. Note: Currently, the BookmarkHomeMediator uses the BookmarkHomePromoItem. It would be good to reduce code duplication by using TableViewSigninPromoItem instead of BookmarkHomePromoItem. However, that would require some refactoring in BookmarkHomeMediator. Screenshot before the fix (iPhone 11 on the left, iPhone SE 2nd Gen on the right): https://drive.google.com/file/d/1QDTQUpcD_7YcMB6wD1CrLFCqCHun8PQZ/view?usp=sharing Screenshot after the fix: https://drive.google.com/file/d/15iF45ZjSaMNHI4ANaTtU4TGWfYMDML3q/view?usp=sharing Screenshot after the fix, with very long strings, both in the label and in the button, to demonstrate that it behaves like other Sign in promos: https://drive.google.com/file/d/14ckOxh5VwF-un2bKaYNwrI0fstX80aaM/view?usp=sharing Bug: 1102043 Change-Id: Iea8ccf8a0fdc3eaeaa1f6d4176f287244168d8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313959Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Maxime Charland <mcharland@google.com> Cr-Commit-Position: refs/heads/master@{#792966}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a40e7b77fbb1..994ce8cf2300 2020-07-29 johnstiles@google.com Add a dev tools section about debug visualizers. 2020-07-29 bungeman@google.com Create a gn link pool which is disabled by default. 2020-07-29 adlai@google.com Migrate MakeFromAdoptedTexture to GrDirectContext 2020-07-29 johnstiles@google.com Remove constexpr workarounds for no-longer-supported compilers. 2020-07-29 jvanverth@google.com Change GrRingBuffer::finishSubmit to be a finishedProc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I2a7fc6577ae9cd7bb3993fb9a6ca056932a9d1b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327737Reviewed-by:
-
Erik Chen authored
Lacros will not launch from the stateful_partition if it is marked as noexec. This is often confusing to developers. Add custom UI error handling for developer builds. Bug: 1107709 Change-Id: Ie766af95fc6119f1b84bfd952a72b97331715a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321778Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#792964}
-
