1. 15 Jan, 2007 15 commits
    • ap's avatar
      Reviewed by Darin. · 85fa531d
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=6272
              XMLHttpRequest freezes on getting a missing document with overridden Content-Length
      
              http://bugs.webkit.org/show_bug.cgi?id=6212
              Investigate disallowing some XMLHttpRequest headers from being set via setRequestHeader.
      
              Tests:
              - http/tests/xmlhttprequest/connection-error-sync.html
              - http/tests/xmlhttprequest/set-dangerous-headers.html
      
              * bindings/js/kjs_binding.cpp:
              (KJS::):
              (KJS::setDOMException): Added support for NETWORK_ERR. Changed the temporary 
              PERMISSION_DENIED error into a special case.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::loadResourceSynchronously):
              * loader/FrameLoader.h:
              Return the error object to the caller. Removed an extra local variable for error, 
              which shadowed the one from enclosing block.
      
              * dom/XMLTokenizer.cpp:
              (WebCore::openFunc): 
              * xml/XSLTProcessor.cpp:
              (WebCore::docLoaderFunc): 
              Updated to pass an error object (currently ignored).
      
              * xml/xmlhttprequest.cpp:
              (WebCore::canSetRequestHeader): Added. The headers to block include the ones from 
              the current XMLHttpRequest draft plus "Via", which is blocked by Firefox.
              (WebCore::XMLHttpRequest::send): Raise an exception if a sync request results in 
              an error.
              (WebCore::XMLHttpRequest::setRequestHeader): Call canSetRequestHeader().
              * xml/xmlhttprequest.h:
              (WebCore::): Added NETWORK_ERR and a comment about PERMISSION_DENIED.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18863 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      85fa531d
    • zack's avatar
      Optimizing rendering on the Qt platform. Mainly switch to QPixmap · 12f665e2
      zack authored
      from client-side QImage. Also clean up nasty hacks in ScrollViewCanvasQt
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18862 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      12f665e2
    • lars's avatar
      Reviewed by Zack · 2dc9a998
      lars authored
              Fix weird crashes when running the layout tests. The
              reason was that I used KURL (and thus DeprecatedString)
              in a thread. Unfortunately that class is not threadsafe
              at all.
      
      	DumpRenderTree: Fix a few smaller issues in there, and update
      	our list of skipped tests.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18861 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2dc9a998
    • eseidel's avatar
      2007-01-15 Eric Seidel <eric@webkit.org> · 119e3dab
      eseidel authored
              Reviewed by rwlbuis.
      
              Make isValid check not malloc 3 SVGStringLists for every element.
              
              No test possible, performance fix only.
      
              * ksvg2/svg/SVGTests.cpp:
              (WebCore::SVGTests::isValid):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18860 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      119e3dab
    • rwlbuis's avatar
      Reviewed by Eric. · c431efb8
      rwlbuis authored
              Remove unused member var.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18859 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c431efb8
    • rwlbuis's avatar
      Reviewed by Eric. · d1fbd1ec
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=12069
              Hit detection fails under some viewbox constraints
      
              Do not take viewBox into account when hit testing svg container.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18858 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d1fbd1ec
    • hyatt's avatar
      Fix for 12275, negative margins confuse page breaks. · fee6a321
      hyatt authored
              Reviewed by Eric
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintChildren):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18857 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      fee6a321
    • eseidel's avatar
      2007-01-15 Eric Seidel <eric@eseidel.com> · 05e5e44b
      eseidel authored
              Reviewed by mjs.
              
              SVG gradients do not notice stop additions
              http://bugs.webkit.org/show_bug.cgi?id=12192
      
              Test: svg/custom/gradient-add-stops.svg
      
              * ksvg2/svg/SVGGradientElement.cpp:
              (WebCore::SVGGradientElement::childrenChanged):
              * ksvg2/svg/SVGGradientElement.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18856 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      05e5e44b
    • hyatt's avatar
      Fix for bug 10356, positioning doesn't work with <svg> elements in... · 01fd06eb
      hyatt authored
              Fix for bug 10356, positioning doesn't work with <svg> elements in XHTML.  Change the requiresLayer
              check to use the DOM, since the old check would fail if the parent block had no element.
      
              Reviewed by Eric
      
              Added svg/custom/relative-positioning.html (absolute/fixed too)
      
              * rendering/RenderSVGContainer.cpp:
              (WebCore::RenderSVGContainer::requiresLayer):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18855 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      01fd06eb
    • eseidel's avatar
      2007-01-14 Eric Seidel <eric@webkit.org> · c3e4e274
      eseidel authored
              Reviewed by hyatt.
              
              SVG does not correctly handle float: left
              http://bugs.webkit.org/show_bug.cgi?id=12210
      
              Test: svg/custom/svg-float-border-padding.xml
      
              * rendering/RenderSVGContainer.cpp:
              (WebCore::RenderSVGContainer::paint):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18854 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c3e4e274
    • hyatt's avatar
      Add layout test for select line breaking. · c9ef3d47
      hyatt authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18852 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c9ef3d47
    • hyatt's avatar
      More work to fix 10145, regression where form elements don't break... · b5524763
      hyatt authored
              More work to fix 10145, regression where form elements don't break properly.  Make sure to really use
              the parent of the replaced element's whitespace value everywhere.
      
              Reviewed by olliej
      
              fast/replaced/three-selects-break.html
      
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::findNextLineBreak):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18851 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b5524763
    • weinig's avatar
      Reviewed by Darin and then by Mitz. · 9159df97
      weinig authored
              Patch for http://bugs.webkit.org/show_bug.cgi?id=12228
              Cleanup assorted CSS classes
      
              * css/CSSBorderImageValue.cpp:
              (WebCore::CSSBorderImageValue::CSSBorderImageValue):
              (WebCore::CSSBorderImageValue::cssText):
              * css/CSSBorderImageValue.h:
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::valueForLength):
              (WebCore::valueForBorderStyle):
              (WebCore::valueForTextAlign):
              (WebCore::valueForShadow):
              (WebCore::getPositionOffsetValue):
              (WebCore::CSSComputedStyleDeclaration::cssText):
              (WebCore::primitiveValueFromLength):
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              (WebCore::CSSComputedStyleDeclaration::getPropertyPriority):
              (WebCore::CSSComputedStyleDeclaration::removeProperty):
              (WebCore::CSSComputedStyleDeclaration::setProperty):
              (WebCore::CSSComputedStyleDeclaration::length):
              (WebCore::CSSComputedStyleDeclaration::item):
              * css/CSSComputedStyleDeclaration.h:
              * css/CSSCursorImageValue.cpp:
              (WebCore::CSSCursorImageValue::CSSCursorImageValue):
              * css/CSSCursorImageValue.h:
              * css/CSSGrammar.y:
              * css/CSSImageValue.cpp:
              * css/CSSImageValue.h:
              * css/CSSInheritedValue.cpp:
              * css/CSSInheritedValue.h:
              * css/CSSInitialValue.cpp:
              * css/CSSInitialValue.h:
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
              (WebCore::CSSMutableStyleDeclaration::operator=):
              (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
              (WebCore::CSSMutableStyleDeclaration::get4Values):
              (WebCore::CSSMutableStyleDeclaration::getShorthandValue):
              (WebCore::CSSMutableStyleDeclaration::getPropertyCSSValue):
              (WebCore::CSSMutableStyleDeclaration::removeProperty):
              (WebCore::CSSMutableStyleDeclaration::setChanged):
              (WebCore::CSSMutableStyleDeclaration::getPropertyPriority):
              (WebCore::CSSMutableStyleDeclaration::getPropertyShorthand):
              (WebCore::CSSMutableStyleDeclaration::isPropertyImplicit):
              (WebCore::CSSMutableStyleDeclaration::setProperty):
              (WebCore::CSSMutableStyleDeclaration::setImageProperty):
              (WebCore::CSSMutableStyleDeclaration::parseDeclaration):
              (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
              (WebCore::CSSMutableStyleDeclaration::setLengthProperty):
              (WebCore::CSSMutableStyleDeclaration::cssText):
              (WebCore::CSSMutableStyleDeclaration::merge):
              (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
              * css/CSSMutableStyleDeclaration.h:
              (WebCore::CSSMutableStyleDeclaration::setProperty):
              (WebCore::CSSMutableStyleDeclaration::removeProperty):
              * css/CSSNamespace.h:
              (WebCore::CSSNamespace::CSSNamespace):
              * css/CSSPrimitiveValue.cpp:
              (WebCore::isCSSTokenizerIdentifier):
              (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
              (WebCore::CSSPrimitiveValue::cleanup):
              (WebCore::CSSPrimitiveValue::computeLengthInt):
              (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
              (WebCore::CSSPrimitiveValue::computeLengthShort):
              (WebCore::CSSPrimitiveValue::computeLengthFloat):
              (WebCore::CSSPrimitiveValue::setFloatValue):
              (WebCore::scaleFactorForConversion):
              (WebCore::CSSPrimitiveValue::getFloatValue):
              (WebCore::CSSPrimitiveValue::setStringValue):
              (WebCore::CSSPrimitiveValue::getStringValue):
              (WebCore::CSSPrimitiveValue::parseString):
              (WebCore::CSSPrimitiveValue::getIdent):
              (WebCore::CSSPrimitiveValue::cssText):
              * css/CSSPrimitiveValue.h:
              (WebCore::CSSPrimitiveValue::getCounterValue):
              (WebCore::CSSPrimitiveValue::getRectValue):
              (WebCore::CSSPrimitiveValue::getRGBColorValue):
              (WebCore::CSSPrimitiveValue::getPairValue):
              (WebCore::CSSPrimitiveValue::getDashboardRegionValue):
              * css/CSSProperty.cpp:
              (WebCore::operator==):
              * css/CSSProperty.h:
              (WebCore::CSSProperty::operator=):
              * css/CSSQuirkPrimitiveValue.h:
              (WebCore::CSSQuirkPrimitiveValue::CSSQuirkPrimitiveValue):
              * css/CSSRuleList.cpp:
              (WebCore::CSSRuleList::CSSRuleList):
              (WebCore::CSSRuleList::deleteRule):
              (WebCore::CSSRuleList::insertRule):
              * css/CSSRuleList.h:
              (WebCore::CSSRuleList::item):
              * css/CSSSelector.cpp:
              (WebCore::CSSSelector::print):
              (WebCore::CSSSelector::specificity):
              (WebCore::CSSSelector::extractPseudoType):
              (WebCore::CSSSelector::operator==):
              (WebCore::CSSSelector::selectorText):
              * css/CSSSelector.h:
              (WebCore::CSSSelector::CSSSelector):
              (WebCore::CSSSelector::~CSSSelector):
              (WebCore::CSSSelector::append):
              (WebCore::CSSSelector::next):
              (WebCore::CSSSelector::pseudoType):
              (WebCore::CSSSelector::hasTag):
              (WebCore::CSSSelector::hasAttribute):
              * css/CSSStyleDeclaration.cpp:
              (WebCore::propertyID):
              (WebCore::CSSStyleDeclaration::getPropertyPriority):
              (WebCore::CSSStyleDeclaration::getPropertyShorthand):
              (WebCore::CSSStyleDeclaration::isPropertyImplicit):
              (WebCore::CSSStyleDeclaration::setProperty):
              (WebCore::CSSStyleDeclaration::isPropertyName):
              (WebCore::CSSStyleDeclaration::parentRule):
              (WebCore::CSSStyleDeclaration::diff):
              (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
              * css/CSSStyleDeclaration.h:
              * css/Counter.h:
              (WebCore::Counter::Counter):
              (WebCore::Counter::listStyleNumber):
              * css/csshelper.cpp:
              (WebCore::parseURL):
              * css/csshelper.h:
              * css/cssparser.h:
              (WebCore::domString):
              (WebCore::atomicString):
              (WebCore::CSSParser::operator|):
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::matchRulesForList):
              (WebCore::CSSStyleSelector::checkSelector):
              (WebCore::CSSStyleSelector::checkOneSelector):
              (WebCore::CSSRuleSet::addRule):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18850 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9159df97
    • bdash's avatar
      2007-01-14 Mark Rowe <mrowe@apple.com> · 7e1b95cd
      bdash authored
              Reviewed by Adam.
      
              <rdar://problem/4908909> Need to create Leopard nightly build
      
              * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Always use the 10.4 Universal SDK.  The disk images don't mount pre-10.4 so we aren't losing anything here.
              * WebKitLauncher/WebKitNightlyEnabler.m:
              (poseAsWebKitApp): Simplify CoreFoundation-related hackery by using _CFGetProcessPath instead of walking the mach-o symbol tables.  The smaller timeframe where the
              CFProcessPath environment variable is set allows this to work correctly on Leopard where the old code failed.
              (enableWebKitNightlyBehaviour):
              * WebKitLauncher/main.m:
              (main): Pass executable path as WebKitAppPath rather than CFProcessPath to prevent it being picked up too early by CoreFoundation.
              * Drosera/launcher.m:
              (main): Ditto
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18849 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7e1b95cd
    • ddkilzer's avatar
      LayoutTests: · 57894b4c
      ddkilzer authored
              Reviewed by Adam.  Patch by Mitz.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=12264
                REGRESSION (r18843): Webkit crashes on 43Folders.com home page
      
              * fast/tokenizer/ignore-tags-in-iframe-expected.txt: Added.
              * fast/tokenizer/ignore-tags-in-iframe.html: Added.
      
      WebCore:
      
              Reviewed by Adam.  Patch by Mitz.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12264
                REGRESSION (r18843): Webkit crashes on 43Folders.com home page
      
              Test: fast/tokenizer/ignore-tags-in-iframe.html
      
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::reset): Removed unused inSelect member variable.
              (WebCore::HTMLParser::selectCreateErrorCheck): Ditto.
              (WebCore::HTMLParser::processCloseTag): Ditto.
              * html/HTMLParser.h: Ditto.
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::parseTag): Changed not to process <pre>, <listing>,
              <script>, <style>, <title>, <textarea> and <xmp> if the parser is in skip mode
              (waiting for a close tag of an element whose contents are not parsed,
              such as iframe).
              * html/HTMLTokenizer.h:
              (WebCore::HTMLTokenizer::State::setInStyle): Removed unused bit.
              (WebCore::HTMLTokenizer::State::): Ditto.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18848 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      57894b4c
  2. 14 Jan, 2007 10 commits
    • ddkilzer's avatar
      WebKit: · c096a199
      ddkilzer authored
              Reviewed by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12251
                REGRESSION (r18822-r18823): Assertion failure opening document with non-existent resources
                (dom/xhtml/level2/html/HTMLIFrameElement11.xhtml)
      
              * WebView/WebView.mm:
              (-[WebView _objectForIdentifier:]): Removed assertion.
              (-[WebView _removeObjectForIdentifier:]): Removed assertion.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18846 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c096a199
    • ap's avatar
      Reviewed by Mitz. · 9527e7f4
      ap authored
              * fast/multicol/float-multicol.html: Fixed an URL not to point to a 
              remote resource (we already have a local copy).
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18845 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9527e7f4
    • ap's avatar
      Reviewed by Darin. · 310fe06a
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=12258
              fast/tokenizer/002 test broken
      
      WebCore:
              * loader/FrameLoader.h: Added a flush parameter to write().
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::write): Ditto.
              (WebCore::FrameLoader::endIfNotLoading): Instead of poorly duplicating the logic in write(),
              call it directly.
      
      LayoutTests:
              * editing/selection/designmode-no-caret-expected.txt:
              * fast/dom/HTMLHeadElement/textInHead4-expected.txt:
              * fast/parser/broken-comments-vs-parsing-mode-expected.txt:
              * fast/parser/tabs-in-scripts-expected.txt:
              * fast/tokenizer/external-script-document-write-expected.txt:
              * fast/tokenizer/missing-title-end-tag-1-expected.txt:
              * tables/mozilla/images/adforce_imgis_com-expected.txt:
              * tables/mozilla_expected_failures/images/adforce_imgis_com-expected.txt:
              Updated the results (inconsequential changes only).
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18844 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      310fe06a
    • aroben's avatar
      LayoutTests: · f3b8edb2
      aroben authored
              Reviewed by Maciej.
      
              * editing/deleting/4845371.html: Removed bogus "Javascript" type.
              * editing/selection/4397952.html: Ditto.
              * fast/html/script-allowed-types-languages-expected.txt: Added.
              * fast/html/script-allowed-types-languages.html: Added. Tests
              type/language whitelisting.
      
      WebCore:
      
              Reviewed by Maciej.
      
              Make sure our whitelisting of the type and language attributes of the
              <script> element is enforced in all HTMLTokenizer/HTMLScriptElement
              code paths.
      
              All layout tests pass.
      
              * html/HTMLScriptElement.cpp:
              (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript): New method to
              determine whether the script should be executed, given its type and
              language attributes.
              (WebCore::HTMLScriptElement::evaluateScript): Check type/language
              before executing.
              * html/HTMLScriptElement.h: Added new declarations.
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::begin): Made scriptSrc a String. 
              (WebCore::HTMLTokenizer::scriptHandler): Check
              shouldExecuteAsJavaScript before executing.
              (WebCore::HTMLTokenizer::notifyFinished): Ditto.
              (WebCore::HTMLTokenizer::parseTag): Moved type/language checking from
              here to HTMLScriptElement::shouldExecuteAsJavaScript.
              * html/HTMLTokenizer.h: Made scriptSrc a String, and removed the
              javascript member.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18843 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f3b8edb2
    • hyatt's avatar
      Add a second breaking test for replaced and text mixtures. · 91710c6d
      hyatt authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18842 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      91710c6d
    • hyatt's avatar
      Add multicol float avoidance test. · 6e58b8d2
      hyatt authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18841 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6e58b8d2
    • hyatt's avatar
      Make sure floats are avoided if you have non-auto column property... · b8fffd35
      hyatt authored
              Make sure floats are avoided if you have non-auto column property values.  Fixes the crazy layout
              on http://weblogs.mozillazine.org/roc.
      
              Reviewed by mitz
      
              Added fast/multicol/float-avoidance.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::avoidsFloats):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18840 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b8fffd35
    • hyatt's avatar
      Add layout test for replaced breaking. · 6040e066
      hyatt authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18839 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6040e066
    • hyatt's avatar
      Fix for 10145, regression where line breaks are not being honored... · 7597f8f4
      hyatt authored
              Fix for 10145, regression where line breaks are not being honored between adjacent replaced elements.
              When checking for break opportunities where replaced elements are involved, we ignore their white-space
              values and use their parents' instead.  The assumption/idea behind this change is that because the element
              is replaced, its white-space value is irrelevant except as a means of applying style to its interior.
      
              The CSS spec does not cover this situation, so we're implementing this based off what other browsers seem to
              do.
      
              Reviewed by aroben
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * css/CSSValueKeywords.in:
              * css/cssparser.cpp:
              (WebCore::CSSParser::parseValue):
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::EventHandler):
              (WebCore::EventHandler::clear):
              (WebCore::EventHandler::handleWheelEvent):
              * page/EventHandler.h:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calcHeight):
              * rendering/RenderLayer.cpp:
              (WebCore::Marquee::Marquee):
              (WebCore::Marquee::start):
              (WebCore::Marquee::updateMarqueePosition):
              (WebCore::Marquee::updateMarqueeStyle):
              (WebCore::Marquee::timerFired):
              * rendering/RenderLayer.h:
              * rendering/RenderPartObject.cpp:
              (WebCore::RenderPartObject::viewCleared):
              * rendering/RenderStyle.h:
              (WebCore::):
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::findNextLineBreak):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18838 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7597f8f4
    • bdash's avatar
      2007-01-14 Mark Rowe <mrowe@apple.com> · 559993f2
      bdash authored
              Reviewed by Mitz.
      
              Minor fixes to JavaScript pretty-printing.
      
              * JavaScriptCore.exp:
              * kjs/Parser.cpp:
              (KJS::Parser::prettyPrint): Return line number and error message if parsing fails.
              * kjs/Parser.h:
              * kjs/nodes2string.cpp:
              (ElementNode::streamTo): Include comma delimiters in array literals.
              (PropertyNameNode::streamTo): Quote property names in object literals to handle the case when the property name is not a valid identifier.
              * kjs/testkjs.cpp:
              (doIt): Print any errors encountered while pretty-printing.
      
      2007-01-14  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by Mitz.
      
              Layout tests for fixes to JavaScript pretty-printing.
      
              * fast/js/pretty-print-expected.txt:
              * fast/js/resources/pretty-print.js: Test handling of object literal with non-identifier property name, and of array literals.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18837 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      559993f2
  3. 13 Jan, 2007 15 commits
    • hyatt's avatar
      While optimizing form controls and fixing their clipping, I caused... · c9cf6677
      hyatt authored
              While optimizing form controls and fixing their clipping, I caused this text zoom regression.  The layout
              of text is necessary because it needs to recalc minmaxwidth.  This is still a really unfortunate
              bit of code... since a lot of properties don't apply to text (e.g., borders), we're marking text renderers
              as dirty when we don't have to.
      
              Reviewed by mitz
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::setStyle):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18836 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c9cf6677
    • lars's avatar
      Reviewed by Alexey · 2ba297f8
      lars authored
              String::format() was relying on undefined behaviour, which
              happened to work on lots of systems (Mac and 32bit Linux at least)
              but broke badly on 64bit Linux.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18835 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2ba297f8
    • lars's avatar
      Fix for bug 11924: WebCore would crash on any HTML content · 16d32864
      lars authored
              with a non-empty <table> tag in it on a 64-bit machine. The
              size_t (64bit) vs int (32bit) cast is now fixed in ensureRows,
              and the clients of this function have been updated to check
              for a false return code.
      
              Reviewed by Darin
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18834 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      16d32864
    • ap's avatar
      Reviewed by Darin. · 7a650a7e
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=12165
              REGRESSION: text encoding problem at jn.sapo.pt
      
              Test: fast/encoding/script-in-head.html
      
              * loader/TextResourceDecoder.cpp:
              (WebCore::TextResourceDecoder::checkForHeadCharset):
              Ignore tags within <script> elements in head, just like we do for <title>.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18833 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7a650a7e
    • lars's avatar
      Reviewed by Maciej · 5079de61
      lars authored
              Don't crash when constructing a GraphicsContext with a 0
              PlatformGraphicsContext and don't do anything if painting
              is disabled.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18832 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5079de61
    • lars's avatar
      Make the Qt port compile again. · beff4db2
      lars authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18831 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      beff4db2
    • eseidel's avatar
      2007-01-13 Eric Seidel <eric@eseidel.com> · 56b73483
      eseidel authored
              Reviewed by hyatt.
      
              RichDraw demo does not live-update in Safari
              (SVG elements should ignore CSS position)
              http://bugs.webkit.org/show_bug.cgi?id=10364
      
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::adjustRenderStyle): ignore position for everything but <svg>
              * ksvg2/svg/SVGStyledElement.cpp:
              (WebCore::SVGStyledElement::rebuildRenderer): move path generation into layout()
              * rendering/RenderContainer.cpp:
              (WebCore::RenderContainer::layout): ASSERT kids marked as having completed layout
              * rendering/RenderPath.cpp:
              (WebCore::RenderPath::layout): move path generation into layout()
              * rendering/RenderSVGContainer.cpp:
              (WebCore::RenderSVGContainer::layout): ASSERT kids marked as having completed layout
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18830 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      56b73483
    • hyatt's avatar
      Fix leak of column vector. · 24cebcc9
      hyatt authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18829 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      24cebcc9
    • hyatt's avatar
      Add layout test for column rules. · d73d0ff9
      hyatt authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18828 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d73d0ff9
    • hyatt's avatar
      Add support for column rules. · e6f60343
      hyatt authored
              Reviewed by bdash
      
              fast/multicol/column-rules.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintColumns):
              * rendering/RenderStyle.h:
              (WebCore::RenderStyle::columnRuleIsTransparent):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18827 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e6f60343
    • hyatt's avatar
      Make multicolumn layout work with floats. · 99d85a2d
      hyatt authored
              Reviewed by andersca
      
              Added fast/multicol/float-multicol.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::layoutBlock):
              (WebCore::RenderBlock::paintColumns):
              (WebCore::RenderBlock::paintObject):
              * rendering/RenderBlock.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18826 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      99d85a2d
    • hyatt's avatar
      New fancy float multicol test (thanks Mozilla!) · af3691c0
      hyatt authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18825 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      af3691c0
    • ddkilzer's avatar
      LayoutTests: · 9ec4dc5d
      ddkilzer authored
              Reviewed by Maciej.
      
              - test for fast/css/line-height.html
                REGRESSION (r18816-r18818): Assertion failure in
                WebCore::Length::Length[in-charge](int, WebCore::LengthType, bool)
      
              * fast/css/line-height-expected.checksum: Added.
              * fast/css/line-height-expected.png: Added.
              * fast/css/line-height-expected.txt: Added.
              * fast/css/line-height.html: Added.
      
      WebCore:
      
              Reviewed by Maciej.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12239
                REGRESSION (r18816-r18818): Assertion failure in 
                WebCore::Length::Length[in-charge](int, WebCore::LengthType, bool)
      
              Test: fast/css/line-height.html
      
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::createInnerTextStyle): Use a float to create a percent Length.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18824 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9ec4dc5d
    • andersca's avatar
      Forgot to save. · f748def0
      andersca authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18823 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f748def0
    • andersca's avatar
      JavaScriptCore: · 7835a675
      andersca authored
              Reviewed by Darin.
      
              * wtf/HashTraits.h:
              Add hash traits for unsigned long and unsigned long long.
      
      WebCore:
      
              Reviewed by Darin.
      
              Use unsigned long for identifiers instead of Objective-C objects.
              
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::loadResourceSynchronously):
              (WebCore::FrameLoader::startLoadingMainResource):
              (WebCore::FrameLoader::startLoading):
              (WebCore::FrameLoader::assignIdentifierToInitialRequest):
              (WebCore::FrameLoader::opened):
              (WebCore::FrameLoader::sendRemainingDelegateMessages):
              (WebCore::FrameLoader::requestFromDelegate):
              (WebCore::FrameLoader::loadedResourceFromMemoryCache):
              * loader/FrameLoader.h:
              * loader/FrameLoaderClient.h:
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::ResourceLoader):
              (WebCore::ResourceLoader::willSendRequest):
              * loader/ResourceLoader.h:
              (WebCore::ResourceLoader::setIdentifier):
              (WebCore::ResourceLoader::identifier):
              * page/Page.cpp:
              (WebCore::Page::Page):
              (WebCore::Page::createUniqueIdentifier):
              * page/Page.h:
              * platform/graphics/svg/SVGImageEmptyClients.h:
              (WebCore::SVGEmptyFrameLoaderClient::assignIdentifierToInitialRequest):
              (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest):
              (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
              (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
              (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse):
              (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveContentLength):
              (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoading):
              (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoading):
              (WebCore::SVGEmptyFrameLoaderClient::incrementProgress):
              (WebCore::SVGEmptyFrameLoaderClient::completeProgress):
      
      WebKit:
      
              Reviewed by Darin.
      
              Add a HashMap between unsigned longs and Objective-C objects and use it for
              the resource load delegate.
              
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::assignIdentifierToInitialRequest):
              (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
              (WebFrameLoaderClient::dispatchWillSendRequest):
              (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
              (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
              (WebFrameLoaderClient::dispatchDidReceiveResponse):
              (WebFrameLoaderClient::dispatchDidReceiveContentLength):
              (WebFrameLoaderClient::dispatchDidFinishLoading):
              (WebFrameLoaderClient::dispatchDidFailLoading):
              (WebFrameLoaderClient::incrementProgress):
              (WebFrameLoaderClient::completeProgress):
              * WebView/WebView.mm:
              (-[WebViewPrivate init]):
              (-[WebViewPrivate dealloc]):
              (-[WebView _addObject:forIdentifier:]):
              (-[WebView _objectForIdentifier:]):
              (-[WebView _removeObjectForIdentifier:]):
              * WebView/WebViewInternal.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18822 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7835a675