- 28 Sep, 2017 5 commits
-
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/408b8e44..7c5095aa Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I3d37fe7c10f4ff01faf9ebda7a3e8f8eebc0fd80 Reviewed-on: https://chromium-review.googlesource.com/688415Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#504815}
-
Sammie Quon authored
name members. It seems some subclass of actionable_view which use SetAccessibleName actually use button's impl of SetAccessibleName which then leaves |accessible_name_| empty in actionable_view, so ChromeVox will then not read anything. There is at least one instance which occurs in system tray, the audio settings button (the other actionable_views are not affected because they have their own GetAVXNodeData impl's). This cl removes SetAccessibleName and accessible_name_ from subclasses of Button. These classes will just use Button::SetAccessibleName and Button::accessible_name() instead. Test: manual Bug: 747469 Change-Id: I03bde6e90ed3b22321585eccccb4cc2c32e5b5ef Reviewed-on: https://chromium-review.googlesource.com/678061 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#504814}
-
Eric Caruso authored
Rearrange the loop so that we can use continue to go to the next file. Also factor the copying bits of CopyFile so that CopyDirectory can use them with files that are already open, so it can open/fstat the files itself and be resilient to time-of-check/time-of-use attacks (such as the attacker replacing a file that was just stated but not yet opened with a pipe that it will block reading from). Bug: 767138 Test: existing + new unit tests Change-Id: I0c2164b0165850834323d860d1d390ac895737e9 Reviewed-on: https://chromium-review.googlesource.com/677563 Commit-Queue: Eric Caruso <ejcaruso@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#504813}
-
Tomasz Mikolajewski authored
Crossfading recreates the layers and fades out the old ones over the new ones. However, when frame sinks are used, the layers still share the same frame sink and surface id. Drawing to the new layer would draw to the old layer too, making both layers equal. This CL fixes this problem by forcing creating a new surface id for the new layers. TEST=Not used yet. Restoring/maximizing existing windows doesn't regress. BUG=b/29406058 Change-Id: I1cc8546a4c0935d55db4d2a5ae8b16b95041d1af Reviewed-on: https://chromium-review.googlesource.com/647347Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tomasz Mikolajewski <mtomasz@chromium.org> Cr-Commit-Position: refs/heads/master@{#504812}
-
Xida Chen authored
This reverts commit a240cac3. Reason for revert: <INSERT REASONING HERE> Cause build failure: https://build.chromium.org/p/chromium.linux/builders/Cast%20Audio%20Linux/builds/4848 Original change's description: > New NTLMv2 Implementation. > > - Supports NTLMv2 with Extended Protection for Authentication (EPA) > and Message Integrity Check (MIC). > - Adds required methods to buffer reader/writers to support NTLMv2 > - Adds optional version/mic fields to all messages > - Removes protocol level tests from HttpAuthHandlerNtlmPortableTest. > A previous CL already implemented all those tests directly against > NtlmClient. The tests at that level only existed to validate that > the behavior of the old and new implementation were the same. > - Future CL updates fuzzer to support v2. > - This CL does not activate NTLMv2. The code still defaults to NTLMv1. > > BUG=chromium:22532 > > Change-Id: I5b6dcbf6cdcf8f671008f60ae49c9bacb4e1d2f3 > Reviewed-on: https://chromium-review.googlesource.com/608620 > Commit-Queue: Zentaro Kavanagh <zentaro@google.com> > Reviewed-by: Asanka Herath <asanka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504808} TBR=rsleevi@chromium.org,zentaro@google.com,asanka@chromium.org Change-Id: Ie6fead019bc26fa2394ba50d19f7c4e10772e566 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:22532 Reviewed-on: https://chromium-review.googlesource.com/688800Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#504811}
-
- 27 Sep, 2017 35 commits
-
-
Tom Sepez authored
Bug: 708738 Change-Id: If649a9eb073f63fb5ccff0cdc1226faa27334644 Reviewed-on: https://chromium-review.googlesource.com/685279Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#504810}
-
Prashant Malani authored
This patch updates the midis.mojom file with struct definitions and interface functions to pass device information to the ARC client, as well as to request midis for port FDs for subdevices, and to close all client connections to a particular device. BUG=chromium:701005 Change-Id: Id9daeeb36b6c7328b5b332420d3afd163a3b48b5 Reviewed-on: https://chromium-review.googlesource.com/685261Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Prashant Malani <pmalani@google.com> Cr-Commit-Position: refs/heads/master@{#504809}
-
Zentaro Kavanagh authored
- Supports NTLMv2 with Extended Protection for Authentication (EPA) and Message Integrity Check (MIC). - Adds required methods to buffer reader/writers to support NTLMv2 - Adds optional version/mic fields to all messages - Removes protocol level tests from HttpAuthHandlerNtlmPortableTest. A previous CL already implemented all those tests directly against NtlmClient. The tests at that level only existed to validate that the behavior of the old and new implementation were the same. - Future CL updates fuzzer to support v2. - This CL does not activate NTLMv2. The code still defaults to NTLMv1. BUG=chromium:22532 Change-Id: I5b6dcbf6cdcf8f671008f60ae49c9bacb4e1d2f3 Reviewed-on: https://chromium-review.googlesource.com/608620 Commit-Queue: Zentaro Kavanagh <zentaro@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#504808}
-
Brian White authored
If "accessibility" is enabled then a pointer to the WebContents- AccessibilityAndroid object is held by an BrowserAccessibility- ManagerAndroid object leaving it dangling if the former is destructed. During destruction of the WCAA object, remove any reference to itself from the BAMA object. Bug: 736675, 727210 Change-Id: I67050e7708abbdfe396a0571bc515a5bda88dcbe Reviewed-on: https://chromium-review.googlesource.com/688035 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#504807}
-
Charles Reis authored
The name is already available from the FrameTreeNode and does not need to be sent up to the browser at commit time. BUG=766262 TEST=No behavior change Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I5f9bc8acd50c868b84514f2ae240b5640ff56a83 Reviewed-on: https://chromium-review.googlesource.com/686174Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Charlie Reis (catching up) <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#504806}
-
Ted Choc authored
Ensures that any selection state set while the omnibox was focused does not remain after it gets defocused. BUG=769229 Change-Id: I5a674bd2c0b9582f158213559da6a5176ab431cd Reviewed-on: https://chromium-review.googlesource.com/688679Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#504805}
-
Nate Fischer authored
This adds @RetryOnFailure to a flaky Safe Browsing test. This does not flake very often. Bug: 765932 Change-Id: Ic7bc40863d395b76c821ee9c277b17d82e5c5ff4 Reviewed-on: https://chromium-review.googlesource.com/688676 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#504804}
-
Lucas Garron authored
Update NavigationThrottle::CancelDeferredNavigation() comment to specifically refer to the ThrottleCheckResult's action. Bug: 762430 Change-Id: Ieaea62732d604ca56fb3cdb97e96a4ac98e76f15 Reviewed-on: https://chromium-review.googlesource.com/686102Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#504803}
-
Xiaochu Liu authored
Instead of downloading container at browser start, we now have a dbus API to download container at any time. BUG=chromium:768009 TEST=manual Change-Id: I00f57024b27e4dc8ad2ba44f7ed7cbb5e374afbc Reviewed-on: https://chromium-review.googlesource.com/688055 Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#504802}
-
John Abd-El-Malek authored
TBR=yzshen@chromium.org NOTRY=true Change-Id: I55a8e2c3f37c5b7c28ba8dea4543c8162bebde3a Reviewed-on: https://chromium-review.googlesource.com/688158 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#504801}
-
Mike Wasserman authored
Make Chrome shelf item context menus open items on the right display. Use a ScopedRootWindowForNewWindows when executing commands in cash. (we'll need another fix for mash, but my first attempt didn't work) Fixes the defect when using --ash-enable-shelf-model-synchronization. Nix the ShelfView codepath that only matches the local menu lifetime. (ShelfModel Sync handles the menu command execution async/remotely) Bug: 768908 Test: Chrome opens on the same display as the shelf item [context menu]. Change-Id: If8c812c892c4c628e9c012ea9e9cd75461d3b71a Reviewed-on: https://chromium-review.googlesource.com/688108Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#504800}
-
Yuke Liao authored
Force layout should happen after load html. This is only a speculative fix of the flake on iPhone 7 iOS 11 devices as I couldn't reproduce the failure locally. Bug: Change-Id: I1c76c7e7ea47d798b125d15ddc2d4f79bc7653c6 Reviewed-on: https://chromium-review.googlesource.com/688634Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#504799}
-
Will Chen authored
I've inlined the handful of tests that used the output API call, which is removed from the new test framework (it was confusing and not available in the new world) Bug: 667560 Change-Id: Ie188797bffe7253ed90dc5ee2ca90c41b495d0e2 Reviewed-on: https://chromium-review.googlesource.com/667805 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#504798}
-
Sammie Quon authored
ChromeVox will read .. literally as two dots. Just use the one period from the .grd file string. Test: manual Bug: 747470 Change-Id: Ia5bc2c0a345f1a5b84f4d26bf0141d565f2d1207 Reviewed-on: https://chromium-review.googlesource.com/677567Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#504797}
-
Yuke Liao authored
Test is failing on ipad devices. Bug: 769464 Change-Id: I9b04bb15b5bdb30afa0aa5a484e4eb25eaeea6de Reviewed-on: https://chromium-review.googlesource.com/688500Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#504796}
-
James Cook authored
For go/mustash we need to eliminate in-process ash to chrome delegates. Eliminate the concept from ash, in favor of checking whether multiple users are signed in or whether more users can be added to the session. Rename the chrome method to make it clearer that it's not just a feature that can be enabled or disabled. Eliminate dead code to support initializing the system tray menu for ephemeral users. See issue 312324 for details. Change InactiveUserNotificationBlocker to only block notifications when multiple users are in the session. This is mostly needed to prevent notifications from being blocked in AshTestBase tests but also more closely matches what we want in production. Bug: 312324, 665064 Test: ash_unittests, unit_tests, manually check system tray menu with ephemeral users and with multi-profile, manually test notification blocking for inactive users with http://jsfiddle.net/qjme9dmd/ Change-Id: Ib1c0bcd5da3f9e9c32641b29e95385e696cc415a Reviewed-on: https://chromium-review.googlesource.com/685823 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#504795}
-
Scott Violet authored
Doing this for same reason as patchset: https://chromium-review.googlesource.com/c/chromium/src/+/685306 BUG=763529 TEST=none Change-Id: Ifb175f0ce95c04ad34ddfe49cb01765a4e2e30e9 Reviewed-on: https://chromium-review.googlesource.com/687888Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#504794}
-
Xiyuan Xia authored
Bug: None Change-Id: Ia5460944347eab0c77dc34b1850d3f26bbadf73d Reviewed-on: https://chromium-review.googlesource.com/688490Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#504793}
-
Selim Gurun authored
When Webview moved to Chromium based code, we invented a "side" shouldoverrideurlloading path for popups because by the time sync ipc's were received, Webview was not ready to receive the shouldoverrideurlloading callback (Popups require embedding app to create them). With PlzNav, we don't use sync IPC's anymore (except renderer-initiated navs, which is mainly about:blank), and now can disable that path. Note that this is not a super well tested path. Some popup tests were added recently and they seem to be working ok with this change. Bug: 766167 Change-Id: I061ab5de7296f7f3d59fb5833ece3f867b2e1c03 Reviewed-on: https://chromium-review.googlesource.com/688474Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Selim Gurun <sgurun@chromium.org> Cr-Commit-Position: refs/heads/master@{#504792}
-
Troy Hildebrandt authored
Bug: Change-Id: I4f4229055e88b6fd8fa8a9c2e9a18f256e05333d Reviewed-on: https://chromium-review.googlesource.com/688215Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#504791}
-
Steven Bennetts authored
Bug: None Change-Id: Ieaf7121840b2866c2dd90264c976af25e4c5bba2 Reviewed-on: https://chromium-review.googlesource.com/687863Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#504790}
-
Hwanseung Lee authored
use USVString for URLs instead of DOMString at Worklet. Bug: 567358 Change-Id: Ia1d777693ce9a71f4369122e389018dc0e5b4921 Reviewed-on: https://chromium-review.googlesource.com/686679Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#504789}
-
Peter Mayo authored
The implementing classes and the idl exposing them are removed. Removed/elevated AbstractAnimationWorkletThread class into actual AnimationWorkletThread since it is the only one now. R=majidvp@chromium.org Bug: 746212 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0970b5a658fdcbfbb4d45f47be5fd33739778155 Reviewed-on: https://chromium-review.googlesource.com/673484Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Peter Mayo <petermayo@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#504788}
-
Giovanni Ortuño Urquidi authored
This reverts commit d643999c. Reason for revert: Flaky on Windows, Mac and Linux Trunk builds. Original change's description: > desktop-pwas: Add more tests for opening desktop pwas > > Tests for: > > 1. POST and GET forms > 2. Prerender links > 3. Fetch requests > 4. Open link in incognito" > 5. Navigating inside an incognito window > > Bug: > Change-Id: Icb383ee64b5d0e253dcf507e56cea718affab99d > Reviewed-on: https://chromium-review.googlesource.com/661998 > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504506} TBR=lazyboy@chromium.org,mgiuca@chromium.org,ortuno@chromium.org Change-Id: I27db621eae080d443fdd2d7ca8af32750ea77746 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/688774Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#504787}
-
Andrey Kraynov authored
<FrameSelection.h> header was needed only for RevealSelectionAfterEditingOperation function parameter. But it seems that all call sites of this private function didn't specify the second parameter and always used default value. Bug: Change-Id: I9c4a40c36287c9ccc9a908554df8c106283d1430 Reviewed-on: https://chromium-review.googlesource.com/667377Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#504786}
-
Lukasz Anforowicz authored
NOTRY=true Bug: 765779 Change-Id: I4c16248e4497ee4c9978d74e64d1591baf45ade7 Reviewed-on: https://chromium-review.googlesource.com/688654Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504785}
-
Lucas Garron authored
Bug: Change-Id: I7492294beda04a07a233fbe2225350f985ec0421 Reviewed-on: https://chromium-review.googlesource.com/686294Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#504784}
-
Dominic Mazzoni authored
It looks like the test was just timing out. Shortened the text used by AccessibilityGmailComposeStory significantly. Locally the test went from taking 110s to 54s. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/663208 Reverted: https://chromium-review.googlesource.com/686454 Adds new stories that exercise things that sometimes cause performance problems for accessibility: live regions, large data tables, scrolling large complex sites, and typing in a contenteditable, and expands the system_health benchmark to track accessibility metrics. Bug: 712417 Change-Id: I4496833409b142babc907dff8033da75789c932e Reviewed-on: https://chromium-review.googlesource.com/688058Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#504783}
-
Xiaohan Wang authored
This code is not being used and there's no plan to enable it any time soon. BUG=730770 TEST=No functionality change Change-Id: I76a0e5823f5c5923f3ae8f134b4a3b6609eb462f Reviewed-on: https://chromium-review.googlesource.com/685460Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#504782}
-
Brett Wilson authored
Code was difficult to copy-and-paste out of the callback examples because typically one would need to add base:: to many types. This explicitly adds "base::" to all examples. Originally I was going to keep the references in the text unchanged and only change the code blocks. But this ended up being confusing. As a result, all code-formatted references have been qualified. In some cases this is a bit verbose and repetitive, but I think its better to be explicit and consistent. Expands a bit on weak pointer usage which I have found myself repeatedly looking up. Change-Id: I961b25ea6db6151180cf0d687e576be72e327427 Reviewed-on: https://chromium-review.googlesource.com/688505Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#504781}
-
Anna Maria authored
Added in a nullptr check for when the navigator has a detached window. Bug: 766498 Change-Id: Ia103761f3673b518428f9e34f6b7082d952b3407 Reviewed-on: https://chromium-review.googlesource.com/685818Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Anna Maria <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#504780}
-
Matt Mueller authored
Fixes "Check failed: TaskScheduler::GetInstance()." Bug: Change-Id: I975bdd95254818f9864cf3e059ad6926bb2985f9 Reviewed-on: https://chromium-review.googlesource.com/686048 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#504779}
-
Philip Rogers authored
Drag link images are an image of the destination url that's created when you drag a link. This patch fixes two bugs in the link image offset: 1) Link images were not offset by the device scale factor. This meant that the link was incorrectly positioned on high-dpi screens. 2) We further regressed the link image offset when DragController::DoSystemDrag started taking into account page scale factor in: https://chromium.googlesource.com/chromium/src/+/7e525d262ca0cd454a91c81d2d23071feef9b1dd This patch adds DragLocationForLink which correctly scales the link offset. Bug: 766355 Change-Id: I25a04fb4bf734cce810a74498fa126d97f58964c Reviewed-on: https://chromium-review.googlesource.com/680535Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#504778}
-
Lei Zhang authored
Change-Id: I553d1d1212162810f62b5f2bedd48c61d6bdd50f Reviewed-on: https://chromium-review.googlesource.com/685989Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#504777}
-
Sammie Quon authored
Vector icons with FLIPS_IN_RTL get shown. Right now there are only the submenu arrow and the tablet mode back button which uses this command. This also only happens when using the 2x icon. The current transforms applied on rtl 2x icons are: - scale down by factor of 2 - scale by -1 - translate by the canvas size This results in the icon being translated out of its bounds and not being shown. This cl does the scaling down after the translation. Test: gfx_unittests VectorIconTest.FlipsInRtl Bug: 769366, 768059 Change-Id: I67e748ea23c9020f13a693546db2fade07e05ae6 Reviewed-on: https://chromium-review.googlesource.com/687826Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#504776}
-