- 13 Jan, 2021 40 commits
-
-
Tim van der Lippe authored
R=szuend@chromium.org Bug: 1050549 Change-Id: I763f8596ab931c97a5b15dcd2639f59baab2763b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627412 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#842985}
-
Yuta Hijikata authored
This change renames deprecated macro name IS_LACROS and IS_ASH with IS_CHROMEOS_LACROS and IS_CHROMEOS_ASH. Bug: 1052397 Change-Id: I58d95a81555a4915b8e80edc1edd23cc3f7d49bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626685 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#842984}
-
kylechar authored
SkiaRenderer will use GL by default if not using Vulkan or Dawn. The --use-gl switch isn't required to get into this state. Add a check that we're using GPU compositing first, since if that is false Chrome will use SoftwareRenderer. Also change the skia-renderer-gl tag to be true if 'opengl' feature is enabled but not using Vulkan or Dawn. Bug: 1163586 Change-Id: Ica5ee59d59b8e437faf0aa9c954e3280d1c7d0e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622237Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#842983}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610517435-1554e99a291ef2bcb6f5a0139dcc2bec362b747b.profdata to chrome-win64-master-1610528340-1fc68c0c17222e2254fe428312433be61c378c49.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6f3dd9bfafb1c22961eee183f0874787a34f6880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627088Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842982}
-
Andrey Zaytsev authored
Mock: https://docs.google.com/presentation/d/1_6jDegg169xJ5qgaABZ_wV3-Csd_OL5bf9H1NeUqS9Y/edit?pli=1#slide=id.gac1f62eb2c_0_23 Screenshot: https://screenshot.googleplex.com/8oc3STHihHMNwaF.png Bug: 1152351 Change-Id: Ib4692d6a540652ab761ab373de619385f76fa08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611098 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#842981}
-
Maxim Kolosovskiy authored
This reverts commit 85753b0f. Reason for revert: I suspect this CL caused failures SubresourceRedirectLoggedInSitesBrowserTest.TestCancelBeforeImageLoadForLoggedInSite https://ci.chromium.org/ui/p/chromium/builders/ci/linux-lacros-tester-rel/6414/overview Fontconfig error: Cannot load default config file: No such file: (null) BrowserTestBase received signal: Terminated. Backtrace: #0 0x5596f4879789 base::debug::CollectStackTrace() #1 0x5596f47e4163 base::debug::StackTrace::StackTrace() #2 0x5596f4dcc0c6 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f128ca544c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x7f12902ec9ff __libc_send #5 0x5596f2a8598f mojo::core::ChannelPosix::WriteNoLock() #6 0x5596f2a854b2 mojo::core::ChannelPosix::Write() #7 0x5596f2a7370e mojo::core::NodeChannel::SendChannelMessage() #8 0x5596f2a7808a mojo::core::NodeController::SendPeerEvent() #9 0x5596f2a78707 mojo::core::NodeController::ForwardEvent() #10 0x5596f6c728d2 mojo::core::ports::Node::SendUserMessageInternal() #11 0x5596f6c72720 mojo::core::ports::Node::SendUserMessage() #12 0x5596f2a768e1 mojo::core::NodeController::SendUserMessage() #13 0x5596f2a71afe mojo::core::MessagePipeDispatcher::WriteMessage() #14 0x5596f2a6744c mojo::core::Core::WriteMessage() #15 0x5596f579b850 mojo::Connector::Accept() #16 0x5596f579d9db mojo::InterfaceEndpointClient::SendMessageWithResponder() #17 0x5596f579dd5f mojo::InterfaceEndpointClient::AcceptWithResponder() #18 0x5596f26f4662 content::mojom::ChildHistogramFetcherProxy::GetChildNonPersistentHistogramData() #19 0x5596f2d9b2aa content::HistogramController::GetHistogramData() #20 0x5596f2d9c905 content::HistogramSynchronizer::RegisterAndNotifyAllProcesses() #21 0x5596f2d9ca56 content::FetchHistogramsAsynchronously() #22 0x5596f4dd4781 content::FetchHistogramsFromChildProcesses() #23 0x5596f52f70fa subresource_redirect::RetryForHistogramUntilCountReached() #24 0x5596f0f9d3d1 subresource_redirect::SubresourceRedirectLoggedInSitesBrowserTest_TestCancelBeforeImageLoadForLoggedInSite_Test::RunTestOnMainThread() #25 0x5596f4dcb6e9 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #26 0x5596f491e0aa ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #27 0x5596f491cea5 ChromeBrowserMainParts::PreMainMessageLoopRun() #28 0x5596f2c33516 content::BrowserMainLoop::PreMainMessageLoopRun() #29 0x5596f30a1833 content::StartupTaskRunner::RunAllTasksNow() #30 0x5596f2c324f9 content::BrowserMainLoop::CreateStartupTasks() #31 0x5596f2c34e78 content::BrowserMainRunnerImpl::Initialize() #32 0x5596f2c30c28 content::BrowserMain() #33 0x5596f373dc93 content::ContentMainRunnerImpl::RunBrowser() #34 0x5596f373d886 content::ContentMainRunnerImpl::Run() #35 0x5596f373ad84 content::RunContentProcess() #36 0x5596f373b70c content::ContentMain() #37 0x5596f4dcac68 content::BrowserTestBase::SetUp() #38 0x5596f47d0edb InProcessBrowserTest::SetUp() #39 0x5596f0f9e065 subresource_redirect::SubresourceRedirectLoggedInSitesBrowserTest::SetUp() #40 0x5596f1cf66e8 testing::Test::Run() #41 0x5596f1cf757f testing::TestInfo::Run() #42 0x5596f1cf7f57 testing::TestSuite::Run() #43 0x5596f1d05777 testing::internal::UnitTestImpl::RunAllTests() #44 0x5596f1d050df testing::UnitTest::Run() #45 0x5596f48d0724 base::TestSuite::Run() #46 0x5596f47b935f ChromeTestSuiteRunner::RunTestSuite() #47 0x5596f4dfaab7 content::LaunchTests() #48 0x5596f47b9632 LaunchChromeTests() #49 0x5596f47b6df4 main #50 0x7f128ca3f840 __libc_start_main #51 0x5596f008526a _start [ RUN ] SubresourceRedirectLoggedInSitesBrowserTest.TestCancelBeforeImageLoadForLoggedInSite Original change's description: > [Safe Browsing] Abstract signin dep from RealTimeUrlLookupService > > This CL continues with the abstraction of dependencies on signin and > sync from //components/safe_browsing's access token fetching flow in > order to enable reuse by WebLayer. The concrete step taken here is to > abstract the dependencies on > //components/safe_browsing/core/browser/sync from > RealTimeUrlLookupService, passing these dependencies in via the > constructor. There are no behavioral changes in this CL: > - //chrome and //ios/chrome's factories glue the relevant parameters > from //components/safe_browsing/core/browser/sync > - //weblayer's factory passes in values for the parameters such that > access token fetching for URL lookups continues to be disabled in > WebLayer > > Followup work will bring up support for access token fetching in > WebLayer. > > Bug: 1080748 > Change-Id: I69fca4b2d04118088bb48596eb192beab7bafb4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621301 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> > Commit-Queue: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842942} TBR=blundell@chromium.org,sdefresne@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,xinghuilu@chromium.org Change-Id: I9aa193871848c7e07353bb2bb428a2a39ba5cb00 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1080748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627391Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#842980}
-
David Roger authored
This CL updates the string to: "To access your Chrome stuff across all your devices, sign in, then turn on sync." https://storage.cloud.google.com/chromium-translation-screenshots/d11144bc8bc505baf22f44152b590dc96c796574 Another version of the string is also added, for possible experimentation later: "To access your Chrome stuff across all your devices, sign in so that you can turn on sync." https://storage.cloud.google.com/chromium-translation-screenshots/6cdbd1b209a8657e0a790d1ec671d522e0c54344 Change-Id: I08e74567ef64e0916366992f35a2901d94975fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626648 Auto-Submit: David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#842979}
-
Adrienne Walker authored
CacheStorageContextImpl implements the new AddReceiver mojo function, but no callers have transitioned from calling C++ to calling mojo yet. This CL is dealing with the churn of changing content::CacheStorageOwner to storage::mojom::CacheStorageOwner. Bug: 1147642 Change-Id: I3b0067767bea4571fd949741780e4a34b18939f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615311Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Auto-Submit: enne <enne@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#842978}
-
Matthias Körber authored
It is currently not the intention to run the subtoken merge strategy but due to an additional or statement, this strategy is executed although it is the intent to only run a token merge strategy when the back of tokens are equivalent. This change removes the wrong application. Bug: 1158810 Change-Id: I08d68818fac1b6a7552f6aa744caca8eed512902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627315Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#842977}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2ed9671a0ddd..62b8364eafc7 2021-01-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2a7e78c7 to 451c64aa (494 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I4d9b1028d1cc3a660843431703a0e6728db70117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627020Reviewed-by:
-
https://crrev.com/c/2599731Yutaka Hirano authored
Bug: None Change-Id: Ic4f42a004df7da9dd39eedbdcc9fd68389108fca Tbr: wutao@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626942Reviewed-by:
-
Tanmoy Mollik authored
Methods OnPrimaryAccountSet/OnPrimaryAccountCleared are deprecated. This cl removes artifacts used by these method overrides in TestIdentityManagerObserver and replaces them with a single callback for OnPrimaryAccountChanged. Bug: 1158855 Change-Id: If0cd666626268c7e21fcde33d26a5c0cfbc298de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618438 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#842974}
-
Ossama Mahmoud authored
Merge the privacy disclaimer footer note with the subheader in the fingerprint-setup initial screen. Bug: 1096679 Change-Id: I7f179931e57a6bcdfc8c60c494ddf6dd37a4f7c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612972 Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#842973}
-
Ramin Halavati authored
Fixes a forgotten value in enums.xml. Bug: 1157764 Change-Id: I4e8f60588f095f31349ad032d89c2cea83fecac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626653 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#842972}
-
Aya ElAttar authored
- Added is_drop parameter tot IsDragDropAllowed. - Changed IsDragDropAllowed logic to notify only if is_drop==true. - Added unittests for IsDragDropAllowed. Bug: 1160656 Change-Id: I6b745aa63756052e58ccd4cea6895ecc34a6c8b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624671 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#842971}
-
Anton Bikineev authored
This is useful for PCScan since it enables the scanning routine to use a bitmap for super-page lookup. Bug: 11297512 Change-Id: I1634f0a97a1dd85e3407d80da6cd43e362476062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627147 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#842970}
-
Stephen McGruer authored
Due to mandatory code review, we need to migrate off of the automatic copy of tools/ in external/wpt, and instead use the manually rolled copy in blinkpy. This change updates run_wpt_tests.py to point at that copy, and updates the include-list as necessary to make wptrunner work. Bug: 1165950 Change-Id: I4c31addbf16fbaba3671048d26399a15c04c0acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470462Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#842969}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cc988a955f26..8d62769d7e71 2021-01-13 sigurds@chromium.org Collect UMA on developer resource loads 2021-01-13 andoli@chromium.org [module.json extensions] Add check for duplicate actions and views 2021-01-13 alcastano@google.com Center vertically popover icon 2021-01-13 tvanderlippe@chromium.org [module.json extensions] animation 2021-01-13 aerotwist@chromium.org Perf panel: fix request finish time 2021-01-13 bmeurer@chromium.org [e2e] Temporarily disable tests to unblock the Chromium roll. 2021-01-13 kimanh@chromium.org Allow live locations even if the debugger is disabled If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1069378,chromium:1132260,chromium:1134103,chromium:1150883,chromium:1157396,chromium:1165304 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic8f7fb75ff841ad9cb888e14a1bfeb79148d1a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627352Reviewed-by:
-
dpapad authored
This ensures that the BUILD.gn file is not unnecessarily evaluated where not applicable. Bug: None Change-Id: I4bc18a19f6fee782ed85df7a2d007465bedced3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626912 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#842967}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7faa362ea9c2..111ba65a5e3d 2021-01-13 cwallez@chromium.org D3D12: Use Texture::Create pattern for swapchain textures 2021-01-13 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 987376cd21a8 to 1c200cffd051 (13 revisions) 2021-01-13 marksibly@gmail.com Reset scissor reset before presenting in opengl 2021-01-13 enga@chromium.org Update DepthStencilStateTests to use WGSL If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Ibb045064f561ef91f34164911d6f000f1d341650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627350Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610495996-5598384ad8a00037e18a56fd00981ea765e31cd1.profdata to chrome-win32-master-1610517435-6cb290631927ae5ce3c51d7b67446e43eb76cc98.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3d2c5a161f10c5c42e5b05e6c54a634d712b1adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627016Reviewed-by:
-
Yutaka Hirano authored
network.mojom.DataElement represents part of a request body. It is a union of several types, and that applies to its typemapped class, network::DataElement. Up until now we had flat members (e.g., offset(), length(), bytes()) with various DCHECKs on network::DataElement. This led to several issues: 1) The code author can be confused. Some members (e.g., length(), bytes()) seems to have a meaning in a wrong context, and that can lead to security issues. See https://crbug.com/1151865 for example. 2) It is hard to maintain the DCHECKs in a consistent way. For example, at this moment we have a DCHECK at chunked_data_pipe_getter(), but we don't have a DCHECK at length(). We have a similar difficulty on mojo deserialization. This CL makes network::DataElement a simple wrapper of absl::variant. network::DataElement has only one member: absl::variant<absl::monostate, DataElementBytes, DataElementDataPipe, DataElementChunkedDataPipe, DataElementFile> variant_; A user needs to check the type and explicitly cast the element to the correct class, to access any information (other than `type`). We rely on checks implemented in absl::variant, so we don't need to have many DCHECKs. This CL also contains the following changes: A) DataElementType.kReadOnceStream is gone, as having two members sharing the same type makes the use of absl::variant difficult. This merges the type to DataElementType.kChunkedDataPipe, and introduced a boolean `read_only_once` in DataElement to distinguish them. B) Removed FetchAPIDataElement, as it seems identical to network.mojom.DataElement. C) Deserialization logic gets more strict. Invalid mojo::pending_remote for kDataPipe and kChunkedDataPipe are now treated as errors. D) Made network.mojom.DataElement a union. E) Added some deserialization tests for network::DataElement. Change-Id: I2c646ead57bc19bee661b711c9c863ce1a5e9c94 Bug: 1156550, 1151865, 1152664 Tbr: koerber@google.com, alexchau@chromium.org, yfriedman@chromium.org, evliu@google.com, ianli@chromium.org, tbansal@chromium.org, karandeepb@chromium.org, alexilin@chromium.org, garykac@chromium.org, charleszhao@chromium.org, inferno@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599731Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#842964}
-
Michael Lippautz authored
Bug: 1056170 Change-Id: I467dbaf29f7474550e2fc17b82c6fc7195c4f84e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627149 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#842963}
-
Tanmoy Mollik authored
Method OnPrimaryAccountCleared is deprecated. So this cl changes these calls to OnPrimaryAccountChanged() Bug: 1158855 Change-Id: I56ea44e66fdd91f9cf81eae822233d792e6927c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622532Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#842962}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4ecb2f5fc58f..0ebc1e8f4c65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kolos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kolos@google.com Change-Id: Ie0d5c7ad00b0b08cbb6740ee2649a925c5d023db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627327Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842961}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610505994-ce0c95957b1d27284e834682f26210d976ec22d1.profdata to chrome-win64-master-1610517435-1554e99a291ef2bcb6f5a0139dcc2bec362b747b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7e851c6840f380e74bb2218345f4de1bcc922afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627069Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 61d100cd. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, smcgruer@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I7aa1a2c05dd2597f4ea0bb3b698349eb0bd1d7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626733Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842959}
-
Hidehiko Abe authored
crrev.com/c/2616981 started to exclude system page from Lacros, but there seems a missing check in the CL. This CL is its follow up. Bug: 1166000 Test: Built locally. Change-Id: Ic3d6b4b49f2a3673abf6efe6202716e7c8592631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626850 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#842958}
-
Jack Franklin authored
It's being removed in https://crrev.com/c/2627267. Bug: chromium:1050549 Change-Id: I686d66c0fdbc00b742f6a05b6d839138954a82d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627407 Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#842957}
-
Jérôme Lebel authored
The goal of this series of patches is to propagate the keychain reload flag that comes with the identity list update notification from GCRSSOService. This flag will be used by AuthenticationService to have a better signal when the identity list is updated by another Google app (when the flag is YES), or if the update comes from Chrome user actions. * crrev.com/i/3513584: Receive the flag from GCRSSOService notification * crrev.com/c/2615421: Add support for the keychain reload flag * crrev.com/i/3470951: Switching FireIdentityListChanged(bool) method =>crrev.com/c/2615538: FireIdentityListChanged() cleanup Bug: 1097080 Change-Id: I7e18bf7747899acde98176ca2ec8e2db347cac67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615538 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#842956}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d98dd8de..03dbe217 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If355faa78be1835cdb9158dbe6563c04e47a0575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626462Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842955}
-
Jonathan Wright authored
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/09efc26aff79..518d81558c79 $ git log 09efc26af..518d81558 --date=short --no-merges --format='%ad %ae %s' 2021-01-12 jonathan.wright Cherry-pick Arm CLZ fixes from upstream Created with: roll-dep src/third_party/libjpeg_turbo Bug: 1160249 Change-Id: Ifb5e6dfbd164098cc8853a4c1b56d25ea506d786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624669Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Jonathan Wright <jonathan.wright@arm.com> Cr-Commit-Position: refs/heads/master@{#842954}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/26ac0bee0167..cc988a955f26 2021-01-13 jacktfranklin@chromium.org Move binaryIndexOf into ArrayUtilities If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I877bad815ab6df1d9fcf6cea746e9cc3a6efe787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627036Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit 9ca977e3. Reason for revert: I suspect this CL caused a failure https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome Two builds: https://ci.chromium.org/ui/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/11124/overview Test 'arc.DragDrop' completed with the following status(es): 'FAILURE' Test 'arc.DragDrop' had the following logs when run: ================================================================================ Failed initializing UI Automator at chromiumos/tast/local/bundles/cros/arc.DragDrop (drag_drop.go:93) at chromiumos/tast/internal/planner.runTestWithRoot.func3 (run.go:755) at chromiumos/tast/internal/planner.safeCall.func2 (safe.go:92) at runtime.goexit (asm_amd64.s:1357) failed installing /usr/local/share/android-uiautomator-server/app-uiautomator.apk at chromiumos/tast/local/android/ui.installServer (device.go:119) at chromiumos/tast/local/android/ui.NewDevice (device.go:91) at chromiumos/tast/local/arc.(*ARC).NewUIDevice (ui.go:16) at chromiumos/tast/local/bundles/cros/arc.DragDrop (drag_drop.go:91) at chromiumos/tast/internal/planner.runTestWithRoot.func3 (run.go:755) at chromiumos/tast/internal/planner.safeCall.func2 (safe.go:92) at runtime.goexit (asm_amd64.s:1357) context deadline exceeded at ??? https://ci.chromium.org/ui/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/11125/overview Test 'chrome_all_tast_tests' completed with the following status(es): 'FAILURE' Test 'chrome_all_tast_tests' had the following logs when run: Original change's description: > [CrOS cellular] Respond to cellular route params in internet page > > Bug: 1163556 > Change-Id: I196b9c9f73fecb169b53ac3d3ed5635a799b7138 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625275 > Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> > Reviewed-by: Azeem Arshad <azeemarshad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842903} TBR=azeemarshad@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,tjohnsonkanu@google.com Change-Id: Icd511320cc5b1df0ad54057e372b4d353fc90778 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1163556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626432Reviewed-by:
-
Takashi Sakamoto authored
Inside RmoveEntryByURLImpl, ReadingListWillRemoveEntry invokes ReadingListManagerImpl::RemoveBookmark. The method removes the node which own the URL. So when invoking entries_-erase(url), url is not available. BookmarkBridge: :DeleteBookmark deletes a reading list item b using url when the bookmark type is BOOKMARK_TYPE_READING_LIST (i.e. node->url()). The deletion invokes ReadingListModelImpl::RemoveEntryByURLImpl with the URL (as const GURL&). Change-Id: I69d6afba8ca8ea72985dd2317db9f6a3a92fefc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616641 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842951}
-
Michael Martis authored
Format is based on services/device/generic_sensor and services/device/usb. Change-Id: Ib21174e9b30ca9f53da90752ff3c423b31d9b57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620739 Auto-Submit: Michael Martis <martis@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#842950}
-
Jason Lin authored
... according to the comment from the UX deck: https://docs.google.com/presentation/d/1MWWejK-y2vnBN3Wg__Kd_LIiAcIF3VctzMowMI3wM4w/edit?disco=AAAAKz06f_U For each VM, there are actually 3 types of notifications: "camera (only)", "mic (only)", and "camera and mic". We have two types of tray items: "camera", and "mic". The "camera" tray item is displayed when there is a "camera" and/or "camera and mic" notifications. The non-trivial part of this cl is that the "camera" tray item now used a different message depending on whether there is a "camera and mic" notification or not. To do this, VmCameraMicManager now exposes the exact type of the notification, and ash will pass this information down to CameraMicTrayItemView. Bug: b/167491603 Change-Id: I7acd1aa87d463930406b917da7dfd0ddbacf799b Fixed: b/177270109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622361 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Daniel Ng <danielng@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842949}
-
Finnur Thorarinsson authored
Video support for the photo picker is currently behind an (off by default) feature flag. We'd like to run an experiment in 89 to see how well it works, but what has been blocking us is that we still have some work to do to find the best way of producing animated tiles for video clips. Video support is going to be a big improvement in the user experience for uploading media to the web and we shouldn't hold off on experimenting with it just because we haven't finalised if/how to produce animated thumbnails for the video tiles. Furthermore, it is increasingly likely that animated tiles will only be available using APIs that were added to later versions of Android, so users on older versions would never enjoy the benefits of animated tiles anyway (hence don't need to wait for them). The purpose of this change is therefore to make sure that when we turn on video support (as an experiment), we don't have to turn on animated tiles as well (it is off-by-default). Bug: 895776, 656015 Change-Id: Id5b4d422136ea1945d47bbd7fb672a56706d3b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616225 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#842948}
-
Yuki Shiino authored
This reverts commit 201f15f1. Reason for revert: Suspicious about causing a test breakage of WindowOpenApiTest.PopupBlockingExtension. https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/22177/overview Original change's description: > Create standard icons on shelf for non-app icons. > > AppService creates standard circle icons for all apps. However, there > are a few cases that icons on shelf are not app icons, e.g.: > 1. Task manager > 2. A few extensions show icons when open a new window, e.g. google > hangouts. > > This CL create standard circle icons for them when they are shown on > shelf. > > Modify TaskManagerView to create standard icon when running in Chrome > OS. > > Modify ChromeLauncherController::OnAppImageUpdated. If the icon is not > loaded by AppServiceAppIconLoader (which loads the standard circle > icons), create standard icons. > > BUG=1162514 > BUG=1142373 > > Change-Id: Ibfe40c33944a1120ca9c991c4953d0da906ee2e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624273 > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842874} TBR=xiyuan@chromium.org,sky@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,nancylingwang@chromium.org Change-Id: I6e0dbef6a173a179d79e39cebbd4a4f78f15bcfb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1162514 Bug: 1142373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626821Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#842947}
-
Sigurd Schneider authored
DevTools front-end CL: https://crrev.com/c/2622195 Bug: chromium:1069378 Change-Id: I51a66ebe85e2036a0939364e0c1e4cb9d525429a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622114 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842946}
-
