- 29 Sep, 2020 40 commits
-
-
Esmael El-Moslimany authored
cl/333509607 Bug: 1076506 Change-Id: I265b7655678d0af4b46a72ed715152e531d11b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433998 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#811637}
-
Richard Knoll authored
Notifications should use the proper background color so the text on them is readable. This also derives the inline settings, actions row and large image background colors from that native background color so light and dark themes work correctly. Screenshots: https://imgur.com/rxq48G7 Bug: 1113313,1065604 Change-Id: I20b833a3a157eabc0c7b03385a4ed88651cffa08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396297Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#811636}
-
Sylvain Defresne authored
Bug: 1018739 Change-Id: Idbdb1544c64e673a1138d3d9af825e135a680fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437812 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#811635}
-
Alex Rudenko authored
If a constructed stylesheet contains rules with 'background-clip:text;', InspectorStyleSheet won't be able to parse them properly, causing the rule diffing algorithm to run. When the number of rules to diff is high, it causes performance problems when opening DevTools. This CL skips the diffing for constructed stylesheets, because the order of rules for constructed stylesheets is known. Ultimately, this workaround would not be needed when InspectorStyleSheet can parse the CSS rules properly. See crbug.com/1132778, crbug.com/604023. Fixed: 1131113 Change-Id: I5c38a52bfb2b04334530c292cd8b4e15c9f6c2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435304Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#811634}
-
Daniel Vogelheim authored
The current code only enables/disables eval (& Function constructors) in workers wholesale, and never registers a callback. This means that the functionality that relies on the callback doesn't work in workers. This patch registers the callback, and removes two assertions that are now no longer true. Bug: 1126472 Change-Id: I3996431acd97fd6f62e8e09ed44732e8eaa438f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426645Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#811633}
-
Javier Ernesto Flores Robles authored
Bug: 1130571 Change-Id: Id3f2ed7e38c1e6863755730c7e02a3380221e336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435094Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#811632}
-
My Nguyen authored
Because of the presence of iron-list, there's a horizontal line separating the buttons from the list, making the padding difference look very obvious. Update all to 20px. Spec has the padding left and right at 24px but current dialog body padding is 20px, so sticking to that. Spec: http://go/cros-lang-settings-figma Current view: http://screen/4EAq4TaqjwEyuTq Bug: 1113439 Change-Id: Ief84905331ba8965854b34252308161cd3bf6eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437069 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#811631}
-
Morten Stenshorne authored
This doesn't make a lot of difference to the NG layout engine (except that consumed block-size may now be larger than the block-size of the preceding fragments combined). The reason for this change is so that we'll write the correct offsets back to the legacy tree. This was wrong for overflowing content whose containing block ended in an earlier fragmentatainer, and that caused trouble for things like offsetTop. This change requires us to replace some logic in the fieldset layout algorithm that calculates the amount of space that a legend "eats" from its containing fieldset. It's actually slightly simpler now. :) Bug: 829028 Change-Id: I84c6188e61ee3e9eaff80f595935768fa68412bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429027 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#811630}
-
Kuo Jen Wei authored
Bug: 1123750 Test: Manually Change-Id: I30ed85248a8985f27ecf51b2a9a88a8108320a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437542 Commit-Queue: Inker Kuo <inker@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#811629}
-
Christian Biesinger authored
Unfortunately this required adding *another* parameter to ComputeOutOfFlowInlineDimensions because we now need two different MinMaxSizes. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1098475 Change-Id: If2c05ce09292bc856e04c7a18950fbdd35579572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430828 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#811628}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0d33d0e062db..bd99a610db07 2020-09-29 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1714fd3ee16592580b660c26ee03686da195a604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437942Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811627}
-
tby authored
This CL contains a handful of fixes that prevent chip results appearing. - On login, query ItemSuggest once, so we have results ready to display the first time the launcher is opened. This is mostly copied from drive_quick_access_provider. - Change some display and result type enums for chip results, needed to rank and display them correctly. - Use a separate schema for chip results, which prevents them being deduplicated with list results. Bug: 1034842 Change-Id: I4da6cc219e19ad05383acdd2f98f64c6b4451a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434111 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#811626}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601337561-307983a438d89a0d060ed0a79e008eada61629c3.profdata to chrome-linux-master-1601358844-b8defbe977309018021c72a700e18c84f94d16d4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I08e04fc681663258e9743b996aad99d33029c88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438110Reviewed-by:
-
Mirko Bonadei authored
No-Try: True Bug: None Change-Id: I8f9f2fa4c83b6764710725026af0e61e0480d807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436811Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#811624}
-
Fredrik Söderqvist authored
Hoist the actual CullRect intersection test into the actual painter and only share the 'can use cull rect' test. This allows moving the check for hidden containers into a more appropriate place thus avoid checking for them when they are guaranteed not to exist. Is also avoids calling ShouldUseInfiniteCullRect() twice in SVGContainerPainter. Align SVGImagePainter to SVGShapePainter by using LocalSVGTransform() rather than LocalToSVGParentTransform() since they are both 'leaves'. Bug: 109224 Change-Id: I92af163bb8d82a22c37f2cb58911240c07e6402b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431929Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#811623}
-
Monica Basta authored
This CL uses |SetupBundledWebUIDataSource| to optimize network requests for the profile picker main view and the profile creation flows. Before: Requests: 75 requests Time: 5.28s Optimized: Requests: ~22 requests Time: 601ms Bug: 1129395 Change-Id: I51147a4f3cd57f1dc43d6ec3ca339e9df2781c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416512Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#811622}
-
Noel Gordon authored
Class ImageLoader is singleton. It creates a new PiexLoader() when its singleton instance is created, then passes it to the only user of that PiexLoader, namely ImageRequestTask, on each image loader request. But the PiexLoader passed is a singleton instance, because ImageLoader is a singleton instance ;) Remove this leaky abstraction. ImageLoader does not need to know about PiexLoader. That is an internal detail of ImageRequestTask, and it can create its own PiexLoader() singleton instance. Do that, and fix BUILD rule deps: image_request_task depends on piex_loader, end of story. No change in behavior. Covered by existing tests. Bug: 1132695 No-try: true Change-Id: I2b5ccfabe24d7ccaca2ed0ef01d2266b6e1ff25d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437579 Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#811621}
-
Mason Freed authored
This CL adds "width: max-content" to the view-source <table> element, so that long lines never get broken. Also, the CL at [1] made better changes to the view-source CSS document which made the ones here obsolete. So this CL cleans up the inline styles on the <table> element. Bug: 920571 Change-Id: I06d0509b71470cdb1baff8e8ada82b4cd366bbd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435807 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#811620}
-
Wei-Yin Chen (陳威尹) authored
Bug: 1121369 Change-Id: I17e0bda0b30c05d1a1f751d8b77215bd7b9cff38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373287 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#811619}
-
Alex Danilo authored
Replaces the example values for a single file copy/move description. Bug: b/168813583 Change-Id: I8e3ccea35f500391d8b1df502085db4d1dc4572a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437572Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#811618}
-
Victor Hugo Vianna Silva authored
- Order Polymer properties and methods according to the style guide[1]. - Ensure @private and @return annotations are present. - Remove unused imports. [1] https://source.chromium.org/chromium/chromium/src/+/master:styleguide/web/web.md Bug: None Change-Id: I4c9c64486944f874cf7c594a8dc43def07e1218c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431516 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#811617}
-
Alison Maher authored
In CL:2412728, percentage block-size was updated to resolve against the computed content-box block-size of the multicol container (not the columns). This change makes the same change for the OOF fragmented descendants. Because the multi-col isn't the container of the OOF, updating this doesn't have an affect on OOF percentage resolution. Rather, the containing block for the OOF element will be used for percentage resolution. This, however, was also broken because we were using the block size of a single containing block fragment rather than the total block size of the containing block. To fix this, we now use the LayoutBox of the containing block to calculate the total consumed block size in order to get the correct percentage resolution size for OOF elements. Bug: 1079031 Change-Id: If584de09a7611ad8b8d4afc5c8205adf159ee7fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422705Reviewed-by:
Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
-
Francois Beaufort authored
This CL adds similar tests to zoom for pan and tilt constraints when calling applyConstraints with invalid values. Bug: 934063 Change-Id: I0d7926ba5c887604fc77c0854e3d3fccea784f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435640Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#811615}
-
Alex Rudenko authored
The network layer might provide the default MIME type for 304 responses. This CL changes the network agent to take the MIME type from the cached resource if the response status code is 304. Bug: 1014906, 1066415 Change-Id: I530411f485b9bef1521d46218513e5b070727e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435090Reviewed-by:
-
Hans Wennborg authored
Zlib has a lot of parameters that can be used for deflate compression. This makes the fuzzer cover a much larger set of them. It also streams the input in an attempt to cover more interesting code paths. I have verified that this allows the fuzzer to hit the issues in the first two linked bugs. Let's see if it finds something else too :-) Bug: 1113142, 1113596, 708726 Change-Id: Ib345460c25787ee639b626cc37fc887017d65246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433344Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#811613}
-
Hidehiko Abe authored
This reverts commit 6dbadbf0. Reason for revert: build broken should be fixed now. Original change's description: > Revert "exo: Move XkbTracker from WaylandKeyboardDelegate to Seat." > > This reverts commit c1744bc0. > > Reason for revert: Broke build: https://crbug.com/1132766 > > Original change's description: > > exo: Move XkbTracker from WaylandKeyboardDelegate to Seat. > > > > This is preparation to share XkbTracker with wayland IME server. > > > > BUG=1123705 > > TEST=Built locally. Run exo_unittests. > > > > Change-Id: I7859c2193578cc5a18fa39a96c3fe86d2f39f4dc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428505 > > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > > Reviewed-by: Jun Mukai <mukai@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#810863} > > TBR=mukai@chromium.org,hidehiko@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1123705,1132766 > Change-Id: I92c8df6383ea569ca2b88780c6017c619e26d1af > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434097 > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811383} TBR=mukai@chromium.org,alemate@chromium.org,hidehiko@chromium.org,afakhry@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1123705 Bug: 1132766 Change-Id: I61fe9b0de93f4de76dec991be699963e31e9d03b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437675Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#811612}
-
Alex Rudenko authored
This is a reland of b37c27dc with an addition of requesting an animation frame to avoid flakiness. Original change's description: > Enable test for persistent overlays > > The test has been implemented in [1] and now, when DevTools rolled, > it can be enabled. > > [1]: crrev.com/c/2400478 > > Bug: 1109224 > Change-Id: I43e4dffbf7d50eae856b5c78290768079094ab69 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435188 > Reviewed-by: Mathias Bynens <mathias@chromium.org> > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811260} Bug: 1109224 Change-Id: I5f40fe8855d69870fab7253f9315d5ffde004dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437371Reviewed-by:
-
Rushan Suleymanov authored
This CL also removes SyncReuploadBookmarkFullTitles from fieldtrial_testing_config.json. Some tests are fixed to pass at any state of the feature toggle SyncReuploadBookmarkFullTitles. Bug: 1061411 Change-Id: I021fd4eb170fbf132b51ffa7074f51c3d18a7a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426703Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Yi Chou authored
Add an UMA report to see the result of InvalidateDirCryptoKey operation. And the CL which adding code to log the metric is crrev.com/c/2400158 BUG=chromium:1116109 Cq-Depend: chromium:2400158 Change-Id: Iab3cac61fd9341e1ad3536f4b0dca823dea30ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432167Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: joe Chou <yich@google.com> Cr-Commit-Position: refs/heads/master@{#811609}
-
My Nguyen authored
Spec: http://go/cros-lang-settings-figma Change device language: http://screen/5tJTJeKbQqqPLBb Add languages: http://screen/A4KkBzEiSFdTzJM Add input methods: http://screen/7ukfaWuZv4fJMpv Border-radius of the underline is not yet updated. Bug: 1113437 Change-Id: Ie4c9828a2ed71ba3b67aef89bbe848c2c5237756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436969Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#811608}
-
Minoru Chikamune authored
Previously, the CL below introduced new trace category for AgentGroupScheduler. The new category was disabled-by-default-agent_scheduling_group. https://chromium-review.googlesource.com/c/chromium/src/+/2414329 This CL folds the category into existing disabled-by-default-renderer.scheduler because it's closely related. Bug: 1105403 Change-Id: I66ea1c4f076b51c6b43e0ac279668969d33f177b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437672 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#811607}
-
Adam Rice authored
Remove the feature flag for Transferable Streams and turn it on by default. Also remove the web test that I created to stop us shipping it by accident, since now we are shipping it on purpose. See the intent to ship thread at https://groups.google.com/a/chromium.org/g/blink-dev/c/1LStSgBt6AM/m/sJaTciPKBwAJ and the completed TAG review at https://github.com/w3ctag/design-reviews/issues/551. BUG=894838 Change-Id: I56f8891bd1051202ef68bb4623ad8bec53045dff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428509Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#811606}
-
Minoru Chikamune authored
[MBI] Revert: Make ThreadTaskRunnerHandle::Get() return currently active AgentGroupSchedulerImpl's default task runer. revert target: https://chromium-review.googlesource.com/c/chromium/src/+/2413728 The reason of revert: 1. The previous CL probably relates to this bug report: https://bugs.chromium.org/p/chromium/issues/detail?id=1133071 2. We want to make sure of these two things. - Ensure that ThreadTaskRunnerHandle::Get return value is not stored in the place where it can be accessed by other AgentGroup (e.g. TLS, shared data structures, etc). - Make sure that ThreadTaskRunnerHandle::Get does not return per-thread task runner (as otherwise it can lead to propagation of incorrect AG attribution via chained TTRH::Get calls). [related design doc] https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A Bug: 1133071, 1105403 Change-Id: Ifc47179c081bad95f1b8e96d7ef3581a7a64402a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437536Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I65aefa50029d343f21beb321df3d95fd39fabd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432768Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#811604}
-
Koji Ishii authored
r810360 crrev.com/c/2429204 changed to `white-space: pre` but it was not effective because we have: white-space: pre-wrap !important; in the UA stylesheet for view-source. This patch updates the UA stylesheet accordingly. Verified this change prevents line wrapping in content_shell. Note the "!important" has been there since 2007, in the initial commit of this file[1], but the CL message does not explain why it is needed. This patch removes it because I do not find it is necessary. We can bring it back if we find it is necessary for any reasons. [1] https://source.chromium.org/chromium/chromium/src/+/0e882e3da67c5efbd3b292a643d79867a4968950 Bug: 920571 Change-Id: Ic3221778142f697e7baa82725b3d54db397e3933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432706Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#811603}
-
Tim Song authored
This is a reland of ac56b3e7 Original change's description: > [CrOS PhoneHub] Add PhoneHubUiController. > > This class translates the PhoneHubManager state into the corresponding > UI state and view that is shown in the tray bubble. Each state has > it's own view class and the PhoneHubTray bubble transitions through > these content views as the UI state changes. > > This CL also refactors PhoneConnectedView into it's own class. > > BUG=1106937,1126208 > > Change-Id: Ie012077a1905f80be91fbfb0b084d89219bd6c26 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427060 > Commit-Queue: Tim Song <tengs@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810942} Bug: 1106937 Bug: 1126208 Change-Id: Idd71d6828f4a4bee3ecbbd5b598d57be3de2fadf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436758 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
-
Xing Liu authored
This reverts commit 1be8a3ba. Reason for revert: Still crash. Original change's description: > Download notification: Fix a crash that startForeground is not called. > > If stopForeground is called between startForegroundService and > startForeground. startForeground will not be called since we clear the > cached service object. This will lead to a crash on O_MR1+. > > Android can reuse the service binder object when this happens. > > Bug: 1121096 > Change-Id: Ic4088af174ca9561714442b29c2e6162995ddc51 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429635 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810857} TBR=dtrainor@chromium.org,qinmin@chromium.org,xingliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1121096 Change-Id: I59ae44f21cbb0ae41f01d698c7c1faddccd2156c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436784 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811601}
-
Nick Diego Yamane authored
xdg-decoration spec says: > [...] clients are responsible for preventing configure loops and > must make sure not to send multiple successive set_mode requests > with the same decoration mode. which wasn't being done so far and issues like crbug.com/1131662 were observed. This patch fixes it by avoiding re-sending subsequent set_mode requests with the same decoration mode. Additionally a few cleanups and style fixes are made. R=msisov@igalia.com Bug: 1131662 Change-Id: I7cb64557775fa8562284067fb90d8cba0dea5d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436851Reviewed-by:
Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#811600}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /chrome/browser/ssl This CL was uploaded by git cl split. R=estark@chromium.org Change-Id: Ifc807a2bc88c612e3099ec92c5a14d693a2fccb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435581 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#811599}
-
Jon Mann authored
This performs a one-time re-enabling of the Messages feature if the PWA is installed but the feature is in the disabled state. This also prevents showing the pairing lost notification if unpaired when re-enabled. Bug: 1131140 Change-Id: I1114cab793c9bad4387c6edf886bcbd735fa7ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432109 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#811598}
-
