- 04 Dec, 2017 40 commits
-
-
Francois Doray authored
Support deleting a window with tracked occlusion from LayerAnimationObserver::OnLayerAnimationEnded. Previously, if a window with tracked occlusion was deleted from LayerAnimationObserver::OnLayerAnimationEnded, an invalid memory access occurred in WindowOcclusionTracker::CleanupAnimatedWindows (because the window was deleted before being removed from |animated_windows_|). This CL fixes this problem by removing the Window* from |animated_windows_| in WindowOcclusionTracker::OnWindowDestroyed. Bug: 668690 Change-Id: I77749c79d72d7cebc3a77647552605c8abec3abb Reviewed-on: https://chromium-review.googlesource.com/806356 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#521420}
-
Morten Stenshorne authored
In an engine with subpixel support, these tests would render ever so slightly "incorrectly", compared to the ref, which assumed that all values less than 1px be rounded down to 0. Bug: 788337 Change-Id: I5810a9620763fa0065ee480ed953a1426c95cf93 Reviewed-on: https://chromium-review.googlesource.com/806173Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#521419}
-
Erik Luo authored
Relevant V8 CLs have landed in this autoroll: https://chromium-review.googlesource.com/c/chromium/src/+/805157 Bug: 700624, 727514 Change-Id: I73392015ee47bb79499cc7ee8b447673c00387da Reviewed-on: https://chromium-review.googlesource.com/806258Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#521418}
-
Michael Spang authored
The tracing request format currently in use is deprecated and does not support enabling some features such as system tracing. Switch to the new format. This requires us to tokenize the category filter ourselves; this is done using the same algorithm as chrome. This also fixes a regression where the category filter was set to '"*"' (double quotes included) which does not work properly, disabling all events. We should use the empty string, which simply means to apply the defaults. The android backend appears to be prepared to handle this as well (mapping it to "_DEFAULT_CHROME_CATEGORIES"). BUG=786091 Change-Id: Ic60a3db7f4decc5ee046ce50bfc58d3c22211558 Reviewed-on: https://chromium-review.googlesource.com/804857Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521417}
-
Greg Thompson authored
r516772 was the last of many commits that resolved a number of problems that made this test suite flaky on Windows. This CL enables tests that had been disabled over time due to flakes, yet now seem to run okay. BUG=133341,751031,751543,764415,789913 This CL was uploaded by git cl split. R=sky@chromium.org Change-Id: I753c741a9194f489f072cd86d72407a1294150c3 Reviewed-on: https://chromium-review.googlesource.com/784937Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#521416}
-
Greg Thompson authored
r516772 was the last of many commits that resolved a number of problems that made this test suite flaky on Windows. This CL enables tests that had been disabled over time due to flakes, yet now seem to run okay. BUG=69475,129235,147579,419468,764415 This CL was uploaded by git cl split. R=sky@chromium.org Change-Id: I99053d0c38c27a0ad91b426214bff6365c3b4a5e Reviewed-on: https://chromium-review.googlesource.com/784934Reviewed-by:
-
Greg Thompson authored
r516772 was the last of many commits that resolved a number of problems that made this test suite flaky on Windows. This CL enables tests that had been disabled over time due to flakes, yet now seem to run okay. BUG=499858,764415 This CL was uploaded by git cl split. R=sky@chromium.org Change-Id: Ic884babd5f4814fdf173a18fe91c6e71ce828f92 Reviewed-on: https://chromium-review.googlesource.com/785018Reviewed-by:
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/17995a9f1282..ad64abd69aed $ git log 17995a9f1..ad64abd69 --date=short --no-merges --format='%ad %ae %s' 2017-12-04 agable git-cl: Fix 'git cl issue --reverse' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: Ieae5e041e0959596cb6b85d3ca289b4d27a7740f Reviewed-on: https://chromium-review.googlesource.com/806432Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521413}
-
Denis Bessonov authored
The reason for change --------------------- The tests of EXTMultisampleCompatibilityTest will crash if CollectBasicGraphicsInfo fails. Crash occurs in the following call graph: TEST_F(EXTMultisampleCompatibilityTest, (any test)) gpu::EXTMultisampleCompatibilityTest::IsApplicable() gpu::GPUTestBotConfig::CurrentConfigMatches("AMD") gpu::GPUTestBotConfig::LoadCurrentConfig(NULL) // Due to CollectBasicGraphicsInfo failure, // function makes no call SetGPUInfo() and returns true. // This will result in empty gpu_vendor_ vector. gpu::CollectBasicGraphicsInfo(&my_gpu_info) // Returns false for any reason gpu::GPUTestBotConfig::Matches(const std::string& = config_data) gpu::GPUTestBotConfig::Matches(const GPUConfig& = config) // BANG! Segfault trying to access gpu_vendor()[0] The example of situation, where CollectBasicGraphicsInfo fails, is a test Mac with no display connected. In this case, the internal call graph of CollectBasicGraphicsInfo will cause the failure: gpu::CollectBasicGraphicsInfo(&my_gpu_info) angle::GetSystemInfo(&system_info) // Will return false after calling GetActiveGPU() angle::{anonimous namespace}::GetActiveGPU(...) // GetEntryProperty() following CGDisplayIOServicePort will // return false. CGDisplayIOServicePort(kCGDirectMainDisplay) // Will return MACH_PORT_NULL if display is not connected. Suggested change ---------------- Check that gpu_vendor_ is empty and bail out early in gpu: :GPUTestBotConfig::Matches(const GPUConfig&) Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id8f325e4155ee928f2988c50240d7517641779f8 Reviewed-on: https://chromium-review.googlesource.com/788851 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#521412}
-
Aleks Totic authored
Bug: 740993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I6deb54167769a639f2d66a01fb1f2ae13e85ba28 Reviewed-on: https://chromium-review.googlesource.com/804955 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#521411}
-
Mohamad Ahmadi authored
This class is to be used in ChromeAutofillClientIOS and PaymentRequest for lazy instantiation of the AddressNormalizerImpl Bug: 788229 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibe57b150e0aeea1777fab5e5a5aebecfd04fdfc3 Reviewed-on: https://chromium-review.googlesource.com/797735 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#521410}
-
Sophie Chang authored
Bug: 783365 Change-Id: Ib19d2453ce4079b2367d8593dd0d1bf1c7fec301 Reviewed-on: https://chromium-review.googlesource.com/762101Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521409}
-
Johann authored
msan builds skip optimizations because of past issues instrumenting the assembly. R=tomfinegan@chromium.org Change-Id: I4ec4195687b54b85e12e21bbb16666ef4dcb8658 Reviewed-on: https://chromium-review.googlesource.com/806634 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Cr-Commit-Position: refs/heads/master@{#521408}
-
Alexis Menard authored
The spec was updated some time ago clarifying how any-hover: none should match (see https://github.com/w3c/csswg-drafts/commit/98f494677a265df504eee67d587329478b8ce6ba). This patch aligns the behavior with the spec clarification by making sure that 'any-hover:none' will only evaluate to true if there are no pointing devices, or if all the pointing devices present lack hover capabilities. The previous implementation was reading the specification literally by returning the union of the capabilities of the input devices connected on the machine. Windows, Linux and Android are now updated in this patch. This technically has a compatibility impact as we're changing behavior but @rbyers and myself did a rapid search of top websites and didn't find anything relevant to the change. BUG=778694 Change-Id: I230a44f29707e660515b4d27a1bc88552aa73032 Reviewed-on: https://chromium-review.googlesource.com/803662 Commit-Queue: Alexis Menard <alexis.menard@intel.com> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
-
Kurt Horimoto authored
This CL converts FullscreenController to a KeyedService vended through FullscreenControllerFactory. Bug: 778016 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2d81964223cff6a16907ebbcbd9a2b357a3ccae0 Reviewed-on: https://chromium-review.googlesource.com/804750Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#521406}
-
Francois Doray authored
Previously, a DCHECK failure occurred if a WindowObserver or a LayoutManager changed a tracked window after Window::AddChild() added it to a root but before WindowOcclusionTracker::OnWindowAddedToRootWindow was notified. With this CL, the DCHECK is replaced with an early return. We rely on WindowOcclusionTracker::OnWindowAddedToRootWindow to mark the new root as dirty shortly after the early return. Bug: 668690 Change-Id: I0030869c01bb2955bcd8c31b7e5212cb404dc794 Reviewed-on: https://chromium-review.googlesource.com/804120 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
-
Robert Hogan authored
The Blink Rename has made most uses of this-> unnecessary. The relevant variable names no longer clash with the getters. Bug: 789653 Change-Id: I016817495e3192c6bf2d226afb2901df4b4c90c7 Reviewed-on: https://chromium-review.googlesource.com/805255Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Robert Hogan <robhogan@gmail.com> Cr-Commit-Position: refs/heads/master@{#521404}
-
Stephen Chenney authored
When layers are squashed they currently lose their border radius clips. Fix that by using ClipRects instead of IntRects in the sqaushed layer clipping code, and gathering the clips appropriately. Based on https://chromium-review.googlesource.com/c/chromium/src/+/772081 by chrishtr@. R=chrishtr@chromium.org Bug: 761298 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I58a4c8bc785a5cea562a7de52ba24ee1600c9cff Reviewed-on: https://chromium-review.googlesource.com/797337 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521403}
-
stkhapugin@chromium.org authored
The DCHECK was added defensively for the developers to make sure that the animation looks fine if one day it's hit. I've checked that the animation looks fine and nothing jumps around, hence removing it. to the tab switcher and rotating the phone, then choosing one of the tabs. The toolbar should be animated correctly. Specifically test iPhone X. Bug: 788742 Test: Enable Tab switcher presents BVC experimental flag. Try going Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib906b4aaa1ac2b2e7eefa3f82931fa59a4dd3ac8 Reviewed-on: https://chromium-review.googlesource.com/806335Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521402}
-
tzik authored
This CL fixes the extra parameter handling on BindLambdaForTesting. On the previous implementation, it had dropped parameters on the resulting Callback::Run. So it used to work only for no-parameter ones. Bug: 789805 Change-Id: I0b708382e206444d1ed9fe8cc932dd7826b02b00 Reviewed-on: https://chromium-review.googlesource.com/804908Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#521401}
-
Weidong Guo authored
Bug: 791199 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I22cfd969f415d32a5bd2aa135e610a55ddab857c Reviewed-on: https://chromium-review.googlesource.com/804939Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#521400}
-
Scott Violet authored
When the ui-service is running without viz we need to run some of the classic behavior (around creating frame ids). This patch updates a handful of sites. BUG=786453 TEST=none Change-Id: I61bef556e8fb21e467741619736067df01c3af88 Reviewed-on: https://chromium-review.googlesource.com/804194Reviewed-by:
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/a9f469b2184d..86de7e898a63 $ git log a9f469b21..86de7e898 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6671a6028d36fb02e9da7f59fc978aab7288330f Reviewed-on: https://chromium-review.googlesource.com/806428Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#521398}
-
dpapad authored
Bug: 791195 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I129cfb90b0e0feb7fda89a431063fdd92de054d3 Reviewed-on: https://chromium-review.googlesource.com/804679Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#521397}
-
Tao Bai authored
This class is shared between autofill and password manager to track the user's interaction and notify observer of change and submission of the form. This patch just adds the FormTracker, tried not change behavior of autofill or password manager. Also add some TODO which will be addressed in follow up patches. Bug: 771298 Change-Id: I56bdade1ba70bb0564b6507f1a6d2014ae87fa24 Reviewed-on: https://chromium-review.googlesource.com/767619Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 786332 Change-Id: I60a347a77fe9c948e63e8b38086bc2969dee32de Reviewed-on: https://chromium-review.googlesource.com/778755Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521395}
-
Jüri Valdmann authored
Although perhaps not strictly required by the specification, it is at least quite clearly suggested that navigator.language should equal the first element of navigator.languages (see note in [1]). [1]: https://html.spec.whatwg.org/multipage/system-state.html#language-preferences Changes in behavior: - navigator.language: Previously returned DefaultLanguage() which may or may not have matched the first element of navigator.languages. Now always returns the first element from navigator.languages. - navigator.languages: Previously would return an empty list if ChromeClient's AcceptLanguages() happened to return an empty string. Now always returns a non-empty list (the existing DefaultLanguage() fallback is extended to cover this case too). Bug: 351715 Change-Id: Id945ec3958180991c0abcfec4e5c191d3cb5e9cf Reviewed-on: https://chromium-review.googlesource.com/581295 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#521394}
-
John Z Wu authored
This code has been moved to AccountFetcherService and AccountInfoFetcher. Bug: Change-Id: I5c0cbf8863e4d7726ad1799551208a4e54f4dfd6 Reviewed-on: https://chromium-review.googlesource.com/801662Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#521393}
-
Jay Civelli authored
Changing the SafeXmlParser so it ignores nodes like DTDs and processing instructions. Bug: 789838 Change-Id: I0bf4a07509309f9e7720fdcea6283542a0b489ff Reviewed-on: https://chromium-review.googlesource.com/804946Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#521392}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/ea6138253bda..bee6cacc5435 $ git log ea6138253..bee6cacc5 --date=short --no-merges --format='%ad %ae %s' 2017-12-04 benjaminwagner Merge UBSAN_float_cast_overflow into ASAN. 2017-12-04 egdaniel Add support for internal gl format in GrGLTextureInfo 2017-12-04 kjlubick Make new CQ jobs experimental Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: I0e67079cc0c72c97e64719ad274ba6e47d0d6655 Reviewed-on: https://chromium-review.googlesource.com/806427Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521391}
-
Mike Baxley authored
A few things were tagged as candidates to move to shared code when creating EarlGrey tests, but these should not move. Bug: 638674 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib80a06abc2c23d729573c594a14cf324284c6591 Reviewed-on: https://chromium-review.googlesource.com/806694Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#521390}
-
Francois Doray authored
This CL removes the following histograms which were recorded before each individual tab discard: - Tabs.Discard.TabCount - Tabs.Discard.InitialTime2 - Tabs.Discard.IntervalTime2 And replaces them with histograms recorded when an urgent discard request is received, before any tab is discarded: - Discarding.Urgent.NumAliveTabs - Discarding.Urgent.TimeSinceStartup - Discarding.Urgent.TimeSinceLastUrgent Also, metrics::RecordMemoryStats() is called when an urgent discard request is received rather than before each individual tab discard. The reason for this change is that we are interested in knowing how often urgent discard requests occur and what leads to them. We don't care how often we proactively discard tabs and we don't need multiple histogram samples when we discard multiple tabs in response to a single discard request. Bug: 775644 Change-Id: Ic603a904dc9635b12b3204c1e12bc293c4dcbaf7 Reviewed-on: https://chromium-review.googlesource.com/786295Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#521389}
-
Nicolas Pena authored
This CL fixes the 3 remaining tests in longtask-timing that Timeout. The iframes are added from script instead of html because this seems to make frame attribution easier. The cross-origin tests are changed to use the sandbox property of iframes instead of changing the src. Bug: 754819 Change-Id: I1dfd0e3d7c1d2f29feb0eba5e98b683faa5ab44c Reviewed-on: https://chromium-review.googlesource.com/798155Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#521388}
-
Mike Baxley authored
Remove logic that manually verifies the size class, and use the utility method that does it. Bug: 638674 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6f7568a8d0dde822db1c1e496dd36de0344d04db Reviewed-on: https://chromium-review.googlesource.com/806235Reviewed-by:
-
Jiaquan He authored
After migrating app_list from Chrome to Ash, we'll need to pass StringOrdinal objects between processes for setting app list item positions, e.g. AppListModel::SetItemPosition. This commit creates a mojo struct for StringOrdinal so that //ash/public/interfaces:interfaces_internal can depend on it. Bug: 733662 Change-Id: I96bbd81a82a53462aa0eb2cdcf9e327045a70051 Reviewed-on: https://chromium-review.googlesource.com/780696Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#521386}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/c5bfeec86aa7..a827770faf5c $ git log c5bfeec86..a827770fa --date=short --no-merges --format='%ad %ae %s' 2017-12-04 dsinclair Shuffle XFA code around 2017-12-04 dsinclair XFA JS method cleanup 2017-12-04 dsinclair Remove XFA isolate tracker 2017-12-04 thestig Fix nits in CPDF_Type3Font. 2017-12-04 dsinclair Remove unused XFA code 2017-12-04 thestig Break out CFX_ImageTransformer mask calculations. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7cabbea48671f114fa5da31107629a8062fe6590 Reviewed-on: https://chromium-review.googlesource.com/806422 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521385}
-
Philip Jägenstedt authored
https://github.com/w3c/web-platform-tests/pull/8533 has been merged and the test confirmed to be working locally if imported. It will be imported by the next automatic import process. No-Try: true Change-Id: Ia73bbe23f21dca58e66ccfd095efb862ec3e94c4 Reviewed-on: https://chromium-review.googlesource.com/805213Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#521384}
-
Dave Tapuska authored
We were not waiting for the GPU to finish its swap before stopping the tracing. Hook up some listeners to latency info coming back and terminate the run loop when we find the terminal component we are looking for. BUG=789096 Change-Id: I2b8336b8568c8d513d60f2314c4a3b7703416a66 Reviewed-on: https://chromium-review.googlesource.com/802017 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Robert Sesek authored
With Breakpad, the crash key storage is stored in a static global, and having the target be a static_library resulted in having multiple copies existing in the component build. This also changes the Breakpad crash key storage to be lazily initialized, which matches what Crashpad does after https://chromium-review.googlesource.com/c/crashpad/crashpad/+/793981. The storage is still initialized deterministically in the static release build, but is done to support unit tests. Bug: 598854 Change-Id: Ic6f100fd0310545fe2697152bd076846153f16d2 Reviewed-on: https://chromium-review.googlesource.com/802274Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#521382}
-
Ojan Vafai authored
This reverts commit 0ea77a78. Reason for revert: Caused crashing browser_tests. ExtensionApiTest.Debugger ExtensionApiTestWithSwitch.ExtensionDebugger https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/64978 Original change's description: > [DevTools] Switch shared worker inspection from routing id to SharedWorkerHost > > This is a preparation to replace routing id + legacy IPC with Mojo interface > retrievable from SharedWorkerHost. > > Temporarily duplicated some code from WorkerDevToolsAgentHost, which > makes it possible to migrate shared and service workers separately. > > Removed a test for WORKER_STATE manipulations altogether with the state itself. > > Bug: 776009 > Change-Id: Id884f4f5009eb70148251c94cae9629d5a1f6e8e > Reviewed-on: https://chromium-review.googlesource.com/783110 > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Tsuyoshi Horo <horo@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521277} TBR=dgozman@chromium.org,horo@chromium.org,alph@chromium.org Change-Id: I263fe6e0f30e3c20fbb91e4a55797aadd9624775 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 776009 Reviewed-on: https://chromium-review.googlesource.com/806814Reviewed-by:
Ojan Vafai <ojan@chromium.org> Commit-Queue: Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#521381}
-
