GitLab

Move the task of managing the task-runners for the worker-thread/main-thread in
a common implementation in WorkerThreadMessageFilter, and use that from the rest
of the message filters.

BUG=none
R=jochen@chromium.org, kinuko@chromium.org

Review URL: https://codereview.chromium.org/892543002

Cr-Commit-Position: refs/heads/master@{#314556}

Cr-Commit-Position: refs/heads/master@{#314555}

The error log is as follows:
../../third_party/skia/include/core/SkImageInfo.h:109: error: undefined reference to 'SkDebugf_FileLine(char const*, int, bool, char const*, ...)'
collect2: error: ld returned 1 exit status

If any modules are going to use any Skia header no matter whether directly or
indirectly, the module must link Skia. src/media/blink doesn't depend on skia
directly but src/media, on which src/media/blink depends, depends on Skia. So
src/media/blink must link to Skia.

Review URL: https://codereview.chromium.org/885373003

Cr-Commit-Position: refs/heads/master@{#314554}

BUG=450050

Review URL: https://codereview.chromium.org/899673003

Cr-Commit-Position: refs/heads/master@{#314553}

This is one of the steps needed to move ContextProviderInProcess to
android_webview.

BUG=338338
R=jamesr@chromium.org,piman@chromium.org

Review URL: https://codereview.chromium.org/890873007

Cr-Commit-Position: refs/heads/master@{#314552}

BUG=454799

Review URL: https://codereview.chromium.org/869073006

Cr-Commit-Position: refs/heads/master@{#314551}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/901493002

Cr-Commit-Position: refs/heads/master@{#314550}

After https://codereview.chromium.org/874833003/, every mixed-content requests from the ServiceWorker are blocked.
So we can show the HTTPS padlock because every responses from the ServiceWorker to the page are created using the resources which are served through the secure protocol.

To show the padlock we fill the SSLInfo of the response from the ServiceWorker using the SSLInfo of the ServiceWorker script.

When we support fetching mixed-content requests from the ServiceWorker in the future, we have to check the security level of the responses.

BUG=392409

Review URL: https://codereview.chromium.org/877623002

Cr-Commit-Position: refs/heads/master@{#314549}

This patch change VideoCaptureController to ignore buffers that cant be converted to I420.
This is mostly important for failures in MJPG decoding.

BUG=453761

Review URL: https://codereview.chromium.org/882883004

Cr-Commit-Position: refs/heads/master@{#314548}

BUG=338837

Review URL: https://codereview.chromium.org/829583002

Cr-Commit-Position: refs/heads/master@{#314547}

BUG=444764

Review URL: https://codereview.chromium.org/873313006

Cr-Commit-Position: refs/heads/master@{#314546}

BUG=437865

Review URL: https://codereview.chromium.org/898553002

Cr-Commit-Position: refs/heads/master@{#314545}

BUG=346797
TBR=plundblad@chromium.org

Review URL: https://codereview.chromium.org/900623005

Cr-Commit-Position: refs/heads/master@{#314544}

To fix a few tests the current behavior when navigating from a non-live RFH was changed so that the new, speculative one is immediately set as active matching what is done in RenderFrameHostManager::UpdateStateForNavigate. This replaced the behavior of simply bringing the current RFH back to life.

With this change 6 tests are fixed for PlzNavigate:

    RenderFrameHostManagerTest.WebUI
    WebContentsImplTest.NTPViewSource
    RenderFrameHostManagerTest.NewTabPageProcesses
    WebContentsImplTest.CrossSiteBoundariesAfterCrash
    WebContentsImplTest.CrossSiteComparesAgainstCurrentPage
    WebContentsImplTest.ShowInterstitialFromBrowserNewNavigationProceed

BUG=439423

Review URL: https://codereview.chromium.org/892123002

Cr-Commit-Position: refs/heads/master@{#314543}

They weren't being properly reported before (the report happened later than it
should) but now there's two different reporting points for current navigation
and for when PlzNavigate is enabled.

BUG=416877

Review URL: https://codereview.chromium.org/874353003

Cr-Commit-Position: refs/heads/master@{#314542}

This makes the geolocation permission tests run for both infobars and
permission bubbles. The tests now run as parameterized tests.

Supercedes parts of:
https://codereview.chromium.org/411503005/
https://codereview.chromium.org/341833004/

BUG=438758

Review URL: https://codereview.chromium.org/787033004

Cr-Commit-Position: refs/heads/master@{#314541}

Revert of Revert of Special check on Supervised User creation flow added to prevent misleading shelf alignment. (patchset #1 id:1 of https://codereview.chromium.org/830393004/)

Reason for revert:
The bug is not reproducible anymore. Some fixes to shelf were done earlier, may be that prevents that one problem

Original issue's description:
> Revert of Special check on Supervised User creation flow added to prevent misleading shelf alignment. (patchset #3 id:40001 of https://codereview.chromium.org/783663003/)
>
> Reason for revert:
> Appears to have caused bug 446212
>
> Original issue's description:
> > Special check on Supervised User creation flow added to prevent misleading shelf alignment.
> >
> > BUG=405361
> >
> > Committed: https://crrev.com/e2b59c4c229ec214150f522f4b3f6b02d9cefaee
> > Cr-Commit-Position: refs/heads/master@{#309555}
>
> TBR=dzhioev@chromium.org,skuhne@chromium.org,merkulova@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=405361
>
> Committed: https://crrev.com/e2e8ff56d1937bb635884032534def9fc42b7809
> Cr-Commit-Position: refs/heads/master@{#310145}

TBR=dzhioev@chromium.org,skuhne@chromium.org,abodenha@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=405361

Review URL: https://codereview.chromium.org/871353003

Cr-Commit-Position: refs/heads/master@{#314540}

GAIA auth extension use special manifest file for Hotrod Enrollment case.
This manifest also needs incognito:split to work on login screen.

BUG=453448
TEST=manual

Review URL: https://codereview.chromium.org/900473007

Cr-Commit-Position: refs/heads/master@{#314539}

Previously, ListThumbnailLoader preloaded images at the top of list when it preloaded to the end of list. However, especially high priority range is at the end of list, the benefit of preloading top images is small.

BUG=438050
TEST=out/Release/browser_tests --gtest_filter=FileManagerJsTest.ListThumbnailLoader

Review URL: https://codereview.chromium.org/877513003

Cr-Commit-Position: refs/heads/master@{#314538}

Revert of Start moving ownership of SyncNotificationController to SyncController. (patchset #3 id:40001 of https://codereview.chromium.org/889723002/)

Reason for revert:
Broke downstream builds

Original issue's description:
> Start moving ownership of SyncNotificationController to SyncController.
>
> GoogleServicesNotificationController is modified to work
> the way most other singleton classes work, so that it is
> not necessary to pass into the SyncNotificationController
> constructor (and thus, into SyncController in the future).
>
> SyncController gets a temporary setter method so that SNC
> can be constructed downstream and passed in until all its
> dependencies are upstream.
>
> BUG=428882
>
> Committed: https://crrev.com/deaa0fe6ca3e0428a85fc22b019819437d84120b
> Cr-Commit-Position: refs/heads/master@{#314515}

TBR=nyquist@chromium.org,maxbogue@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=428882

Review URL: https://codereview.chromium.org/895373002

Cr-Commit-Position: refs/heads/master@{#314537}

All arm platforms support V4L2 SVDA by default and use_v4l2_codec also governs V4L2 VDA/VEA now.
Generates libv4l2 stub in GN file.

BUG=449883
TEST=build chrome and vda unittest on peach_pit, veyron_pinky, squawks,
and panther_freon

Review URL: https://codereview.chromium.org/828063009

Cr-Commit-Position: refs/heads/master@{#314536}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/2340dcb..d3780c5

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/893403002

Cr-Commit-Position: refs/heads/master@{#314535}

BUG=454457

Review URL: https://codereview.chromium.org/896823002

Cr-Commit-Position: refs/heads/master@{#314534}

This CL generalizes upload_network_service.py to support uploading other
services (currently, html_viewer). html_viewer.mojo is not zipped before being
uploaded so that it can be accessed dynamically by mojo_shell.

Review URL: https://codereview.chromium.org/879233006

Cr-Commit-Position: refs/heads/master@{#314533}

Before: while UserManager and UserManagerBase were componentized to user_manager namespace, FakeUserManager was staying at chromeos namespace.

After: UserManager Chrome OS-related interface moved to a separate class ChromeUserManagerInterface. Mixing it to UserManagerBase and FakeUserManager we're getting chrome OS versions of them. That allows us to move UserManagerBase and FakeUserManager into component user_manager.

Main changes are located at .*user_manager.* files. Such as chrome_user_manager, chrome_user_manager_interface, fake_chrome_user_manager, user_manager_base etc.
Other files (mostly tests) were changed due to changes in include paths and FakeUserManager class renaming.

BUG=443119

Review URL: https://codereview.chromium.org/824683002

Cr-Commit-Position: refs/heads/master@{#314532}

Previously the test does not wait dialog hiding unintentinally.

BUG=452723
TEST=DefaultActionDialog/FileManagerBrowserTest

Review URL: https://codereview.chromium.org/897863002

Cr-Commit-Position: refs/heads/master@{#314531}

This test calls chdir() which corrupts subsequent tests like
NamespaceSandboxTest.

TBR=jln@chromium.org

Review URL: https://codereview.chromium.org/902533002

Cr-Commit-Position: refs/heads/master@{#314530}

This CL has some minor clean up.
- In IsFileSystemAccessDenied, now we check "/" instead of "/proc/self/exe".
- Remove SetuidSandboxClient::CreateInitProcessReaper.
  Now contents uses sandbox::CreateInitProcessReaper directly
  and noone uses the method.
- Clean up include directives in the header.
This is also the preparation of enabling Layer-one sandbox
(suid sandbox) on nacl_helper_nonsfi.

TEST=Ran trybots.
BUG=455087

Review URL: https://codereview.chromium.org/885673007

Cr-Commit-Position: refs/heads/master@{#314529}

New icons used for indication of kids accounts on sign-in screen. Icons for supervised accounts returned.

BUG=450795

Review URL: https://codereview.chromium.org/899663003

Cr-Commit-Position: refs/heads/master@{#314528}

Revert of Revert of Add Mojo interfaces for out-of-process proxy resolver. (patchset #1 id:1 of https://codereview.chromium.org/892373006/)

Reason for revert:
The code in this change is not linked into any binary.

Test is flaky:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=device_unittests&tests=SerialConnectionTest.Cancel

The likely cause of the test failure is https://chromium.googlesource.com/chromium/src/+/bc78a2320b50eba4fe397f1f838a82ad30b16cd6. The author has been informed and the test will be fixed soon.

Original issue's description:
> Revert of Add Mojo interfaces for out-of-process proxy resolver. (patchset #4 id:60001 of https://codereview.chromium.org/900433003/)
>
> Reason for revert:
> http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/38575
> Broke device_unittests device_unittests SerialConnectionTest.Cancel it seems.
>
> Original issue's description:
> > Add Mojo interfaces for out-of-process proxy resolver.
> >
> > See:
> > https://docs.google.com/a/chromium.org/document/d/1n5hr4KJhZl2A4MicTfmyiHPdiKp7kmUoWXnRBN8SrZE/edit#
> >
> > BUG=11746
> >
> > Committed: https://crrev.com/073e42bb7587b90594e5799fb6a4afe08a1e1561
> > Cr-Commit-Position: refs/heads/master@{#314509}
>
> TBR=rdsmith@chromium.org,eroman@chromium.org,sammc@chromium.org,amistry@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=11746
>
> Committed: https://crrev.com/7d4ec1aa24e79406d29e0cafbb531a3fabfe815f
> Cr-Commit-Position: refs/heads/master@{#314519}

TBR=rdsmith@chromium.org,eroman@chromium.org,sammc@chromium.org,noel@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=11746

Review URL: https://codereview.chromium.org/882173005

Cr-Commit-Position: refs/heads/master@{#314527}

BUG=405700

Review URL: https://codereview.chromium.org/887393002

Cr-Commit-Position: refs/heads/master@{#314526}

loadAsDataUrl loads thumbnail as data url instead of attaching it to a box. While loadAsDataUrl does not fit image to the box, it returns dataUrl of thumbnail which transform is applied when it is necessary.

BUG=438050
TEST=out/Release --gtest_filter=FileManagerJsTest.ThumbnailLoader

Review URL: https://codereview.chromium.org/902513002

Cr-Commit-Position: refs/heads/master@{#314525}

Revert of Remove Client= from device/serial/data_stream.mojom. (patchset #1 id:20001 of https://codereview.chromium.org/889283002/)

Reason for revert:
Switching to two pipes broke FIFO assumption, causing DataSinkTest.CancelDuringError and SerialConnectionTest.Cancel to become flaky

Original issue's description:
> Remove Client= from device/serial/data_stream.mojom.
>
> BUG=451321
>
> Committed: https://crrev.com/bc78a2320b50eba4fe397f1f838a82ad30b16cd6
> Cr-Commit-Position: refs/heads/master@{#314231}

TBR=rockot@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=451321

Review URL: https://codereview.chromium.org/873293006

Cr-Commit-Position: refs/heads/master@{#314524}

This CL fixes an issue where a speech query in the app list, that was
interrupted by the app list closing, would complete when the app list
was reopened.

BUG=440061

Review URL: https://codereview.chromium.org/886353004

Cr-Commit-Position: refs/heads/master@{#314523}

We are going to remove Timeline domain from the remote debugging protocol soon. This CL fixes remaining usages of timeline commands.

BUG=448318

Review URL: https://codereview.chromium.org/895043002

Cr-Commit-Position: refs/heads/master@{#314522}

Cr-Commit-Position: refs/heads/master@{#314521}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/fe3f260..2340dcb

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/896123002

Cr-Commit-Position: refs/heads/master@{#314520}

Revert of Add Mojo interfaces for out-of-process proxy resolver. (patchset #4 id:60001 of https://codereview.chromium.org/900433003/)

Reason for revert:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/38575
Broke device_unittests device_unittests SerialConnectionTest.Cancel it seems.

Original issue's description:
> Add Mojo interfaces for out-of-process proxy resolver.
>
> See:
> https://docs.google.com/a/chromium.org/document/d/1n5hr4KJhZl2A4MicTfmyiHPdiKp7kmUoWXnRBN8SrZE/edit#
>
> BUG=11746
>
> Committed: https://crrev.com/073e42bb7587b90594e5799fb6a4afe08a1e1561
> Cr-Commit-Position: refs/heads/master@{#314509}

TBR=rdsmith@chromium.org,eroman@chromium.org,sammc@chromium.org,amistry@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=11746

Review URL: https://codereview.chromium.org/892373006

Cr-Commit-Position: refs/heads/master@{#314519}

BUG=454995

Review URL: https://codereview.chromium.org/895233002

Cr-Commit-Position: refs/heads/master@{#314518}

If <webview> attempts to navigate to a URL that is invalid or it cannot
access, it will fire a loadabort message. However, a loadstop will not fire
and <webview> may remain in an unnavigated state despite having a set src
attribute. This causes various APIs such as executeScript to fail.

This CL navigates <webview> to about:blank in the case of a bad navigation.
This puts <webview> back to a sane state.

BUG=450125

Review URL: https://codereview.chromium.org/888563003

Cr-Commit-Position: refs/heads/master@{#314517}