- 14 Mar, 2018 40 commits
-
-
rbpotter authored
Since we now send a PDF from print preview, the offsets aren't computed in PrintRenderFrameHelper. They should be the printable area offsets, not the content area. The content area offsets reflect the margins set in Print Preview, which are no longer relevant since the generated PDF already includes these margins. Bug: 821485 Change-Id: I5ba009408bb7bb0251cdd85b3ed7b6e10e293826 Reviewed-on: https://chromium-review.googlesource.com/962878 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#543192}
-
https://chromium.googlesource.com/catapult.git/+log/b1242f4c6f85..fb4a44ab53c4 $ git log b1242f4c6..fb4a44ab5 --date=short --no-merges --format='%ad %ae %s' 2018-03-14 perezju Reland "[Telemetry] Use correct WebView apk for --browser android-webview" 2018-03-12 dtu [pinpoint] Retry job.put() on ndb error. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Iea0e198660e78e9447b37c141942edc46660c2c7 Reviewed-on: https://chromium-review.googlesource.com/962830Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543191}
-
James Cook authored
Generate synthetic clicks and dispatch them via the window service. Add the remote event dispatcher interface to a new "accessibility" capability, available only to trusted apps. Bug: 821471, 628665 Test: Use autoclick on multiple displays with different scale factors Change-Id: I61352a0849a96a2bc0ae14d0b8afcca051ba67e2 Reviewed-on: https://chromium-review.googlesource.com/961668Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#543190}
-
Dave Schuyler authored
This CL reverts part of CL/952669 until a better fix is found for showing the tab switch button (which stopped displaying with CL/952669). Bug: None Change-Id: Ia5896087c644f6998350a06d783d7dd58c3f919a Reviewed-on: https://chromium-review.googlesource.com/961734Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#543189}
-
Marijn Kruisselbrink authored
On of several changes towards making uploading blobs with network service work. Tested in a separate CL because multiple unrelated bugfixes are needed to make this all work and testable (https://chromium-review.googlesource.com/c/chromium/src/+/963008). Bug: 821878 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I33812ac556029066196b3fcbdb54d6bdbc041a86 Reviewed-on: https://chromium-review.googlesource.com/963007Reviewed-by:
-
Fady Samuel authored
As per anicolao@'s advice, this CL converts surface invariants violations dumps into an optional feature whereas we always report UMA. This allows us to ship with invariants violations that do not impact the user experience. Bug: 814690, 672962 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I206bc32d30afcccc8dd0e0200601961c72943a1f Reviewed-on: https://chromium-review.googlesource.com/962929Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#543187}
-
John Abd-El-Malek authored
The first fix is to get the CookieManager from the render process' StoragePartition, instead of using GetDefaultStoragePartition. The second fix is to not use the StoragePartition's CookieManager (which is used for web requests) when ContentBrowserClient::OverrideRequestContextForURL returns a different store (e.g. for chrome-extension scheme). Bug: 769401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id61abda2cd38957867fb3848d06b1b18d9e89b79 Reviewed-on: https://chromium-review.googlesource.com/957554Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#543186}
-
Michael Spang authored
If the pen device is disabled while the pen is near the screen it leads to infinite recursion. This is because we make a call to disable palm suppression, which revalidates device enablement. Post a task instead of disabling inline to fix this. The same thing happens if we lose events since Reinitialize() gained a call to ReleaseButtons() when pen support was added, which calls ReportEvents(), which can again call Reinitialize(). To fix that one, kill ReleaseButtons() as ReleaseTouches() should be sufficient. BUG=814071 TEST=powerd_dbus_suspend with pen touching screen Change-Id: I8bb66feddc7961f1fa28d062133671ad1c46948c Reviewed-on: https://chromium-review.googlesource.com/961386Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#543185}
-
David Tseng authored
Bug: 539022 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2e8f9b364e380b8c3200f6674b0ecea859adba01 Reviewed-on: https://chromium-review.googlesource.com/951854 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#543184}
-
https://pdfium.googlesource.com/pdfium.git/+log/2c3cfa734d03..40c223e4ed41 $ git log 2c3cfa734..40c223e4e --date=short --no-merges --format='%ad %ae %s' 2018-03-14 thestig Fix bad return value in WideString::Compare(). Created with: roll-dep src/third_party/pdfium BUG=821454 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I686ce1083770018cbe352bbfe6e902a9fd48f0c2 Reviewed-on: https://chromium-review.googlesource.com/963014Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543183}
-
Illia Martyniuk authored
Moving enable-ui-devtools flag to the browser, so now DevTools won't carry any host specific information. Bug: 816802 Change-Id: I9830227660d31803226d8ec469f75f2ce6007712 Reviewed-on: https://chromium-review.googlesource.com/962360Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Illia Martyniuk <illiam@google.com> Cr-Commit-Position: refs/heads/master@{#543182}
-
Min Qin authored
This CL moved DownloadFile and DownloadFileImpl to components/download There are no functional changes. Bug: 803135 Change-Id: I3c40ce2ac56251a3fec9d0eb75acb12ce0c0b0d3 Reviewed-on: https://chromium-review.googlesource.com/957845 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#543181}
-
Caleb Rouleau authored
This reverts commit cf978e37. Reason for revert: not more flaky than the other ones. https://bugs.chromium.org/p/chromium/issues/detail?id=821697#c17 Original change's description: > Disable flaky testSafeBrowsingOnSafeBrowsingHitProceed > > TBR=ntfschr > > Bug: 821697 > Change-Id: I61515e735a542cf94dcb00c50263ea512d66fcea > Reviewed-on: https://chromium-review.googlesource.com/963081 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543146} TBR=crouleau@chromium.org,ntfschr@chromium.org Change-Id: I141561d5448a77c0dc12a91032850c9dd2dc2e1c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821697 Reviewed-on: https://chromium-review.googlesource.com/963230Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#543180}
-
Sean Topping authored
Adds an observer interface for CastWebView. This allows multiple components to track the CastWebView lifecycle (similar to WebContentsObserver APIs). Bug: None Test: cast_shell Change-Id: I37f45b896c1696c9fe91d9706cbddf0b2e46d2cc Reviewed-on: https://chromium-review.googlesource.com/961588Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#543179}
-
Tom Anderson authored
Linux distros like Gentoo have a philosophy of not statically-linking dependencies. The reason is not necessarily to save disk space, but because they like to compile with their own flags and patches applied. This CL fixes the zlib unbundle for them. BUG=800977 Change-Id: I129d95a5a4b6c4183666f712609b2e3f0509526e Reviewed-on: https://chromium-review.googlesource.com/947464 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#543178}
-
Jared Saul authored
As requested by bettes@, reduce default padding to 8px Bug: 820619 Change-Id: Idb708763cfc3e5b1dcee456e7429d0ce28ced4b1 Reviewed-on: https://chromium-review.googlesource.com/958087 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
-
Johann authored
VPX_CODEC_DISABLE_COMPAT has been removed for years. The headers are guarded internally with extern "C" {}. Sort order is no longer critical for vp8[c|d]x.h and vpx_[en|de]coder.h. BUG=webm:649 Change-Id: I957f4d81adc51bacc6d66457053bad98c761e257 Reviewed-on: https://chromium-review.googlesource.com/959455Reviewed-by:Avi Drissman <avi@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#543176}
-
Eugene Ostroukhov authored
1. Disable search extension. 2. Do not show search prompt in the Network log 3. Hide serch type selection when there's no meaningful choice. Bug: 468416 Change-Id: I461b84719a804da7bf53c94a3392d8123f9d15c5 Reviewed-on: https://chromium-review.googlesource.com/962662Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#543175}
-
Nodir Turakulov authored
TBR=iannucci@chromium.org No-Try: true Change-Id: Idbcf63650aac281cd3a98aed4a8c6cd453d78c72 Reviewed-on: https://chromium-review.googlesource.com/963293Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#543174}
-
James Hawkins authored
This is unused for Chromebooks and removing this has the added benefit of removing an incorrect dependency on ash. Bug: 723873 Test: none Change-Id: I417f2030851438ce7ebb23f3394ed0772bf7514e Reviewed-on: https://chromium-review.googlesource.com/961730 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#543173}
-
https://webrtc.googlesource.com/src.git/+log/31791e7e2c2c..2ce1e749a898 $ git log 31791e7e2..2ce1e749a --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1998bb70f242251c08115a6b50c6959ee632fe67 Reviewed-on: https://chromium-review.googlesource.com/963011Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543172}
-
Steven Bennetts authored
In ONC, if a policy provided network configuration does not explicitly list a property as 'Recommended', the user is not able to set the property. In Google's OpenVPN policy configuration (and potentially others), UserAuthenticationType is not explicitly set, and OTP is not included in the Recommended list, even though it needs to be provided by the user. To work around this technically incorrect policy configuration (and not break existing policies with the new UI), when UserAuthenticationType is not explicitly set in the policy, this change adds Password and OTP to the Recommended list so that they can be provided by the UI. This also adds a test that catches the failure case and passes with the new changes. Bug: 817617 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If22f34e8943a2b82cf8becc93f257413c3cdcf92 Reviewed-on: https://chromium-review.googlesource.com/961365 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#543171}
-
Sidney San Martín authored
- If a browser window becomes key while a dialog is up and the web content is first responder, give focus to the dialog. - If the web content *loses* first responder while the dialog is key, make the browser window key. This makes sure that clicking the omnibox or typing ⌘L, for instance, focuses the browser window. The final version of this change is incomplete: The separation between "focused" ("the web content is focused within its window") and "active" ("the web content's window is the active window") is mostly an illusion because it only exists on Mac and I kept running into cases where it breaks down (e.g. setting "focused" implicitly sets "active" deep inside WebViewImpl). A bunch of tests also check that certain functions and IPCs happen in a certain order, so fiddling with anything just breaks a bunch of tests in ways that don't map to real-world behavior. Now isn't the right time to mess with that, especially in Cocoa code, so this leaves one case unfixed: - If a dialog becomes key some other way, make sure that the web content is first responder in its parent window (so that focus returns to the web content on dismissing the dialog, and no other views have first responder appearance). I filed https://crbug.com/821931 to track it. Bug: 658405 Change-Id: I7ec11568d860e7371f552baa44a0d6b45db6dc22 Reviewed-on: https://chromium-review.googlesource.com/935424 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
James Hawkins authored
R=khorimoto@chromium.org Bug: none Test: none Change-Id: I783fa50b6a6e36f1cf7ca9c3cd85c4948486199a Reviewed-on: https://chromium-review.googlesource.com/961650Reviewed-by:
-
Alex Loiko authored
See WebRTC CL https://webrtc-review.googlesource.com/c/src/+/57740 Bug: webrtc:8925 Change-Id: Ib38948e843645e883deb18cde6549a3daec6397b Reviewed-on: https://chromium-review.googlesource.com/939473Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Alex Loiko <aleloi@chromium.org> Cr-Commit-Position: refs/heads/master@{#543168}
-
Marijn Kruisselbrink authored
Bug: 821878 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id88ba9903bfb075100c481c2cb923f5ef93d7492 Reviewed-on: https://chromium-review.googlesource.com/963008 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#543167}
-
Justin Novosad authored
TexImage2D calls with a video element as a source were sometimes failing because of a texture copy that was missing posterior synchronization. This meant that it was possible for the source texture to be recycled by skia (in a different command stream) before the copy is executed. BUG=807974 R=xlai@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5f5124e45e803240507a676e75b2183cf564e1ab Reviewed-on: https://chromium-review.googlesource.com/945331Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3325@{#644} Cr-Original-Branched-From: bc084a8b-refs/heads/master@{#530369} Reviewed-on: https://chromium-review.googlesource.com/960423 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#543166}
-
Ryan Landay authored
This CL splits StackLayout into a base class and child class: - StackLayoutBase is an abstract base class that contains most of the existing logic. - StackLayout is a non-abstract child class that contains the pieces of existing logic that are assume there will always be exactly two stacks: one for all normal tabs, and one for all incognito tabs (the incognito stack is not displayed if empty). This enables us to prototype new UIs on top of the tab switcher. I've already built one prototype on top of this base class; we may end up needing to tweak StackLayoutBase slightly as we build different types of prototypes, but I think this is a pretty good start. Bug: 648314 Change-Id: I25ca7169a1dfd3e780adea58ecb8043da9b55035 Reviewed-on: https://chromium-review.googlesource.com/957875Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#543165}
-
Elly Fong-Jones authored
This change: 1) Removes a conflicting definition of AutofillPopupView::Create by providing a polychrome shim; 2) Marks AutofillPopupBaseViewTest as Views-only because it seems tightly bound to BrowserView. Bug: 817408 Change-Id: Icf164106f427dc9ee99f11234c9f3ca876ffe3df Reviewed-on: https://chromium-review.googlesource.com/962999Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#543164}
-
Benjamin Pastene authored
Bug: 817779 Change-Id: I9fc5b1f51d536262f22ba5f412e8cf94ed3dae42 Reviewed-on: https://chromium-review.googlesource.com/963301Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#543163}
-
Wez authored
Changes to manual ref-counting in a recent change to the timing of write-error notifications in ChannelWin missed that multiple write operations may be in-progress at the same time, and so introduced issues with the lifetime of the ChannelWin object if ShutDown() while write operations were in-progress. We also add some DCHECKs to sanity-check the pending-IO flags. Bug: 821658, 816620 Change-Id: I69cea0a1ed080ca2920738f5212a25d5f5e63c42 Reviewed-on: https://chromium-review.googlesource.com/961941 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
-
Charles Harrison authored
This will help us see how much we stand to lose by relaxing tab-under protection to sites with low (or 0) site engagement scores. A followup will probably land a relaxed blocking scheme for origins with nonzero engagement, possibly behind another variation flag. This data will give us better insight into whether our hypothesis is right: namely, that tab-under destinations will often have low engagement. See doc for tab-under relaxation: https://docs.google.com/document/d/1N-0etmATN6PhQt-m9S8sCgfz88zv8lZ2dBFdqKlzsPg/edit?ts=5aa73bff# Bug: 661629 Change-Id: I535710fdde0a162c53994b0df99f6333a8af99ce Reviewed-on: https://chromium-review.googlesource.com/959538Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#543161}
-
Elly Fong-Jones authored
These tests were broken by conflicting definitions of chrome::DisableFindBarAnimationsDuringTesting. This change fixes that conflict by having the Views version call the Cocoa version when needed. After this change, all FindInPageControllerTest tests pass in cocoa and polychrome-cocoa, and most pass in polychrome-views. Bug: 817408 Change-Id: I7d028e57502b29a2303164662dea05bb6641c142 Reviewed-on: https://chromium-review.googlesource.com/962713 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543160}
-
Nodir Turakulov authored
Make luci-task-force@google.com group a WRITER of luci.chromium.ci so that they can bump next build number. R=vadimsh@chromium.org No-Try: true Change-Id: Ice4dfb8e2f9910a8ca42f2b4dfe753d161d0f09c Reviewed-on: https://chromium-review.googlesource.com/963228 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#543159}
-
Kevin McNee authored
We introduce a DumpWithoutCrashing when a new gesture event is queued while acks are being processed if the processing has already lasted over 2 seconds. This is to test the hypothesis that the queue is getting stuck in a loop in GestureEventQueue::AckCompletedEvents. Bug: 818214 Change-Id: I36daa488d3f5aa5e8eee5e4f442fdb3d8445c0a7 Reviewed-on: https://chromium-review.googlesource.com/959179 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#543158}
-
Steven Bennetts authored
Several UI paths can lead to CreateConfiguration getting called for a network that is already configured. This should be supported as all validation checks are still performed and Shill supports it. Bug: 819422 Change-Id: I456f69697b9181d2377efee6dcb3342dda5b8c72 Reviewed-on: https://chromium-review.googlesource.com/961732Reviewed-by:
-
Scott Violet authored
I'm not sure on the name here. I went with WindowService-ChromeOS as at some point we will launch the WindowService on other platforms, but that won't be anytime soon and is likely to be very different. So, I'm thinking later on we have the field trial WindowService-Desktop. BUG=814898 TEST=none TBR=rkaplow@chromium.org Change-Id: I555c9cea0f59c28b2e6124196f362ac3231104fc Reviewed-on: https://chromium-review.googlesource.com/962877Reviewed-by:
-
Calder Kitagawa authored
A few simple changes/typos that require correction which were detected when merging changes into trunk. Change-Id: Ib088ca4a1741e642e3d912d010e4e77ba5fb72b0 Reviewed-on: https://chromium-review.googlesource.com/962357 Commit-Queue: Calder Kitagawa <ckitagawa@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#543155}
-
Chris Palmer authored
Previously, history.{push,replace}State spam failed silently, causing developer confusion. This change also introduces the --disable-pushstate-throttle flag to allow users to disable the throttling. This work was primarily authored by Trent Willis <trentmwillis@gmail.com>. R=creis@chromium.org, dcheng@chromium.org Bug: 769592, 794923 Change-Id: I969456b190d535f8dee3e03b5c4f4f36730d6b38 Reviewed-on: https://chromium-review.googlesource.com/851000 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#543154}
-
Matthew Jones authored
This change adds a composited version of the bottom toolbar. The layer is not specific to the bottom sheet and can be used for any bottom UI. The layer is not added to the hierarchy in this patch. BUG=815324 Change-Id: I309f392c975ed7099aaf7562461625bd7c886a2d Reviewed-on: https://chromium-review.googlesource.com/935742 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
