GitLab

WebVideoRenderer was added in r40137 as part of my IPC-based video rendering experiment.

I later added --enable-video-logging in r43038 which was intended to log timestamps and do logs analysis to determine playback smoothness. This again was experimental and never used.

Also removed WebMediaPlayerProxy::SetRect() and VideoRendererImpl::SetRect() as they were not implemented.

Review URL: http://codereview.chromium.org/8601004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110786 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8561016

TBR=pkotwicz@chromium.org
Review URL: http://codereview.chromium.org/8558033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110785 0039d316-1c4b-4281-b951-d872f2087c98

http://crrev.com/110761 fails check_deps on OSX 10.6
ERROR in /b/build/slave/Mac_10_6_Tests__dbg__2_/build/src/ui/views/bubble/bubble_border.cc
Illegal include: "grit/ui_resources_standard.h"
    Because of no rule applying

TBR=tfarina@chromium.org

Review URL: http://codereview.chromium.org/8561032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110784 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8561016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110783 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102903
TEST=compile

Change-Id: I5bea343f65b9db676b0f07e1b41bb59cf4f7cf38

R=oshima@chromium.org,saintlou@chromium.org,dnicoara@chromium.org

Review URL: http://codereview.chromium.org/8596010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110782 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8589018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110780 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103500
TEST=browser_tests

Review URL: http://codereview.chromium.org/8561030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110779 0039d316-1c4b-4281-b951-d872f2087c98

I previously assumed that PipelineImpl would go through a clean Pause/Flush/Stop on an error but it turns out that Stop() can be called at anytime. Fortunately a DCHECK() would catch this condition and was easily triggerable using the test case attached in bug 100434.

Review URL: http://codereview.chromium.org/8561019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110778 0039d316-1c4b-4281-b951-d872f2087c98

dev interfaces, and we want it to go through IDL so that the PNaCl shim
will know about them. There are few others dev and private interfaces
not yet converted to IDL, but this is a start.

TEST= ./generator.py
BUG= http://code.google.com/p/chromium/issues/detail?id=89968

Review URL: http://codereview.chromium.org/8586031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110777 0039d316-1c4b-4281-b951-d872f2087c98

Preallocating the shared memory object saves an IPC round trip.
It also makes the code path more similar for Linux and Mac.
It also lays the groundwork for changing the allocation method
later without having to replumb the proxying layer.

BUG= http://code.google.com/p/chromium/issues/detail?id=103377
TEST= nacl still works on Linux

R=mseaborn@chromium.org,jam@chromium.org

Review URL: http://codereview.chromium.org/8513018

TBR=mseaborn@chromium.org
Review URL: http://codereview.chromium.org/8598029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110776 0039d316-1c4b-4281-b951-d872f2087c98

which crashes consistently.

BUG=104805
TEST=none

R=dhollowa@chromium.org

Review URL: http://codereview.chromium.org/8549029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110775 0039d316-1c4b-4281-b951-d872f2087c98

nested loop can exit.

BUG=104684
TEST=BrowserTest.CloseWithAppMenuOpen passes on aura build

Review URL: http://codereview.chromium.org/8597010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110774 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin@chromium.org

Review URL: http://codereview.chromium.org/8566047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110773 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104636
TEST=No process swap on a link to/from a bookmark app.


Review URL: http://codereview.chromium.org/8585016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110772 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102903
TEST=compile

Change-Id: I96c63b55a6be4623f8edd202a1642ae6f7a6eb7a

R=mark@chromium.org,oshima@chromium.org,dnicoara@chromium.org


Review URL: http://codereview.chromium.org/8561018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110771 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103488
TEST=DownloadTests.* browser tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110765

Review URL: http://codereview.chromium.org/8585040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110770 0039d316-1c4b-4281-b951-d872f2087c98

Disable more failing PPAPITests on Valgrind Mac bot.

BUG=104535
TEST=Valgrind on Mac goes green
TBR=yzshen@chromium.org

Review URL: http://codereview.chromium.org/8602008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110769 0039d316-1c4b-4281-b951-d872f2087c98

crashes due to a NULL tabContents pointer.

BUG=104751
TEST=no

Review URL: http://codereview.chromium.org/8586056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110768 0039d316-1c4b-4281-b951-d872f2087c98

Adds suppressions for ThreadData::TallyABirthIfActive ThreadData::TallyADeath

BUG=104806
TEST=Valgrind bots go green
TBR=jar@chromium.org

Review URL: http://codereview.chromium.org/8569016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110767 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103488
TEST=DownloadTests.* browser tests

Review URL: http://codereview.chromium.org/8585040

TBR=davemoore@chromium.org
Review URL: http://codereview.chromium.org/8569015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110766 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103488
TEST=DownloadTests.* browser tests

Review URL: http://codereview.chromium.org/8585040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110765 0039d316-1c4b-4281-b951-d872f2087c98

Just show the setting level bubble on the default monitor, since ChromeOS only really supports one monitor right now anyway.

Code like this will end up living in aura_shell::Shell by the time we end up figuring out how to support multiple monitors.

For now, this removes a USE_AURA ifdef/NOTIMPLEMENTED() and some unnecessary complexity for cros.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8596013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110764 0039d316-1c4b-4281-b951-d872f2087c98

It's definitely not something we want to expose to users.

Review URL: http://codereview.chromium.org/8590011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110763 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=browser_tests, unit_tests etc. builds

Review URL: http://codereview.chromium.org/8599003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110762 0039d316-1c4b-4281-b951-d872f2087c98

Left stub files that will be removed in a follow up patch after updating
the files to point to the new location.

BUG=104039
R=ben@chromium.org

Review URL: http://codereview.chromium.org/8588064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110761 0039d316-1c4b-4281-b951-d872f2087c98

This is a relative path version of:
   http://codereview.chromium.org/8539019
with valgrind tests disabled.

Copy server pieces to build output dir.
Update ppapi_uitests.cc to run server from output dir.
Add test to ppapi_uitests, update dependecies.
Update test_sever to support a fully qualified path.

BUG= http://code.google.com/p/chromium/issues/detail?id=96782
TEST= try (ui_tests --gtest_filter="PPAPI*.*")
Review URL: http://codereview.chromium.org/8585003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110760 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104580
TEST=see bug
Review URL: http://codereview.chromium.org/8598004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110759 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8566044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110758 0039d316-1c4b-4281-b951-d872f2087c98

BUG=22660
TEST=manual. Need to make another WebKit patch to enable this functionality.

Review URL: http://codereview.chromium.org/8591034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110757 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8549012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110756 0039d316-1c4b-4281-b951-d872f2087c98

ChromeOS with aura uses the normal BrowserView, and not chromeos::BrowserView,
so it is necessary to dup this logic in here.

BUG=103484
TEST=browser_tests:BrowserNavigatorTest.Disposition_LargePopup*

Review URL: http://codereview.chromium.org/8595017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110755 0039d316-1c4b-4281-b951-d872f2087c98

Revert 110741 - Fix ProcessSingletonTest.StartupRaceCondition for win.

    This was originally submitted as http://codereview.chromium.org/8539038/ which was reverted because of a failing test on win.

    This reverts the code back to a single instance of BrowserMainParts, with auxillary parts (Gtk, Views, Aura, Touch) implemented from a new base class, ChromeBrowserParts, which has a Chrome specific interface, allowing initialization to be better subdivided.

    This should fix the notifications auto tests.

    This CL also addresses the test failure on win (and a test failure on linux_chromeos triggered by the windows fix).

BUG=103821
TEST=Make sure all tests and autotests run

TBR=stevenjb@chromium.org

Review URL: http://codereview.chromium.org/8596015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110753 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of gpu_messages.h include in chrome by having the RenderWidgetHostView implementation ask the RenderWidgetHost to ack for the swap buffers GPU message.
Review URL: http://codereview.chromium.org/8595002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110752 0039d316-1c4b-4281-b951-d872f2087c98

This test is working as expected, at least on my local machine.

BUG=chromium:100345
TEST=manually


Review URL: http://codereview.chromium.org/8510043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110751 0039d316-1c4b-4281-b951-d872f2087c98

download has started.
Review URL: http://codereview.chromium.org/8587042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110750 0039d316-1c4b-4281-b951-d872f2087c98

The original change (http://codereview.chromium.org/8565011/) was
reverted due to failing NativeTextfieldViewsTest.HitInsideTextAreaTest.

The test was too strict when comparing cursor bounds and failed due
to font fallback causing height differences in cursor bounds. This
updated CL makes the test only check the x value of cursor bounds.

Original CL description:

This is done by using a metafile to capture the font
that Uniscribe would use to render the text (since
there is no API to get this from Uniscribe itself).

Makes SCRIPT_CACHE be per-run, since different runs
may have different fonts and the SCRIPT_CACHE cannot
be re-used between these.

This is similar to what is done in WebKit in FontCacheWin.cpp

BUG=90426,104234
TEST=Run chrome.exe --use-pure-views and paste some Hebrew
text into the omnibox. It should show up properly.
Review URL: http://codereview.chromium.org/8570003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110749 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102903
TEST=compile

Change-Id: Ia9780044a47c91b8172710cc92481af60433b3a1

R=sky@chromium.org,jcivelli@chromium.org,saintlou@chromium.org,dnicoara@chromium.org


Review URL: http://codereview.chromium.org/8598020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110748 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98716
Review URL: http://codereview.chromium.org/8574070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110747 0039d316-1c4b-4281-b951-d872f2087c98

This does not crash on my machine and succeeds as expected.

BUG=chromium:100338
TEST=manually


Review URL: http://codereview.chromium.org/8497066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110746 0039d316-1c4b-4281-b951-d872f2087c98

profile that isn't current.

BUG=92536
TEST=Go to chrome://settings/personal. Create a profile. Try to double-click on a non-current profile. Nothing should happen.


Review URL: http://codereview.chromium.org/8549013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110745 0039d316-1c4b-4281-b951-d872f2087c98