- 15 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/d28e6c52e05e..cb31feffa500 2021-01-15 fabiansommer@chromium.org Enable saigo llvm regression tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1106311 Tbr: mseaborn@chromium.org Change-Id: I51e1579a1af780afb801873266c45fa7e45f5600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631794Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844023}
-
Benoit Lize authored
(v)asprintf() allocates internally, and is implemented by libc. This makes Chrome crash with PartitionAlloc on Android, since the allocated memory will be freed by PartitionAlloc even though it was not allocated by it. Implement (v)asprintf() ourselves, and wrap it. Bug: 1166558 Change-Id: I4b5ce4be55bd818a029009fa9eb37e123df7f2d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629707 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#844022}
-
Martin Robinson authored
Instead of mapping the ARIA combobox role to other roles on MacOS, always use it unless it is applied to a multiline edit field. This matches the specified behavior and other browsers. These were originally mapped to other roles because of VoiceOver failures that have been fixed with other changes. Bug: 1125165 Change-Id: I26b8ccb006c15d6329da1c29193640f529fab781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611093Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#844021}
-
Alex Ilin authored
This CL adds an experiment parameter that allows to control after how many times user declined the profile switch bubble we stop showing the profile switch bubble. The parameter is called "max_profile_switch_declined_count". It can have the following values: - N < 0 - we always show the bubble when eligible - N == 0 - we never show the bubble - N > 0 - we stop showing the bubble after the user declines it N times Bug: 1166851 Change-Id: Ic165216a338a11d5730e582cd3c2045d107266f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630805Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844020}
-
Mihai Sardarescu authored
This CL ensures that GetStartupProfile() and GetStartupProfilePath() have the same behavior to return the Guest profile when the profile picker needs to be shown. This fixed the bug below as ProcessCommandLineAlreadyRunning() path uses GetStartupProfilePath while ChromeBrowserMainParts::PreMainMessageLoopRunImpl() was using GetStartupProfile(). Bug: 1166166 Change-Id: I53a363c87ae0957fdf35a197755979c33141c975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628990Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#844019}
-
Anastasiia N authored
Move `SigninHelper` class from chrome/browser/ui/webui/signin/inline_login_handler_chromeos.cc to chrome/browser/ui/webui/signin/signin_helper_chromeos.cc Bug: 1140469 Change-Id: Ia6c79410085240dc6c56e053ac595f9e3138d805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550546 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#844018}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/57654f96e343..3abe4703fa62 2021-01-15 szuend@chromium.org Revert "[module.json extensions] Migrate @ViewLocationResolver in elements/" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibefd6031050bd9d9fbe861f9b7f8141b7d6ef606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631791Reviewed-by:
-
Fredrik Söderqvist authored
Since the oBB is in unzoomed space but the <foreignObject> local-to-parent transform performs adjustment for zoom we need to perform correction when propagating it. Similarly change LayoutSVGForeignObject::StrokeBoundingBox() to return the same bounds as VisualRectInLocalSVGCoordinates() (which is zoomed). Bug: 1162993 Change-Id: I430cd7832b37475ef1d139997ef5ac5c0bcc17c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627491Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#844016}
-
Anatoliy Potapchuk authored
This reverts commit dd223e70. Reason for revert: these tests have been failing constently on MSAN builders https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests Original change's description: > Add browser tests for AppLaunchHandler. > > Add browser tests for AppLaunchHandler to verify the restoration > process. > > BUG=1146900 > > Change-Id: Ibeaf262080a24c680718888ee081cc62c5b21a3a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619245 > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843901} TBR=xiyuan@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,nancylingwang@chromium.org Change-Id: Icc6cc9ccbf6fcb0759bf2d03efd2d25a31d90d44 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1146900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632606Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#844015}
-
Sylvain Defresne authored
For device that do not support multi-window, the persistent identifier returned by -[UISceneSession persistentIdentifier] may change when the user "swipe" the app (as this gesture is interpreted as "close window" under certain circumstances). In preparation for using a stable identifier (i.e. a constant) for devices that do not support multi-window, do not access the value from UISceneSession directly in Chrome but instead through SceneState. There is one location that is still using -persistentIdentifier: the code responsible for recording the OS message asking Chrome to purge old session data. It is find to use -persistentIdentifier there because the value is correct for device that support multi-window, for other device the value is not used as part of a path to save data thus it is benign to try to delete data from a place that does not exists. Bug: 1165798 Change-Id: I5169b5c0be961987ef8e1edc9c122947848268e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626440Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#844014}
-
Jan Wilken Dörrie authored
This change modifies `IsPossibleUsernameValid` to require that the possible username is part of an already saved credential for the same site. This will be later extended to only require a match with a local username saved on any site. For robustness the username and the set of allowed usernames are canonicalized, that is case and email providers are irrelevant. The existing requirements to only be ASCII and to not contain whitespace are dropped. Bug: 959776, 1167042 Change-Id: Ic50c954ddd7a4fd969c56295825ae717c870b915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627278 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#844013}
-
Andreas Haas authored
This reverts commit 6e5458b0. Reason for revert: UMA metrics cause errors when more than one WebAssembly module gets compiled, see https://bugs.chromium.org/p/chromium/issues/detail?id=1163528 Original change's description: > [v8-browsing] Add WebAssembly UMA metrics to v8-browsing > > This CL brings WebAssembly UMA metrics to the v8-browsing benchmark in > Telemetry. > > R=mythria@chromium.org, clemensb@chromium.org > > Bug: chromium:1084929 > Change-Id: I28e72378774c3d599da1ad670ba036a3f0ea84e0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497164 > Reviewed-by: Mythri Alle <mythria@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820779} TBR=ahaas@chromium.org,mythria@chromium.org,clemensb@chromium.org,johnchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1084929, chromium:1163528 Change-Id: Id160376c4f56c160cf48bb9575e4b3c6d629e540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627153Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#844012}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b2af2da3481c..f54810158ebb 2021-01-15 dberris@chromium.org Revert "chromeperf: Anomaly configs in subscriptions" 2021-01-15 dberris@chromium.org chromeperf: Remove outdated documentation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1158326 Tbr: oysteine@google.com Change-Id: Ia5ec64506320f332d3a31db3a564ffe8151167fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632367Reviewed-by:
-
Jérôme Lebel authored
Fixed: 903396 Change-Id: I4f2b7fa2d80f5248a6c9c04681bb8494e39061f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391131 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#844010}
-
Antia Puentes authored
This CL migrates the legacy IPC message out of extension_messages.h to Renderer mojo interface from extensions.mojom. Bug: 1165814 Change-Id: I338e9e1e59321d143053ec4c47bed7234c04ae5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627270 Commit-Queue: Antia Puentes <apuentes@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#844009}
-
Alice Wang authored
This CL moves logSigninStartUserAction to SigninMetricsUtils to group the signin metrics logging methods in one place. Bug: 1163476 Change-Id: I515a2c04f4bac3541a0a3bcee4097c3dabab95cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611715Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844008}
-
Sami Kyostila authored
Chrome is about to switch to the TRACE_EVENT macro implementation provided by Perfetto. The new implementation requires trace event statements to be terminated by semicolons, so this patch modifies the codebase to add semicolons where they were previously left out. No functional changes. Bug: 1006541 Change-Id: I589aed41f82edb909194234a5561e3096ca14a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627406 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Alice Wang authored
This CL disables the flaky test SearchActivityTest#testNewIntentDiscardsQuery. Bug: 1166647 Change-Id: I1a6edefbb2cb64bc9bf181a7fd9727822b651716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628954 Auto-Submit: Alice Wang <aliceywang@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#844006}
-
Jérôme Lebel authored
This patch makes the alert coordinator to show the account details more readable. Also this patch makes the _alertCoordinator variable lifetime more explicit. Bug: 1166148 Change-Id: I7a0fcf61b83573dc2d99244a2df639832a75fef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627322Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#844005}
-
Antonio Sartori authored
This is a small refactoring of the code in blink::CSPDirectiveList, removing the property CSPDirectiveList::eval_disabled_error_message_. This is part of a project to harmonize the CSP code in Blink and in services/network, and will make it easier to synchronize Content Security Policies between the two. Bug: 1021462,1149272 Change-Id: If9994d3bda9bde47433fcc089acb74ef0fdb426e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601746 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#844004}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/29da6d23a9d7..57654f96e343 2021-01-15 sigurds@chromium.org Import `ls` in NetworkConfigView If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I55d59e29d0026e00b02c5637af2f9da98decfe86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632466Reviewed-by:
-
Shik Chen authored
This CL shows the content of the QR code that is closet to the center of the camera frame if there are multiple QR codes detects. Bug: b/172879638 Test: Manually with two QR codes Change-Id: I236bf0a5652b67339051bb3603011209464de6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631549 Commit-Queue: Inker Kuo <inker@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#844002}
-
Matt Menard authored
This addresses the issue when the print servers config is updated before the print destination dialog is open which causes the print servers names never to be populated and doesn't allow print servers to be updated in this case. Bug: b:168650771 Change-Id: Ia8ec86d9660f86e05342247bed2f171ea13cf019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623110 Commit-Queue: Matt Menard <mattme@google.com> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#844001}
-
Frédéric Wang authored
This CL removes the following methods: WebSecurityPolicy::AddOriginToTrustworthySafelist SecurityPolicy::AddOriginToTrustworthySafelist SecurityPolicy::IsOriginTrustworthySafelisted Outside tests, these methods are only used to populate SecurityPolicy's safelist from SecureOriginAllowlist. The last one is only called from SecurityOrigin::IsSecure and SecurityOrigin::IsPotentiallyTrustworthy, but they can rely on SecureOriginAllowlist::IsOriginAllowlisted instead. Some tests also rely on SecurityPolicy::AddOriginToTrustworthySafelist, but they can directly set the command line parameters to configure the allow list accordingly. There is no observable behavior change but this makes easier to compare SecurityOrigin::IsSecure and SecurityOrigin::IsPotentiallyTrustworthy with network::IsURLPotentiallyTrustworthy, to facilitate unification of all these APIs. Bug: 1153336 Change-Id: I2df13abbdf697ec78136a16373b0b9fc6372bf88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612947Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#844000}
-
Nohemi Fernandez authored
Promote Sync as the default option in Settings. This will make the Settings terminology more consistent with following sign-in flow screens. Screenshot: https://drive.google.com/file/d/1CHdPdbjJ1ppB_TakOcB4JuiQtoJW3-ld Bug: 1151289 Change-Id: Ia053d6c07874d22ab4b77395d40140305b9dffc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627375Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#843999}
-
Markus Handell authored
This change exposes header extension control following spec details in https://w3c.github.io/webrtc-extensions/#rtcrtptransceiver-interface. Note: support for signalling directionality of header extensions in the SDP isn't implemented yet. https://chromestatus.com/feature/5680189201711104. Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/65YdUi02yZk Bug: 1051821 Change-Id: I7770fff0ebbab7ca316b811cf88da32bf5cc580c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597315 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#843998}
-
Matt Giuca authored
Activates the existing feature RemoveStatusBarInWebApps. This allows us to test it on Chrome OS. Bug: 1151487 Change-Id: I451147588eb7abe8ab77e30fd464b030b0312052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632107 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Auto-Submit: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#843997}
-
Anatoliy Potapchuk authored
This reverts commit 62cb2352. Reason for revert: causes linux-chromeos-dbg failures. example failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/22208 Original change's description: > system-web-apps: implements a new LaunchSystemWebAppAsync API > > This CL implements a new LaunchSystemWebAppAsync API, which is for other > chrome components to launch a SWA safely. This new API should be used > for SWA launches. > > The new API uses AppService to record metrics, handle disabled apps, > etc. > > The old LaunchSWA is deprecated (its logic now becomes LaunchSWAImpl). > > LaunchSWAImpl is publicly declared because certain browser tests need to > know the browser that hosts the SWA. It shouldn't be used to launch the > App (other than LaunchSWA and Web app implementations). Subsequent CLs > will attempt to migrate these browsertests to work with the new API. > > Bug: 1154540 > Change-Id: I648a3b0404067ba460f0174e975fae44b3a0001a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592270 > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Jiewei Qian <qjw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843939} TBR=jamescook@chromium.org,sky@chromium.org,ortuno@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,nancylingwang@chromium.org,qjw@chromium.org,dominicschulz@google.com Change-Id: If5742abcd9b31e66dfd9c15c0b6d40185d948f31 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1154540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632686Reviewed-by:
-
Tsuyoshi Horo authored
This CL introduces "scopes" attribute in <link> element for SubresourceWebBundles feature. https://github.com/WICG/webpackage/blob/master/explainers/subresource-loading.md#defining-the-scopes For example, if the following link tag exists in the page, <link rel="webbundle" href="https://example.com/dir/subresources.wbn" scopes="https://example.com/dir/js/ https://example.com/dir/img/ https://example.com/dir/css/"> subresources under "/dir/js/", "/dir/img/" and "/dir/css/" will be loaded from the web bundle "subresources.wbn". Bug: 1082020 Change-Id: I36ab832c301f33b0d0f1b6f4fea7e871f7ce2b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615732Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#843995}
-
danakj authored
Step 6 for bug 1125106. This is a subset of the mega-patch in https://chromium-review.googlesource.com/c/chromium/src/+/2462248. A same-document navigation should only be performed when the commit will happen in the currently loaded document. The renderer handled the browser doing the wrong thing in all kinds of ways, due to the browser making incorrect decisions when: - On an empty error page - Having an ongoing cross-document navigation which hasn't committed yet Now the browser does the right thing, so the renderer does not need to handle the fallback - except in one case which is a frameset. In that case the browser doesn't know the document is frameset, and the renderer currently enforces a policy that same-document navigations in a frameset document cause it to be reloaded. This is done for both renderer-initiated navigations (by sending the navigation to the browser process instead of performing the navigation immediately) and then by bouncing any same-document requests from the browser back as RestartCrossDocument. R=nasko@chromium.org Bug: 1125106 Change-Id: I74ca38a2213215a107c955127f1f664b96b58aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558926 Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#843994}
-
Omar Morsi authored
Before this CL, platform keys API tests were disabled because they were flaky. The main reason behind that was mixing chrome.test.callbackPass() and chrome.test.succeed() in more than one test. This introduces unpredictable behavior as if the callback counter is incremented anywhere in a test function, the test infrastructure will automatically invoke chrome.test.succeed(). For more information about this problem, please refer to https://chromium.googlesource.com/chromium/src.git/+/master/extensions/docs/testing_api.md#don_t-mix-chrome_test_callbackpass_et-al_and-chrome_test_succeed This CL fixes mixing chrome.test.callbackPass() and chrome.test.succeed() by adapting only one of them in each test. This is a quick fix so as to include platform keys API tests again in trybots, but a refactor to totally avoid using callbackPass is being tracked in crbug.com/1154680. The flakiness is verified to be fixed by running the suite 20 consecutive successful times using the following command. browser_tests --gtest_filter=*EnterprisePlatform* --gtest_repeat=20 Bug: 1157137 Change-Id: If7a94d4cc37e5b0719d18fdd3a9cef425de17ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624473Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#843993}
-
Canon Mukai authored
Replace value.View() with value.Get() since View() is deprecated. Get() does the same thing as View(), so I just rewrote 'View' to 'Get'. Change-Id: I1e77b1eb8854722af6501841f825082b60c5b2e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631870Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This reverts commit 18f22206. Reason for revert: https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/12159 Original change's description: > trigger_scripts: do not use use_swarming_go > > This is specified by default after https://crrev.com/c/2626865 > > Bug: 1127205 > Change-Id: I6d1b64ab6c68283196cc5614bfd26a2e03b025be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627651 > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843977} TBR=kbr@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenbinzhang@google.com Change-Id: If016b45324dfcf43c70a35ebcf8d203af8a192c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632546Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#843991}
-
Anatoliy Potapchuk authored
This reverts commit 669044bf. Reason for revert: ExternalConstantsOverriderTest.* tests were failing on many mac builders after adding them. example: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/33860 Original change's description: > Implement an ExternalConstants provider that reads from a base::Value. > > This is going to get populated with a JSONFileDeserializer. > > Bug: 1154901 > Change-Id: I5285b3b24a4d574c311addd44e34572b9e863c8b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598004 > Commit-Queue: Adam Norberg <norberg@google.com> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843868} TBR=sorin@chromium.org,waffles@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,milagreen@chromium.org,norberg@google.com Change-Id: Ieefffd98bc15542b8758a70c5590cdf90d3acc34 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1154901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632665Reviewed-by:
-
Christopher Cameron authored
This adds a zero-copy desktop capture mechanism to macOS. The frames are captured as NV12 IOSurfaces, packaged in IOSurfaces, and passed directly to the consumers (e.g, compositor, encoders, etc). This implementation is a trimmed-down version of the existing system, which can be found in the DesktopCaptureDevice class and the WebRTC class ScreenCapturerMac. The CGDisplayStream code is identical to the WebRTC code except for the following changes: - It requests NV12 as the capture format - It specifies the requested capture resolution (rather than capturing at retina resolution and downsampling in software) - It specifies kCGDisplayStreamMinimumFrameTime and kCGDisplayStreamColorSpace. Otherwise, all calls are identical. Bug: 1164736 Change-Id: I962911aa9b1863d730c333866f5644bbbd2b7164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616802 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#843989}
-
Keishi Hattori authored
Add use_backup_ref_ptr gn args flag which enables the ref count in PA and switches the CheckedPtr implementation to BackupRefPtr. Also turns off backup ref ptr support for NaCl as it is compiled as 32bit but address_pool_manager is not available, causing a link errors. https://source.chromium.org/chromium/chromium/src/+/master:base/BUILD.gn;l=1772 Bug: 1073933 Change-Id: I1e0ea1b1181623fa5783d39c6d9a379c1df2daf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626681Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843988}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610668478-7094d9e47d32a574227817d5f93a8aaa3dc9b368.profdata to chrome-mac-master-1610690109-720706a87994e4668591f57ede90f04b6ed715af.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic517e97e34cc6a69fb63ae812dba3a411359e7c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632169Reviewed-by:
-
Anatoliy Potapchuk authored
This reverts commit b7af27f9. Reason for revert: seem to cause infra failures Original change's description: > Roll goldctl (mac) from Cb3ZdanPJ... to Asi8KSWBq... > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll > Please CC bsheedy@chromium.org on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: None > Tbr: bsheedy@chromium.org > Change-Id: I5dd6f36473a83bc37b9f49e4c32558313fce09bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631472 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#843947} TBR=bsheedy@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: If840302f0f1ae3d7ccceca403277f47cba14ccf0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632605Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610668478-7263610d5b531e252a86c5f5dc54aba9a5ada050.profdata to chrome-win32-master-1610679078-fe2bb289a257049a216843cebd228815ff771bd5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib7250492bf0cae079f40cc185ce3f94b29799adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632166Reviewed-by:
-
Michael Bai authored
The experiment hasn't finished yet Bug: 1125778 Change-Id: I1e5e036cc8e41b77e8c3d79374e91301ac5c499e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625531 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843984}
-
