GitLab

Traverse flat tree instead of layout tree for ancestor style. Required
to update pseudo elements as part of style recalc.

Bug: 836126
Change-Id: I509b89ad6907f7856022fb3b28151829b6317f49
Reviewed-on: https://chromium-review.googlesource.com/1109828
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569316}

The gfx::AcceleratedWidget StructTraits had it passed by reference
instead of value. The underlying type is always a primitive so it should
be passed by value. Update StructTraits and mojom implementations.

Change the StructTraits implementation to fail deserialization for
platforms that don't support sending AcceleratedWidgets over IPC. Also
change StructTraits unittest not to need a test interface, directly
serialize and then deserialize instead.

Bug: none
Change-Id: Iee82df75d248fe48f5478ca5251a08238707758e
Reviewed-on: https://chromium-review.googlesource.com/1110023Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569315}

This reverts commit 40d02af1.

Reason for revert: Broke downstream release builders, and caused
large binary size regression.

Original change's description:
> [Android MR] Migrate session management
> 
> This CL migrates the session management part of MediaRouter.
> CreateRouteRequest is not used and we are using route selection
> to let CAF start sessions automatically.
> 
> Change-Id: I58d267418d9afd11f4f44520e8ca8ad94e82388b
> Reviewed-on: https://chromium-review.googlesource.com/1006358
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
> Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569080}

TBR=dtrainor@chromium.org,zqzhang@chromium.org,tguilbert@chromium.org

Change-Id: I8fae7d4492f873223b5efb3fc3e5d6acef37f981
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 855081, 855025
Reviewed-on: https://chromium-review.googlesource.com/1109981Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569314}

GetRootWindow can return null but ScheduleFlingProgress doesn't check
for it.

Bug: 855045
Change-Id: Ib82b8169d74efc02800bd7b975f111f653bbadc3
Reviewed-on: https://chromium-review.googlesource.com/1110260
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569313}

This reverts commit bdb95bb9.

Reason for revert: crbug.com/855107

../../chrome/browser/resource_coordinator/local_site_characteristics_database_browsertest.cc:15:10: fatal error: 'chrome/browser/notifications/desktop_notification_profile_util.h' file not found
#include "chrome/browser/notifications/desktop_notification_profile_util.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Original change's description:
> Reland "RC: Connect the Local DB to TabHelper and add browsertests."
> 
> This is a reland of 8f4ffc9a with a fix
> for a flakiness in LocalSiteCharacteristicsDatabaseTest.PRE_ClearHistory,
> the HistoryService::Delete task didn't always had time to run before we
> assumed that the entry had been removed from the history, this fix this
> by running RunUntilIdle() several time (until the deletion has
> complete)
> 
> 
> 
> Original change's description:
> > RC: Connect the Local DB to TabHelper and add browsertests.
> >
> > Bug: 773382
> > Change-Id: Ie7cbbf2c74bfbf1f1522b2a1f775a392545ad0a9
> > Reviewed-on: https://chromium-review.googlesource.com/1088196
> > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> > Reviewed-by: François Doray <fdoray@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#568519}
> 
> Bug: 773382
> Change-Id: I05072f974d70c200fff87e0239c8537c8d0bcfc8
> Reviewed-on: https://chromium-review.googlesource.com/1106940
> Commit-Queue: François Doray <fdoray@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569311}

TBR=fdoray@chromium.org,sebmarchand@chromium.org

Change-Id: I7d78bd84033e6ad7ea2ff30be3f4b28d86ababd1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 773382
Reviewed-on: https://chromium-review.googlesource.com/1110417Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569312}

This is a reland of 8f4ffc9a with a fix
for a flakiness in LocalSiteCharacteristicsDatabaseTest.PRE_ClearHistory,
the HistoryService::Delete task didn't always had time to run before we
assumed that the entry had been removed from the history, this fix this
by running RunUntilIdle() several time (until the deletion has
complete)



Original change's description:
> RC: Connect the Local DB to TabHelper and add browsertests.
>
> Bug: 773382
> Change-Id: Ie7cbbf2c74bfbf1f1522b2a1f775a392545ad0a9
> Reviewed-on: https://chromium-review.googlesource.com/1088196
> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568519}

Bug: 773382
Change-Id: I05072f974d70c200fff87e0239c8537c8d0bcfc8
Reviewed-on: https://chromium-review.googlesource.com/1106940
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569311}

Right now GetWebContents is done by first fetching GetWebUILoginView, which is
not available in LoginDisplayHostMojo; however, LoginDisplayHostMojo does have
an associated WebContents instance when it is hosting oobe in a dialog, so
return that.

Bug: 851012
Change-Id: Icb1f296ce4513369ecae424c717f9991baa142c0
Reviewed-on: https://chromium-review.googlesource.com/1100384Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569310}

On 32-bit machines, cookies with expiration dates beyond the year 2037
are stored with the expiration time as base::Time::Max(). When
converting to a double, this will return infinity(). infinity() cannot
be serialized in JSON, which can lead to a crash.

Instead, gracefully handle this case by setting the cookie to expire at
std::numeric_limits<double>::max(). Add a regression test for the same.

Bug: 848221
Change-Id: Id1bae19f785d864bf6d926f360a31f485d6dd574
Reviewed-on: https://chromium-review.googlesource.com/1105122Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569309}

Instead of using ArcBluetoothBridge as the pairing delegate and forward
pairing request to the UI dialog, use BluetoothPairingDialog directly,
which will automatically pair and handling incoming requests.

This would also fix the general bluetooth pairing regression which
incorrectly send the pairing request to ArcBluetoothBridge, so default
handling in BluetoothNotificationController is skipped unexpectedly.

Tested two device pairing flow[A] and ble signin flow[B].

A:
1. Get two chromebooks A and B, with B as your DUT.
2. After login on B, start a terminal, type in "bluetoothctl" and then
   "discoverable on".
3. On A, scan for B and then pair with B.
4. Confirm the passcode on A.
5. Confirm the passcode on B.

1. In settings, navigate to manage Android preferences.
2. Click Accounts to add a google account with a ble security key registered
as the second factor authenticator.
3. Follow the steps and observe a UI dialog show up and ask for passcode.
4. Enter the passcode and the pairing is successful (a notification is shown).

B: 
Change-Id: I48ce5d1968f4d532b72af7df5e5b6e7be586d7d8
Reviewed-on: https://chromium-review.googlesource.com/1109377Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569308}

R=dmazzoni@chromium.org

Change-Id: I67b011c0b140695be58f161bdeff39851d18f3e4
Reviewed-on: https://chromium-review.googlesource.com/1086447
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569307}

R=nektar@chromium.org,dmazzoni@chromium.org

Bug: 845474
Change-Id: I77f6dd6ef5c51ecbba2684c14c0680d0366ce6e3
Reviewed-on: https://chromium-review.googlesource.com/1108571
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569306}

This patch updates the composited bottom toolbar's shadow visibility
to depend on the android view's visibility. If the android view is
visible, the compositor shadow is not.

Bug: 854642
Change-Id: Ib1f3f1491fc8728ad5f49d8170145bd5d3161ce2
Reviewed-on: https://chromium-review.googlesource.com/1108343Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569305}

MoveContentBelowHeader() was not working correctly with the UI refresh
flag enabled because it only knew about the height delta, while we
actually needed to inset based on the expanded height.  This CL updates
the broadcaster API to send the collapsed and expanded toolbar heights
so that this information is available for these content adjustments.

This CL also updates CRWWebViewContentView to check against the old
value of self.contentInset rather than the |_contentInset| ivar.  This
fixes the bug where navigating back from a pdf wouldn't correctly
reset WKScrollView.contentInset since the value of |_contentInset| had
not changed from the previous value.

Bug: 849132, 851129
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1e46e4fc69fc0ac7a7d114b7c463e1f6a90964f9
Reviewed-on: https://chromium-review.googlesource.com/1094480
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569304}

The coordinator should only have references to sub coordinators and to
the mediator.

Change-Id: I6269e25f51b17f29c14730451ef67a82c2f59356
Reviewed-on: https://chromium-review.googlesource.com/1107124Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569303}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a28b14f12246..04925ac3f7e5


git log a28b14f12246..04925ac3f7e5 --date=short --no-merges --format='%ad %ae %s'
2018-06-21 sjg@chromium.org chromite_wrapper: add python3 support for except


Created with:
  gclient setdep -r src/third_party/depot_tools@04925ac3f7e5

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None
TBR=agable@chromium.org

Change-Id: I5f7e3eb0a52941d57e1d7d570f69190a58a15801
Reviewed-on: https://chromium-review.googlesource.com/1110199Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569302}

Unlike Windows and Linux, Mac allows top UI to show or hide in browser
fullscreen mode. Also this option can be toggled at runtime to make the
change. But in tab fullscreen mode, top UI should always hide. These
require propagating fullscreen and user preference changes, recording
the toolbar styles and applying the layout accordingly.

This CL makes sure the top chrome UI status is correct across different
fullscreen modes, and responds to user changes as well. Some tests are
also added.

BUG=851261,831219,852779
TEST=Pls check the toolbar/tabstrip show or hide correctly when
entering and exiting various fullscreen modes. Bookmark bar, slide-down
menu and traffic lights will be fixed later.

Change-Id: I78a2b68821d5e633ac5c2823f65390809a57dad5
Reviewed-on: https://chromium-review.googlesource.com/1102026
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569301}

The MediaControlsExpandGesture feature in Blink should be
linked to the Chrome feature.

BUG=825890

Change-Id: Ic070d901e7d9b52aa208d89e178eb5c17c93b3d4
Reviewed-on: https://chromium-review.googlesource.com/1108568Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569300}

https://skia.googlesource.com/skia.git/+log/ae17e65ef4b4..61582510eeb8


git log ae17e65ef4b4..61582510eeb8 --date=short --no-merges --format='%ad %ae %s'
2018-06-21 halcanary@google.com SkRefCnt, SkTypes: fix includes for clients
2018-06-21 herb@google.com Revert "Make SkRemoteGlyphCache tests use private glyph cache"
2018-06-21 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 cd70aa422ce6..3237f75953c1 (1 commits)
2018-06-21 borenet@google.com Add gclient_gn_args_from var to DEPS
2018-06-21 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 e5c614fbaf79..cd70aa422ce6 (8 commits)
2018-06-20 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-20 fmalita@chromium.org [skjson] Remove the scope index stack
2018-06-20 mtklein@chromium.org add hello-opencl
2018-06-20 bungeman@google.com Remove utility include from SkTypes.h
2018-06-20 bungeman@google.com Update gdb bitmap viewer.
2018-06-20 halcanary@google.com SkRefCnt.h no longer uses SkTLogic.h
2018-06-20 bsalomon@google.com Ensure that textures exported via SkImage::MakeBackendTextureFromSkImage
2018-06-20 brianosman@google.com Revert "Update GPU DM/nanobench configs for color testing"
2018-06-20 brianosman@google.com Update GPU DM/nanobench configs for color testing
2018-06-20 herb@google.com Make SkRemoteGlyphCache tests use private glyph cache
2018-06-20 bungeman@google.com Remove SkTSwap.
2018-06-20 borenet@google.com [recipes] Simplify test/perf dirs


Created with:
  gclient setdep -r src/third_party/skia@61582510eeb8

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=kjlubick@chromium.org

Change-Id: I7c5e6a64e53125191ff6474daa97a66a4b1aaa1a
Reviewed-on: https://chromium-review.googlesource.com/1109999Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569299}

Following bot results are included.
7011 7012 7019 7026 7029

1 lines were removed and 3 lines were deflaked by consecutive
results since 6982.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I37cda9e4efbeedcbabf0e71f50d88bd185e9df34
Reviewed-on: https://chromium-review.googlesource.com/1109588
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569298}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9fa1ff3ed9abbf5fcbed72b6a3c805194561c528
Reviewed-on: https://chromium-review.googlesource.com/1108450Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569297}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/653887dd..3cb681ba

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I31c014067ec2e1da60eabf08c0a203b6cc4400ab
Reviewed-on: https://chromium-review.googlesource.com/1110031Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569296}

This CL adds a current_rssi field to the mojom::ConnectionMetadata
struct and implements fetching this field throughout all classes
involved with returning the value.

Bug: 844759, 824568, 752273
Change-Id: I663326ceb7bb3c5113289f0b29a2ad9c26fcbfa9
Reviewed-on: https://chromium-review.googlesource.com/1106810Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569295}

This CL separates the logic which controls Mojo bindings from the rest
of MultiDeviceSetupImpl. This will allow me to add a follow-up CL
which adds an initialization step to this service.

Bug: 824568
Change-Id: I5cc870f44f8933b2eee16336e9476684fe6ada85
Reviewed-on: https://chromium-review.googlesource.com/1109276Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569294}

Bug: 824568
Change-Id: I411f838c9082e1dff6f713dec8c99b5e420e3b7f
Reviewed-on: https://chromium-review.googlesource.com/1109315Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569293}

Refer to that bug in the test expectations file.

TBR=dgrogan@chromium.org,kojii@chromium.org

Bug: 855039
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I9eb0827a1d56a7a196e862c6580dedb9fdffad3a
Reviewed-on: https://chromium-review.googlesource.com/1110122
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569292}

Android P splits some of the old android.test.* classes into what it
calls "legacy testing libraries." These need to interact with our build
system like the main android.jar does. That jar previously interacted
with the build system as a special case, though; this CL generalizes
it.

Bug: 841695
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie6a61bdafbf4990e6f82d9431ae8d7c2fd6ba709
Reviewed-on: https://chromium-review.googlesource.com/1102915
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569291}

Also remove some people who left the team.

Change-Id: Ib26f8d1f712d4b9955824fa0c548b0539fd8c3d7
Reviewed-on: https://chromium-review.googlesource.com/1110262Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569290}

This CL clips the content of the popup menu's table view to its bounds,
making sure its content, including the selection highlight respect the
bounds set by the rounded corners.

Bug: 850511
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I516224790aed23fd88387ac3236d36861697cde3
Reviewed-on: https://chromium-review.googlesource.com/1110129
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569289}

Intent to Ship thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/wJwVSo52Dno/CjrUTTuyBAAJ

Bug: 731170
Change-Id: I53274b2bf5a622cb50d4b59f521bf56160172b61
Reviewed-on: https://chromium-review.googlesource.com/1100884
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569288}

The CL https://chromium-review.googlesource.com/c/chromium/src/+/1104682/9/components/signin/core/browser/signin_manager.cc
introduced a regression, leading to cookies not being merged correctly.
The cookies should be merged in all cases except Mirror, but that CL
did the opposite (only merging cookies when Mirror is enabled)

Change-Id: Ib3c5454259ff6b7ec82bb2411bcff011bc63f3e1
Bug: 777774
Reviewed-on: https://chromium-review.googlesource.com/1109976Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569287}

On Samsung Lollipop devices the Intents used to communicate with a
foreground WebappActivity were causing a new instance of the
WebappActivity to be launched instead of causing onNewIntent of the
current Activity to be run. This only occurs when a
ChromeTabbedActivity is in the background, when it is not, onNewIntent
is called properly.

I'm not sure what is special about WebappActivity that causes this -
I've been unable to generate a smaller repro.

This issue is solved however by making sure both the
FLAG_ACTIVITY_NEW_TASK and FLAG_ACTIVITY_NEW_DOCUMENT (which was
FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET in pre-Lollipop) have been set
on the Intent and FLAG_ONE_SHOT has been set on the PendingIntent.

Bug: 846528
Change-Id: I9602537e68b24a186961d29f4c4b1fb1ae9235b0
Reviewed-on: https://chromium-review.googlesource.com/1107631Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569286}

The main menu has a built-in 100ms delay. Combined with higher priority for
incoming NSEvents compared to chrome tasks, holding down key equivalents [e.g.
cmd + w] starves the chrome task queue. The implementation of tab-closing
requires the main thread to process the on unload ACK from the renderer before
closing the tab [which is a chrome task], so this causes a live-lock.

This CL lets reserved keyEquivalents bypass the main menu. This avoids the
live-lock indicated above. This also loses the built-in 100ms throttle, so this
CL adds a custom 50ms throttle [disabled in tests].

Bug: 836947
Change-Id: Idb88ee84d7aa82da4104893ed85358c75e385ea3
Reviewed-on: https://chromium-review.googlesource.com/1108095
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569285}

Android WebView had the UseSurfaceLayerForVideo feature enabled
unintentionally which was causing a crash. This was fixed in
https://crbug.com/853832. Enable WebView perf tests that got disabled
due to the crash.

Bug: 853204
Change-Id: Ib678a48ec723f40a4ab3be72f6078cafcfc311c6
Reviewed-on: https://chromium-review.googlesource.com/1110018Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569284}

Using wpt-import in Chromium 8a119eb7.
With Chromium commits locally applied on WPT:
03ef65db "Update existing WebUSB WPT to be multi-global"
89102421 "Reland "Multi-global WebUSB WPT for window and worker""


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19946

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request

TBR=robertma

No-Export: true
Change-Id: Ifa23c23d080a1981f76955170b511f4239fa9396
Reviewed-on: https://chromium-review.googlesource.com/1109743
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569283}

The old Symantec PKI will be fully distrusted in M70
(https://security.googleblog.com/2018/03/distrust-of-symantec-pki-immediate.html). We
already have DevTools console messages in place for affected resources, and this
CL adds UseCounters so that we know how many page loads will be affected.

The counters give us:
- % of page visits with an affected main frame main resource
- % of page visits with an afected subframe main resource
- % of page visits with an affected subresource

Note that these buckets can overlap, for example a single page visit can
increment all 3 counters.

Bug: 853868
Change-Id: I7ae103efcc47a3e4e381b35c6803ef2d8ed4c7fb
Reviewed-on: https://chromium-review.googlesource.com/1107841
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569282}

The next-generation C++ APIs for interacting with the user's Google
identities currently do not give the ability to fetch access tokens
for arbitrary accounts; rather, there exists only the
PrimaryAccountAccessTokenFetcher, which provides user-friendly access
token fetching for the primary account.

This CL introduces an analogous AccessTokenFetcher class that allows
such user-friendly access token fetching for arbitrary accounts. This
class is currently built on top of the Token Service, as it remains
future work to expose access token fetching APIs on IdentityManager
itself. Once that future work is completed, AccessTokenFetcher will
be ported to be layered on top of IdentityManager. In the meantime,
we introduce IdentityManager::CreateAccessTokenFetcherForAccount()
to allow consumers of IdentityManager to create an AccessTokenFetcher.
Note that our intention is that even in the long-term consumers will
use AccessTokenFetcher and PrimaryAccountAccessTokenFetcher as the
interfaces for fetching access tokens, rather than interacting directly
with IdentityManager's lower-level APIs.

This CL also ports PrimaryAccountAccessTokenFetcher to internally use
AccessTokenFetcher rather than directly fetching access tokens from
ProfileOAuth2TokenService.

API design note: It would be reasonable to build PAATF's idea of an
"access token fetching mode" into AccessTokenFetcher: in this context,
kWaitUntilAvailable would simply mean waiting until the refresh token
was available. This CL does not add such a mode. However, for Sync's
use case having the mode will likely be useful (Sync will alternately
use the primary account and an arbitrary account, and it would be
ergonomic to be able to fetch access tokens in both contexts using
AccessTokenFetcher). Hence, followup work will move this mode down
into AccessTokenFetcher.

Bug: 729547
Change-Id: Id296adcd1567d6cbfbaf6ffd1dafb718c1f01ed7
Reviewed-on: https://chromium-review.googlesource.com/1104118
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569281}

The IDL tests in the subdirectories aren't really needed anymore since
we have webaudio/idlharness.https.html that covers everything in the
individual tests.

Bug: 854220
Change-Id: I589f4972922dfc15c475ce20e7c4cb664b529920
Reviewed-on: https://chromium-review.googlesource.com/1107120Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569280}

The dispatcher wasn't set for the primary toolbar used by the NTP,
leading to bugs where the commands weren't sent to the rest of the
application.

Bug: 851930
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I17b2e015a307e993e548c4dfcbca599472503d58
Reviewed-on: https://chromium-review.googlesource.com/1110123
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569279}

TalkBack should just speak the cell data for cells in table.

TBR=avi@chromium.org

Bug: 669622
Change-Id: Iecb736acdbe36d106672b97425bb72988eef1efa
Reviewed-on: https://chromium-review.googlesource.com/1108920
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569278}

We're getting ready to roll extension bindings out to beta, so add a
fieldtrial testing config entry for the experiment to have it run by
default on the bots.

Bug: 763564

Change-Id: Ibdf83e16cbc10e4c62e2304cf14cd7c24377bc31
Reviewed-on: https://chromium-review.googlesource.com/1108192Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569277}