GitLab

None of the implementations if WindowTreeHosts do anything when
the device-scale factor changes. So remove it.

BUG=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/389663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282799 0039d316-1c4b-4281-b951-d872f2087c98

Do not call Pipeline::On{Audio|Video}RendererEnded() because it's pipeline's
implementation detail and will go away. Instead, let the mock renderers call the
ended_cb.

Also rename several helper functions to reflect what they really do.

BUG=392259
TEST=All current tests pass.

Review URL: https://codereview.chromium.org/388763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282798 0039d316-1c4b-4281-b951-d872f2087c98

Video renderers don't need the information as they are already making
audio/video synchronization decisions based on a media timeline that
already incorporates the current playback rate via the time callback.

In particular, VideoRendererImpl only used playback rate to estimate
a better duration to sleep until the current frame was ready ...
except that in most cases we'd sleep for kIdleTimeDelta and wait
until the media timeline had progressed past the current frame's
timestamp. In other words, there's absolutely no reason to even try
to estimate the sleep duration based on the playback rate.

BUG=370634

Review URL: https://codereview.chromium.org/384943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282797 0039d316-1c4b-4281-b951-d872f2087c98

Calling it with render_frame_host is wrong because that object
might have been deleted above. Only dest_render_frame_host is valid
at this point.

BUG=393032
TBR=nasko

Review URL: https://codereview.chromium.org/380413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282796 0039d316-1c4b-4281-b951-d872f2087c98

With media files copied over to media/test/data, this CL makes media related content browser tests and chrome browser tests load test data from one location. 

The location is common with media unit tests data forder;  managed in one place in media/base/test_data_util.h 

BUG=379314

Review URL: https://codereview.chromium.org/357413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282795 0039d316-1c4b-4281-b951-d872f2087c98

If an event is redirected to a different WindowTreeHost because the target
window belongs to that, then make sure the event is in the WindowTreeHost's
root-window's coordinate space. This is necessary to make sure that the
target (and the pre/post-target handlers) see the event in the correct
location.

BUG=385770
R=sky@chromium.org

Review URL: https://codereview.chromium.org/380343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282794 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282793 0039d316-1c4b-4281-b951-d872f2087c98

> Enable media in default GN build.
> 
> Roll ffmpeg to pick up build fix. f620cda6 -> 04bb33e9
> 
> All hail GN. oRZ
> 
> BUG=none
> TBR=brettw
> 
> Review URL: https://codereview.chromium.org/381903003

TBR=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/387103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282792 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282786 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Breaks speedometer. Should be a ListOfScalarValues.

Traceback (most recent call last):
  _RunPage at tools/telemetry/telemetry/page/page_runner.py:534
    test.RunPage(page, page_state.tab, results)
  RunPage at tools/telemetry/telemetry/page/page_test.py:247
    self.ValidatePage(page, tab, results)
  ValidatePage at tools/telemetry/telemetry/page/page_measurement.py:62
    self.MeasurePage(page, tab, results)
  MeasurePage at tools/perf/benchmarks/speedometer.py:36
    tab.EvaluateJavaScript('benchmarkClient._timeValues')))
  __init__ at tools/telemetry/telemetry/value/scalar.py:19
    assert isinstance(value, numbers.Number)
AssertionError

Locals:
  important : True
  name      : 'Total'
  page      : <telemetry.page.page.Page object at 0x1d6e590>
  units     : 'ms'
  value     : [13237.9869999991, 13351.2720000012, 14052.7640000023, 14136.3950000013, 13685.9580000001, 14048.2879999999, 14010.3279999989, 13941.6210000018, 14087.0519999998, 13388.6279999983]

Original issue's description:
> Update speedometer to use results.AddValue
> 
> BUG=391943
> TBR=nduca@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282750

TBR=nduca@chromium.org,nednguyen@google.com
NOTREECHECKS=true
NOTRY=true
BUG=391943

Review URL: https://codereview.chromium.org/387953006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282784 0039d316-1c4b-4281-b951-d872f2087c98

This allows using the VIDEO_HOLE outside of Android.

R=xhwang,damienv1
BUG=392993

Review URL: https://codereview.chromium.org/375713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282783 0039d316-1c4b-4281-b951-d872f2087c98

The callback was not used

Review URL: https://codereview.chromium.org/387123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282782 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282781 0039d316-1c4b-4281-b951-d872f2087c98

Roll ffmpeg to pick up build fix. f620cda6 -> 04bb33e9

All hail GN. oRZ

BUG=none
TBR=brettw

Review URL: https://codereview.chromium.org/381903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282780 0039d316-1c4b-4281-b951-d872f2087c98

The definitions of hit test masks and related logic
have beed moved into MaskedTargeterDelegate, so
remove HasHitTestMask(), GetHitTestMaskDeprecated(),
and the HitTestSource enum from views::View.

BUG=388838
TEST=ViewTargeterTest.HitTestCallsOnView

Review URL: https://codereview.chromium.org/365263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282779 0039d316-1c4b-4281-b951-d872f2087c98

Possible failure on Android ( http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Tests%20%28dbg%29&number=21495 )

> Change PhoneNumber::SetInfo to only apply formatting where there is none
> 
> See discussion on https://codereview.chromium.org/347183005/
> 
> BUG=none
> 
> Review URL: https://codereview.chromium.org/374053007

TBR=estade@chromium.org

Review URL: https://codereview.chromium.org/383123011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282778 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372212
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/372883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282777 0039d316-1c4b-4281-b951-d872f2087c98

We will be using the AsDict() call to support JSON output of Telemetry results.
This CL adds the ability to output the important information associated with a
page to the Telemetry Page class.

BUG=375541

Review URL: https://codereview.chromium.org/388653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282776 0039d316-1c4b-4281-b951-d872f2087c98

Replicates FFmpeg's behavior for frame allocation.  They do not zero
the frame on subsequent pool reuse, so I have not done so either.

BUG=390941,390944,390945
TEST=new unittest.

Review URL: https://codereview.chromium.org/383893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282775 0039d316-1c4b-4281-b951-d872f2087c98

R=thakis@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/383543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282773 0039d316-1c4b-4281-b951-d872f2087c98

Currently, every single test case needs to check whether the infobar or tha password bubble is used, and do different checks accordingly. Even worse, auto-saving behaviour is different for those two, so people modifying existing tests are very likely to have false expectations.

This CL creates a PromptObserver class by decoupling prompt observing from navigation observation. PromptObserver takes care of the differences between infobar and bubble automatically, and provides a clear API to check for the prompt being shown, and to instruct the prompt to save passwords, respectively.

BUG=392144

Review URL: https://codereview.chromium.org/378643006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282772 0039d316-1c4b-4281-b951-d872f2087c98

The new Handoff feature in OSX 10.10 only works with devices that support
Bluetooth LE. Record metrics to determine the percentage of Chrome users that
this affects.

BUG=392166

Review URL: https://codereview.chromium.org/374203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282771 0039d316-1c4b-4281-b951-d872f2087c98

The private key's the hard one, but this is a first step
and can be independent of USE_OPENSSL_CERTS.

BUG=362035

Review URL: https://codereview.chromium.org/383003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282770 0039d316-1c4b-4281-b951-d872f2087c98

This CL turns const by value return values into const by ref. 

Replacing const value by a const ref when a member variable is safe, because
the member variable will live at least as long as the temporary object returned
now. It can also be more efficient, because returning a ref can spare copying.

BUG=393155

Review URL: https://codereview.chromium.org/382243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282769 0039d316-1c4b-4281-b951-d872f2087c98

BUG=388506

Review URL: https://codereview.chromium.org/386093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282768 0039d316-1c4b-4281-b951-d872f2087c98

This is so that callers can code against a TaskRunner interface
directly, rather than converting message_loop_proxy() into a TaskRunner.

BUG=391045

Review URL: https://codereview.chromium.org/389653005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282767 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364141

Review URL: https://codereview.chromium.org/378873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282766 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282765 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282764 0039d316-1c4b-4281-b951-d872f2087c98

1950: Edited wiki page GypHacking through web user interface.
1949: Fixes two bugs in analyzer

BUG=383609
TEST=none

Review URL: https://codereview.chromium.org/385283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282763 0039d316-1c4b-4281-b951-d872f2087c98

BUG=346958

Review URL: https://codereview.chromium.org/385983009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282762 0039d316-1c4b-4281-b951-d872f2087c98

See discussion on https://codereview.chromium.org/347183005/

BUG=none

Review URL: https://codereview.chromium.org/374053007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282761 0039d316-1c4b-4281-b951-d872f2087c98

I started with CreateNode so that you can get a feel for how this
would look. I may need a couple of other error codes, but not many
more.

BUG=384437
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/383293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282760 0039d316-1c4b-4281-b951-d872f2087c98

The crash occurs because a scoped_ptr instance which holds the TestLegacyRenderWidgetHostHWND class
is left with a dangling pointer to the LegacyRenderWidgetHostHWND instance which is destroyed via
DestroyWindow.

Fix is to first reset the scoped_ptr which in turn destroys the legacy window and the instance.
The DestroyWindow call is removed as it is not needed anymore.

I also added a call to the CreateATLModuleIfNeeded helper function in BrowserAccessibility::Create as I was
hitting a crash due to a NULL AtlModule. We do this already in the ctor of the BrowserAccessibilityManagerWin
class. However that is too late as we have base classes which create COM objects.

This crash only happens in the component builds.

BUG=393228

Review URL: https://codereview.chromium.org/383263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282759 0039d316-1c4b-4281-b951-d872f2087c98

This is to facilitate overriding UI strings from the variations service.

BUG=370033

Review URL: https://codereview.chromium.org/322523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282758 0039d316-1c4b-4281-b951-d872f2087c98

1. Moved creation of ConnectionToHost to ChromotingClient. Previously
   ConnectionToHost had to be passed in the constructor.
2. Authentication now is created outside of ChromotingClient. This
   allowed to remove ClientConfig struct (it was used mostly to
   pass authentication parameters). This will also allow passing
   a fake authenticator for tests.
3. Removed ClientConfig.

Review URL: https://codereview.chromium.org/384523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282757 0039d316-1c4b-4281-b951-d872f2087c98

SocketLibevent release ref-count of read/write buffer before calling callback.
Need to hold ref-count of buffer in TCPSocketLibevent to make sure the buffer
alive in callback.

BUG=393221

Review URL: https://codereview.chromium.org/382143007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282756 0039d316-1c4b-4281-b951-d872f2087c98

This deletes some assets that are now unused:
 - infobar_button_*
 - infobar_shadow
 - infobar_update_uma (not used in Chromium)

Updates some infobar icons with pretty new blue versions:
 - infobar_microphone
 - infobar_protected_media_identifier

And deletes icons for infobars that never appear on Android:
 - infobar_theme
 - infobar_cookie
 - infobar_desktop_notifications
 - infobar_didyoumean
 - infobar_plugin
 - infobar_plugin_crashed
 - infobar_restore

This also renames infobar_autofill.png to infobar_autofill_cc.png since
it always refers to credit card-related autofill.

R=dfalcantara@chromium.org, dtrainor@chromium.org, estade@chromium.org, oshima@chromium.org
TBR=oshima@chromium.org
BUG=375379
BUG=386359

Review URL: https://codereview.chromium.org/383123008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282752 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369552

TBR=xiyuan

Review URL: https://codereview.chromium.org/387143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282751 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/386893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282750 0039d316-1c4b-4281-b951-d872f2087c98