GitLab

This documentation is not very clear and a bit out of date/incorrect.
Updated to make it clearer.

Change-Id: I125d73884838c388ead20d62de5f0cba093715ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318426
Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791804}

As https://crrev.com/c/2299189 adds `OS_MAC` & `OS_APPLE`, add a gn
variable `is_apple` that is true when `OS_APPLE` is defined. This
allow an easy mapping between gn variables and cpp macros.

Convert all usages of `is_ios || is_mac` or `is_mac || is_ios` to
use the new variable instead.

Bug: 1105907
Change-Id: I4cef55496a0ccf0a6162e60409ff3b7996f633dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315695
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791803}

According to the following spec radio and menuitemradio should expose
UIA SelectedItem.IsSelected when aria-checked is set :
https://www.w3.org/TR/core-aam-1.1/#mapping_state-property_table

This CL ensures that radio / menuitemradio fire appropriate
SelectionItem events, and whenever a SelectionItem changes its
selection state that we also fire a Property Changed event for
SelectionItem.IsSelected.

AX-Relnotes: Fire missing events for ARIA radio/menuitemradio when aria-checked changes. Narrator will now announce selected state changes for this scenario.
Bug: 1102580
Change-Id: I72f479e25f61b0ddffc28f73d4a9c34e8dc4ecb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212982Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#791802}

Bug: 1107762
Change-Id: I8b5f928ac091811f4b7b6461acfbc1885ffc8093
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313100Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791801}

Bug: 1098883
Change-Id: I52fd87ecd652e7224fd6190f1f58ba36b4f6b148
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276311Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Commit-Queue: Ben Schwartz <bemasc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791800}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f4f0170b8694..450afef18d5b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC rsorokin@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: rsorokin@google.com
Change-Id: I6c9a90af068b282d62735d0b05c012e71b112a57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320034Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#791799}

Bug: none
Change-Id: I29a3fb669cbda96ca11c3fd3838347722f1023dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317993
Auto-Submit: Avi Drissman <avi@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791798}

This reverts commit 69a60019.

chrome-prefixed URLs are exempted from the getUserMedia() requirement.

Original change's description:
> Revert "Do not expose media devices before a successful getUserMedia()"
>
> This reverts commit d64e736a.
>
> Reason for revert: Caused chrome_all_tast_tests / camera.CCAUISanity.fake failures; e.g. https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/7680
>
> Original change's description:
> > Do not expose media devices before a successful getUserMedia()
> >
> > This is a spec-compliance change.
> >
> > This CL also adds some improvements to the blink MediaDevices unit test.
> >
> > Bug: 1101860
> > Change-Id: If2e7824df3b3dbd3cdb80f4bcf6b5c417d6f0ef2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279808
> > Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> > Reviewed-by: Harald Alvestrand <hta@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#786253}
>
> TBR=hta@chromium.org,guidou@chromium.org
>
> Change-Id: I41b676c7d3e437c06d23f2b46270453f1cc81670
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1101860
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288282
> Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
> Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#786615}

TBR=mohsen@chromium.org,hta@chromium.org,guidou@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1101860
Change-Id: I3fb6d9a620291cda57eb5fe48ce330b45425a5bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289833
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791797}

Fix after https://crrev.com/c/2315691, which references
mac_xcode_version without importing gclient_args.gni where it gets
defined. It only worked in the Chromium project since the import
is in Chromium's build overrides.

Bug: 1109624
Change-Id: I575c7b87dbb96c3a79b8243bfe63c33b2427479d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317871Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791796}

Compositing SVG exposed a bug where the filter paint property was not
used when painting. Before CompositeSVG, this was not needed because
filter paint properties were not created for SVG. This will be useful
when SVG supports CSS filters (https://crbug.com/109224).

Bug: 1106780
Change-Id: I664995c8b81f201e9e30e0a670e9c252829013ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311114Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791795}

The test was incorrectly removed at
https://chromium-review.googlesource.com/c/chromium/src/+/2302193

Bug: 1045846
Change-Id: I8c7f386a245b5a9fc9cc44c8976b220ed5b11b18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317879
Auto-Submit: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791794}

This patch reintroduces the visibility flag to the native update prarms
in the ToolbarSceneLayer. The reason for this is that the tree becomes
stale and keeps some of the layers around (currently no easy alternative
to detaching layers). This patch also makes the layer always "visible"
according to isSceneOverlayTreeShowing as it would otherwise block the
extra frame to make the layer [in]visible.

Bug: 1109126
Change-Id: If8aed99d9cd6b7d436b563064be3c33b3deea8b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317291Reviewed-by: Mei Liang <meiliang@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791793}

Crostini registers Linux applications it knows about, however many GUI
Linux apps don't have .desktop files to register or icons to show but
they still have windows that should appear in the shelf. For them we
show a default penguin icon as a fallback when we can't find a better
icon. This was broken per the linked bug.

There are two changes to fix this:
1. We end up in RequestContainerAppIcon, however this method ignores
requests for unregistered apps and never calls the callback. Fix that by
skipping directly to returning no icon instead of calling
RequestContainerAppIcon
2. Pass app_id to LoadIcon in crostini_apps so it can tell if it's being
asked for an icon for an unregistered Linux app (as opposed to e.g. an
unregistered PluginVM app) and update a check to handle this
appropriately.

Bug: chromium:1106280
Test: manual - run some Crostini apps and look for penguins

Change-Id: Iacf7c889989a4e91db16adf1244f13e56a71e97b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318891Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: David Munro <davidmunro@google.com>
Cr-Commit-Position: refs/heads/master@{#791792}

This change adds reauthentication mechanism before revealing password on
Password Details Screen. Reauth will be requested before showing,
editing or copying password. Password editing and copying to be done in
the future CLs.

Bug: 1075494
Change-Id: Idbebddb9dcdb0928af16e115d69c6fe28860c872
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302753
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791791}

Makes sure initialization of tests is correct and also non-Ozone/X11
specific tests are not run when OzonePlatform feature is used.

-----

PS: Please note that this is a temp solution that will help to choose
between ozone and non-ozone X11 build. The switch that will be used
to choose the path is --enable-features=UseOzonePlatform. Once
non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how
th finch trial goes), the wrapper will be removed.

Please also note that it's impossible to build use_x11 && use_ozone
without some hacks in PlatformCursor code. The changes to that are
on their way to upstream.

----

Bug: 1085700
Change-Id: If9f7e04b0c39dfe2782622f225de7d1b901575f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315144
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791790}

This reverts commit 2c79a900.

Reason for revert: tests have stopped to fail and should have low
flakiness score now.

Original change's description:
> Disable MigrationSingleClientTest tests due to flakiness
>
> Tests disabled on Windows:
> - MigrationSingleClientTest.PrefsOnlyTriggerRefresh
> - MigrationSingleClientTest.PrefsOnlyModifyBookmark
>
> Bug: 1094907
> Change-Id: Ifba9e0a15138f4875ed6d2cb1ec1392b29b16c17
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294859
> Commit-Queue: Rushan Suleymanov <rushans@google.com>
> Auto-Submit: Rushan Suleymanov <rushans@google.com>
> Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
> Cr-Commit-Position: refs/heads/master@{#787685}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1094907
Change-Id: Ic3a2e4e77d49aeaaf3de83aa701f7305b31d76e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317803Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/master@{#791789}

This CL implements the RemoteApps PublisherBase and RemoteAppsManager
which are used to manage Remote Apps. Remote Apps are items which are
added to the launcher but are not backed by an app/extension/web app.
Instead, the item is managed by an extension via an API. The extension
is able to add multiple items and folders to the launcher and observe
when the items are launched. The extension can then decide on how to
handle the launch event. Currently RemoteApps are only available to
Managed Guest Sessions.

RemoteAppsManager is the KeyedService which handles the adding and
deleting of Remote Apps and folders. RemoteAppsManager also implements
RemoteApps::Delegate and is used by RemoteApps to handle the LaunchApp(),
GetIcon() and GetMenuModel() methods.

RemoteAppsManager is not initialized as a KeyedService so this CL does
not change any existing behavior.

Bug: 1101208
Change-Id: I664469fa0284c6e65288e59ba7a5d1271b081a04
DD: go/cros-remote-apps
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299226
Commit-Queue: Jit Yao Yap <jityao@google.com>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791788}

This change adds support for multiple projections to util::ranges by
improving the capabilities of the ProjectedBinaryPredicate. The
resulting object will now consider several permutations of the provided
projections, and choose an appropriate one. This change required the
introduction of a few internal helpers.

Bug: 1071094
Change-Id: I46b05e1e0ddf0b15b0ed1518fb6de263bb23b8a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310533
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791787}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e5505fa8a8ca..cec3e4fd4e86

2020-07-27 janscheffler@chromium.org Migrate `front_end/worker_service` to `devtools_entrypoint`
2020-07-27 mathias@chromium.org Revert "De-obfuscate X-Client-Data header values in Network tab"
2020-07-27 jacktfranklin@chromium.org Component bridges: Support nested interfaces/types in unions
2020-07-27 janscheffler@chromium.org Migrate `front_end/workspace_diff` to `devtools_entrypoint`
2020-07-27 jacktfranklin@chromium.org Add support for `type X =` to component bridges
2020-07-27 jacktfranklin@chromium.org Add support for type aliases to component bridges generation
2020-07-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1101738,chromium:1103854
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I47ba1c85d97520bae3dcd7957ec13695ca1dcd70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320045Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#791786}

When the page is preloaded, a session restoration is done.
But the "visible" page isn't loaded as it would in a normal session
restoration.
This CL makes sure that this page gets the correct UA.

Bug: 1100852
Change-Id: Ia666dd17e512c8d9c7e84e750722dae90f56ca14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279757
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791785}

TBR=afakhry@chromium.org

Bug: 1106036
Change-Id: I03a33991b8956ea702ef85fd6b5e3f481c2e9096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320166Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791784}

This CL moves this message out of view_messages.h and adds a new method
in blink::mojom::RemoteMainFrameHost to allow notifying a renderer, via
the browser process, that the window of its main frame needs to be
closed when the request got originated in a different process.

For requests originated in the same renderer process than the one
hosting the main frame whose window needs to be closed, this CL
simply delegates on WebWidgetClient::CloseWidgetSoon().

Last, this CL adds a new helper FakeRemoteMainFrameHost helper class
to allow migrating one WebFrameTest that was currently relying on the
WebViewClient::CloseWindowSoon() method, which no longer exists, to
test that a remote window has been correctly instructed to close.

Bug: 1102449
Change-Id: Iaefc432a71bba50be0e00e9e1c98170d2759c529
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309704Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#791783}

When PasswordModelTypeController was updated to support the
account-scoped password storage, a condition was added to its
GetPreconditionState() method to make sure Password Sync only runs if
either Sync-the-feature is enabled, or the user has opted in to the
account-scoped storage.

However, for the case of local Sync, Sync-the-feature is *not*
considered enabled (and of course no account-storage-opt-in exists).
So this broke local Sync for Passwords.

Bug: 1108609
Change-Id: I2bb2edb7247d3b2e95dba306718488352329840b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316214
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791782}

Removes unnecessary case for surface handle (non-Ozone X11 and Ozone has
the same type of AcceleratedWidget now), chooses correct path based on
OzonePlatform feature usage.

-----

PS: Please note that this is a temp solution that will help to choose
between ozone and non-ozone X11 build. The switch that will be used
to choose the path is --enable-features=UseOzonePlatform. Once
non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how
th finch trial goes), the wrapper will be removed.

Please also note that it's impossible to build use_x11 && use_ozone
without some hacks in PlatformCursor code. The changes to that are
on their way to upstream.

----

Bug: 1085700
Change-Id: I3f82aa08d02e8daa58ab39831b67ddb91d25913c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315026Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#791781}

Flaky on Windows.

TBR=minggang.wang@intel.com

Bug: 1104847
Change-Id: Idbed763741b2fdf2fe3e8697b2465633bf14f007
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317884Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791780}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/374acd70..f23e4df5

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Id8ca62422f4797c66cb734a627a75453889a91f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320107Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#791779}

It was difficult to understand the current constraint layout of the
"Turn on Sync" page due to the inconsistencies in the view manipulation.
This patch attempts to make the layout and styling of the views and
buttons more straightforward.

Bug: 1105853
Change-Id: I0c0bca5aa1be5200d3be414804976efc8ed7ef22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312556
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791778}

Bug: 1104264
Change-Id: I535e5a6abdcc17726d0e55fd4d405b2cce08c7d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292526
Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791777}

We still need it: the title can be empty in some scenarios.

Looks like we need to generate some icon based on url
to show this icon for a user in web app install dialog, where
user should enter a non-empty title.

1) WebAppInstallTask::OnIconsRetrievedShowDialog()
2) FilterAndResizeIconsGenerateMissing()
3) Show dialog with the generated icon, `title` is still empty here.

This is a partial revert of
https://chromium-review.googlesource.com/c/chromium/src/+/2312056

The title populating code is left there in unit tests.

Bug: 1109540, 1103570
Change-Id: Ia281397d3483ad08d02ae4a9f0e2ca60bd34e859
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319493Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791776}

Due to flakiness

TBR=stkhapugin@chromium.org

Bug: 1107877
Change-Id: I134760ea3b31c9e5e93319e3180a760de4c15c6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317882Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791775}

Bug: 1079297
Change-Id: I071760c7bae8a6648b1c6d7f6047702af56f7002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316199
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791774}

https://skia.googlesource.com/skia.git/+log/befe11cae7c1..ec788be8b577

2020-07-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from df5ed61ddbca to 3f851efa2adc (5 revisions)
2020-07-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 6a8a74986c35 to 3b2cd31c7400 (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC borenet@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: borenet@google.com
Test: Test: Test: KHR-GLES31.core.shader_storage_buffer_object.basic-syntaxSSOTest: Test: KHR-GLES31.core.vertex_attrib_binding.advanced-bindingUpdateTest: Test: KHR-GLES31.core.vertex_attrib_binding.advanced-largeStrideAndOffsetsNewAndLegacyAPITest: Test: Manual script execution and building in AOSP
Change-Id: Ibbaaa2cf381fc4a4792d4b500510eee5e313998e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319971Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#791773}

Disables/enables tests for Ozone/Linux or non-Ozone/X11

-----

PS: Please note that this is a temp solution that will help to choose
between ozone and non-ozone X11 build. The switch that will be used
to choose the path is --enable-features=UseOzonePlatform. Once
non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how
th finch trial goes), the wrapper will be removed.

Please also note that it's impossible to build use_x11 && use_ozone
without some hacks in PlatformCursor code. The changes to that are
on their way to upstream.

----

Bug: 1085700
Change-Id: I48797083cecf61929e10381d740590fc4584137d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315027
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791772}

The 10 minute timeout logic follows: https://docs.google.com/presentation/d/13qExIGI7BDaSUGBAXR0B02VzKcIqVt5Y_vo0lC7nC04/edit?ts=5ef0c30f#slide=id.g8a1bab3ac0_6_125

Bug: 1070620
Change-Id: I876c0b2981321d278747ad3eaaca09890a80cb5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317228
Commit-Queue: Andrey Zaytsev <andzaytsev@google.com>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791771}

Bug: 1109663
Change-Id: I6e61cb1d71e654ff359bf9a1d429719a2a920ec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317877
Commit-Queue: David Jean <djean@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: David Jean <djean@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791770}

This patch migrates tests away from deprecated APIs and adopts
TestingProfile::Builder for tests in
/chrome/browser/browsing_data.

Rationale: creating or overriding keyed services after the profile has
been created is problematic and known to cause hard-to-debug test
flakiness, because it bypasses BrowserContextDependencyManager and often
leading to use-after-free.

This CL was uploaded by git cl split.

R=dullweber@chromium.org

Bug: 1106699
Change-Id: Idea748f489836737cfd60e5e8c4ad98662103680
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315354
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791769}

There are 4 tests with the reporting installed in the opener window. The
expectation was wrong, because we expected the url to be the openee URL.

Bug: chromium:1090273
Change-Id: I7b217d7548c8f5a2d41e5f879d11447c4a25f5fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317211
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791768}

Tested manually, including updates by hardcoding the Chrome app id values.

Bug: 1070620, 1107387
Change-Id: I0631df830ff20c000c57235eab1dbd300645db24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307330
Commit-Queue: Andrey Zaytsev <andzaytsev@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791767}

This CL abstracts the file system entry so that we can have two kinds of
implementation:
1. Implementation which is used by chrome.filesystem and File and
Directories API
2. Implementation which is used by NativeFileSystem API

Bug: 980846
Test: Check CCA works normally as a Chrome app

Change-Id: I87d1c121951152e0975f10d8b43787f6a279f186
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237545
Commit-Queue: Wei Lee <wtlee@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Reviewed-by: Kuo Jen Wei <inker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791766}

Adds the purpose of the device
Corresponds to the following platform CL:
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2241226

BUG=b:151176984
TEST=unittest

Change-Id: I55dc88271c3c90cf4bf85db3d0b9c7fe4f641e00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298759
Commit-Queue: Daniil Lunev <dlunev@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Paul Moy <pmoy@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791765}